Commit Graph

3892 Commits

Author SHA1 Message Date
0d44584112 ENH: rationalize wmake rules to avoid unnecessary duplication
- main mplib rules located in GENERAL_RULES with specializations
  (if any) under RULES. Modest change in a few options files, but
  cleans up the rules directories.

  previously in options:
      include $(RULES)/mplib$(WM_MPLIB)

  now in options:
      sinclude $(GENERAL_RULES)/mplib$(WM_MPLIB)
      sinclude $(RULES)/mplib$(WM_MPLIB)

  For GNU make it would be permissible to write both in a single line.
2010-04-22 15:01:07 +02:00
4d2a297a67 BUG: syntax problems found by gcc-4.5.0
- "cpp -traditional-cpp" doesn't strip C++-style comments
  Probably need a workaround with sed -e 's@^ *//@@' if we
  wish to support C++-style comments in Make/{files,options}

- lduMatrixTests.C:121:1:
  error: ‘Foam::lduMatrix::solverPerformance::solverPerformance’ names
  the constructor, not the type

- edgeFaceCirculatorI.H:355:1:
  error: ‘Foam::edgeFaceCirculator::edgeFaceCirculator’ names the
  constructor, not the type

- patchPointEdgeCirculatorI.H:236:1:
  error: ‘Foam::patchPointEdgeCirculator::patchPointEdgeCirculator’
  names the constructor, not the type

- objToVTK.C:116:5:
  error: ‘Foam::argList::argList’ names the constructor, not the type

  same in surfaceClean.C, surfaceRefineRedGreen.C, surfaceSplitByPatch.C

- fireFoam/createFields.H:74:41:
  error: type/value mismatch at argument 1 in template parameter list
  for ‘template<class T> class Foam::autoPtr’
2010-04-22 09:00:31 +02:00
c7267ed9ad STYLE: remove disabled methods from autoPtr
- (have been disabled for more than 1 year)
2010-04-21 15:36:10 +02:00
526aefad60 Merge branch 'master' of ssh://noisy/home/noisy3/OpenFOAM/OpenFOAM-dev 2010-04-21 12:30:36 +01:00
5f0538ecca ENH: Added active flag to KinematicParcel
- used during parcel calc() function to flag whether the parcel should be tracked
- if false, parcel not tracked, but sub-models are still active
- useful, e.g. for particle 'stick' condition
- NOTE: stored as a bool, but read/written as a label for restarts/post-processing
2010-04-21 12:22:22 +01:00
5cfa97624e STYLE: more consistent New methods, use unregistered IOobject where appropriate 2010-04-20 17:13:35 +02:00
41eb599433 BUG: allow defaultFaces specification for both shapes constructors 2010-04-16 21:53:27 +01:00
55d6460445 BUG: jump should be negated on slave patch. 2010-04-16 21:52:39 +01:00
adb9389846 ENH: InteractionLists/CollisionModel. Referring wall data, creating
referredWallFace class to hold patch information was well as face and
pointField.
2010-04-16 19:04:06 +01:00
b19e3cbcf2 Merge branch 'olesenm' 2010-04-16 18:55:27 +01:00
2599c9e1c1 ENH: make Switch implementation more opaque to protect against user mistakes 2010-04-16 16:57:14 +02:00
ad1f99ff71 BUG: IOstream::compressionEnum() used Switch::switchType incorrectly
- use enhanced Switch constructor and the new valid() method to
  avoid potential pitfalls of using Switch::switchType directly.
2010-04-16 15:43:28 +02:00
a17daf7fcc ENH: improve robustness and usability of Switch
- add operator=(const switchType) to avoid this type of problem:

      Switch sw;
      sw = Switch::asEnum("foo", true);
      if (sw) ...  // evaluated incorrectly

- add constructor Switch(const switchType) for convenience

- add valid() method to avoid using the switchType directly
2010-04-16 15:22:11 +02:00
0712a68639 Merge branch 'master' into splitCyclic 2010-04-16 14:21:27 +01:00
dfa2c67602 ENH: Allow specification of defaultFaces boundary type 2010-04-16 13:15:12 +01:00
cff2580336 Merge branch 'master' into splitCyclic
Conflicts:
	applications/utilities/mesh/manipulation/splitMeshRegions/splitMeshRegions.C
	applications/utilities/parallelProcessing/decomposePar/domainDecompositionMesh.C
	src/OpenFOAM/db/IOstreams/Pstreams/UPstream.H
	src/OpenFOAM/fields/pointPatchFields/pointPatchField/pointPatchField.C
	src/OpenFOAM/matrices/lduMatrix/solvers/GAMG/interfaces/cyclicGAMGInterface/cyclicGAMGInterface.C
	src/OpenFOAM/meshes/pointMesh/pointPatches/constraint/processor/processorPointPatch.H
	src/OpenFOAM/meshes/polyMesh/polyPatches/constraint/cyclic/cyclicPolyPatch.H
	src/OpenFOAM/meshes/polyMesh/syncTools/syncTools.C
	src/OpenFOAM/meshes/polyMesh/syncTools/syncToolsTemplates.C
	src/meshTools/sets/topoSets/faceSet.C
	src/parallel/decompose/decompositionMethods/decompositionMethod/decompositionMethod.C
2010-04-16 12:09:34 +01:00
6c6b3ad109 BUG: missing initialisation of boolList 2010-04-16 10:59:40 +01:00
5f8f105965 Merge remote branch 'OpenCFD/master' into olesenm 2010-04-16 11:57:12 +02:00
300ac4843c BUG: fieldValue.C was defining duplicate IOField symbols 2010-04-15 18:15:09 +01:00
01aa79be54 ENH: multiple faces between two cells gives problems for scotch
We filter them out now when constructing the adjacency structure.
2010-04-15 15:12:48 +01:00
d4ca02cf7e BUG: using Time::run() as a loop construct was not doing the functionObjects. 2010-04-15 12:22:56 +01:00
014fbd603d Merge branch 'master' into particleInteractions 2010-04-15 10:22:42 +01:00
d5cb528bf7 ENH: PairCollision. Adding function to WallSpringSliderDashpot to
control the number of subCycles.  Adding the request for timestep
control from the wall model to PairCollision.
2010-04-14 16:12:04 +01:00
2de3c0d2cf Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev 2010-04-14 16:12:02 +01:00
36e845a7a3 ENH: Allow derivation of constraint types (for pointFields only). Allow usage of
non constraint patchFields on constraint patch types (all fields)
2010-04-14 16:10:31 +01:00
bdaca3a63f ENH: Store additional information to handle split cyclics (still not correct though) 2010-04-14 15:57:36 +01:00
d807c16732 BUG: Ordering should use other side information. 2010-04-14 15:57:13 +01:00
c75b0bb02a BUG: Remove initialisation of cyclic since interferes with referred patch
setting transformation properties later on
2010-04-14 15:56:05 +01:00
93a0172f03 BUG: incorrect statistics in parallel. Also removed sign of magSf. 2010-04-14 15:47:39 +01:00
35763926a3 Merge branch 'master' into particleInteractions 2010-04-14 14:05:35 +01:00
c948fadb10 ENH: particleForces. Not caching gradH field, looking up HdotGradH
field directly.

Renaming Ftot to accelTot to remind that the functions return
accelerations.
2010-04-14 13:59:58 +01:00
09374af35e ENH: particleForces. Not caching gradH field, looking up HdotGradH
field directly.

Renaming Ftot to accelTot to remind that the functions return
accelerations.
2010-04-14 13:59:58 +01:00
74b6885674 STYLE: change "it's" to "it is" 2010-04-14 11:39:55 +02:00
55cd7409d8 STYLE: particleForces. Rename variable chi -> magneticSusceptibility. 2010-04-14 09:51:46 +01:00
da5529250f STYLE: particleForces. Rename variable chi -> magneticSusceptibility. 2010-04-14 09:51:46 +01:00
7b2aa07925 Merge remote branch 'OpenCFD/master' into olesenm 2010-04-14 09:42:47 +02:00
6a48570c20 STYLE: add quotes around html attributes 2010-04-14 09:41:52 +02:00
bbb22dc331 ENH: remove existing doxygen html/ in background 2010-04-14 09:14:49 +02:00
3c06042179 ENH: particleForces. Adding paramagnetic force. Adding d to
calcCoupled/calcNonCoupled arguments and call.
2010-04-13 18:24:54 +01:00
5950090d00 ENH: particleForces. Adding paramagnetic force. Adding d to
calcCoupled/calcNonCoupled arguments and call.
2010-04-13 18:24:54 +01:00
937e0d23d0 STYLE: consistent naming of files containing the 'New' method
before:
    - 'new' prefixed to camel-cased class name: eg, someClass -> newSomeClass
    - 'New' prefixed to templated class name:   eg, TmplClass -> NewTmplClass
    - 'New' suffixed to class name:             eg, someClass -> someClassNew

after:
    - consistent 'New' suffixed to class name, no change of case
          eg, someClass -> someClassNew
          eg, TmplClass -> TmplClassNew
2010-04-13 18:47:47 +02:00
6c3c14ab20 Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev 2010-04-13 16:50:12 +01:00
4ede1bc104 Merge branch 'tmp' 2010-04-13 16:50:03 +01:00
1cdcfd7291 ENH: new pointPatchField type cyclicSlip. 2010-04-13 16:49:18 +01:00
8d2e5df846 ENH: Allow pointPatchFields derived from constrained pointPatchField types. 2010-04-13 16:46:35 +01:00
42807ddd7e STYLE: fix worst spacing violations for 'os <<' constructions
- accept some violations of the coding guidelines though
- perhaps adding a style exception would be simpler.
2010-04-13 17:45:49 +02:00
3be2501cd9 Merge branch 'master' into particleInteractions
Conflicts:
	src/lagrangian/intermediate/parcels/Templates/KinematicParcel/CollisionRecordList/CollisionRecordList.H
	src/lagrangian/intermediate/submodels/Kinematic/CollisionModel/NoCollision/NoCollision.H
	src/lagrangian/molecularDynamics/molecule/interactionLists/referralLists/receivingReferralList.C
	src/lagrangian/molecularDynamics/molecule/interactionLists/referralLists/sendingReferralList.C
2010-04-13 16:34:36 +01:00
6b819eb50a STYLE: use new fvPatch::start() method 2010-04-13 17:12:57 +02:00
af039f0eb7 ENH: add fvPatch::start() method to simplify some expressions 2010-04-13 16:06:57 +02:00
868d5866b4 ENH: Use reference instead of copy 2010-04-13 15:01:08 +01:00