Commit Graph

68 Commits

Author SHA1 Message Date
e2ef006b91 applications: Update ...ErrorIn -> ...ErrorInFunction
Avoids the clutter and maintenance effort associated with providing the
function signature string.
2015-11-10 17:53:31 +00:00
42fb1b9e8e Updated notImplemented -> NotImplemented
The new NotImplemented macro uses __PRETTY_FUNCTION__ for GNU compatible
compilers otherwise __func__ to provide the function name string.
2015-11-01 10:26:37 +00:00
988b0fd3e1 ThermalDiffusivity: Refactored to support phase turbulence models 2015-08-20 17:54:51 +01:00
365f9b0006 dimensioned<Type>: Added constructor from name, dimensions and dictionary
to simplify construction of dimensionedScalar properties and avoid the
duplication of the name string in the constructor call.
2015-07-21 12:57:07 +01:00
94401af010 Resolved issues with virtual function inheritance and warning from clang
Also removed __GNUC__ conditional compilation statements which are no
longer needed.
2015-07-17 12:11:37 +01:00
0ea062816e Correct section comment: there can only be one destructor 2015-02-12 21:57:29 +00:00
2aec249647 Updated the whole of OpenFOAM to use the new templated TurbulenceModels library
The old separate incompressible and compressible libraries have been removed.

Most of the commonly used RANS and LES models have been upgraded to the
new framework but there are a few missing which will be added over the
next few days, in particular the realizable k-epsilon model.  Some of
the less common incompressible RANS models have been introduced into the
new library instantiated for incompressible flow only.  If they prove to
be generally useful they can be templated for compressible and
multiphase application.

The Spalart-Allmaras DDES and IDDES models have been thoroughly
debugged, removing serious errors concerning the use of S rather than
Omega.

The compressible instances of the models have been augmented by a simple
backward-compatible eddyDiffusivity model for thermal transport based on
alphat and alphaEff.  This will be replaced with a separate run-time
selectable thermal transport model framework in a few weeks.

For simplicity and ease of maintenance and further development the
turbulent transport and wall modeling is based on nut/nuEff rather than
mut/muEff for compressible models so that all forms of turbulence models
can use the same wall-functions and other BCs.

All turbulence model selection made in the constant/turbulenceProperties
dictionary with RAS and LES as sub-dictionaries rather than in separate
files which added huge complexity for multiphase.

All tutorials have been updated so study the changes and update your own
cases by comparison with similar cases provided.

Sorry for the inconvenience in the break in backward-compatibility but
this update to the turbulence modeling is an essential step in the
future of OpenFOAM to allow more models to be added and maintained for a
wider range of cases and physics.  Over the next weeks and months more
turbulence models will be added of single and multiphase flow, more
additional sub-models and further development and testing of existing
models.  I hope this brings benefits to all OpenFOAM users.

Henry G. Weller
2015-01-21 19:21:39 +00:00
ea94da2168 ENH: Documentation updates 2013-06-13 12:58:03 +01:00
b69e0ae07a ENH: Consisteny update for turbulence G field name 2013-02-18 14:20:37 +00:00
aa5a119be6 ENH: Updated turbulence code/utilities affected by updates to turbulence model behaviour 2012-11-27 17:11:56 +00:00
d40a374cbc dictionary: changes field scoping operator from "::" to '.' 2012-10-12 12:47:54 +01:00
9f096a403e Update headers 2012-08-23 14:13:30 +01:00
830c0ef382 Thermodynamyics: rename basicThermo -> fluidThermo and veryBasicThermo -> basicThermo 2012-08-23 14:13:13 +01:00
dead8ec098 Thermodynamics: Rationalization
At the specie level:
    hs = sensible enthalpy
    ha = absolute (what was total) enthalpy
    es = sensibly internal energy
    ea = absolute (what was total) internal energy

At top-level
    Rename total enthalpy h -> ha
    Rename sensible enthalpy hs -> h

Combined h, hs, e and es thermo packages into a single structure.

Thermo packages now provide "he" function which may return either enthalpy or
internal energy, sensible or absolute according to the run-time selected form

alphaEff now returns the effective diffusivity for the particular energy which
the thermodynamics package is selected to solve for.
2012-05-30 15:21:32 +01:00
63da3e9afc Thermodynamics: Rationalization
At the specie level:
    hs = sensible enthalpy
    ha = absolute (what was total) enthalpy
    es = sensibly internal energy
    ea = absolute (what was total) internal energy

At top-level
    Rename total enthalpy h -> ha
    Rename sensible enthalpy hs -> h

Combined h, hs, e and es thermo packages into a single structure.

Thermo packages now provide "he" function which may return either enthalpy or
internal energy, sensible or absolute according to the run-time selected form

alphaEff now returns the effective diffusivity for the particular energy which
the thermodynamics package is selected to solve for.
2012-05-30 15:19:38 +01:00
932e72f17b STY: column limit 2012-02-17 17:33:17 +00:00
e75a5571a5 ENH: Changes to input for the PDR models 2012-02-17 17:31:46 +00:00
c2dd153a14 Copyright transfered to the OpenFOAM Foundation 2011-08-14 12:17:30 +01:00
4be6e5f3e6 ENH: corrected ambiguous construct from temp 2011-03-08 10:23:19 +00:00
e0a29f44ad BUG: Correction after merge 2011-03-07 12:49:41 +00:00
2896dcd91e Merge branch 'master' of /home/noisy3/OpenFOAM/OpenFOAM-dev 2011-03-07 12:48:32 +00:00
fa96053fc3 BUG: Added missing destructor for PDRkEpsilon 2011-03-07 12:48:26 +00:00
a9151f6abd STY: deleting old format "New" 2011-03-07 12:47:25 +00:00
391f1ddbd9 BUG: virtual destructor 2011-03-07 12:31:10 +00:00
d2c698e994 STY: Changing destructors style and MyClassNew format 2011-03-07 11:10:37 +00:00
1fbf80f410 STY: date correction 2011-03-04 18:27:48 +00:00
b88dd7c6c0 ENH: Updated PDRFoam 2011-03-04 18:24:15 +00:00
c3cb632c24 Documentation: converted javadoc @ to LaTeX style \ in Doxygen code docs 2011-02-08 18:22:00 +00:00
eaef8d482b STYLE: Updated 1991 start copyright year to 2004 2011-01-14 16:08:00 +00:00
099cc39e2e Revert "STYLE: 2011 copyright date."
This reverts commit b18f6cc1ce.
2011-01-05 18:24:29 +00:00
b18f6cc1ce STYLE: 2011 copyright date. 2011-01-05 11:14:26 +00:00
a78fa5add5 STYLE: remove trailing ';' after '{ ... }' compound 2010-12-30 17:50:47 +01:00
c5ee4e1b04 COMP: avoid ambiguous construct from tmp - solvers/ combustion 2010-12-21 09:49:34 +01:00
012494fdb5 STYLE: Fixing code style requirements for all apps.
Exception: applyWallFunctionBoundaryConditions.C cannot split #include
directives.
2010-07-27 15:27:05 +01:00
1a2319fde6 STYLE: PDRkEpsilon refactored to use kEpsilon inheritance 2010-06-18 19:24:23 +02:00
583d518ad5 ENH: Register RAS/LES models with (optional) alternative name
- allows better inheritance of models, since the coefficients
  dictionary can be made to match the derived class.

  related to commits 9544280e65 + 14b4c3849c
2010-06-18 15:37:00 +02:00
c1857db513 Merge remote branch 'OpenCFD/master' into olesenm 2010-06-18 12:52:46 +02:00
14b4c3849c ENH: allow protected access to RAS model coeffs/methods 2010-06-18 09:45:39 +02:00
9544280e65 ENH: Register turbulenceModel with optional name (default is 'turbulenceModel')
Now instead of looking up RASModel we can lookup turbulenceModel instead.
2010-06-11 16:39:16 +01:00
d5ec1d3cee STYLE: minor typo in comments 2010-06-09 08:58:41 +02:00
03338b9ea9 STYLE: partial revert for 5cfa97624e 2010-04-23 10:23:08 +02:00
5cfa97624e STYLE: more consistent New methods, use unregistered IOobject where appropriate 2010-04-20 17:13:35 +02:00
937e0d23d0 STYLE: consistent naming of files containing the 'New' method
before:
    - 'new' prefixed to camel-cased class name: eg, someClass -> newSomeClass
    - 'New' prefixed to templated class name:   eg, TmplClass -> NewTmplClass
    - 'New' suffixed to class name:             eg, someClass -> someClassNew

after:
    - consistent 'New' suffixed to class name, no change of case
          eg, someClass -> someClassNew
          eg, TmplClass -> TmplClassNew
2010-04-13 18:47:47 +02:00
b6f3bd4c23 STYLE: follow coding guide recommendation for '//- Destructor' 2010-04-12 11:55:52 +02:00
d29c438657 STYLE: use url for FSF license instead of postal address, switch to GPL v3 2010-03-29 14:07:56 +02:00
0c8fb634f0 ENH: enforce consistent boundness on turbulence models.
- remove epsilonSmall, omegaSmall
- k0/epsilon0/omega0 become kMin/epsilonMin/omegaMin
- add qMin/zetaMin for consistency

These files still need some attention:
    dynOneEqEddy.C
    NonlinearKEShih.C
    settlingFoam

BUG: incompressible::LESModels:dynOneEqEddy::correct()
- avoid tmp field destruction for consistency with the compressible
  version

Possible TODO:
   - set kMin to zero (instead of SMALL) and introduce kSmall
     to avoid division by zero
2010-03-24 09:07:53 +01:00
0455e4a013 BUG: volScalarField G in registry named RANSModel::G 2010-03-11 14:33:19 +00:00
19f8fa236a Update PDR turbulence model to conform to updated turbulence model api 2010-01-11 12:59:32 +00:00
31c76da40f Changed the runtime-selection tables to output a sorted toc. 2009-08-06 18:01:28 +01:00
5297267a5f Use new patch-based wall-functions. 2009-07-27 07:52:14 +01:00