Commit Graph

10533 Commits

Author SHA1 Message Date
eafd5a3850 ENH: Updated Info, Warning and Error messages 2015-12-08 11:15:39 +00:00
ae95edeea4 ENH: Lagrangian sub models - tidied autoPtr clone usage 2015-12-08 11:09:22 +00:00
3f55f752fc GIT: Resolve conflict with upstream merge from Foundation 2015-12-07 17:07:20 +00:00
736621b945 fvOptions: Reorganized and updated to simplify use in sub-models and maintenance
fvOptions are transferred to the database on construction using
fv::options::New which returns a reference.  The same function can be
use for construction and lookup so that fvOptions are now entirely
demand-driven.

The abstract base-classes for fvOptions now reside in the finiteVolume
library simplifying compilation and linkage.  The concrete
implementations of fvOptions are still in the single monolithic
fvOptions library but in the future this will be separated into smaller
libraries based on application area which may be linked at run-time in
the same manner as functionObjects.
2015-12-02 11:49:52 +00:00
e35afa35bf ENH: tabulatedNTUHeatTransfer fvOption - updated header documentation and minor code clean-up 2015-12-02 09:00:08 +00:00
3c9deb1080 STYLE: Corrected error messages 2015-12-02 08:58:50 +00:00
5edab1caea CONTRIBUTION: NTU inter-region heat transfer model
- Initial code supplied by CFD+Engineering
- Refactored and integrated into the code by OpenCFD
2015-12-01 16:57:46 +00:00
2c055f2b39 porousBafflePressureFvPatchField: Corrected handling of mass-flux
Resolves the bug-report http://www.openfoam.org/mantisbt/view.php?id=1934
2015-12-01 16:31:32 +00:00
6ed6b93c34 radiationModels: Correct handling of ECont and make P1 and fvDOM consistent
Patch provided by Timo Niemi
Resolved bug-report http://www.openfoam.org/mantisbt/view.php?id=1636

This correction corresponds to option 3 of the options proposed by Timo:

Define both ECont and EDisp to be the total emission per surface area,
apply multiplication by 4 in cloudAbsorptionEmission model (the only
place that uses EDisp?). Do not multiply E in P1 at all, divide both
ECont and EDisp in fvDOM.
2015-12-01 16:20:37 +00:00
bd737621a0 ENH: fluxSummary function object - added faceZone area output on construction 2015-12-01 15:34:25 +00:00
7fe531bde5 ENH: OutputFilter function object updates from internal development line 2015-12-01 15:22:13 +00:00
8e5f7e0889 fvOptions: wmakeLnInclude before building the TurbulenceModels libraries
Do not link the fvOptions library into the TurbulenceModels libraries
due to cyclic dependency
2015-12-01 13:10:51 +00:00
f9a02bd412 Merge branch 'feature-turbulence' into 'develop'
Feature turbulence

Integration of new kOmega SST turbulence model variants: DES, DDES, IDDES

Initially supplied by CFD Software E+F GmbH



See merge request !20
2015-12-01 10:45:01 +00:00
7ebfbecd74 Turbulence - updated Spalart-Allmaras IDDES to be consistent with reference 2015-12-01 10:26:23 +00:00
52d83407f3 TurbulenceModels: Added validate function
Moved correctNut call from constructors to the new validate function to
avoid problems with construction order and field availability for the
calculation of nut.

To ensure nut is physical and consistent with the turbulence fields the
validate function should be called after the construction of the
turbulence model, fvOptions and any other fields that the calculation of
nut might depend on.
2015-12-01 10:07:00 +00:00
184a95a96a ENH: Turbulence models - header documentation updates 2015-12-01 09:54:47 +00:00
b8ffb82bb8 circleSet: Corrected point ordering
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1932
2015-12-01 09:45:58 +00:00
ea62de36dc ENH: Turbulence model updates 2015-11-30 17:51:23 +00:00
43f91a1415 CONTRIBUTION: Turbulence - new kOmegaSST DES, DDES and IDDES model variants
- Initial code supplied by CFD Software E+F GmbH
- Refactored and integrated into the new templated Turbulence structure
  by OpenCFD

References:

- kOmegaSSTDES model:
  Strelets, M. (2001)
  Detached Eddy Simulation of Massively Separated Flows,
  39th AIAA Aerospace Sciences Meeting and Exhibit, Reno, NV

- kOmegaSSTDDES model:
  Gritskevich, M.S., Garbaruk, A.V., Schuetze, J., Menter, F.R. (2011)
  Development of DDES and IDDES  Formulations for the k-omega
  Shear Stress Transport Model, Flow, Turbulence and Combustion,
  pp. 1-19

- kOmegaSSTIDDES model:
  Gritskevich, M.S., Garbaruk, A.V., Schuetze, J., Menter, F.R. (2011)
  Development of DDES and IDDES Formulations for the k-omega
  Shear Stress Transport Model, Flow, Turbulence and Combustion,
  pp. 1-19
2015-11-30 16:18:17 +00:00
3e783accd2 ENH: Turbulence - refactored kOmegaSST models to enable easier addition of derived types 2015-11-30 16:17:21 +00:00
9d4e09bbd1 BUG: pressurePIDControlInletVelocity: incorporate faceZones on processor boundaries
It was not correctly interpolating faceZones which are on processor boundaries.
This caused difference between serial and parallel running. Fixes #16.
2015-11-30 14:48:50 +00:00
981b6303a4 ENH: Spalart-Allmaras DES, DDES and IDDES model updates
Included option to use the low Reynolds number correction, with a
default value of 'on'.  Further details can be found in the reference:

    Spalart, P. R., Deck, S., Shur, M.L., Squires, K.D., Strelets, M.Kh,
    Travin, A. (2006).
    A new version of detached-eddy simulation, resistant to ambiguous grid
    densities.
    Theor. Comput. Fluid Dyn., 20, 181-195.

Set using the entry:

    lowReCorrection on; // off
2015-11-30 12:48:20 +00:00
aef2fd5ef4 BUG: scalarTransport: force early creation of transported field
Some bcs (e.g. humidity) use an external transported field so this needs
to be registered asap.
2015-11-30 12:16:05 +00:00
c56c12e277 nutWallFunctionFvPatchScalarField: Added documentation for default coefficients
Patch provided by Bruno Santos
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1930
2015-11-29 21:27:26 +00:00
7cb12e208d STYLE: streamLineBase: DOS line endings 2015-11-29 06:17:57 +00:00
c0ddac32ae turbulenceModels/RAS/kEpsilon/kEpsilon: Added experimental support for fvOptions 2015-11-28 19:07:42 +00:00
2dbf835485 reactingTwoPhaseEulerFoam: Added thermal wall-functions with support for wall-boiling
Code and tutorial case provided by Juho Peltola
2015-11-27 18:51:23 +00:00
e6daf7825c Merge branch 'feature-turbulence' into 'develop'
Feature turbulence

Turbulence updates from our internal development line:
- Added DESModel base class for DES models
- Moved DES models to separate DES directory
- Added DESModelRegions function object
- Updated porousBafflePressure BC to use DataEntry class for D and I inputs
- Documentation updates

See merge request !17
2015-11-27 16:59:58 +00:00
9a281d78b6 ENH: Turbulence - added DES turbulence group documentation 2015-11-27 16:30:48 +00:00
a020b2c6cd BUG: hexRef8Data: scatter master value
For distributed data + running redistributePar some of the processors
might not have level0Edge. In this case the sync() routine should
fix this but it does require at least the master to have valid data.
2015-11-27 16:25:54 +00:00
cf240d79fb CONTRIBUTION: Turbulence DES convection scheme
- Initial code supplied by CFD Software E+F GmbH
- Refactored and integrated into the new templated Turbulence structure by
  OpenCFD
- To use the new convection scheme, add the library
  libturbulenceModelSchemes.so to the $FOAM_CASE controlDict
2015-11-27 15:35:21 +00:00
43ae91c1f7 ENH: Code clean-up 2015-11-27 15:32:33 +00:00
ecdfe31f2d ENH: Added new DESModelRegions function object from internal dev line
Object generates an indicator field for DES turbulence models to show
in which regions LES or RAS modelling is active.
2015-11-27 15:30:26 +00:00
dc40eb98d2 ENH: Updated head documentation 2015-11-27 15:11:05 +00:00
04e39e1eab ENH: porousBafflePressure boundary condition - change D and I to DataEntry types 2015-11-27 15:10:40 +00:00
61ce372bff ENH: kOmegaSSTSAS - enable printCoeffs to output model coefficients on construction 2015-11-27 15:09:41 +00:00
9857a94b98 ENH: Turbulence externalWallHeatFluxTempertaure - updated output messages 2015-11-27 15:08:47 +00:00
b4ab6141b2 ENH: Turbulence - moved DES models to DES directory
SpalartAllmarasDES now derived from DESModel class
2015-11-27 15:06:39 +00:00
ca460ffba2 ENH: Turbulence - added new DESModel layer for DES models 2015-11-27 15:04:37 +00:00
451342abcb ENH: Corrected spelling typos in headers 2015-11-27 15:03:19 +00:00
99bdd2c1d7 ENH: signals: refactored to make static methods
The signal handling can now be set and unset. This latter is important
for external libraries (e.g. VTK/OpenGL) that do not work with it.
2015-11-27 12:14:14 +00:00
b784c09af1 Merge branch 'develop' of develop.openfoam.com:Development/OpenFOAM-dev-OpenCFD into develop 2015-11-27 08:32:44 +00:00
c0391a54cf BUG: Added missing Make rule to build graphics function object 2015-11-27 08:32:39 +00:00
e5993002e9 snappyHexMesh layerParameters: Increased maxIters to 20
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1918
Patch provided by Richard Jones

maxIters could be made an option input if 20 is not sufficient for
difficult cases.
2015-11-26 20:24:26 +00:00
d2fea5fc95 BUG: cyclicACMI: change order of AMI initialisation
The resetAMI in the cyclicAMI would go up to cyclicACMI and do the
initPatchFaceAreas again - but with already masked areas
2015-11-26 16:53:19 +00:00
8d0154ba32 ENH: regionSplit: improve algorithm order
The old version of regionSplit would hand out regions one by one. This
is a big problem when there are lots of regions - the extreme being
in the decompositionMethods, where it is used to cluster cells and most clusters
being only one cell. This rewrite uses a mesh wave to determine disconnected
regions in one go. This produced non-compact numbering which is then compacted
in a second phase.
On a 14M cell case with cyclic constraints this reduced decompose
time from 40 mins down to 5.
2015-11-26 16:52:18 +00:00
710f189456 Merge branch 'develop' of develop.openfoam.com:Development/OpenFOAM-dev-OpenCFD into develop 2015-11-26 16:27:25 +00:00
62c80898d1 BUG: motionSmoother: knock out displacement on points coupled to patch points
Before was zeroing displacement on all coupled points before
applying the displacement. This meant that we could not modify the
internal displacement on coupled points before setting the patch displacement.
Fixes #10.
2015-11-26 16:24:56 +00:00
8d5800c5f8 ENH: externalCoupled: changed to non-OutputFilter functionObject.
- moved control to functionObject (from bc)
- this allows multi-region support
- see heatTransfer/chtMultiRegionFoam/externalCoupledMultiRegionHeater tut
- generalisation of streamed reading/writing of specialised bcs
2015-11-26 13:04:06 +00:00
8317038ac9 Merge branch 'feature-sampledSurfaces' into 'develop'
Feature sampled surfaces

Bounds handling for sampledSurfaces only (so not for streamlines)

See merge request !13
2015-11-26 12:55:09 +00:00