Commit Graph

192 Commits

Author SHA1 Message Date
3c790e2316 Correcting Typo in SolarLoad radiation model 2016-09-28 10:42:21 -07:00
3dbd39146c STYLE: consistency updates 2016-09-27 15:17:55 +01:00
89d9fd1550 ENH: Tutorial updates 2016-09-26 13:00:49 +01:00
ad1e798293 ENH: Initial testing updates 2016-09-26 09:28:31 +01:00
1fbcb686ff STYLE: Consistency updates 2016-09-23 16:52:46 +01:00
9fbd612672 GIT: Initial state after latest Foundation merge 2016-09-20 14:49:08 +01:00
0857f479a8 PBiCGStab: New preconditioned bi-conjugate gradient stabilized solver for asymmetric lduMatrices
using a run-time selectable preconditioner

References:
    Van der Vorst, H. A. (1992).
    Bi-CGSTAB: A fast and smoothly converging variant of Bi-CG
    for the solution of nonsymmetric linear systems.
    SIAM Journal on scientific and Statistical Computing, 13(2), 631-644.

    Barrett, R., Berry, M. W., Chan, T. F., Demmel, J., Donato, J.,
    Dongarra, J., Eijkhout, V., Pozo, R., Romine, C. & Van der Vorst, H.
    (1994).
    Templates for the solution of linear systems:
    building blocks for iterative methods
    (Vol. 43). Siam.

See also: https://en.wikipedia.org/wiki/Biconjugate_gradient_stabilized_method

Tests have shown that PBiCGStab with the DILU preconditioner is more
robust, reliable and shows faster convergence (~2x) than PBiCG with
DILU, in particular in parallel where PBiCG occasionally diverges.

This remarkable improvement over PBiCG prompted the update of all
tutorial cases currently using PBiCG to use PBiCGStab instead.  If any
issues arise with this update please report on Mantis: http://bugs.openfoam.org
2016-09-05 11:46:42 +01:00
1988e4bb60 STYLE: avoid backticks for getApplication 2016-06-27 17:50:55 +02:00
dd60cfcd06 FIX: provide restore0Dir function to fix issue #159
- makes it easier to ensure the correct behaviour, consistently
2016-06-27 16:33:55 +02:00
3d98d6e5c6 changeDictionary: Simplified by removing the need for the superfluous dictionaryReplacement sub-dictionary
Added the option '-subDict' to specify a sub-dictionary if multiple
replacement sets are present in the same file.  This also provides
backward compatibility by setting '-subDict dictionaryReplacement'
2016-06-15 09:03:05 +01:00
344f435f54 Tutorials fvSolution files: removed solver entries which use default
values; formatted Switch entries consistently across all cases
2016-06-15 07:39:12 +01:00
3eec5854be Standardized the selection of required and optional fields in BCs, fvOptions, functionObjects etc.
In most boundary conditions, fvOptions etc. required and optional fields
to be looked-up from the objectRegistry are selected by setting the
keyword corresponding to the standard field name in the BC etc. to the
appropriate name in the objectRegistry.  Usually a default is provided
with sets the field name to the keyword name, e.g. in the
totalPressureFvPatchScalarField the velocity is selected by setting the
keyword 'U' to the appropriate name which defaults to 'U':

        Property     | Description             | Required    | Default value
        U            | velocity field name     | no          | U
        phi          | flux field name         | no          | phi
        .
        .
        .

However, in some BCs and functionObjects and many fvOptions another
convention is used in which the field name keyword is appended by 'Name'
e.g.

        Property     | Description             | Required    | Default value
        pName        | pressure field name     | no          | p
        UName        | velocity field name     | no          | U

This difference in convention is unnecessary and confusing, hinders code
and dictionary reuse and complicates code maintenance.  In this commit
the appended 'Name' is removed from the field selection keywords
standardizing OpenFOAM on the first convention above.
2016-05-21 20:28:20 +01:00
78d2971b21 functionObjects: rewritten to all be derived from 'functionObject'
- Avoids the need for the 'OutputFilterFunctionObject' wrapper
  - Time-control for execution and writing is now provided by the
    'timeControlFunctionObject' which instantiates the processing
    'functionObject' and controls its operation.
  - Alternative time-control functionObjects can now be written and
    selected at run-time without the need to compile wrapped version of
    EVERY existing functionObject which would have been required in the
    old structure.
  - The separation of 'execute' and 'write' functions is now formalized in the
    'functionObject' base-class and all derived classes implement the
    two functions.
  - Unnecessary implementations of functions with appropriate defaults
    in the 'functionObject' base-class have been removed reducing
    clutter and simplifying implementation of new functionObjects.
  - The 'coded' 'functionObject' has also been updated, simplified and tested.
  - Further simplification is now possible by creating some general
    intermediate classes derived from 'functionObject'.
2016-05-15 16:40:01 +01:00
4bc77e6aff Sprucing up the tutorials folder and adding -dict to "collapseEdges"
Patch provided by Bruno Santos
Resolves patch application request http://www.openfoam.org/mantisbt/view.php?id=2015
2016-03-06 19:06:44 +00:00
b6ad46e139 GIT: Resolved conflict 2016-06-17 14:20:45 +01:00
acc0e56c78 ENh: Updating windshieldDefrost case set up 2016-06-14 15:01:56 -07:00
d571e6cfcc BUG: externalSolarLoad: boundaryRadiationProperties : uniform emissivity etc. 2016-06-13 13:12:20 +01:00
86bdabccb5 GIT: Resolved conflict 2016-06-08 13:57:05 +01:00
4b807b580c ENH: Global file handling - update initial Solver control 2016-06-03 17:10:37 +05:30
ec5a0e75b4 ENH: Update tutorial for features directionalPressureGradient, Global file handling 2016-06-03 16:38:34 +05:30
62144e4dd7 Revert "Change boundaryRadiationProperties and boundaryRadiationPropertiesPatch to mesh object and changing tutorials accordingly"
This reverts commit 662f9242e9.

Note: functionality moved to feature-boundaryRadiationProperties branch
2016-05-05 12:21:23 +01:00
b7ee80c926 GIT: Resolve conflict when applying Sergio's updates to new local branch 2016-04-29 15:51:08 -07:00
662f9242e9 Change boundaryRadiationProperties and boundaryRadiationPropertiesPatch to mesh object and changing tutorials accordingly 2016-04-29 15:51:08 -07:00
16dfd33db8 ENH: Tutorials - updates 2016-04-26 14:32:19 +01:00
a7dcf8fc61 ENH: Tutorials - updated use of -log to use -s 2016-04-26 09:31:44 +01:00
fd9d801e2d GIT: Initial commit after latest foundation merge 2016-04-25 11:40:48 +01:00
53d474db41 GIT: boundary: generated file 2016-03-23 15:52:14 +00:00
350d03246e scripts: Reformat with consistent section separators 2016-02-15 18:30:24 +00:00
daf44fda3d tutorials and templates: Updated wall BC for velocity to noSlip 2016-02-09 20:08:34 +00:00
b3d47f0423 bin/tools/RunFunctions: runParallel now obtains the number of processors from numberOfSubdomains
in decomposeParDict.

This default number of processors may be overridden by the new "-np"
option to runParallel which must be specified before the application
name e.g.:

runParallel -np 4 pisoFoam
2016-01-27 14:19:25 +00:00
2aeaa7c5d5 ENH: Added chtMultiRegionFoam 'windshieldDefrost' tutorial showing example of explict solidificationMelting fvOption 2015-12-23 12:13:28 +00:00
f0c3e8d599 STYLE: Updated version to 'plus' 2015-12-22 23:14:17 +00:00
cab9b02c9e STYLE: Updated docs to OpenFOAM.com 2015-12-22 16:57:50 +00:00
04752147c8 GIT: Resolved conflict on merge from upstream 2015-12-22 16:49:44 +00:00
30a03e31f3 files: taking out the compilation of pressureJumpDirec.... fo.
radiationProperties: general model organization
fvOptions: taking out the use of pressureJumpDirec.... from tutorial
2015-12-18 12:17:00 -08:00
cdbe0e31a8 BUG: Switching off radiationProperties in heater. Adding boundaryRadiationProperties
and adding transmissivity keyword in radiationProperties.
2015-12-14 10:43:31 -08:00
92b5ee3487 Merge branch 'develop' into radiation
Conflicts:
	applications/utilities/preProcessing/viewFactorsGen/shootRays.H
	src/lagrangian/intermediate/submodels/addOns/radiation/absorptionEmission/cloudAbsorptionEmission/cloudAbsorptionEmission.C
	src/thermophysicalModels/radiation/derivedFvPatchFields/radiationCoupledBase/radiationCoupledBase.C
	src/thermophysicalModels/radiation/derivedFvPatchFields/radiationCoupledBase/radiationCoupledBase.H
	src/thermophysicalModels/radiation/radiationModels/fvDOM/fvDOM/fvDOM.C
	src/thermophysicalModels/radiation/radiationModels/fvDOM/radiativeIntensityRay/radiativeIntensityRay.C
	tutorials/mesh/parallel/filter/0.org/T
2015-12-11 09:50:43 +00:00
0e01c44129 GIT: Resolved conflict 2015-12-09 16:19:28 +00:00
5c9dff6146 GIT: Resolved conflict 2015-12-09 16:19:28 +00:00
8837a89237 STYLE: Updated links from openfoam.org to openfoam.com 2015-12-09 15:03:05 +00:00
e8118a9b04 ENH: Tutorials - removed boundary files from repository 2015-12-08 15:06:13 +00:00
dbea5806ce ENH: Tutorials - removing fluxRequired from fvSchemes 2015-12-08 12:14:13 +00:00
3f55f752fc GIT: Resolve conflict with upstream merge from Foundation 2015-12-07 17:07:20 +00:00
8d5800c5f8 ENH: externalCoupled: changed to non-OutputFilter functionObject.
- moved control to functionObject (from bc)
- this allows multi-region support
- see heatTransfer/chtMultiRegionFoam/externalCoupledMultiRegionHeater tut
- generalisation of streamed reading/writing of specialised bcs
2015-11-26 13:04:06 +00:00
d98136e122 tutorials: Removed unnecessary "boundary" files 2015-11-13 20:05:37 +00:00
0431b8fbe1 ENH: humidityTemperatureCoupledMixed: moved to separate library
This bc was in compressible turbulence library which made it dependent
on liquidProperties. It was moved to a separate library since it is only
used in a single tutorial.
2015-11-09 14:40:21 +00:00
047211b1f7 ENH: Adding humidityTemperatureCoupledMixed BC and directionalPressureGradientExplicitSource and the corresponding tutorial
tutorials/heatTransfer/chtMultiRegionFoam/windshieldCondensation
2015-11-03 14:42:08 -08:00
eedbd182d1 ENH: Adding solar radiation modelling and tutorial changes 2015-11-02 11:54:27 -08:00
37cfc3ab46 tutorials: Removed unnecessary spaces between parentheses and values in vectors 2015-07-21 20:55:44 +01:00
4c21f24a8c Input of dimensionedScalars: update read-construction of dimensionedScalar in applications
so that the specification of the name and dimensions are optional in property dictionaries.

Update tutorials so that the name of the dimensionedScalar property is
no longer duplicated but optional dimensions are still provided and are
checked on read.
2015-07-20 22:52:53 +01:00