zhyang-dev/OpenFOAM-12
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

InterfaceCompositionPhaseChangePhaseSystem: Two sided mass transfer fix

Browse Source 
This change fixes an issue where mass transfer models were being looked
up on the wrong side of the interface. This also means that specifying
mass transfer just on one side of an interface is now possible without
generating errors.
This commit is contained in:
Will Bainbridge
2018-09-24 11:21:27 +01:00
parent 819c24869e
commit eaa089e38c
1 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
applications/solvers/multiphase/reactingEulerFoam/phaseSystems/PhaseSystems/InterfaceCompositionPhaseChangePhaseSystem/InterfaceCompositionPhaseChangePhaseSystem.C
View File

@ -123,6 +123,8 @@ InterfaceCompositionPhaseChangePhaseSystem
{
const phasePair& pair =
this->phasePairs_[interfaceCompositionModelIter.key()];
const phaseModel& phase = pair.phase1();
const phaseModel& otherPhase = pair.phase2();
if (!pair.ordered())
{
@ -136,14 +138,27 @@ InterfaceCompositionPhaseChangePhaseSystem
<< exit(FatalError);
}
const phasePairKey key(pair.phase1().name(), pair.phase2().name());
if (!massTransferModels_[key][pair.index(pair.phase1())].valid())
const phasePairKey key(phase.name(), otherPhase.name());
if (!this->phasePairs_.found(key))
{
FatalErrorInFunction
<< "A mass transfer model the " << key << " pair is not "
<< "specified. This is required by the corresponding interface "
<< "composition model."
<< exit(FatalError);
}
const phasePair& uoPair = this->phasePairs_[key];
if (!massTransferModels_[uoPair][uoPair.index(phase)].valid())
{
FatalErrorInFunction
<< "A mass transfer model for the " << pair.phase1().name()
<< " side of the " << key << " pair is not specified. This is "
<< "required by the corresponding interface composition model."
<< " side of the " << uoPair << " pair is not "
<< "specified. This is required by the corresponding interface "
<< "composition model."
<< exit(FatalError);
}
}
@ -180,7 +195,6 @@ InterfaceCompositionPhaseChangePhaseSystem
const phasePair& pair =
this->phasePairs_[interfaceCompositionModelIter.key()];
const phasePair unorderedPair(pair.phase1(), pair.phase2());
iDmdtSu_.insert(pair, new HashPtrTable<volScalarField>());
iDmdtSp_.insert(pair, new HashPtrTable<volScalarField>());
@ -317,13 +331,14 @@ massTransfer() const
this->phasePairs_[interfaceCompositionModelIter.key()];
const phaseModel& phase = pair.phase1();
const phaseModel& otherPhase = pair.phase2();
const phasePair unorderedPair(phase, otherPhase);
const phasePair& unorderedPair =
this->phasePairs_[phasePair(phase, otherPhase)];
const volScalarField& Tf(*this->Tf_[unorderedPair]);
const volScalarField K
(
massTransferModels_[unorderedPair][pair.index(phase)]->K()
massTransferModels_[unorderedPair][unorderedPair.index(phase)]->K()
);
forAllConstIter(hashedWordList, compositionModel.species(), memberIter)