OpenFOAM: Updated for gcc-13

gcc-13 has new code checking and warning mechanisms which are useful but not
entirely robust and produce many false positives, particularly with respect to
local references:

    warning: possibly dangling reference to a temporary

This commit resolves many of the new warning messages but the above false
warnings remain.  It is possible to switch off this warning but as it also
provides some useful checks it is currently left on.

applications/solvers/combustion/PDRFoam/XiModels/XiEqModels/Gulder/Gulder.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -70,7 +70,9 @@ Foam::XiEqModels::Gulder::~Gulder()
 Foam::tmp<Foam::volScalarField> Foam::XiEqModels::Gulder::XiEq() const
 {
     volScalarField up(sqrt((2.0/3.0)*turbulence_.k()));
-    const volScalarField& epsilon = turbulence_.epsilon();
+
+    tmp<volScalarField> tepsilon = turbulence_.epsilon();
+    const volScalarField& epsilon = tepsilon();
 
     if (subGridSchelkin_)
     {

applications/solvers/combustion/PDRFoam/XiModels/XiEqModels/SCOPEXiEq/SCOPEXiEq.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -76,8 +76,11 @@ Foam::XiEqModels::SCOPEXiEq::~SCOPEXiEq()
 
 Foam::tmp<Foam::volScalarField> Foam::XiEqModels::SCOPEXiEq::XiEq() const
 {
-    const volScalarField& k = turbulence_.k();
+    tmp<volScalarField> tk = turbulence_.k();
-    const volScalarField& epsilon = turbulence_.epsilon();
+    const volScalarField& k = tk();
+
+    tmp<volScalarField> tepsilon = turbulence_.epsilon();
+    const volScalarField& epsilon = tepsilon();
 
     volScalarField up(sqrt((2.0/3.0)*k));
     if (subGridSchelkin_)

applications/solvers/combustion/PDRFoam/XiModels/XiGModels/KTS/KTS.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -64,7 +64,9 @@ Foam::XiGModels::KTS::~KTS()
 Foam::tmp<Foam::volScalarField> Foam::XiGModels::KTS::G() const
 {
     volScalarField up(sqrt((2.0/3.0)*turbulence_.k()));
-    const volScalarField& epsilon = turbulence_.epsilon();
+
+    tmp<volScalarField> tepsilon = turbulence_.epsilon();
+    const volScalarField& epsilon = tepsilon();
 
     volScalarField tauEta(sqrt(mag(thermo_.muu()/(thermo_.rhou()*epsilon))));
 

applications/solvers/modules/compressibleMultiphaseVoF/pressureCorrector.C

@@ -80,7 +80,7 @@ void Foam::solvers::compressibleMultiphaseVoF::pressureCorrector()
         {
             const compressibleVoFphase& phase = phases[phasei];
             const rhoThermo& thermo = phase.thermo();
-            const volScalarField& rho = thermo.rho()();
+            const volScalarField& rho = phases[phasei].thermo().rho();
 
             p_rghEqnComps.set
             (

applications/solvers/modules/compressibleVoF/compressibleVoF.C

@@ -143,8 +143,8 @@ void Foam::solvers::compressibleVoF::prePredictor()
 {
     twoPhaseVoFSolver::prePredictor();
 
-    const volScalarField& rho1 = mixture.thermo1().rho();
+    const volScalarField& rho1 = mixture_.thermo1().rho();
-    const volScalarField& rho2 = mixture.thermo2().rho();
+    const volScalarField& rho2 = mixture_.thermo2().rho();
 
     alphaRhoPhi1 = fvc::interpolate(rho1)*alphaPhi1;
     alphaRhoPhi2 = fvc::interpolate(rho2)*(phi - alphaPhi1);

applications/solvers/modules/isothermalFilm/isothermalFilm.C

@@ -233,7 +233,7 @@ Foam::wordList Foam::solvers::isothermalFilm::alphaTypes() const
 Foam::solvers::isothermalFilm::isothermalFilm
 (
     fvMesh& mesh,
-    autoPtr<fluidThermo> thermoPtr
+    autoPtr<rhoThermo> thermoPtr
 )
 :
     solver(mesh),
@@ -403,7 +403,7 @@ Foam::solvers::isothermalFilm::isothermalFilm
 
 Foam::solvers::isothermalFilm::isothermalFilm(fvMesh& mesh)
 :
-    isothermalFilm(mesh, fluidThermo::New(mesh))
+    isothermalFilm(mesh, rhoThermo::New(mesh))
 {}
 
 

applications/solvers/modules/isothermalFilm/isothermalFilm.H

@@ -46,7 +46,7 @@ See also
 #define isothermalFilm_H
 
 #include "solver.H"
-#include "fluidThermo.H"
+#include "rhoThermo.H"
 #include "filmCompressibleMomentumTransportModel.H"
 #include "uniformDimensionedFields.H"
 
@@ -93,10 +93,10 @@ protected:
     // Thermophysical properties
 
         //- Pointer to the fluid thermophysical properties
-        autoPtr<fluidThermo> thermoPtr_;
+        autoPtr<rhoThermo> thermoPtr_;
 
         //- Reference to the fluid thermophysical properties
-        fluidThermo& thermo_;
+        rhoThermo& thermo_;
 
         //- The thermodynamic pressure field
         volScalarField& p;
@@ -276,7 +276,7 @@ public:
         const volScalarField& alpha;
 
         //- Reference to the fluid thermophysical properties
-        const fluidThermo& thermo;
+        const rhoThermo& thermo;
 
         //- Reference to the thermodynamic density field
         const volScalarField& rho;
@@ -300,7 +300,7 @@ public:
     // Constructors
 
         //- Construct from region mesh and thermophysical properties
-        isothermalFilm(fvMesh& mesh, autoPtr<fluidThermo>);
+        isothermalFilm(fvMesh& mesh, autoPtr<rhoThermo>);
 
         //- Construct from region mesh
         isothermalFilm(fvMesh& mesh);

applications/solvers/modules/multiphaseEuler/interfacialModels/dragModels/segregated/segregated.C

@@ -131,7 +131,7 @@ Foam::tmp<Foam::volScalarField> Foam::dragModels::segregated::K() const
 
     const volScalarField::Internal ReI
     (
-        (interface_.rho()()()*interface_.magUr()()())
+        (interface_.rho()()*interface_.magUr()()())
        /(magGradI*limitedAlpha1*limitedAlpha2*muI)
     );
 

applications/solvers/modules/multiphaseEuler/multiphaseCompressibleMomentumTransportModels/kineticTheoryModels/frictionalStressModel/JohnsonJacksonSchaeffer/JohnsonJacksonSchaefferFrictionalStress.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2016-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2016-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -157,8 +157,6 @@ JohnsonJacksonSchaeffer::nu
     }
 
     const fvPatchList& patches = phase.mesh().boundary();
-    const volVectorField& U = phase.U();
-
     volScalarField::Boundary& nufBf = nuf.boundaryFieldRef();
 
     forAll(patches, patchi)
@@ -169,7 +167,7 @@ JohnsonJacksonSchaeffer::nu
                 (
                     pf.boundaryField()[patchi]*sin(phi_.value())
                    /(
-                        mag(U.boundaryField()[patchi].snGrad())
+                        mag(phase.U()().boundaryField()[patchi].snGrad())
                       + small
                     )
                 );

applications/solvers/modules/multiphaseEuler/multiphaseCompressibleMomentumTransportModels/kineticTheoryModels/frictionalStressModel/Schaeffer/SchaefferFrictionalStress.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -146,8 +146,6 @@ Foam::kineticTheoryModels::frictionalStressModels::Schaeffer::nu
     }
 
     const fvPatchList& patches = phase.mesh().boundary();
-    const volVectorField& U = phase.U();
-
     volScalarField::Boundary& nufBf = nuf.boundaryFieldRef();
 
     forAll(patches, patchi)
@@ -158,7 +156,7 @@ Foam::kineticTheoryModels::frictionalStressModels::Schaeffer::nu
                 (
                     pf.boundaryField()[patchi]*sin(phi_.value())
                    /(
-                        mag(U.boundaryField()[patchi].snGrad())
+                       mag(phase.U()().boundaryField()[patchi].snGrad())
                       + small
                     )
                 );

applications/solvers/modules/multiphaseEuler/multiphaseCompressibleMomentumTransportModels/kineticTheoryModels/kineticTheoryModel/kineticTheoryModel.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -410,7 +410,9 @@ void Foam::RASModels::kineticTheoryModel::correct()
     const volScalarField& rho = phase_.rho();
     const surfaceScalarField& alphaRhoPhi = alphaRhoPhi_;
     const volVectorField& U = U_;
-    const volVectorField& Uc_ = continuousPhase.U();
+
+    tmp<volVectorField> tUc(continuousPhase.U());
+    const volVectorField& Uc = tUc();
 
     const scalar sqrtPi = sqrt(constant::mathematical::pi);
     const dimensionedScalar ThetaSmall("ThetaSmall", Theta_.dimensions(), 1e-6);
@@ -470,7 +472,7 @@ void Foam::RASModels::kineticTheoryModel::correct()
         const volScalarField J2
         (
             "J2",
-            0.25*sqr(beta)*da*magSqr(U - Uc_)
+            0.25*sqr(beta)*da*magSqr(U - Uc)
            /(
                max(alpha, residualAlpha_)*rho
               *sqrtPi*(ThetaSqrt + ThetaSmallSqrt)

applications/solvers/modules/multiphaseEuler/multiphaseEuler/facePressureCorrector.C

@@ -63,7 +63,7 @@ void Foam::solvers::multiphaseEuler::facePressureCorrector()
                 fvc::interpolate
                 (
                     max(alpha.oldTime(), phase.residualAlpha())
-                   *phase.rho()().oldTime()
+                   *phase.rho().oldTime()
                 )
             ).ptr()
         );

applications/solvers/modules/multiphaseEuler/multiphaseThermophysicalTransportModels/wallBoilingSubModels/departureDiameterModels/KocamustafaogullariIshiiDepartureDiameter/KocamustafaogullariIshiiDepartureDiameter.C

@@ -133,8 +133,14 @@ KocamustafaogullariIshiiDepartureDiameter::dDeparture
             Tl,
             Tsatw,
             L,
-            liquid.thermo().rho(patchi)(),
+            static_cast<const scalarField&>
-            vapour.thermo().rho(patchi)(),
+            (
+                liquid.rho().boundaryField()[patchi]
+            ),
+            static_cast<const scalarField&>
+            (
+                vapour.rho().boundaryField()[patchi]
+            ),
             liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour), patchi)()
         );
 }
@@ -158,8 +164,8 @@ KocamustafaogullariIshiiDepartureDiameter::dDeparture
         liquid.thermo().T(),
         Tsatw,
         L,
-        liquid.thermo().rho()(),
+        liquid.rho(),
-        vapour.thermo().rho()(),
+        vapour.rho(),
         liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour))()
     );
 }

applications/solvers/modules/multiphaseEuler/multiphaseThermophysicalTransportModels/wallBoilingSubModels/departureFrequencyModels/Cole/Cole.C

@@ -143,8 +143,8 @@ Foam::wallBoilingModels::departureFrequencyModels::Cole::fDeparture
         (
             liquid.mesh(),
             dDep,
-            liquid.thermo().rho()(),
+            liquid.rho(),
-            vapour.thermo().rho()()
+            vapour.rho()
         );
 }
 

applications/solvers/modules/multiphaseEuler/multiphaseThermophysicalTransportModels/wallBoilingSubModels/departureFrequencyModels/KocamustafaogullariIshiiDepartureFrequency/KocamustafaogullariIshiiDepartureFrequency.C

@@ -128,8 +128,14 @@ KocamustafaogullariIshiiDepartureFrequency::fDeparture
         (
             liquid.mesh(),
             dDep,
-            liquid.thermo().rho(patchi)(),
+            static_cast<const scalarField&>
-            vapour.thermo().rho(patchi)(),
+            (
+                liquid.rho().boundaryField()[patchi]
+            ),
+            static_cast<const scalarField&>
+            (
+                vapour.rho().boundaryField()[patchi]
+            ),
             liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour), patchi)()
         );
 }
@@ -153,8 +159,8 @@ KocamustafaogullariIshiiDepartureFrequency::fDeparture
         (
             liquid.mesh(),
             dDep,
-            liquid.thermo().rho()(),
+            liquid.rho(),
-            vapour.thermo().rho()(),
+            vapour.rho(),
             liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour))()
         );
 }

applications/solvers/modules/multiphaseEuler/multiphaseThermophysicalTransportModels/wallBoilingSubModels/nucleationSiteModels/KocamustafaogullariIshiiNucleationSite/KocamustafaogullariIshiiNucleationSite.C

@@ -145,8 +145,14 @@ KocamustafaogullariIshiiNucleationSite::nucleationSiteDensity
             L,
             dDep,
             Tw,
-            liquid.thermo().rho(patchi)(),
+            static_cast<const scalarField&>
-            vapour.thermo().rho(patchi)(),
+            (
+                liquid.rho().boundaryField()[patchi]
+            ),
+            static_cast<const scalarField&>
+            (
+                vapour.rho().boundaryField()[patchi]
+            ),
             liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour), patchi)()
         );
 }
@@ -172,8 +178,8 @@ KocamustafaogullariIshiiNucleationSite::nucleationSiteDensity
         L,
         dDep,
         Tf,
-        liquid.thermo().rho()(),
+        liquid.rho(),
-        vapour.thermo().rho()(),
+        vapour.rho(),
         liquid.fluid().sigma(phaseInterfaceKey(liquid, vapour))()
     );
 }

applications/solvers/modules/multiphaseEuler/phaseSystems/PhaseSystems/InterfaceCompositionPhaseChangePhaseSystem/InterfaceCompositionPhaseChangePhaseSystem.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2015-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2015-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -693,7 +693,7 @@ correctInterfaceThermo()
 
                     const volScalarField rhoKDL
                     (
-                        phase.thermo().rho()
+                        phase.rho()
                        *diffusiveMassTransferModel.modelInThe(phase).K()
                        *compositionModel.modelInThe(phase).D(specie)
                        *this->Li

applications/solvers/modules/multiphaseEuler/phaseSystems/PhaseSystems/MomentumTransferPhaseSystem/MomentumTransferPhaseSystem.C

@@ -280,7 +280,9 @@ Foam::MomentumTransferPhaseSystem<BasePhaseSystem>::momentumTransfer()
                 fvVectorMatrix& eqn = *eqns[phase.name()];
 
                 const volVectorField& U = eqn.psi();
-                const surfaceScalarField& phi = phase.phi();
+
+                tmp<surfaceScalarField> tphi(phase.phi());
+                const surfaceScalarField& phi = tphi();
                 const tmp<surfaceScalarField> taphi(fvc::absolute(phi, U));
                 const surfaceScalarField& aphi(taphi());
 
@@ -420,8 +422,11 @@ Foam::MomentumTransferPhaseSystem<BasePhaseSystem>::momentumTransferf()
 
         if (!phase.stationary())
         {
-            const volVectorField& U = phase.U();
+            tmp<volVectorField> tU = phase.U();
-            const surfaceScalarField& phi = phase.phi();
+            const volVectorField& U = tU();
+
+            tmp<surfaceScalarField> tphi(phase.phi());
+            const surfaceScalarField& phi = tphi();
             const tmp<surfaceScalarField> taphi(fvc::absolute(phi, U));
             const surfaceScalarField& aphi(taphi());
 
@@ -1132,7 +1137,7 @@ Foam::MomentumTransferPhaseSystem<BasePhaseSystem>::ddtCorrs() const
             fvc::ddtCorr
             (
                 phase,
-                phase.rho()(),
+                phase.rho(),
                 phase.U()(),
                 phase.phi()(),
                 phase.Uf()

applications/solvers/modules/multiphaseEuler/phaseSystems/diameterModels/IATE/IATE.C

@@ -129,7 +129,7 @@ void Foam::diameterModels::IATE::correct()
                   + fvc::div(phase().alphaPhi())
                 )
               - (
-                    fvc::ddt(phase(), phase().rho()())
+                    fvc::ddt(phase(), phase().rho())
                   + fvc::div(phase().alphaRhoPhi())
                 )/phase().rho()
             ),

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/MovingPhaseModel/MovingPhaseModel.C

@@ -170,7 +170,7 @@ Foam::MovingPhaseModel<BasePhaseModel>::MovingPhaseModel
         phaseCompressible::momentumTransportModel::New
         (
             *this,
-            this->thermo().rho(),
+            this->rho(),
             U_,
             alphaRhoPhi_,
             phi_,
@@ -335,7 +335,7 @@ Foam::tmp<Foam::fvVectorMatrix>
 Foam::MovingPhaseModel<BasePhaseModel>::UEqn()
 {
     const volScalarField& alpha = *this;
-    const volScalarField& rho = this->thermo().rho();
+    const volScalarField& rho = this->rho();
 
     return
     (
@@ -355,7 +355,7 @@ Foam::MovingPhaseModel<BasePhaseModel>::UfEqn()
     // As the "normal" U-eqn but without the ddt terms
 
     const volScalarField& alpha = *this;
-    const volScalarField& rho = this->thermo().rho();
+    const volScalarField& rho = this->rho();
 
     return
     (

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/MulticomponentPhaseModel/MulticomponentPhaseModel.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2015-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2015-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -91,7 +91,7 @@ Foam::tmp<Foam::fvScalarMatrix>
 Foam::MulticomponentPhaseModel<BasePhaseModel>::YiEqn(volScalarField& Yi)
 {
     const volScalarField& alpha = *this;
-    const volScalarField& rho = this->thermo().rho();
+    const volScalarField& rho = this->rho();
 
     const tmp<surfaceScalarField> talphaRhoPhi(this->alphaRhoPhi());
     const surfaceScalarField& alphaRhoPhi(talphaRhoPhi());

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/ThermoPhaseModel/ThermoPhaseModel.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2015-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2015-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -90,7 +90,7 @@ Foam::ThermoPhaseModel<BasePhaseModel, ThermoModel>::thermoRef()
 
 
 template<class BasePhaseModel, class ThermoModel>
-Foam::tmp<Foam::volScalarField>
+const Foam::volScalarField&
 Foam::ThermoPhaseModel<BasePhaseModel, ThermoModel>::rho() const
 {
     return thermo_->rho();

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/ThermoPhaseModel/ThermoPhaseModel.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2015-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2015-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -103,7 +103,7 @@ public:
             virtual rhoThermo& thermoRef();
 
             //- Return the density field
-            virtual tmp<volScalarField> rho() const;
+            virtual const volScalarField& rho() const;
 
 
         // Transport

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/phaseModel/phaseModel.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2015-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2015-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -210,7 +210,9 @@ void Foam::phaseModel::correctInflowOutflow(surfaceScalarField& alphaPhi) const
 {
     surfaceScalarField::Boundary& alphaPhiBf = alphaPhi.boundaryFieldRef();
     const volScalarField::Boundary& alphaBf = boundaryField();
-    const surfaceScalarField::Boundary& phiBf = phi()().boundaryField();
+
+    tmp<surfaceScalarField> tphi(phi());
+    const surfaceScalarField::Boundary& phiBf = tphi().boundaryField();
 
     forAll(alphaPhiBf, patchi)
     {

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseModel/phaseModel/phaseModel.H

@@ -261,7 +261,7 @@ public:
             virtual rhoThermo& thermoRef() = 0;
 
             //- Return the density field
-            virtual tmp<volScalarField> rho() const = 0;
+            virtual const volScalarField& rho() const = 0;
 
             //- Return whether the phase is isothermal
             virtual bool isothermal() const = 0;

applications/solvers/modules/multiphaseEuler/phaseSystems/phaseSystem/phaseSystem.C

@@ -701,7 +701,8 @@ void Foam::phaseSystem::correctBoundaryFlux()
     {
         phaseModel& phase = movingPhases()[movingPhasei];
 
-        const volVectorField::Boundary& UBf = phase.U()().boundaryField();
+        tmp<volVectorField> tU(phase.U());
+        const volVectorField::Boundary& UBf = tU().boundaryField();
 
         FieldField<fvsPatchField, scalar> phiRelBf
         (
@@ -806,7 +807,7 @@ void Foam::phaseSystem::correctPhi
             phaseModel& phase = phases()[phasei];
             const volScalarField& alpha = phase;
 
-            psi += alpha*phase.thermo().psi()/phase.thermo().rho();
+            psi += alpha*phase.thermo().psi()/phase.rho();
         }
 
         fv::correctPhi

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/binaryBreakupModels/Liao/LiaoBase.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2021-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2021-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -126,14 +126,14 @@ void Foam::diameterModels::LiaoBase::precompute()
         (
             "rhoc",
             dimDensity,
-            gAverage(populationBalance_.continuousPhase().rho()())
+            gAverage(populationBalance_.continuousPhase().rho())
         );
 
         const dimensionedScalar rhod
         (
             "rhod",
             dimDensity,
-            gAverage(populationBalance_.sizeGroups()[1].phase().rho()())
+            gAverage(populationBalance_.sizeGroups()[1].phase().rho())
         );
 
         const dimensionedScalar sigma

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/coalescenceModels/BrownianCollisions/BrownianCollisions.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2019-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2019-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -107,7 +107,9 @@ addToCoalescenceRate
     const sizeGroup& fj = popBal_.sizeGroups()[j];
 
     const volScalarField& T = popBal_.continuousPhase().thermo().T();
-    const volScalarField& mu = popBal_.continuousPhase().thermo().mu();
+
+    tmp<volScalarField> tmu(popBal_.continuousPhase().thermo().mu());
+    const volScalarField& mu = tmu();
 
     const volScalarField Cci
     (

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/coalescenceModels/LiaoCoalescence/LiaoCoalescence.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2021-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2021-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -178,7 +178,7 @@ void Foam::diameterModels::coalescenceModels::LiaoCoalescence::precompute()
         (
             popBal_.sigmaWithContinuousPhase(popBal_.sizeGroups()[1].phase())()
            /(mag(g)*(popBal_.continuousPhase().rho()
-          - popBal_.sizeGroups()[1].phase().rho()()))
+          - popBal_.sizeGroups()[1].phase().rho()))
         );
 }
 

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/coalescenceModels/turbulentShear/turbulentShear.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2019-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2019-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -74,9 +74,9 @@ addToCoalescenceRate
     const sizeGroup& fi = popBal_.sizeGroups()[i];
     const sizeGroup& fj = popBal_.sizeGroups()[j];
 
-    const volScalarField& epsilon = popBal_.continuousTurbulence().epsilon();
     const volScalarField& rho = popBal_.continuousPhase().rho();
-    const volScalarField& mu = popBal_.continuousPhase().thermo().mu();
+    tmp<volScalarField> epsilon(popBal_.continuousTurbulence().epsilon());
+    tmp<volScalarField> mu(popBal_.continuousPhase().thermo().mu());
 
     coalescenceRate += C_*sqrt(epsilon*rho/mu)*pow3(fi.d() + fj.d());
 }

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/driftModels/densityChange/densityChange.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2017-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2017-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -67,7 +67,7 @@ void Foam::diameterModels::driftModels::densityChangeDrift::addToDriftRate
     const sizeGroup& fi = popBal_.sizeGroups()[i];
     const phaseModel& phase = fi.phase();
     const volScalarField& alpha = phase;
-    const volScalarField& rho = phase.thermo().rho();
+    const volScalarField& rho = phase.rho();
 
     driftRate -=
         fi.x()

applications/solvers/modules/multiphaseEuler/phaseSystems/populationBalanceModel/populationBalanceModel/populationBalanceModel.C

@@ -695,7 +695,7 @@ void Foam::diameterModels::populationBalanceModel::correctDilatationError()
         const phaseModel& phase = fluid_.phases()[phaseName];
         const velocityGroup& velGroup = *velocityGroupPtrs_[phaseName];
         const volScalarField& alpha = phase;
-        const volScalarField& rho = phase.thermo().rho();
+        const volScalarField& rho = phase.rho();
 
         dilatationError =
             fvc::ddt(alpha) + fvc::div(phase.alphaPhi())
@@ -1167,7 +1167,7 @@ void Foam::diameterModels::populationBalanceModel::solve()
                 sizeGroup& fi = sizeGroups_[i];
                 const phaseModel& phase = fi.phase();
                 const volScalarField& alpha = phase;
-                const volScalarField& rho = phase.thermo().rho();
+                const volScalarField& rho = phase.rho();
                 const volScalarField& dilatationError =
                     dilatationErrors_[phase.name()];
 

applications/solvers/modules/solid/solid.C

@@ -203,7 +203,7 @@ void Foam::solvers::solid::momentumPredictor()
 void Foam::solvers::solid::thermophysicalPredictor()
 {
     volScalarField& e = thermo_.he();
-    const volScalarField& rho = thermo.rho();
+    const volScalarField& rho = thermo_.rho();
 
     while (pimple.correctNonOrthogonal())
     {

applications/solvers/modules/solidDisplacement/solidDisplacement.C

@@ -171,7 +171,7 @@ void Foam::solvers::solidDisplacement::pressureCorrector()
 {
     volVectorField& D(D_);
 
-    const volScalarField& rho = thermo.rho();
+    const volScalarField& rho = thermo_.rho();
 
     int iCorr = 0;
     scalar initialResidual = 0;

applications/utilities/thermophysical/chemkinToFoam/chemkinReader/chemkinReader.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -741,9 +741,9 @@ void Foam::chemkinReader::addReaction
         default:
         {
             FatalErrorInFunction
-                << "Reaction rate type " << reactionRateTypeNames[rrType]
+                << "Reaction rate type index " << rrType
                 << " on line " << lineNo_-1
-                << " not implemented"
+                << " unknown"
                 << exit(FatalError);
         }
     }

src/OSspecific/POSIX/POSIX.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -1354,7 +1354,7 @@ Foam::fileNameList Foam::dlLoaded()
             << " : determined loaded libraries :" << libs.size() << std::endl;
     }
 
-    return move(libs);
+    return libs;
 }
 
 

src/OpenFOAM/containers/Lists/List/List.H

@@ -55,7 +55,7 @@ using std::move;
 template<class T>
 inline T clone(const T& t)
 {
-    return move(T(t));
+    return T(t);
 }
 
 // Forward declaration of classes

src/OpenFOAM/db/functionObjects/writeObjectsBase/writeObjectsBase.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2016-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2016-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -93,7 +93,7 @@ Foam::wordList Foam::functionObjects::writeObjectsBase::objectNames()
         }
     }
 
-    return move(allNames);
+    return allNames;
 }
 
 

src/OpenFOAM/fields/pointPatchFields/basic/basicSymmetry/basicSymmetryPointPatchField.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -115,6 +115,11 @@ public:
                 const Pstream::commsTypes commsType =
                     Pstream::commsTypes::blocking
             );
+
+
+    // Member Operators
+
+        using pointPatchField<Type>::operator=;
 };
 
 

src/OpenFOAM/global/fileOperations/collatedFileOperation/hostCollatedFileOperation.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2017-2020 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2017-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -119,7 +119,7 @@ Foam::labelList Foam::fileOperations::hostCollatedFileOperation::subRanks
         }
     }
 
-    return move(subRanks);
+    return subRanks;
 }
 
 

src/OpenFOAM/global/fileOperations/masterUncollatedFileOperation/masterUncollatedFileOperation.C

@@ -112,7 +112,8 @@ Foam::labelList Foam::fileOperations::masterUncollatedFileOperation::subRanks
                 break;
             }
         }
-        return move(subRanks);
+
+        return subRanks;
     }
 }
 

src/OpenFOAM/meshes/meshObjects/DemandDrivenMeshObject.C

@@ -87,9 +87,7 @@ Type& Foam::DemandDrivenMeshObject<Mesh, MeshObjectType, Type>::New
 
         Type* objectPtr = new Type(mesh);
 
-        regIOobject::store(objectPtr);
+        return regIOobject::store(objectPtr);
-
-        return *objectPtr;
     }
 }
 
@@ -120,9 +118,7 @@ Type& Foam::DemandDrivenMeshObject<Mesh, MeshObjectType, Type>::New
 
         Type* objectPtr = new Type(mesh, args...);
 
-        regIOobject::store(objectPtr);
+        return regIOobject::store(objectPtr);
-
-        return *objectPtr;
     }
 }
 

src/OpenFOAM/meshes/polyMesh/polyBoundaryMesh/polyBoundaryMesh.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2022 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -680,7 +680,7 @@ Foam::labelList Foam::polyBoundaryMesh::findIndices
         }
     }
 
-    return move(indices);
+    return indices;
 }
 
 

src/OpenFOAM/meshes/polyMesh/polyMeshTetDecomposition/polyMeshTetDecomposition.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -551,7 +551,7 @@ Foam::List<Foam::tetIndices> Foam::polyMeshTetDecomposition::cellTetIndices
         cellTets.append(faceTetIndices(mesh, fI, cI));
     }
 
-    return move(cellTets);
+    return cellTets;
 }
 
 

src/conversion/polyDualMesh/polyDualMesh.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -317,7 +317,7 @@ Foam::labelList Foam::polyDualMesh::collectPatchSideFace
         reverse(dualFace);
     }
 
-    return move(dualFace);
+    return dualFace;
 }
 
 

src/finiteVolume/fields/fvPatchFields/basic/basicSymmetry/basicSymmetryFvPatchField.H

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2020 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -121,6 +121,11 @@ public:
 
         //- Return face-gradient transform diagonal
         virtual tmp<Field<Type>> snGradTransformDiag() const;
+
+
+    // Member Operators
+
+        using transformFvPatchField<Type>::operator=;
 };
 
 

src/finiteVolume/fvMeshToFvMesh/patchToPatchFvPatchFieldMapper.H

@@ -82,6 +82,8 @@ public:
         //- Map a label field (not implemented)
         DEFINE_FIELD_MAPPER_OPERATOR(label, );
 
+        using fvPatchFieldMapper::operator();
+
         //- Map a temporary field
         template<class Type>
         void operator()(Field<Type>& f, const tmp<Field<Type>>& tmapF) const;

src/functionObjects/forces/forces/forces.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -71,7 +71,7 @@ Foam::wordList Foam::functionObjects::forces::createFileNames
         }
     }
 
-    return move(names);
+    return names;
 }
 
 

src/mesh/snappyHexMesh/externalDisplacementMeshMover/medialAxisMeshMover.C

@@ -77,7 +77,7 @@ Foam::labelList Foam::medialAxisMeshMover::getFixedValueBCs
         }
     }
 
-    return Foam::move(adaptPatchIDs);
+    return adaptPatchIDs;
 }
 
 

src/mesh/snappyHexMesh/meshRefinement/meshRefinement.C

@@ -2067,7 +2067,7 @@ Foam::labelList Foam::meshRefinement::meshedPatches() const
         }
     }
 
-    return move(patchIDs);
+    return patchIDs;
 }
 
 

src/mesh/snappyHexMesh/refinementRegions/refinementRegions.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -222,11 +222,12 @@ void Foam::refinementRegions::orient()
 
             if (shell.triSurface::size())
             {
-                const pointField& points = shell.points();
+                tmp<pointField> tpoints(shell.points());
+                const pointField& points = tpoints();
 
                 hasSurface = true;
-
                 boundBox shellBb(points[0], points[0]);
+
                 // Assume surface is compact!
                 forAll(points, i)
                 {

src/meshTools/meshSearch/meshSearch.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -882,7 +882,7 @@ Foam::List<Foam::pointIndexHit> Foam::meshSearch::intersections
 
     hits.shrink();
 
-    return move(hits);
+    return hits;
 }
 
 

src/meshTools/patchToPatch/patchToPatchStabilisation/patchToPatchStabilisation.C

@@ -191,12 +191,13 @@ void Foam::patchToPatchStabilisation::update
           + "_connections.obj"
         );
 
-        pointField fcs(patch.faceCentres());
+        const pointField fcs(patch.faceCentres());
-        stabilise(fcs);
+        pointField sfcs(fcs);
+        stabilise(sfcs);
 
         forAll(fcs, celli)
         {
-            const point& c = patch.faceCentres()[celli];
+            const point& c = fcs[celli];
             if (magSqr(c - fcs[celli]) == 0) continue;
             obj.write(linePointRef(fcs[celli], c));
         }

src/meshTools/searchableSurfaces/triSurfaceMesh/extractCloseness.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2018-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2018-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -43,7 +43,8 @@ void Foam::triSurfaceMesh::drawHitProblem
     if (debug)
     {
         const List<labelledTri>& tris = *this;
-        const pointField& points = this->points();
+        tmp<pointField> tpoints = points();
+        const pointField& points = tpoints();
 
         Info<< nl << "# findLineAll did not hit its own face."
             << nl << "# fi " << fi
@@ -316,7 +317,8 @@ Foam::triSurfaceMesh::extractPointCloseness
 
     // Prepare start and end points for intersection tests
 
-    const pointField& points = this->points();
+    tmp<pointField> tpoints = points();
+    const pointField& points = tpoints();
     const labelList& meshPoints = this->meshPoints();
     const pointField& faceCentres = this->faceCentres();
     const vectorField& normals = this->faceNormals();

src/meshTools/triSurface/booleanOps/intersectedSurface/intersectedSurface.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -1114,7 +1114,7 @@ Foam::faceList Foam::intersectedSurface::splitFace
         }
     }
 
-    return move(faces);
+    return faces;
 }
 
 

src/parallel/decompose/decompositionMethods/manualDecomp/manualDecomp.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2021 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -115,7 +115,7 @@ Foam::labelList Foam::manualDecomp::decompose
             << exit(FatalError);
     }
 
-    return move(finalDecomp);
+    return finalDecomp;
 }
 
 

src/parallel/decompose/decompositionMethods/multiLevelDecomp/multiLevelDecomp.C

@@ -395,7 +395,7 @@ Foam::labelList Foam::multiLevelDecomp::decompose
         finalDecomp
     );
 
-    return move(finalDecomp);
+    return finalDecomp;
 }
 
 
@@ -420,7 +420,7 @@ Foam::labelList Foam::multiLevelDecomp::decompose
         finalDecomp
     );
 
-    return move(finalDecomp);
+    return finalDecomp;
 }
 
 

src/renumber/renumberMethods/manualRenumber/manualRenumber.C

@@ -2,7 +2,7 @@
   =========                 |
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     | Website:  https://openfoam.org
-    \\  /    A nd           | Copyright (C) 2011-2019 OpenFOAM Foundation
+    \\  /    A nd           | Copyright (C) 2011-2023 OpenFOAM Foundation
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
 License
@@ -122,7 +122,7 @@ Foam::labelList Foam::manualRenumber::renumber
         }
     }
 
-    return move(newToOld);
+    return newToOld;
 }
 
 

src/specieTransfer/derivedFvPatchFields/specieTransferMassFraction/specieTransferMassFractionFvPatchScalarField.H

@@ -181,6 +181,11 @@ public:
             virtual void updateCoeffs();
 
 
+    // Member Operators
+
+        using mixedFvPatchScalarField::operator=;
+
+
         //- Write
         virtual void write(Ostream&) const;
 };