Commit Graph

4385 Commits

Author SHA1 Message Date
5b4e84c97b reactingEulerFoam::MovingPhaseModel: Generalised support for derived fixedValue BCs using the assignable() member function
Resolves bug-report https://bugs.openfoam.org/view.php?id=3457
2020-02-23 22:17:54 +00:00
5ce2130f1a reactingEulerFoam/phaseSystems: Rationalised the handling of continuity error compensation
Updated the continuity error compensation term in the face momentum formulation
so that separate flow and source continuity errors are combined into a single
term.
2020-02-18 17:24:33 +00:00
7f36cf7feb Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2020-02-18 13:57:41 +00:00
bda904ca95 Corrected the name of tutorials/incompressible/boundaryFoam/boundaryNonNewtonian 2020-02-18 13:57:11 +00:00
7010a8ec24 cyclicTransform: Improved automatic calculation of rotational transforms
Rotational transforms can now be automatically calculated from the
coupled patch geometries even when a) the patches are non-planar, b)
the patch normals are not perpendicular to the rotation axis, and/or c)
the rotation angle is 180 degrees.
2020-02-18 08:38:39 +00:00
75c332c6c8 reacting*EulerFoam/.../wallDampingModels: Fixed memory reuse issue and removed unused code 2020-02-18 08:38:07 +00:00
17afa7d79b reactingEulerFoam::AnisothermalPhaseModel: Added a continuity error compensation term to the internal energy pressure work
Reduced the accumulation of error for incompressible and low compressibility
cases.

Partly resolves report https://bugs.openfoam.org/view.php?id=3442
2020-02-17 14:04:45 +00:00
fe13ba9fac functionObjects::forces: Corrected coordinate system example in header
Resolves bug-report https://bugs.openfoam.org/view.php?id=3455
2020-02-17 09:53:31 +00:00
1875257198 tutorials/incompressible/boundaryFoam/boundaryNonNewonian: New tutorial to demonstrate non-Netwonian flow capability in boundaryFoam 2020-02-16 00:17:46 +00:00
89439aa1ff tutorials/multiphase/reactingMultiphaseEulerFoam/laminar/damBreak4phase: New tutorial to demonstrate interface capturing in reactingMultiphaseEulerFoam
This case is an updated version of
tutorials/multiphase/multiphaseEulerFoam/damBreak4phase using the latest models
available in reactingMultiphaseEulerFoam for interface capturing.
2020-02-16 00:14:32 +00:00
70f7643451 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2020-02-14 17:07:04 +00:00
4deaba90f7 cylinderAnnulusToFace, cylinderToFace: Corrected setType
Resolves bug-report https://bugs.openfoam.org/view.php?id=3453
2020-02-14 17:06:22 +00:00
6996bcb28c reacting*EulerFoam/.../interfaceCompositionModel: Fixed pair ordering bug 2020-02-14 12:23:34 +00:00
2d3b02c130 primitiveMeshGeometry, polyMeshGeometry: Removed unused code
The utilised static parts of polyMeshGeometry are now part of a
polyMeshCheck namespace. Everything else has been removed, as they were
unused, out of date, and/or duplicated elsewhere.
2020-02-13 14:33:18 +00:00
ba52c4047c transformer: Removed &= operator
This operator was defined with an incorrect (or at least
counter-intuitive) ordering. Given the possibility for ambiguity
associated with transformation ordering it is considered preferable for
the transformer class not to have compound assigment operators. Forcing
the full syntax (e.g., "a = a & b" or "a = b & a") makes it clear in
which order the transformations are intended to be applied.
2020-02-11 12:01:29 +00:00
a283130301 coupledPolyPatch: Removed unecessary calcGeometry overload 2020-02-11 09:23:44 +00:00
ba8e1ecd2d cyclicPolyPatch: Optionally deduce ordering transformation from temporary primativePatch
Resolves bug report https://bugs.openfoam.org/view.php?id=3447
2020-02-11 09:22:12 +00:00
e659b2e7ab PrimitivePatch: Added faceAreas method 2020-02-11 08:32:23 +00:00
bc0175f7ca reactingMultiphaseEulerFoam/multiphaseSystem: Fix to correction fluxes
Correction fluxes need for a given phase need to be calculated relative
to all other phases, both moving and stationary.
2020-02-10 16:13:51 +00:00
c829ae0cfc reacting*EulerFoam: Added pressure referencing for incompressible phase systems
Patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2020-02-10 13:42:25 +00:00
3d70311c21 filmViscosityModel::thixotropicViscosity: Added optional Bingham plastic yield stress support
There is now an optional tauy entry in the thixotropicCoeffs to specify the
Bingham yield stress.
2020-02-10 08:57:00 +00:00
ab9b5eae92 Revert "filmViscosityModel::thixotropicViscosity: Added optional Bingham plastic yield stress support"
This reverts commit fc5d0c7dee.
2020-02-10 08:55:52 +00:00
19c9b59c4a tutorials/heatTransfer/buoyantSimpleFoam/buoyantCavity: Swapped the frontAndBack and topAndBottom patch names 2020-02-09 14:36:10 +00:00
972af235a0 List: Corrected construction from SLList
Resolves bug-report https://bugs.openfoam.org/view.php?id=3448
2020-02-09 12:05:42 +00:00
d8cf7788eb CodedBase: Changed construction of static words to avoid construction order problems with Clang 20200208 2020-02-07 22:09:09 +00:00
04a3f9f237 CodedFunction1: Moved the static data member definitions to makeFunction1s.C 2020-02-07 15:42:13 +00:00
fc5d0c7dee filmViscosityModel::thixotropicViscosity: Added optional Bingham plastic yield stress support
There is now an optional tauy entry in the thixotropicCoeffs to specify the
Bingham yield stress, e.g.:

    filmViscosityModel thixotropic;
    thixotropicCoeffs
    {
        mu0             100;
        muInf           0.1;
        a               0.1;
        b               3;
        c               0.005;
        d               0.9;
        tauy            1.1;   // Yield stress in Pa
    }
2020-02-07 15:14:52 +00:00
a728a69c59 codedMixedFvPatchField, codedFixedValuePointPatchField: Updated and simplified using the new CodedBase class
reducing code duplication and maintenance overhead.
2020-02-07 00:05:27 +00:00
6a2ecb4d04 nutkAtmRoughWallFunction: Updated calcNut -> nut
Resolves bug-report https://bugs.openfoam.org/view.php?id=3443
2020-02-06 21:40:20 +00:00
4cbb849eda codedFixedValueFvPatchField: Updated and simplified using the new CodedBase class
reducing code duplication and maintenance overhead.
2020-02-06 16:04:21 +00:00
b2c30b93ce reactingEulerFoam::phaseSystem: Corrected loops to start from 1 2020-02-06 14:49:09 +00:00
cdf95fa6ef reactingEulerFoam::phaseSystems: Ensure the sum of phase fractions of the moving phases has calculated BCs 2020-02-06 14:38:46 +00:00
082a3c3ff3 General maintenance: Replaced convertToRad with degToRad 2020-02-05 17:30:39 +00:00
d1170cd177 reactingMultiphaseEulerFoam: Added referencePhase option
In multiphase systems it is only necessary to solve for all but one of the
moving phases.  The new referencePhase option allows the user to specify which
of the moving phases should not be solved, e.g. in constant/phaseProperties of the
tutorials/multiphase/reactingMultiphaseEulerFoam/RAS/fluidisedBed tutorial case with

phases (particles air);

referencePhase air;

the particles phase is solved for and the air phase fraction and fluxes obtained
from the particles phase which provides equivalent behaviour to
reactingTwoPhaseEulerFoam and is more efficient than solving for both phases.
2020-02-05 16:49:22 +00:00
5f79067082 reactingTwoPhaseEulerFoam::YEqns.H: Removed temporary diagnostic messages 2020-02-05 16:46:36 +00:00
35565437f5 reactingMultiphaseEulerFoam::multiphaseSystem: Updated implicitPhasePressure handling to improve stability and allow larger time-steps 2020-02-05 10:56:12 +00:00
99725b178f phaseCompressibleTurbulenceModels/Make/options: Removed redundant include 2020-02-04 13:10:16 +00:00
1dfec06aac twoPhaseCompressibleTurbulenceModels: Removed duplicate instantiation of phase turbulence model base classes 2020-02-04 12:17:44 +00:00
d728b23427 codedFunctionObject: Updated and simplified using the new CodedBase 2020-02-03 21:44:44 +00:00
7a717a6929 reactingEulerFoam/phaseCompressibleTurbulenceModels: New turbulence library for both two and multiphase reactingEulerFoam solvers
combining the multiphaseCompressibleTurbulenceModels and derivedFvPatchFields
libraries with the generic multiphase turbulence models from the
twoPhaseCompressibleTurbulenceModels library, kineticTheoryModels and
phasePressureModel into a single common library compiled and linked into both
reactingTwoPhaseEulerFoam and reactingMultiphaseEulerFoam.
2020-02-03 18:33:11 +00:00
01f4faa486 reactingEulerFoam::kineticTheoryModel: Generalised to handle any pair of phases in a multiphase system
If the system has more than two phases the continuous phase must be specified.

Patch contributed by Timo Niemi, VTT.
2020-02-03 18:29:42 +00:00
0bff8ef536 reactingMultiphaseEulerFoam: Completed support for LTS in the face momentum formulation
consistent with the treatment in reactingTwoPhaseEulerFoam and using the same
included files to avoid code duplication.
2020-02-03 11:16:00 +00:00
963392e86c CodedBase: New template wrapper to provide most of the members needed by codedBase
This significantly simplifies the creation and maintenance of coded classes and
used in CodedFunction1 to provide an example of its use; the other coded classes
will be refactored and simplified in this manner in the future.
2020-02-02 18:17:31 +00:00
617695fef4 CodedFunction1: Resolved problem with operator order in the description string construction 2020-02-01 17:50:01 +00:00
dbdc119309 CodedFunction1: Updated documentation 2020-02-01 17:00:35 +00:00
7632b94218 tutorials/basic/potentialFoam/pitzDaily: Use the centralised blockMeshDict $FOAM_TUTORIALS/resources/blockMesh/pitzDaily 2020-02-01 06:22:35 +00:00
7282c0575d tutorials/incompressible/pisoFoam/LES/pitzDailyMapped: Reverted blockMeshDict 2020-01-31 23:48:09 +00:00
0dd2e97bd8 CodedFunction1: New Function1 which uses codeStream to dynamically compile the value function code
For example in the new tutorial case:
tutorials/incompressible/pimpleFoam/laminar/pitzDailyPulse
a cosine bell velocity pulse is specified at the inlet by directly defining the
code for it:

    inlet
    {
        type            uniformFixedValue;
        uniformValue    coded;

        name            pulse;

        codeInclude
        #{
            #include "mathematicalConstants.H"
        #};

        code
        #{
            return vector
            (
                0.5*(1 - cos(constant::mathematical::twoPi*min(x/0.3, 1))),
                0,
                0
            );
        #};
    }

which is then compiled automatically and linked into the running pimpleFoam
dynamically and executed to set the inlet velocity.
2020-01-31 23:39:59 +00:00
aff00a2e7e dlLibraryTable: Simplified and rationalised the handling of dynamic library loading
Rather than being tied to the Time class the dlLibraryTable libs is now a global
variable in the Foam namespace which is accessable by any class needing to load
dynamic libraries, in particular argList, Time and codeStream.
2020-01-31 08:18:10 +00:00
6dc3b30017 functionObjects::randomise: Resolved problem with construction order 2020-01-29 19:22:39 +00:00