Commit Graph

5475 Commits

Author SHA1 Message Date
8a104e2d53 TDACChemistryModel: Completed separation from standardChemistryModel
Another step towards merging TDACChemistryModel with standardChemistryModel to
create a single general chemistryModel.
2021-09-10 23:31:07 +01:00
8805c03c4d Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-09-10 16:34:08 +01:00
41be50ab58 TDACChemistryModel: Further simplification and rationalisation
removed confusing duplicate storage of the complete species composition field.
2021-09-10 16:32:22 +01:00
7f926bb1da DimensionedSymmTensorField: Added missing includes 2021-09-08 09:49:38 +01:00
5d1a756178 etc/config.sh/unset: Added missing environment variables 2021-09-08 09:04:40 +01:00
18bd2b24df Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-09-07 21:09:22 +01:00
1932addc2c TDACChemistryModel: Rationalised interface to reduction and tabulation methods
Most tabulation and reduction specific code in TDACChemistryModel has been moved
into the appropriate tabulation and reduction classes and the "none" methods of
each simplified so that they can be instantiated without any user input.  This
allows the "none" tabulation and reduction methods to be selected automatically
when the "tabulation" or "reduction" entries are not present in the
chemistryProperties dictionary so that the TDACChemistryModel can be run in the
same manner as the standardChemistryModel when tabulation and reduction are not
required.

This is the first step towards merging TDACChemistryModel with standardChemistryModel.
2021-09-07 21:03:55 +01:00
3f8baf9c12 Merge branch 'master' of github.com:OpenFOAM/OpenFOAM-dev 2021-09-07 17:19:36 +01:00
8830b2fa1e etc/bashrc: removed sourcing of additional files passed as
arguments to the original sourced file. Caused an infinite loop if original source command
is called within a function, e.g.

sourceFile() {
    . $1
}
2021-09-07 17:19:13 +01:00
4736c42343 etc/bashrc: removed sourcing of additional files passed as
arguments to the original sourced file. Causes an infinite loop if original source command
is called within a function, e.g.

sourceFile() {
    .
}

sourceFile etc/bashrc
2021-09-07 17:10:13 +01:00
19950fa3b8 functionObjects::comfort: extended to calculate the draught rate (DR)
The draught rate determines the percentage of affected people by an airflow
caused due to room ventilation or buoyancy effects (cold windows). The draught
rate calculation is valid for room temperatures between 20 and 26 degrees
Celsius and airspeed less than 0.5 m/s.  This quantity is used widely for
quantifying offices, auditoriums, or similar rooms in which persons are working.

Patch contributed by Tobias Holzmann
2021-09-03 19:38:16 +01:00
531904ebae AMIMethod, mapNearestMethod: Removed unnecessary and inconsistent name enumerations
Both AMIMethod and mapNearestMethod are run-time selectable using the standard
OpenFOAM constructor tables, they do not need a separate enumeration-based
selection method which requires duplicate constructors and a lot of other
clutter.
2021-09-03 16:27:39 +01:00
c180395e0c topoSet: rotatedBoxToCell: Added box and rotation specification
The rotatedBoxToCell topoSet source can now be specified by providing
the geometry of a non-rotated box and how it should be rotated. For
example, in system/topoSetDict:

    actions
    (
        {
            name    c1;
            type    cellSet;
            action  new;
            source  rotatedBoxToCell;
            box     (0.4 0.4 -100) (0.6 0.6 100);
            centre  (0.4 0.4 0);
            n1      (1 0 0);
            n2      (1 1 0);
        }
    );

This selects cells in a box rotated from (1 0 0) to (1 1 0) (i.e., 45
degrees around the z-axis), with width and depth of 0.2, height of 200,
and with a bottom left corner at (0.4 0.4 -100).

The origin, i, j, k, specification is still available, and will be used
if the keyword "box" is not present. The equivalent input to the above
in this form is as follows:

    actions
    (
        {
            name    c1;
            type    cellSet;
            action  new;
            source  rotatedBoxToCell;
            origin  (0.4 0.4 -100);
            i       (0.141421 0.141421 0);
            j       (-0.141421 0.141421 0);
            k       (0 0 200);
        }
    );
2021-09-03 15:08:39 +01:00
e6fdd180e8 mapFieldsPar: Corrected handling of argList and reverted change to createTimes.H 2021-09-02 19:45:14 +01:00
3554f2140e Test-IOField: Updated and improved to use typeIOobject 2021-09-02 07:55:49 +01:00
2b5edb1119 specieTransferVelocity: Use base class dictionary constructor 2021-09-01 14:01:11 +01:00
c4187efc28 tutorials: DTCHullWave: Increase upstream mesh density
The mesh in the upstream region of this case has been refined back to
its original density. This restores the wave propagation behaviour
through this region.
2021-09-01 10:56:47 +01:00
559fe8ca7e waves: Optionally input period rather than length for Stokes-type waves
Stokes-type waves (i.e., Airy, Stokes2 and Stokes5) now support
specification in terms of wave period, as well as length. The following
specifications are therefore equivalent:

    Stokes2
    {
        length      300; // <-- Wave length specified
        amplitude   2.5;
        phase       0;
        angle       0;
        depth       50;
    }

    Stokes2
    {
        period      15.643; // <-- Wave period specified
        amplitude   2.5;
        phase       0;
        angle       0;
        depth       50;
    }

Note that the period is that of the wave in a reference frame with zero
mean flow. Specifying a doppler shifted period is not yet supported.

Exactly one of period or length must be specified. If both, or neither,
are provided then an error will be generated.

Corrections have also been made to the calculation of the celerity of
Stokes2 and Stokes5 waves.
2021-09-01 10:56:26 +01:00
d07713062a specieTransfer: Improved inlet-outlet handling for velocity boundary condition 2021-09-01 10:56:08 +01:00
96508b8406 waves: Removed unused pressure method and simplified handling of gravity 2021-09-01 10:55:51 +01:00
1c48685b09 waves: Improved reverse flow formulation and new test cases
It is now possible to use waveVelocity and waveAlpha boundary conditions
in cases in which the waves generate localised flow reversals along the
boundary. This means waves can be speficied at arbitrary directions and
with zero mean flow. Previously and integral approach, similar to
flowRateOutlet, was used, which was only correct when the direction of
wave propagation was aligned with the boundary normal.

This improvement has been achieved by reformulating the waveVelocity and
waveAlpha boundary conditions in terms of a new fixedValueInletOutlet
boundary condition type. This condition enforces a fixed value in all
cases except that of advection terms in the presence of outflow. In this
configuration a gradient condition is applied that will relax towards
the desired fixed value.

The wavePressure boundary condition has been removed, as it is no longer
necessary or advisable to locally switch between velocity and pressure
formulations along a wave boundary. Wave boundaries should now have the
general fixedFluxPressure or fixedFluxExtrapolatedPressure conditions
applied to the pressure field.

Two new tutorial cases have been created to demonstrate the new
functionality. The multiphase/interFoam/laminar/wave3D case demonstrates
wave generation with zero mean flow and at arbitrary angles to the
boundaries, and incompressible/pimpleFoam/RAS/waveSubSurface
demonstrates usage for sub-surface problems.
2021-09-01 10:55:23 +01:00
984066f81e Corrected typos 2021-08-30 16:37:38 +01:00
8dbbe122f1 thermophysicalModels/specie/transport: Added documentation with examples 2021-08-30 16:29:45 +01:00
b3e02df01a thermophysicalModels/specie/thermo: Added documentation with examples 2021-08-30 14:31:41 +01:00
61174d8fa8 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-08-30 10:31:30 +01:00
e6d7b7aa3f mapFieldsPar: added createTimes.H from mapFields
Resolves bug-report https://bugs.openfoam.org/view.php?id=3722
2021-08-30 10:29:56 +01:00
d002a4de50 massSource: Simplified reading of field value functions 2021-08-27 11:59:44 +01:00
c86c64db72 src/thermophysicalModels/specie/equationOfState: Added documentation with example usage 2021-08-26 16:44:11 +01:00
987d5906ef fvModels, fvConstraints: Prevent crash when applied to solver-type function objects
This fixes a crash that occured when the field that the fvModel applies
to does not exist at the point of the fvModel's construction. This is
the case for function objects that solve equations, e.g., the
scalarTransport or age functions, as the relevant fields are constructed
on demand at the point of the functions' execution. Sources and
constraints now work correctly for these sorts of equations.
2021-08-26 11:19:35 +01:00
e52567a4cf lagrangian: Ensure reacting properties are written for bare cloned clouds
Resolves bug report https://bugs.openfoam.org/view.php?id=3719
2021-08-26 09:11:08 +01:00
21cafbbfa0 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-08-25 11:59:59 +01:00
32cfad7002 error: Fixed bug in copy construction
Resolves bug report https://bugs.openfoam.org/view.php?id=3716
2021-08-25 11:50:15 +01:00
9b8aa48a7e basicChemistryModelTemplate: Corrected test for TDAC
Resolves bug-report https://bugs.openfoam.org/view.php?id=3717
2021-08-25 11:47:42 +01:00
09e8377d73 foamGet: sets the target directory after the file selection is confirmed 2021-08-24 15:21:29 +01:00
2c0a7c2df3 Merge branch 'master' of github.com:OpenFOAM/OpenFOAM-dev 2021-08-24 15:20:00 +01:00
b8fbdd7523 limitPressure, limitTemperature: added example fvConstraints 2021-08-24 15:19:40 +01:00
24a359af70 fvModels: clouds: Added example usage to pimpleFoam/RAS/TJunction tutorial 2021-08-24 09:34:02 +01:00
5f11467ca0 fvModels: clouds: Extend to work with incompressible solvers 2021-08-24 08:48:06 +01:00
a33a4d73b1 templates/singleFluidCHT: switched off thermal radiation in solids by default
and used explicit feature capturing by default in the meshing
2021-08-23 19:46:35 +01:00
032a2ccc66 etc/templates: update dynamicMeshDict and apply explicit feature capturing to rotating cases 2021-08-23 17:08:29 +01:00
909faa2d40 cloudProperties: adding missing 'type' entry 2021-08-23 12:16:10 +01:00
08d6791d81 lagrangian: Error, rather than hang, in unrecoverable situations
Resolves bug report https://bugs.openfoam.org/view.php?id=3712
2021-08-18 13:41:22 +01:00
4d97c30469 mapFields: Removed temporary debug flag
Resolves report https://bugs.openfoam.org/view.php?id=3715
2021-08-17 08:51:16 +01:00
393023e81e tutorials/combustion/reactingFoam/laminar/counterFlowFlame2D(LTS): changed to Wilke transport mixing
Changed the laminar methane combustion cases to use the Wilke mixing rule for
the transport properties obtained from the Sutherland model but with coefficient
mixing for thermodynamic properties for efficient evaluation of reaction
equilibria.

This provides significantly more accurate results for laminar combustion,
producing a thinner flame and a 10K reduction in peak temperature.
2021-08-16 17:35:55 +01:00
d1ebcad3ca tutorials/combustion: Added Sutherland coefficients for all methane combustion species 2021-08-16 17:34:27 +01:00
9353828505 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-08-16 11:24:24 +01:00
64e94cfa66 heheuPsiThermo: Added the missing Cp and Cv updates to the calculate() function
Resolves bug-report https://bugs.openfoam.org/view.php?id=3711
2021-08-16 11:23:33 +01:00
57a4460d08 surfaceTransformPoints, transformPoints: documented transformations in '-help' option 20210815 2021-08-14 17:42:51 +01:00
f3454baa08 lagrangian: DevolatilisationModel: Added access to the parcel 2021-08-13 12:30:14 +01:00
41b73ec578 sampling: Ensure tracking is done at the new-time mesh state 2021-08-13 09:44:54 +01:00