Commit Graph

7759 Commits

Author SHA1 Message Date
cbfee5596e externalTemperature BC: corrected intialization of qrPrevious 2025-01-23 19:01:39 +00:00
9eccd46b29 NH3::sigma: Added Tc to the initialisation of the NSRDS6 function
Resolves bug-report https://bugs.openfoam.org/view.php?id=4203
2025-01-21 09:36:53 +00:00
dcff2b94e8 nonConformalProcessorCyclic: Corrected transformation of deltas 20250102 2024-12-19 15:49:23 +00:00
fedf1e596c Merge branch 'master' of github.com:OpenFOAM/OpenFOAM-12 2024-12-19 12:37:02 +00:00
f4db98dd0d foamGet: fixed bug in commit 3b72908b 2024-12-19 12:36:56 +00:00
8ecfbe007e Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-12 2024-12-16 09:36:46 +00:00
e9b7b62d1f fvModels::verticalDamping: Added readCoeffs to constructor to read lambda
Resolves bug-report https://bugs.openfoam.org/view.php?id=4189
2024-12-16 09:35:53 +00:00
999196b7c1 bash_completion: updated 2024-12-13 17:39:39 +00:00
ce94118bbc foamGenerateBashCompletion: customise the -region option 2024-12-12 17:39:48 +00:00
3b72908bd8 foamGet: added -region option
to copy files into a specified region sub-directory
2024-12-12 17:35:39 +00:00
deaea4fe77 snappyHexMeshConfig: new -closedDomain, -minDimCells, -region options
-closedDomain        domain does not contain inlets or outlets
    -minDimCells <int>   number of cells in the shortest direction, e.g. 10
    -region <name>       specify alternative mesh region
2024-12-12 17:30:50 +00:00
aebfc940a1 mergeMeshes: Corrected addressing of multiple zones from the add meshes
Resolves bug-report https://bugs.openfoam.org/view.php?id=4187
2024-12-11 15:02:35 +00:00
9ec94dd57a multiphaseEuler: turbulentDispersionModel: Sign correction to blended coefficent 2024-12-04 11:11:04 +00:00
5829755744 etc/bashrc: Allow parameter/prefs modification of user and site paths 2024-11-26 14:34:08 +00:00
fe01324f53 SprayParcel: Copy construct mass0 data
Resolves bug report https://bugs.openfoam.org/view.php?id=4181
2024-11-21 16:57:31 +00:00
f2360fda09 polyMesh: Corrected removal of addressing fields with collated file handler
Resolves bug report https://bugs.openfoam.org/view.php?id=4176
2024-11-12 15:23:05 +00:00
361ebb1597 fluent3DMeshToFoam: Renumbered faceZones
The faces in the mesh are renumbered to ensure upper-triangular ordering, the
faces in the faceZones must also be renumbered accordingly.

Resolves bug-report https://bugs.openfoam.org/view.php?id=4171
2024-11-07 11:07:47 +00:00
7ec1023376 domainDecompositon: Fix to the ordering of non-conformal mapped walls 2024-10-25 13:55:09 +01:00
d19b858ec2 distributions::standardNormal: Prevent call of log with zero value
Resolves bug report https://bugs.openfoam.org/view.php?id=4167
2024-10-24 13:03:00 +01:00
e971fc5fd6 fvMeshStitcher: Fixes for cases with multiple NCC-s
A number of bugs have been fixed relating to cases in which multiple NCC
patches are locally edge-connected, and/or are edge-connected across a
processor boundary.
2024-10-24 11:30:01 +01:00
b3905752d1 foamSetupCHT: checks entries in materialProperties are correct
before copying any files
2024-10-24 09:50:28 +01:00
0a3044caf4 tutorials/incompressibleFluid/turbineSiting/constant/momentumTransport: Added nutMaxCoeff
Resolves bug-report https://bugs.openfoam.org/view.php?id=4165
2024-10-17 15:10:02 +01:00
29e2c93dc1 foamNewBC: Reinstate time method
This serves as an example of the creation of a private method. It no
longer needs to convert the Function1 argument to user time, following
the addition of generalised unit conversion.
2024-10-17 14:06:14 +01:00
a00b947c1d unitConversion: Fixed format of non-named units
Non-named unit conversions are now written in a single set of square
brackets, with colons used to separate the sets of exponents and
multipliers. So, for example, a named unit conversion of [rpm] gets
converted to a non-named [0 0 -1 0 0 0 0 : 0 1 : 0.10472] (i.e.,
[time^-1 : angle : 0.10472]).

Previously, multiple sets of square brackets were used to separate the
sections, so the above example would have been written as
[0 0 -1 0 0 0 0][0 1][0.10472]. The problem with this is that '][' is
not distinguished in the token parser from '] ['. Combined with the fact
that the later sections are optional, this makes reading pairs or lists
of these objects impossible. The new format is, by comparison,
unambiguously delimited in all contexts.

This change may break the restart of a case in which unit conversion
entries have been written out. It is unlikely to require modification to
an initial configuration as named unit conversion entries (such as [rpm]
and [MPa] and [l/min]) are unaffected.
2024-10-03 11:54:56 +01:00
cc05c1b03c multiphaseEuler: Reinstated multicomponentIsothermalPhaseModel
This phase model solves multiple physical species, but fixes the
temperature to a constant value. This combination does not conserve
the energy of the phase.
2024-10-02 15:50:02 +01:00
855365b951 fvMeshStitcher: Update the event index of modified fields
This prevents inconsistent field data being cached.

Note that the stitcher still does not cause old-time fields to be
stored. Stitching is not considered an update (in time) to a field's
value. It is a pure mapping, and it applies similarly to both current
and old-time fields.

Resolves bug report https://bugs.openfoam.org/view.php?id=4155
2024-09-24 15:10:26 +01:00
4bcbc28400 mappedPatchBase: Fix for patches with a single face
Resolves bug report https://bugs.openfoam.org/view.php?id=4152

Patch contributed by Timo Niemi, VTT.
2024-09-17 19:47:06 +01:00
2853f9ddfd movingMappedWallVelocity: Fix calculation of mapped shear velocity 2024-09-11 17:00:52 +01:00
f1068151ee functionObjects::residuals: Write into directory of the start time
This restores the output to that prior to commit 0829dbdf, but retains
the bug fix from that commit.
2024-09-04 16:30:22 +01:00
6aa359dae6 Merge branch 'master' of github.com:OpenFOAM/OpenFOAM-12 20240902 2024-08-13 14:21:32 +01:00
4ce83bd477 foamVTKSeries: simplify the script.
Thanks for Clemens Goessnitzer for suggested changes
2024-08-13 14:21:12 +01:00
fb0e5201d2 functionObjects::residuals: Prevent exectution at the start
Residuals are only available once some equations have been solved, so it
is not valid for this function to execute until the end of the first
timestep.

This also prevents a bug in which the residuals function trggers the
construction of a Residuals mesh object during the writing of the file
header. This only happens on the master process, and therefore leads to
the master having more objects in its database than the other processes.
If this results in the object table being resized then this can change
the iteration order, which can in turn break mapping procedures (in NCC,
topology change, mesh-to-mesh mapping, ...) which rely on fields being
accessed from the database in a consistent order.
2024-08-07 11:54:49 +01:00
74a1c352b2 surfaceFieldValue: Added the ability to specify multiple patches
The 'select' control can now take the value 'patches' in which case a
'patches' control will be used to specify a list of patches, rather than
just a single patch. The 'patches' and 'patch' controls now also both
support wildcards.
2024-08-07 11:16:03 +01:00
bb6f2ab003 bin/foamVTKSeries: fix for multiple VTK files in same time directory 2024-08-05 10:43:16 +01:00
91320321f5 bin/foamVTKSeries: new script which generates '.vtk.series' files
which can be opened in ParaView, for it to interpret series of VTK files
generated by OpenFOAM post-processing.  This script supercedes the
'foamSequenceVTKFiles' script which generates a directory of indexed
soft-links which is no longer needed.  'foamSequenceVTKFiles' is
nevertheless maintained for workflow backward-compatibility.
2024-08-05 08:50:37 +01:00
1bb564c77e dictionary::changeKeyword: Convert newKeyword to word before updating the iterator name
This change allows non-pattern keywords to be changed into pattern keywords
without generating a stripInvalid error.
2024-07-30 17:32:00 +01:00
67b4399e15 surfaceAutoPatch: fixed reading includedAngle in degrees 2024-07-30 16:41:20 +01:00
d76e1b4974 distributions::tabulated: Corrected documentation 2024-07-30 11:27:55 +01:00
b4edb74dcf multiphaseEuler: Uniquely name fields to prevent duplicate registration 2024-07-30 11:27:55 +01:00
2da4528add foamSequenceVTKFiles: generates a .vtk.series file to maintain time
in a sequence of VTK files.  Instead of loading a group of VTK which
uses their index as time, the respective .vtk.series file can be loaded
which relates each file to the correct time.
2024-07-29 14:44:51 +01:00
8b1612fe08 snappyHexMeshConfig: adjust bounds of rotatingZone bounding box, updated .H file 20240728 2024-07-28 10:14:28 +01:00
275189c0c2 bash_completion: updated 2024-07-28 10:13:41 +01:00
2165520541 snappyHexMeshConfig: adjust bounds of rotatingZone bounding box,
when using '-rotatingZones' option
2024-07-27 18:11:13 +01:00
0070ddccb5 snappyHexMeshConfig: added '-noBackground' option to prevent writing of a blockMeshDict file 2024-07-27 17:11:02 +01:00
a246faf1c1 snappyHexMeshConfig: fix bounds of the background mesh without adjustment
when using the '-bounds' option
2024-07-27 17:06:46 +01:00
c6d0d1af39 snappyHexMeshConfig: improve surface projections with '-cylindricalBackground' option 2024-07-27 16:57:55 +01:00
6ebeb96563 dynamicCodeContext: Lookup variables from the context dictionary
codeStream (#calc etc.) creates a local sub-dictionary in which to expand the
code so variable lookup needs to be checked with respect to the context
dictionary rather than with respect to the code sub-dictionary.  With this
change the following test/dictionary/testCalc #calc example now works:

    a   1.1;

    d
    {
        b   4.8;
    }

    // Access to higher-level sub-entries using the "../" operators, e.g.
    f
    {
        g #calc "$a / $../d/b";
    }
2024-07-26 11:15:56 +01:00
44bfb5ac43 unitConversion: Fix bug preventing checking of dimensionless units 2024-07-25 12:47:27 +01:00
858aab68ad foamUnits: replaced hard coded search directory 2024-07-18 15:27:18 +01:00
65b4d33620 fvMeshStitcher: Fix incompatibility with CrankNicolson 2024-07-16 08:15:51 +01:00