Commit Graph

3606 Commits

Author SHA1 Message Date
3419593a95 liquidProperties::C3H6O: Corrected enthalpy coefficients
Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=3085
2018-11-03 09:59:52 +00:00
b1d3aefb6c rhoReactionThermos: Instantiated WLF transport model 2018-10-31 11:12:21 +00:00
b59c71a15e chtMultiRegionFoam: Removed Qdot from top-level solver
Qdot is only relevant for reacting cases, and even then it is only
written out for post-processing purposes. It has been removed from
chtMultiRegionFoam as this solvers' typical usage is for non-reacting
simulations.

If it is desired to obtain Qdot from a chtMultiRegionFoam simulation,
then a better way would be to implement a function object to look up the
reaction model and write it out.
2018-10-30 16:01:19 +00:00
b7c64995b0 IsothermalPhaseModel: Always correct thermo
Commit 674bff40 was in the right direction, but pressure dependence also
has to be corrected for, whether the phase is pure or not. The phase now
always updates the thermo whilst maintaining a constant temperature.
2018-10-30 15:35:41 +00:00
674bff4031 IsothermalPhaseModel: Correct base thermo
An isothermal phase still needs to trigger a thermo update in it's base
classes, primarily to ensure that any inert species fractions get
updated. This will not trigger an actual update of the thermodynamics,
as that is done in AnisothermalPhaseModel.
2018-10-30 14:27:39 +00:00
e1c95941e7 reactingEulerFoam: Added linearTsub diameter model
This is a model for the diameter of vapour bubbles. It calculates the
diameter as a linear function of the liquid sub-cooling.

Also removed the correct method from diameterModel, as it wasn't really
doing anything except facilitating the update of diameter fields to be
written out. Derived sub-models can control this locally without
polluting the base interface.

Based on patch contributed by by Juho Peltola, VTT.
2018-10-29 14:16:41 +00:00
c9d7131eef driftFluxFoam: Added support for LRR and SSG Reynolds stress models 2018-10-29 12:05:54 +00:00
ba9f8f271f HookFunctions: Fixed check for file extensions 2018-10-29 09:34:46 +00:00
30f4f70fda tutorials::wallBoilingIATE: Updated for consistency with the wallBoiling case
Resolves a thermodynamic stability problem.
20181028
2018-10-27 10:56:04 +01:00
80cc9603a1 thermophysicalModels::eRefConstThermo: New thermodynamics to be used with internal energy
in preference hRefConstThermo.
2018-10-26 18:19:44 +01:00
2cc3cb1b0d Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-10-26 11:43:34 +01:00
fc3861dacf functionObjects::turbulenceFields: The field name prefix "turbulenceProperties:" is now optional
By default the prefix is no longer added to the field names but the previous
behaviour can be reproduced by setting the optional "prefix" entry to "on" or
"yes".
2018-10-26 11:41:08 +01:00
0ae01264e4 HookFunctions: Exclude markdown files from trailing whitespace check 2018-10-26 09:31:29 +01:00
43da4fefb2 TwoResistanceHeatTransferPhaseSystem: Moved interface update to before the energy solution
This has some stability benefits for both wall boiling and evaporation
cases.

Patch contributed by Juho Peltola, VTT.
2018-10-26 08:56:49 +01:00
2249f8ad5c functionObject::turbulenceFields: Added support for basic compressible turbulence models without heat transfer support 2018-10-25 20:32:00 +01:00
0f422c2a54 thermophysicalModels: Changed constFluidEThermoPhysics and constEThermoPhysics to use eConstThermo rather than hConstThermo
to avoid the need to evaluate departure functions and simplify evaluation of the
temperature.  In general it makes more sense to use and e/Cv based
thermodynamics when solving for internal energy rather than h/Cp and have
convert between the energy forms.

All related tutorials and test cases have also been updated.
2018-10-25 10:45:45 +01:00
94e8ac2a25 EtoHthermo.H: Corrected Ha 2018-10-24 23:23:25 +01:00
da339ac190 equationOfState::perfectFluid: Added Pstd term to departure function 2018-10-24 20:11:35 +01:00
cdebd70d9a test/interfaceComposition: Changed liquid to rhoConst equation of state 2018-10-23 16:18:57 +01:00
139d75be31 TurbulenceModels::LRR: added wallDist.H 2018-10-23 12:17:44 +01:00
76425c1021 wave: Formatted references according the style guide 20181020 2018-10-19 11:06:25 +01:00
a0a88d66be volPointInterpolation: Interpolation with patch-type overrides
This resolves bug report https://bugs.openfoam.org/view.php?id=2057
2018-10-19 11:06:25 +01:00
214ae651ec reactingEulerFoam: Formatted references according the style guide
Patch contributed by Institute of Fluid Dynamics, Helmholtz-Zentrum
Dresden - Rossendorf (HZDR)
2018-10-19 11:06:25 +01:00
f9971f80d7 thermophysicalModels::equationOfState: Completed departure functions for all except adiabaticPerfectFluid
Changed liquid thermo from sensibleEnthalpy to sensibleInternalEnergy in
tutorials.  It is generally more convergent and stable to solve for internal
energy if the fluid is incompressible or weakly compressible.
2018-10-19 10:31:42 +01:00
ffc354252f equationOfState::perfectFluid: Added enthalpy departure function
Updated steamInjection to solve for internal energy for the water.
2018-10-18 12:10:28 +01:00
62d278467c src/OpenFOAM/Make/files: Updated 2018-10-17 21:23:17 +01:00
66bb8b12d3 reactingTwoPhaseEulerFoam, reactingMultiphaseEulerFoam boiling tutorials: Changed to solve for internal energy
This is more stable and convergent for incompressible fluids
2018-10-17 18:54:11 +01:00
625c6854fd equationOfState::Boussinesq, PengRobinsonGas, icoPolynomial added missing departure functions 2018-10-17 18:53:07 +01:00
91d3f06846 polynomialFunction: Removed unused class 2018-10-17 18:52:28 +01:00
0546089b7d solidEquilibriumDisplacementFoam: Updated zeroing of Dcorr field 2018-10-17 16:01:08 +01:00
a8fc88b8ee DimensionedField, GeometricField: Added assignment to zero
Zeroing a dimensioned field can now be achieved by assignment to the
zero type. This prevents the clutter associated with constructing an
appropriate dimensioned type, or having to use multiply-equals-zero as a
workaround.
2018-10-17 13:41:16 +01:00
6b740a6776 reactingEulerFoam: Fixed functionObject phaseForces
The phaseForces function object now only calulates and writes out forces
when the corresponding model exists.

Patch contributed by Institute of Fluid Dynamics, Helmholtz-Zentrum
Dresden - Rossendorf (HZDR)
2018-10-17 12:16:21 +01:00
739b9e32fb reactingEulerFoam: Minor improvements to populationBalanceModel
Changed to using of UPtrList<Type> instead of List<*Type> for storing
reference to size and velocity groups, as this removes de-referencing
clutter. Fixed lookup of critical film thickness in PrinceBlanch
coalescence model. Added functionality calculating the overall diameter,
void fraction and void fraction weighted velocity for multiple velocity
groups.

Patch contributed by Institute of Fluid Dynamics, Helmholtz-Zentrum
Dresden - Rossendorf (HZDR)
2018-10-17 12:08:10 +01:00
63b641a068 interpolationCellPointWallModified: Restored interpolation method
This interpolation method was previously removed by commit fbf00209.

The intention of this method is to provide a slip-like wall boundary
condition for the velocity when interpolated to the location of a
Lagrangian element. This is difficult because any velocity which points
through the wall can cause a drag model and a rebound wall interaction
to "fight"; i.e., the drag pushes the particle to the wall, the wall
bounces it back. This can result in the program hanging.

This method extrapolates a vector field to the wall points and then
modifies the result so that it does not point through the wall. It does
this by rotating the vectors towards the (reversed) point normal. The
result is also scaled so that is reduced to zero if the necessary
rotation exceeds 90 degrees.

This provides an alternate resolution to bug report
https://bugs.openfoam.org/view.php?id=2826
2018-10-17 08:22:13 +01:00
7ead70d89a thermophysicalModels::equationOfState: Added E and Cv departure functions 2018-10-16 17:53:17 +01:00
fc00e4c0c9 thermophysicalModels: Added direct support for Es, Ea and Cv as thermodynamic primitives 2018-10-16 09:59:42 +01:00
a0addf5e8f etc/config.sh/aliases: use a direct call to $wmProjectDir/etc/config.sh/unset rather than the wmUnset alias
Patch contributed by Bruno Santos
Resolves patch request https://bugs.openfoam.org/view.php?id=3088
2018-10-15 10:31:01 +01:00
8102dd3e47 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-10-15 10:19:50 +01:00
849c11b637 gmvOutputParcels.H: Removed unused file
Resolved https://bugs.openfoam.org/view.php?id=3090
2018-10-15 10:18:58 +01:00
47efc8f898 cyclicAMIPointPatchField: Fixed type-detection for ACMI 2018-10-15 09:17:19 +01:00
45a4930538 rhoThermos: Instantiate liquid thermo packages on eConstThermo rather than hConstThermo
to provide better numerical behaviour of the conversion of internal energy to temperature.
2018-10-13 21:50:10 +01:00
7f16808709 eConstThermo: Improve consistency between the H and E functions
so that conversions between H and E and back again reproduce the original
values.
2018-10-13 21:46:48 +01:00
e1e7d4d763 nutkAtmRoughWallFunctionFvPatchScalarField: Minor improvement to documentation 2018-10-13 21:46:22 +01:00
c17e6dbfe4 KinematicParcel: Do not execute face/patch functions when inactive
Resolves bug report https://bugs.openfoam.org/view.php?id=3084
2018-10-12 08:57:10 +01:00
dffe3213d7 doc/Doxygen/Doxyfile: Increased FORMULA_FONTSIZE to 16 2018-10-07 10:24:52 +01:00
8f3f2f7365 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 20181008 2018-10-05 21:30:13 +01:00
ff2c2dfea3 turbulentTransportModel: Renamed template parameter
Resolves request https://bugs.openfoam.org/view.php?id=3081
2018-10-05 21:29:05 +01:00
94d5db7198 treeBoundBox: Improved asymmetry
This fixes a failure in the foamyHexMesh mixerVessel case
2018-10-05 16:06:26 +01:00
85cdf55073 conformalVoronoiMesh: Fixed processor patch reordering 2018-10-05 16:06:26 +01:00
77dd7556c9 offsetCylinder: New tutorial to demonstrate the generalizedNewtonian laminarModel
with the CrossPowerLaw viscosityModel
2018-10-05 11:28:34 +01:00