ENH: Added check to field sources to issue warning if source defined but not used

src/finiteVolume/cfdTools/general/fieldSources/basicSource/basicSource/basicSource.H

@@ -242,6 +242,9 @@ public:
             //- Return const access to the source active flag
             inline bool active() const;
 
+            //- Return const access to the applied flag
+            inline bool applied() const;
+
             //- Return const access to the time start
             inline scalar timeStart() const;
 

src/finiteVolume/cfdTools/general/fieldSources/basicSource/basicSource/basicSourceI.H

@@ -51,6 +51,12 @@ inline bool Foam::basicSource::active() const
 }
 
 
+inline bool Foam::basicSource::applied() const
+{
+    return applied_;
+}
+
+
 inline Foam::scalar Foam::basicSource::timeStart() const
 {
     return timeStart_;

src/finiteVolume/cfdTools/general/fieldSources/basicSource/basicSource/basicSourceList.C

@@ -33,6 +33,24 @@ namespace Foam
     defineTypeNameAndDebug(basicSourceList, 0);
 }
 
+
+// * * * * * * * * * * * * Private Member Functions  * * * * * * * * * * * //
+
+void Foam::basicSourceList::checkApplied() const
+{
+    forAll(*this, i)
+    {
+        const basicSource& bs = this->operator[](i);
+
+        if (!bs.applied())
+        {
+            WarningIn("void Foam::basicSourceList::checkApplied() const")
+                << "Source " << bs.name() << " defined, but not used" << endl;
+        }
+    }
+}
+
+
 // * * * * * * * * * * * * * * * * Constructors  * * * * * * * * * * * * * * //
 
 Foam::basicSourceList::basicSourceList

src/finiteVolume/cfdTools/general/fieldSources/basicSource/basicSource/basicSourceList.H

@@ -62,6 +62,9 @@ private:
 
     // Private Member Functions
 
+        //- Check that all sources have been applied
+        void checkApplied() const;
+
         //- Disallow default bitwise copy construct
         basicSourceList(const basicSourceList&);
 

src/finiteVolume/cfdTools/general/fieldSources/basicSource/basicSource/basicSourceListTemplates.C

@@ -23,11 +23,19 @@ License
 
 \*---------------------------------------------------------------------------*/
 
+#include "fvMesh.H"
+#include "Time.H"
+
 // * * * * * * * * * * * * * * * Member Functions  * * * * * * * * * * * * * //
 
 template<class Type>
 void Foam::basicSourceList::apply(fvMatrix<Type>& eqn)
 {
+    if (mesh_.time().timeIndex() == mesh_.time().startTimeIndex() + 1)
+    {
+        checkApplied();
+    }
+
     const word& fieldName = eqn.psi().name();
 
     forAll(*this, i)