zhyang-dev/openfoam
1
0
Fork 0
mirror of https://develop.openfoam.com/Development/openfoam.git synced 2025-11-28 03:28:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

BUG: state error in volRegion::calculateCache() (fixes #2121)

Browse Source 
- need to change requireUpdate_ at the beginning of calculateCache
  otherwise it is not updated for "ALL" selection (causing unnecessary
  repeated calculations). For other modes, it would have tripped
  an error in FULLDEBUG.
This commit is contained in:
Kutalmis Bercin
2021-07-02 13:12:45 +01:00
committed by Mark Olesen
parent 8cda8e5c3a
commit 64deb4e4b8
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/finiteVolume/functionObjects/volRegion/volRegion.C
View File

@ -61,6 +61,9 @@ void Foam::functionObjects::volRegion::calculateCache()
regionID_ = -1;
cellIds_.clear();
// Update now. Need a valid state for the cellIDs() call
requireUpdate_ = false;
switch (regionType_)
{
case vrtAll:
@ -93,15 +96,18 @@ void Foam::functionObjects::volRegion::calculateCache()
}
}
// Cached value for nCells()
nCells_ = returnReduce(cellIDs().size(), sumOp<label>());
// Cached value for V()
// Calculate cache value for nCells() and V()
const labelList& selected = this->cellIDs();
nCells_ = selected.size();
V_ = 0;
for (const label celli : cellIDs())
for (const label celli : selected)
{
V_ += volMesh_.V()[celli];
}
reduce(nCells_, sumOp<label>());
reduce(V_, sumOp<scalar>());
if (!nCells_)
@ -112,8 +118,6 @@ void Foam::functionObjects::volRegion::calculateCache()
<< " Region has no cells" << nl
<< exit(FatalError);
}
requireUpdate_ = false;
}