COMP: g++11: suppress optimisation. See #3024

Was checking the old celli instead of the result of
re-finding the position. See also Foundation commit 50a965f8866683a81d79cbc7811af7333baf9d10.

src/OpenFOAM/db/error/error.C

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2014 OpenFOAM Foundation
-    Copyright (C) 2015-2023 OpenCFD Ltd.
+    Copyright (C) 2015-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -34,24 +34,8 @@ License
 #include "Pstream.H"
 #include "foamVersion.H"
 #include "OSspecific.H"
-#include "Enum.H"
 #include "Switch.H"
 
-// * * * * * * * * * * * * * * Static Data Members * * * * * * * * * * * * * //
-
-const Foam::Enum
-<
-    Foam::error::handlerTypes
->
-Foam::error::handlerNames
-({
-    { handlerTypes::DEFAULT, "default" },
-    { handlerTypes::IGNORE, "ignore" },
-    { handlerTypes::WARN, "warn" },
-    { handlerTypes::STRICT, "strict" },
-});
-
-
 // * * * * * * * * * * * * * Static Member Functions * * * * * * * * * * * * //
 
 void Foam::error::warnAboutAge(const char* what, const int version)

src/OpenFOAM/db/error/error.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2015 OpenFOAM Foundation
-    Copyright (C) 2015-2023 OpenCFD Ltd.
+    Copyright (C) 2015-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -53,8 +53,8 @@ SeeAlso
 
 \*---------------------------------------------------------------------------*/
 
-#ifndef Foam_error_H
-#define Foam_error_H
+#ifndef error_H
+#define error_H
 
 #include "messageStream.H"
 #include <memory>
@@ -64,10 +64,6 @@ SeeAlso
 namespace Foam
 {
 
-// Forward Declarations
-class OStringStream;
-template<class EnumType> class Enum;
-
 /*---------------------------------------------------------------------------*\
                             Class error Declaration
 \*---------------------------------------------------------------------------*/
@@ -96,21 +92,6 @@ protected:
 
 public:
 
-    // Data Types
-
-        //- Handling of errors. The exact handling depends on the local context.
-        enum class handlerTypes : char
-        {
-            DEFAULT = 0,  //!< Default behaviour (local meaning)
-            IGNORE,       //!< Ignore on errors/problems
-            WARN,         //!< Warn on errors/problems
-            STRICT        //!< Fatal on errors/problems
-        };
-
-        //- Names of the error handler types
-        static const Enum<handlerTypes> handlerNames;
-
-
     // Constructors
 
         //- Construct from title string

src/OpenFOAM/db/functionObjects/functionObjectList/functionObjectList.C

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2017 OpenFOAM Foundation
-    Copyright (C) 2015-2023 OpenCFD Ltd.
+    Copyright (C) 2015-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -43,7 +43,7 @@ License
 /* * * * * * * * * * * * * * * Static Member Data  * * * * * * * * * * * * * */
 
 //- Max number of warnings (per functionObject)
-static constexpr const unsigned maxWarnings = 10u;
+static constexpr const uint32_t maxWarnings = 10u;
 
 Foam::fileName Foam::functionObjectList::functionObjectDictPath
 (
@@ -51,6 +51,19 @@ Foam::fileName Foam::functionObjectList::functionObjectDictPath
 );
 
 
+const Foam::Enum
+<
+    Foam::functionObjectList::errorHandlingType
+>
+Foam::functionObjectList::errorHandlingNames_
+({
+    { errorHandlingType::DEFAULT, "default" },
+    { errorHandlingType::WARN, "warn" },
+    { errorHandlingType::IGNORE, "ignore" },
+    { errorHandlingType::STRICT, "strict" },
+});
+
+
 // * * * * * * * * * * * * * * * Local Functions * * * * * * * * * * * * * * //
 
 namespace Foam
@@ -383,12 +396,12 @@ bool Foam::functionObjectList::readFunctionObject
 }
 
 
-Foam::error::handlerTypes
+Foam::functionObjectList::errorHandlingType
 Foam::functionObjectList::getOrDefaultErrorHandling
 (
     const word& key,
     const dictionary& dict,
-    const error::handlerTypes deflt
+    const errorHandlingType deflt
 ) const
 {
     const entry* eptr = dict.findEntry(key, keyType::LITERAL);
@@ -405,16 +418,16 @@ Foam::functionObjectList::getOrDefaultErrorHandling
         {
             const word enumName(eptr->get<word>());
 
-            if (!error::handlerNames.found(enumName))
+            if (!errorHandlingNames_.found(enumName))
             {
                 // Failed the name lookup
                 FatalIOErrorInFunction(dict)
                     << enumName << " is not in enumeration: "
-                    << error::handlerNames << nl
+                    << errorHandlingNames_ << nl
                     << exit(FatalIOError);
             }
 
-            return error::handlerNames.get(enumName);
+            return errorHandlingNames_.get(enumName);
         }
     }
 
@@ -670,15 +683,15 @@ bool Foam::functionObjectList::execute()
 
         for (functionObject& funcObj : functions())
         {
-            const auto errorHandling = *errIter;
+            const errorHandlingType errorHandling = *errIter;
             ++errIter;
 
             const word& objName = funcObj.name();
 
             if
             (
-                errorHandling == error::handlerTypes::WARN
-             || errorHandling == error::handlerTypes::IGNORE
+                errorHandling == errorHandlingType::WARN
+             || errorHandling == errorHandlingType::IGNORE
             )
             {
                 // Throw FatalError, FatalIOError as exceptions
@@ -702,12 +715,12 @@ bool Foam::functionObjectList::execute()
                 catch (const Foam::error& err)
                 {
                     // Treat IOerror and error identically
-                    unsigned nWarnings;
+                    uint32_t nWarnings;
                     hadError = true;
 
                     if
                     (
-                        (errorHandling != error::handlerTypes::IGNORE)
+                        errorHandling != errorHandlingType::IGNORE
                      && (nWarnings = ++warnings_(objName)) <= maxWarnings
                     )
                     {
@@ -748,11 +761,11 @@ bool Foam::functionObjectList::execute()
                 catch (const Foam::error& err)
                 {
                     // Treat IOerror and error identically
-                    unsigned nWarnings;
+                    uint32_t nWarnings;
 
                     if
                     (
-                        (errorHandling != error::handlerTypes::IGNORE)
+                        errorHandling != errorHandlingType::IGNORE
                      && (nWarnings = ++warnings_(objName)) <= maxWarnings
                     )
                     {
@@ -881,7 +894,7 @@ bool Foam::functionObjectList::end()
 
         for (functionObject& funcObj : functions())
         {
-            const auto errorHandling = *errIter;
+            const errorHandlingType errorHandling = *errIter;
             ++errIter;
 
             const word& objName = funcObj.name();
@@ -900,11 +913,11 @@ bool Foam::functionObjectList::end()
             catch (const Foam::error& err)
             {
                 // Treat IOerror and error identically
-                unsigned nWarnings;
+                uint32_t nWarnings;
 
                 if
                 (
-                    (errorHandling != error::handlerTypes::IGNORE)
+                    errorHandling != errorHandlingType::IGNORE
                  && (nWarnings = ++warnings_(objName)) <= maxWarnings
                 )
                 {
@@ -1012,7 +1025,7 @@ bool Foam::functionObjectList::read()
         errorHandling_.resize
         (
             functionsDict.size(),
-            error::handlerTypes::DEFAULT
+            errorHandlingType::DEFAULT
         );
 
         HashTable<label> newIndices;
@@ -1028,12 +1041,12 @@ bool Foam::functionObjectList::read()
         );
 
         // Top-level "errors" specification (optional)
-        const error::handlerTypes errorHandlingFallback =
+        const errorHandlingType errorHandlingFallback =
             getOrDefaultErrorHandling
             (
                 "errors",
                 functionsDict,
-                error::handlerTypes::DEFAULT
+                errorHandlingType::DEFAULT
             );
 
         label nFunc = 0;
@@ -1058,7 +1071,7 @@ bool Foam::functionObjectList::read()
             bool enabled = dict.getOrDefault("enabled", true);
 
             // Per-function "errors" specification
-            const error::handlerTypes errorHandling =
+            const errorHandlingType errorHandling =
                 getOrDefaultErrorHandling
                 (
                     "errors",
@@ -1148,16 +1161,16 @@ bool Foam::functionObjectList::read()
 
                     switch (errorHandling)
                     {
-                        case error::handlerTypes::IGNORE:
+                        case errorHandlingType::IGNORE:
                             break;
 
-                        case error::handlerTypes::STRICT:
+                        case errorHandlingType::STRICT:
                         {
                             exitNow(err);
                             break;
                         }
 
-                        case error::handlerTypes::DEFAULT:
+                        case errorHandlingType::DEFAULT:
                         {
                             if (isA<Foam::IOerror>(err))
                             {
@@ -1170,7 +1183,7 @@ bool Foam::functionObjectList::read()
                             [[fallthrough]];
                         }
 
-                        case error::handlerTypes::WARN:
+                        case errorHandlingType::WARN:
                         {
                             // Trickery to get original message
                             err.write(Warning, false);

src/OpenFOAM/db/functionObjects/functionObjectList/functionObjectList.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2016 OpenFOAM Foundation
-    Copyright (C) 2015-2023 OpenCFD Ltd.
+    Copyright (C) 2015-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -77,10 +77,11 @@ SourceFiles
 
 \*---------------------------------------------------------------------------*/
 
-#ifndef Foam_functionObjectList_H
-#define Foam_functionObjectList_H
+#ifndef functionObjectList_H
+#define functionObjectList_H
 
 #include "PtrList.H"
+#include "Enum.H"
 #include "functionObject.H"
 #include "SHA1Digest.H"
 #include "HashTable.H"
@@ -105,10 +106,25 @@ class functionObjectList
 :
     private PtrList<functionObject>
 {
+    // Data Types
+
+        //- Handling of construction or execution errors
+        enum class errorHandlingType : uint8_t
+        {
+            DEFAULT = 0,  //!< Warn on construct, Fatal on runtime
+            WARN,         //!< Warn on construct, Warn on runtime
+            IGNORE,       //!< Ignore on construct, Ignore on runtime
+            STRICT,       //!< Fatal on construct, Fatal on runtime
+        };
+
+        //- Names for error handling types
+        static const Enum<errorHandlingType> errorHandlingNames_;
+
+
     // Private Data
 
         //- A list of error/warning handling
-        List<error::handlerTypes> errorHandling_;
+        List<errorHandlingType> errorHandling_;
 
         //- A list of SHA1 digests for the function object dictionaries
         List<SHA1Digest> digests_;
@@ -119,7 +135,7 @@ class functionObjectList
         //- Track the number of warnings per function object and limit
         //  to a predefined number to avoid flooding the display.
         //  Clear on re-read of functions.
-        HashTable<unsigned> warnings_;
+        HashTable<uint32_t> warnings_;
 
         //- Reference to Time
         const Time& time_;
@@ -169,11 +185,11 @@ class functionObjectList
         //
         //  This additional treatment is to ensure that potentially existing
         //  code with an "errors" functionObject will continue to run.
-        error::handlerTypes getOrDefaultErrorHandling
+        errorHandlingType getOrDefaultErrorHandling
         (
             const word& key,
             const dictionary& dict,
-            const error::handlerTypes deflt
+            const errorHandlingType deflt
         ) const;
 
 

src/OpenFOAM/primitives/Tensor/TensorI.H

@@ -513,6 +513,10 @@ inline Foam::Tensor<Cmpt> Foam::Tensor<Cmpt>::T() const
 
 
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Foam::Tensor<Cmpt>
 Foam::Tensor<Cmpt>::inner(const Tensor<Cmpt>& t2) const
 {
@@ -536,6 +540,10 @@ Foam::Tensor<Cmpt>::inner(const Tensor<Cmpt>& t2) const
 
 
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Foam::Tensor<Cmpt>
 Foam::Tensor<Cmpt>::schur(const Tensor<Cmpt>& t2) const
 {
@@ -970,6 +978,10 @@ operator&(const Tensor<Cmpt>& t1, const Tensor<Cmpt>& t2)
 
 //- Inner-product of a SphericalTensor and a Tensor
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Tensor<Cmpt>
 operator&(const SphericalTensor<Cmpt>& st1, const Tensor<Cmpt>& t2)
 {
@@ -984,6 +996,10 @@ operator&(const SphericalTensor<Cmpt>& st1, const Tensor<Cmpt>& t2)
 
 //- Inner-product of a Tensor and a SphericalTensor
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Tensor<Cmpt>
 operator&(const Tensor<Cmpt>& t1, const SphericalTensor<Cmpt>& st2)
 {
@@ -998,6 +1014,10 @@ operator&(const Tensor<Cmpt>& t1, const SphericalTensor<Cmpt>& st2)
 
 //- Inner-product of a SymmTensor and a Tensor
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Tensor<Cmpt>
 operator&(const SymmTensor<Cmpt>& st1, const Tensor<Cmpt>& t2)
 {
@@ -1020,6 +1040,10 @@ operator&(const SymmTensor<Cmpt>& st1, const Tensor<Cmpt>& t2)
 
 //- Inner-product of a Tensor and a SymmTensor
 template<class Cmpt>
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
 inline Tensor<Cmpt>
 operator&(const Tensor<Cmpt>& t1, const SymmTensor<Cmpt>& st2)
 {
@@ -1046,7 +1070,7 @@ template<class Cmpt>
 // Workaround for gcc (11+) that fails to handle tensor dot vector
 __attribute__((optimize("no-tree-vectorize")))
 #endif
-inline typename innerProduct<Tensor<Cmpt>, Vector<Cmpt>>::type
+inline Vector<Cmpt>
 operator&(const Tensor<Cmpt>& t, const Vector<Cmpt>& v)
 {
     return Vector<Cmpt>
@@ -1060,7 +1084,11 @@ operator&(const Tensor<Cmpt>& t, const Vector<Cmpt>& v)
 
 //- Inner-product of a Vector and a Tensor
 template<class Cmpt>
-inline typename innerProduct<Vector<Cmpt>, Tensor<Cmpt>>::type
+#if defined(__GNUC__) && !defined(__clang__)
+// Workaround for gcc (11+) that fails to handle tensor dot vector
+__attribute__((optimize("no-tree-vectorize")))
+#endif
+inline Vector<Cmpt>
 operator&(const Vector<Cmpt>& v, const Tensor<Cmpt>& t)
 {
     return Vector<Cmpt>

src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.C

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2017 OpenFOAM Foundation
-    Copyright (C) 2017-2023 OpenCFD Ltd.
+    Copyright (C) 2017-2021 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -38,9 +38,6 @@ License
 
 // * * * * * * * * * * * * * * Static Data Members * * * * * * * * * * * * * //
 
-// Max number of warnings
-static constexpr const unsigned maxWarnings = 10u;
-
 namespace Foam
 {
 namespace functionObjects
@@ -139,13 +136,39 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setFaceZoneFaces()
         mesh_.faceZones().indices(selectionNames_)
     );
 
-    // Total number of faces that could be selected (before patch filtering)
+    // Total number of faces selected
     label numFaces = 0;
     for (const label zoneId : zoneIds)
     {
         numFaces += mesh_.faceZones()[zoneId].size();
     }
 
+    if (zoneIds.empty())
+    {
+        FatalErrorInFunction
+            << type() << ' ' << name() << ": "
+            << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl
+            << "    No matching face zone(s): "
+            << flatOutput(selectionNames_)  << nl
+            << "    Known face zones: "
+            << flatOutput(mesh_.faceZones().names()) << nl
+            << exit(FatalError);
+    }
+
+    // Could also check this
+    #if 0
+    if (!returnReduce(bool(numFaces), orOp<bool>()))
+    {
+        WarningInFunction
+            << type() << ' ' << name() << ": "
+            << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl
+            << "    The faceZone specification: "
+            << flatOutput(selectionNames_) << nl
+            << "    resulted in 0 faces" << nl
+            << exit(FatalError);
+    }
+    #endif
+
     faceId_.resize(numFaces);
     facePatchId_.resize(numFaces);
     faceFlip_.resize(numFaces);
@@ -208,75 +231,7 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setFaceZoneFaces()
     faceId_.resize(numFaces);
     facePatchId_.resize(numFaces);
     faceFlip_.resize(numFaces);
-    nFaces_ = returnReduce(numFaces, sumOp<label>());
-
-    if (!nFaces_)
-    {
-        // Raise warning or error
-        refPtr<OSstream> os;
-        bool fatal = false;
-
-        ++nWarnings_;  // Always increment (even if ignore etc)
-
-        switch (emptySurfaceError_)
-        {
-            case error::handlerTypes::IGNORE:
-            {
-                break;
-            }
-
-            case error::handlerTypes::WARN:
-            {
-                if (nWarnings_ <= maxWarnings)
-                {
-                    os.ref(WarningInFunction);
-                }
-                break;
-            }
-
-            // STRICT / DEFAULT
-            default:
-            {
-                os.ref(FatalErrorInFunction);
-                fatal = true;
-                break;
-            }
-        }
-
-        if (os)
-        {
-            os.ref()
-                << type() << ' ' << name() << ": "
-                << regionTypeNames_[regionType_]
-                << '(' << regionName_ << "):" << nl;
-
-            if (zoneIds.empty())
-            {
-                os.ref()
-                    << "    No matching face zones: "
-                    << flatOutput(selectionNames_)  << nl
-                    << "    Known face zones: "
-                    << flatOutput(mesh_.faceZones().names()) << nl;
-            }
-            else
-            {
-                os.ref()
-                    << "    The face zones: "
-                    << flatOutput(selectionNames_) << nl
-                    << "    resulted in 0 faces" << nl;
-            }
-
-            if (fatal)
-            {
-                FatalError<< exit(FatalError);
-            }
-            else if (nWarnings_ == maxWarnings)
-            {
-                os.ref()
-                    << "... suppressing further warnings." << nl;
-            }
-        }
-    }
+    nFaces_ = returnReduce(faceId_.size(), sumOp<label>());
 }
 
 
@@ -352,10 +307,36 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setPatchFaces()
         patchIds = std::move(selected);
     }
 
+    if (patchIds.empty())
+    {
+        FatalErrorInFunction
+            << type() << ' ' << name() << ": "
+            << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl
+            << "    No matching patch name(s): "
+            << flatOutput(selectionNames_)  << nl
+            << "    Known patch names:" << nl
+            << mesh_.boundaryMesh().names() << nl
+            << exit(FatalError);
+    }
+
+    // Could also check this
+    #if 0
+    if (!returnReduce(bool(numFaces), orOp<bool>()))
+    {
+        WarningInFunction
+            << type() << ' ' << name() << ": "
+            << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl
+            << "    The patch specification: "
+            << flatOutput(selectionNames_) << nl
+            << "    resulted in 0 faces" << nl
+            << exit(FatalError);
+    }
+    #endif
+
     faceId_.resize(numFaces);
     facePatchId_.resize(numFaces);
     faceFlip_.resize(numFaces);
-    nFaces_ = returnReduce(numFaces, sumOp<label>());
+    nFaces_ = returnReduce(faceId_.size(), sumOp<label>());
 
     numFaces = 0;
     for (const label patchi : patchIds)
@@ -369,74 +350,6 @@ void Foam::functionObjects::fieldValues::surfaceFieldValue::setPatchFaces()
 
         numFaces += len;
     }
-
-    if (!nFaces_)
-    {
-        // Raise warning or error
-        refPtr<OSstream> os;
-        bool fatal = false;
-
-        ++nWarnings_;  // Always increment (even if ignore etc)
-
-        switch (emptySurfaceError_)
-        {
-            case error::handlerTypes::IGNORE:
-            {
-                break;
-            }
-
-            case error::handlerTypes::WARN:
-            {
-                if (nWarnings_ <= maxWarnings)
-                {
-                    os.ref(WarningInFunction);
-                }
-                break;
-            }
-
-            // STRICT / DEFAULT
-            default:
-            {
-                os.ref(FatalErrorInFunction);
-                fatal = true;
-                break;
-            }
-        }
-
-        if (os)
-        {
-            os.ref()
-                << type() << ' ' << name() << ": "
-                << regionTypeNames_[regionType_]
-                << '(' << regionName_ << "):" << nl;
-
-            if (patchIds.empty())
-            {
-                os.ref()
-                    << "    No matching patches: "
-                    << flatOutput(selectionNames_)  << nl
-                    << "    Known patch names:" << nl
-                    << mesh_.boundaryMesh().names() << nl;
-            }
-            else
-            {
-                os.ref()
-                    << "    The patches: "
-                    << flatOutput(selectionNames_) << nl
-                    << "    resulted in 0 faces" << nl;
-            }
-
-            if (fatal)
-            {
-                FatalError<< exit(FatalError);
-            }
-            else if (nWarnings_ == maxWarnings)
-            {
-                os.ref()
-                    << "... suppressing further warnings." << nl;
-            }
-        }
-    }
 }
 
 
@@ -670,30 +583,20 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::update()
         return false;
     }
 
-    // Reset some values
-    totalArea_ = 0;
-    nFaces_ = 0;
-    bool checkEmptyFaces = true;
-
     switch (regionType_)
     {
         case stFaceZone:
         {
-            // Raises warning or error internally, don't check again
             setFaceZoneFaces();
-            checkEmptyFaces = false;
             break;
         }
         case stPatch:
         {
-            // Raises warning or error internally, don't check again
             setPatchFaces();
-            checkEmptyFaces = false;
             break;
         }
         case stObject:
         {
-            // TBD: special handling of cast errors?
             const polySurface& s = dynamicCast<const polySurface>(obr());
             nFaces_ = returnReduce(s.size(), sumOp<label>());
             break;
@@ -707,76 +610,23 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::update()
         // Compiler warning if we forgot an enumeration
     }
 
-    if (nFaces_)
+    if (nFaces_ == 0)
     {
-        // Appears to be successful
-        needsUpdate_ = false;
-        totalArea_ = totalArea();   // Update the area
-        nWarnings_ = 0u;            // Reset the warnings counter
+        FatalErrorInFunction
+            << type() << ' ' << name() << ": "
+            << regionTypeNames_[regionType_] << '(' << regionName_ << "):" << nl
+            << "    Region has no faces" << exit(FatalError);
     }
-    else if (checkEmptyFaces)
-    {
-        // Raise warning or error
-        refPtr<OSstream> os;
-        bool fatal = false;
 
-        ++nWarnings_;  // Always increment (even if ignore etc)
-
-        switch (emptySurfaceError_)
-        {
-            case error::handlerTypes::IGNORE:
-            {
-                break;
-            }
-
-            case error::handlerTypes::WARN:
-            {
-                if (nWarnings_ <= maxWarnings)
-                {
-                    os.ref(WarningInFunction);
-                }
-                break;
-            }
-
-            // STRICT / DEFAULT
-            default:
-            {
-                os.ref(FatalErrorInFunction);
-                fatal = true;
-                break;
-            }
-        }
-
-        if (os)
-        {
-            os.ref()
-                << type() << ' ' << name() << ": "
-                << regionTypeNames_[regionType_]
-                << '(' << regionName_ << "):" << nl
-                << "    Region has no faces" << endl;
-
-            if (fatal)
-            {
-                FatalError<< exit(FatalError);
-            }
-            else if (nWarnings_ == maxWarnings)
-            {
-                os.ref()
-                    << "... suppressing further warnings." << nl;
-            }
-        }
-    }
+    totalArea_ = totalArea();
 
     Log << "    total faces   = " << nFaces_ << nl
         << "    total area    = " << totalArea_ << nl
         << endl;
 
-    // Emit file header on success or change of state
-    if (nWarnings_ <= 1)
-    {
-        writeFileHeader(file());
-    }
+    writeFileHeader(file());
 
+    needsUpdate_ = false;
     return true;
 }
 
@@ -1069,12 +919,10 @@ Foam::functionObjects::fieldValues::surfaceFieldValue::surfaceFieldValue
     ),
     needsUpdate_(true),
     writeArea_(false),
-    emptySurfaceError_(error::handlerTypes::DEFAULT),
     selectionNames_(),
     weightFieldNames_(),
     totalArea_(0),
     nFaces_(0),
-    nWarnings_(0),
     faceId_(),
     facePatchId_(),
     faceFlip_()
@@ -1105,12 +953,10 @@ Foam::functionObjects::fieldValues::surfaceFieldValue::surfaceFieldValue
     ),
     needsUpdate_(true),
     writeArea_(false),
-    emptySurfaceError_(error::handlerTypes::DEFAULT),
     selectionNames_(),
     weightFieldNames_(),
     totalArea_(0),
     nFaces_(0),
-    nWarnings_(0),
     faceId_(),
     facePatchId_(),
     faceFlip_()
@@ -1130,19 +976,10 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::read
 
     needsUpdate_ = true;
     writeArea_ = dict.getOrDefault("writeArea", false);
-    emptySurfaceError_ = error::handlerNames.getOrDefault
-    (
-        "empty-surface",
-        dict,
-        error::handlerTypes::DEFAULT,
-        true  // Failsafe behaviour
-    );
-
     weightFieldNames_.clear();
 
     totalArea_ = 0;
     nFaces_ = 0;
-    nWarnings_ = 0;
     faceId_.clear();
     facePatchId_.clear();
     faceFlip_.clear();
@@ -1324,15 +1161,7 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::write()
 
     if (writeArea_)
     {
-        // Update the area
-        if (!nFaces_)
-        {
-            totalArea_ = 0;
-        }
-        else
-        {
-            totalArea_ = totalArea();
-        }
+        totalArea_ = totalArea();
         Log << "    total area = " << totalArea_ << endl;
 
         if (operation_ != opNone && Pstream::master())
@@ -1341,18 +1170,6 @@ bool Foam::functionObjects::fieldValues::surfaceFieldValue::write()
         }
     }
 
-    if (!nFaces_)
-    {
-        // Early exit on error
-        if (operation_ != opNone)
-        {
-            file() << endl;
-            Log << endl;
-        }
-        return true;
-    }
-
-
     // Many operations use the Sf field
     vectorField Sf;
     if (usesSf())

src/functionObjects/field/fieldValues/surfaceFieldValue/surfaceFieldValue.H

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2017 OpenFOAM Foundation
-    Copyright (C) 2015-2023 OpenCFD Ltd.
+    Copyright (C) 2015-2020 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -88,7 +88,6 @@ Usage
         scaleFactor     1.0;
         writeArea       false;
         surfaceFormat   none;
-        empty-surface   warn;  // default | warn | ignore | strict
 
         // Optional (inherited) entries
         ...
@@ -112,7 +111,6 @@ Usage
       writeArea    | Write the surface area             | bool |  no   | false
       surfaceFormat | Output value format               | word <!--
                 --> | conditional on writeFields  | none
-      empty-surface | Error handling for empty surfaces | enum | no | default
     \endtable
 
     The inherited entries are elaborated in:
@@ -403,9 +401,6 @@ protected:
         //- Optionally write the area of the surfaceFieldValue
         bool writeArea_;
 
-        //- Handling of empty surfaces (nFaces = 0). Default is Fatal.
-        error::handlerTypes emptySurfaceError_;
-
         //- Extended selections
         wordRes selectionNames_;
 
@@ -418,9 +413,6 @@ protected:
         //- Global number of faces
         label nFaces_;
 
-        //- Number of warnings emitted since the last valid update
-        unsigned nWarnings_;
-
 
     // If operating on mesh faces (faceZone, patch)
 

src/lagrangian/basic/particle/particle.C

@@ -6,7 +6,7 @@
      \\/     M anipulation  |
 -------------------------------------------------------------------------------
     Copyright (C) 2011-2017, 2020 OpenFOAM Foundation
-    Copyright (C) 2018-2020 OpenCFD Ltd.
+    Copyright (C) 2018-2021 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -415,21 +415,21 @@ void Foam::particle::locate
 {
     if (debug)
     {
-        Info << "Particle " << origId() << nl << FUNCTION_NAME << nl << endl;
+        Pout<< "Particle " << origId() << nl << FUNCTION_NAME << nl << endl;
     }
 
     celli_ = celli;
 
     // Find the cell, if it has not been given
-    if (celli < 0)
+    if (celli_ < 0)
     {
         celli_ = mesh_.cellTree().findInside(position);
-    }
-    if (celli < 0)
-    {
-        FatalErrorInFunction
-            << "Cell not found for particle position " << position << "."
-            << exit(FatalError);
+        if (celli_ < 0)
+        {
+            FatalErrorInFunction
+                << "Cell not found for particle position " << position << "."
+                << exit(FatalError);
+        }
     }
 
     const vector displacement = position - mesh_.cellCentres()[celli_];
@@ -811,10 +811,10 @@ Foam::scalar Foam::particle::trackToStationaryTri
 
     if (debug)
     {
-        Info << "Step Fraction : " << stepFraction_ << endl;
-        Info << "fraction*muH*detA : " << fraction*muH*detA << endl;
-        Info << "static muH : " << muH << endl;
-        Info << "origId() : " << origId() << endl;
+        Pout << "Step Fraction : " << stepFraction_ << endl;
+        Pout << "fraction*muH*detA : " << fraction*muH*detA << endl;
+        Pout << "static muH : " << muH << endl;
+        Pout << "origId() : " << origId() << endl;
     }
 
     // Accumulate displacement behind
@@ -864,7 +864,7 @@ Foam::scalar Foam::particle::trackToMovingTri
     {
         Pair<vector> o, b, v1, v2;
         movingTetGeometry(fraction, o, b, v1, v2);
-        Info<< "Tet points o=" << o[0] << ", b=" << b[0]
+        Pout<< "Tet points o=" << o[0] << ", b=" << b[0]
             << ", v1=" << v1[0] << ", v2=" << v2[0] << endl
             << "Tet determinant = " << detA[0] << endl
             << "Start local coordinates = " << y0[0] << endl;
@@ -895,10 +895,10 @@ Foam::scalar Foam::particle::trackToMovingTri
     {
         for (label i = 0; i < 4; ++ i)
         {
-            Info<< (i ? "             " : "Hit equation ") << i << " = "
+            Pout<< (i ? "             " : "Hit equation ") << i << " = "
                 << hitEqn[i] << endl;
         }
-        Info<< " DetA equation = " << detA << endl;
+        Pout<< " DetA equation = " << detA << endl;
     }
 
     // Calculate the hit fraction
@@ -927,12 +927,12 @@ Foam::scalar Foam::particle::trackToMovingTri
                     );
                     const scalar detAH = detAEqn.value(mu[j]);
 
-                    Info<< "Hit on tet face " << i << " at local coordinate "
+                    Pout<< "Hit on tet face " << i << " at local coordinate "
                         << (std::isnormal(detAH) ? name(yH/detAH) : "???")
                         << ", " << mu[j]*detA[0]*100 << "% of the "
                         << "way along the track" << endl;
 
-                    Info<< "derivative : " << hitEqn[i].derivative(mu[j]) << nl
+                    Pout<< "derivative : " << hitEqn[i].derivative(mu[j]) << nl
                         << " coord " << j << " mu[j]: " << mu[j] << nl
                         << " hitEq " << i << endl;
                 }

src/sampling/meshToMesh/meshToMeshTemplates.C

@@ -843,15 +843,15 @@ Foam::meshToMesh::mapTgtToSrc
         label srcPatchi = srcPatchID_[i];
         label tgtPatchi = tgtPatchID_[i];
 
-        if (!srcPatchFields.set(tgtPatchi))
+        if (!srcPatchFields.set(srcPatchi))
         {
             srcPatchFields.set
             (
                 srcPatchi,
                 fvPatchField<Type>::New
                 (
-                    tgtBfld[srcPatchi],
-                    srcMesh.boundary()[tgtPatchi],
+                    tgtBfld[tgtPatchi],
+                    srcMesh.boundary()[srcPatchi],
                     DimensionedField<Type, volMesh>::null(),
                     directFvPatchFieldMapper
                     (