Commit Graph

5245 Commits

Author SHA1 Message Date
40bc30c0f7 multiphaseEulerFoam: wallBoiling: Corrections to tabulated thermo
The themo tables used in wallBoiling have had their Cp/Cv values
corrected, and have been coarsened and reduced in size to bound only the
operating point of the wallBoiling tutorials. They have also been moved
to $FOAM_TUTORIALS/resources/thermoData.

The correction to thermophysical properties has improved the stability
of these cases. As a result it has been possible to reduce the amount of
under-relaxation used in the wall modelling.
2021-05-18 13:52:16 +01:00
a8eef3be87 codedFvModel: Removed unnecessary and inconsistent "name" entry
The name of the codedFvModel is now set to the key name of the sub-dictionary in
the fvModels dictionary that defines it.
2021-05-18 13:31:20 +01:00
58afe5dccb ISstream: Added test for empty string before parsing continuation lines
Resolves bug-report https://bugs.openfoam.org/view.php?id=3675
2021-05-18 13:12:03 +01:00
0510053f61 tutorials: Removed obsolete patch ordering and transform entries
Resolves bug report: http://bugs.openfoam.org/view.php?id=3672
2021-05-14 09:06:18 +01:00
d47d266246 tutorials/multiphase/compressibleInterFoam/laminar/cylinder: Reduced write frequency 2021-05-13 17:45:41 +01:00
276e4452d7 compressibleInterFoam::pEqn: Add fvModels contribution to the continuity correction after phase-fraction filtering
The phase-fraction filtering of the compressibility terms is present to avoid
spurious phase-change due to numerical noise.  The fvModels contribution may
cause physical phase-change due to cavitation, boiling, transfer from film or
VoF even where none of the phase is present and hence must be added after the
compressibility filtering.
2021-05-13 16:17:44 +01:00
707fb6d849 compressibleInterFoam: Added the Lagrangian fvModel VoFClouds
With VoFClouds and VoFSurfaceFilm compressibleInterFoam supports Lagrangian
clouds which can impinge on walls forming a film which in turn can transfer to
the VoF when the film is thick enough to resolve.  The new tutorial case

tutorials/multiphase/compressibleInterFoam/laminar/cylinder

is provided to demonstrate this functionality.

Direct transfer of droplets to the VoF phase is not yet supported but will be
added later.
2021-05-13 10:33:56 +01:00
187abf590e lagrangian/parcel/submodels: Correcting handling of the cast from momentum cloud to thermo cloud 2021-05-13 10:06:41 +01:00
0be43e7bb6 lagrangian: phaseProperties: Support species that don't exist in the carrier
A cloud may now contain species that do not exist within the carrier
thermodynamics. Correspondence between lagrangian and carrier components
is only required when there is phase change.
2021-05-12 16:07:03 +01:00
d53b521abf lagrangian: CompositionModel: Construct from non-multi-component carrier thermo 2021-05-12 15:14:58 +01:00
0bf013ec5a thermoCloud: Instantiated lookup table injection model 2021-05-12 15:04:37 +01:00
40d3dbbd02 lagrangian: Moved composition modelling into the thermo cloud
The thermo parcel now supports thermophysical property modelling. This
particle does not store phase or specie fractions so it only provides a
single phase with a uniform composition. Additional specification is
required in the cloud subModel configuration in order to select the
specie. For example:

    compositionModel singlePhaseMixture;

    singlePhaseMixtureCoeffs
    {
        phases
        (
            solid
            {
                CaCO3   1;
            }
        );
    }
2021-05-12 14:42:23 +01:00
5c8dc9c2f1 lagrangian: Simplified and rationalised SLGThermo pending a more general and extensible replacement
The reduced SLGThermo has been renamed parcelThermo to better represent the
purpose.

parcelThermo is not created and stored in the cloud that requires it rather than
requiring it to be created in the solver createFields and passed to the cloud on
construction.
2021-05-12 14:17:45 +01:00
845d5b16e3 transformPoints: Generalised to apply a sequence of transformations
This makes usage of transformPoints the same as for
surfaceTransformPoints. Transformations are supplied as a string and are
applied in sequence.

Usage
    transformPoints "\<transformations\>" [OPTION]

    Supported transformations:
      - "translate=<translation vector>"
        Translational transformation by given vector
      - "rotate=(<n1 vector> <n2 vector>)"
        Rotational transformation from unit vector n1 to n2
      - "Rx=<angle [deg] about x-axis>"
        Rotational transformation by given angle about x-axis
      - "Ry=<angle [deg] about y-axis>"
        Rotational transformation by given angle about y-axis
      - "Rz=<angle [deg] about z-axis>"
        Rotational transformation by given angle about z-axis
      - "Ra=<axis vector> <angle [deg] about axis>"
        Rotational transformation by given angle about given axis
      - "scale=<x-y-z scaling vector>"
        Anisotropic scaling by the given vector in the x, y, z
        coordinate directions

    Example usage:
        transformPoints \
            "translate=(-0.05 -0.05 0), \
            Rz=45, \
            translate=(0.05 0.05 0)"
2021-05-11 10:06:45 +01:00
c55dceca80 lagrangian: Changed the field argument for source function SU, Sh and SYi to const
for consistency with the rest of OpenFOAM
2021-05-10 13:49:55 +01:00
643fbbd1d5 compressibleInterFoam: Created run-time loadable library for VoFSurfaceFilm
Now the VoFSurfaceFilm library is optionally loaded at run-time for cases that
require surface film by adding the optional "libs" entry in controlDict:

libs            ("libVoFSurfaceFilm.so");

See tutorials/multiphase/compressibleInterFoam/laminar/plateFilm
2021-05-10 13:49:18 +01:00
ef0dced356 compressibleInterFoam: Created run-time loadable library for VoFSurfaceFilm
Now the VoFSurfaceFilm library is optionally loaded at run-time for cases that
require surface film by adding the optional "libs" entry in controlDict:

libs            ("libVoFSurfaceFilm.so");

See tutorials/multiphase/compressibleInterFoam/laminar/plateFilm
2021-05-10 13:45:56 +01:00
50d491a209 lagrangian, surfaceFilm: Prevent "none" models from generating output property entries
The property entries created by the "none" models were not formatted
correctly, oweing to the lack of a base name or model name in the
sub-model base. These erroneous entries then resulted in restart
failures.
2021-05-05 14:44:37 +01:00
eeb9b35a72 codedFvModelTemplate: Fixed syntax error 2021-05-04 17:06:42 +01:00
e8ff92cd67 CorrectPhi: Added pressureReference argument to set the reference cell
so that the same reference cell is used for pcorr and p or p_rgh to improve
consistency between flux and flux correction.
2021-04-30 21:07:15 +01:00
007658b768 thermophysicalModels::rhoReactionThermos: Only instantiate singleComponentMixture for rhoReactionThermo
to avoid duplicate entries for rhoThermo
2021-04-30 15:52:09 +01:00
4181e9e5e6 fvConstraints::limitPressure: Corrected parallel handling of minFactor and maxFactor 2021-04-30 14:38:44 +01:00
77d3985edc Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-04-30 12:23:01 +01:00
6d7703bfa3 Time: Corrected handling of startTime other than 0 with writeControl runTime
Resolves bug-report https://bugs.openfoam.org/view.php?id=3669
2021-04-30 12:21:32 +01:00
8f851eab77 functionObjects: stopAtClockTime: Corrected documentation 2021-04-30 09:28:53 +01:00
c6e1d1b2f1 bash_completion: Updated 2021-04-30 09:17:00 +01:00
61f3662b0a foamDictionary: Added writePrecision option 2021-04-30 09:14:44 +01:00
9c7328c097 thermophysicalModels: Improved compilation error message generated for unsupported combination of properties and mixing
in particular for equations of state which do not support coefficient mixing
required by equilibrium constant evaluation in reactions.

Also improved the set of pre-compiled combinations of properties and mixing
rules.
2021-04-29 18:48:15 +01:00
6e3b5207ae surfaceFilmModels: waxSolventEvaporation: Fixed parallelisation 2021-04-29 14:43:49 +01:00
61012f472b tests: Rmeoved depreciated pMin entries 2021-04-29 11:16:13 +01:00
6c48cd55dd tutorials/compressible/rhoSimpleFoam/squareBend/system/fvSolution: Removed deprecated pMax/MinFactor entries 2021-04-28 18:59:55 +01:00
1b84e2f2e1 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-04-28 17:48:24 +01:00
07d583e989 StandardChemistryModel: Renamed as standardChemistryModel for consistency with the run-time selection name "standard"
which simplifies dynamic compilation of chemistry and error messages.
2021-04-28 17:47:08 +01:00
dd06d98c16 multiphaseEulerFoam: Renamed Laakkonen et al models
Patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2021-04-28 16:52:06 +01:00
80139f6116 compileTemplate: Improved the handling of backward-compatibility renaming of classes 2021-04-28 11:29:35 +01:00
c4484b0a60 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2021-04-28 10:54:10 +01:00
ed2ca63244 surfaceInterpolationSchemes::deferred: New convection interpolation scheme which provides conservative diagonal dominance
Description
    Deferred correction interpolation scheme derived from upwind
    which returns upwind weighting factors and an explicit correction obtained
    from the specified scheme.

    This ensures that the transport matrix generated is at least diagonally
    equal and avoids the need for relaxation of the matrix (which can affect
    conservation) for transient running.

e.g.

divSchemes
{
    default             none;
    div(phi,U)          Gauss deferred limitedLinear 1;
    .
    .
    .

and with this setting relaxation of the U-equation is not necessary irrespective
of the Courant number.
2021-04-27 20:17:34 +01:00
9e7480e028 TDACChemistryModel: Updates to configuration files
Unused entries have been removed, and documentation provided for
previously undocumented entries has been added.

Patch contributed by Francesco Contino
2021-04-27 11:04:00 +01:00
5371ffcc6e StandardChemistryModel: Consistent chemical time scale
The chemical time-scale has been generalised so that it generates
identical results for equivalent sets of reactions. Otherwise, the
calculation is unchanged. The time scale is still based on the amount of
time a reaction would take to consume all moles currently present in the
system.
2021-04-27 10:40:51 +01:00
4b65112182 tutorials/heatTransfer/chtMultiRegionFoam/coolingSphere: Updated water Prandtl number
and removed unused files.

Resolves patch request https://bugs.openfoam.org/view.php?id=3666
2021-04-27 10:35:14 +01:00
ab7d010a9a fvConstraints: Added limitPressure which replaces pressureControl.limit
To provide more flexibility, extensibility, run-time modifiability and
consistency the handling of optional pressure limits has been moved from
pressureControl (settings in system/fvSolution) to the new limitPressure
fvConstraint (settings in system/fvConstraints).

All tutorials have been updated which provides guidance when upgrading cases but
also helpful error messages are generated for cases using the old settings
providing specific details as to how the case should be updated, e.g. for the
tutorials/compressible/rhoSimpleFoam/squareBend case which has the pressure
limit specification:

SIMPLE
{
...
    pMinFactor      0.1;
    pMaxFactor      2;
...

generates the error message

--> FOAM FATAL IO ERROR:
Pressure limits should now be specified in fvConstraints:

limitp
{
    type       limitPressure;

    minFactor  0.1;
    maxFactor  2;
}

file: /home/dm2/henry/OpenFOAM/OpenFOAM-dev/tutorials/compressible/rhoSimpleFoam/squareBend/system/fvSolution/SIMPLE from line 41 to line 54.
2021-04-27 10:25:28 +01:00
ad82628b14 Reaction: Simplified rate methods
The linearisation of the reaction rate relative to the concentration of
a reference specie is not required anywhere. This data has been removed
from the rate method's output and the internals of the rate method
simplified accordingly. The clipping in the rate methods has also been
simplified and made consistent across the different rate and rate
derivative methods.
20210425
2021-04-22 16:14:33 +01:00
469c3b1c82 Reaction: Removed unused rate calculation methods 2021-04-22 10:46:00 +01:00
672afc917d ISAT: Removed variable time step flag
This change ensures that ISAT operates correctly as a result of changes
to the chemistry integration step, by putting it permenantly into what
was previously a variable-time-step mode. The constant-time-step mode is
no longer available.

The constant-time-step mode was not compatible with run-time changes,
certain types of restart, or models in which chemistry is integrated
over a time-scale which differs from the physical time-step. The level
of optimsation that the constant-time-step mode previously provided was
also found to be negligible. It's removal therefore simplifies the code
and improves the correctness of operation whilst not removing any
meaningful functionality.
2021-04-22 10:31:57 +01:00
974712b2bd thermophysicalModels: Removed seldom used or unused instantiations
Now that dynamic compilation of thermo and chemistry is available it is no
longer necessary or useful to instantiate vast numbers of thermo combinations
within the standard OpenFOAM libraries.  This reduces compile time, library size
and simplifies maintenance.
2021-04-21 21:22:52 +01:00
6897a85cc3 volPointInterpolation::pointConstraints: Resize patchPatchPointConstraints_ if necessary 2021-04-21 21:21:14 +01:00
1db93cb57b StandardChemistryModel: Removed unused method 2021-04-21 16:49:44 +01:00
204de79bf6 combustionModels/EDC: Added "outerCorrect" switch
This switch controls whether the model is corrected every outer
iteration, or just once per timestep.

This is the same as the corresponding switch in the laminar and PaSR
models, except that in the case of EDC it defaults to true. EDC folds
more information pertaining to transport into the chemistry integration,
so updating the chemistry on outer iteration is likely to have greater
effect than for the other models.
2021-04-21 12:01:57 +01:00
f0d6051815 tutorials: Fixes to TDAC cases
Properties have been removed that are set in the standard TDAC ".cfg"
file, and ".orig" files have been used to better ensure that cleanCase
restores the original state. Sandia has also had it's TDAC parameters
slightly tweaked for stability.
2021-04-20 17:25:19 +01:00
8547ae173f chemistryReductionMethods: Change dictionaries to lists
The "initialSet" and "fuelSpecies" settings for chemistry reduction
methods now have to be formatted as lists, rather than dictionaries.
This is so that the settings in the TDAC configuration files can be
overridden in a case without the dictionaries being merged.
2021-04-20 17:14:30 +01:00