Commit Graph

4250 Commits

Author SHA1 Message Date
7ee9aaa51e singleLayerRegion: Renamed VbyA 2019-12-16 15:17:15 +00:00
7cd43ea5f8 tutorials/incompressible/simpleFoam/roomResidenceTime/validation/plotPos1Data.*: Removed shebang
These scripts are executed directly in gnuplot so the shebang is not necessary
and gnuplot may not be installed in /bin.
20191215
2019-12-15 18:48:33 +00:00
de9d59ecf1 filmViscosityModel::thixotropicViscosity: Improved the handling of the implicit shear term 2019-12-12 16:38:36 +00:00
75f11686ba filmViscosityModel::filmViscosityModel: Updated the mass source 2019-12-12 15:17:10 +00:00
00075498d5 filmTurbulenceModel::laminar: Generalised the thin film stabilisation
Replaced the arbitrary constant limiter with one based on the time-step.
2019-12-12 15:15:43 +00:00
b5cb979460 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-12-12 11:57:55 +00:00
52255e53a7 Ensight format writing: Reverted changes to writeKeyword
Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=3409
2019-12-12 11:53:54 +00:00
d37fbcc39c liquidProperties/C2H5OH: Corrected specific heat and enthalpy coefficients
Resolves bug report https://bugs.openfoam.org/view.php?id=3390
2019-12-12 11:24:53 +00:00
0ad918f659 surfaceFilmModels: Rewritten in mass conservative form
All of the film transport equations are now formulated with respect to the film
volume fraction in the region cell layer rather than the film thickness which
ensures mass conservation of the film even as it flows over curved surfaces and
around corners.  (In the previous formulation the conservation error could be as
large as 15% for a film flowing around a corner.)

The film Courant number is now formulated in terms of the film cell volumetric
flux which avoids the stabilised division by the film thickness and provides a
more reliable estimate for time-step evaluation.  As a consequence the film
solution is substantially more robust even though the time-step is now
significantly higher.  For film flow dominated problem the simulations now runs
10-30x faster.

The inconsistent extended PISO controls have been replaced by the standard
PIMPLE control system used in all other flow solvers, providing consistent
input, a flexible structure and easier maintenance.

The momentum corrector has been re-formulated to be consistent with the momentum
predictor so the optional PIMPLE outer-corrector loop converges which it did not
previously.

nonuniformTransformCyclic patches and corresponding fields are no longer needed
and have been removed which paves the way for a future rationalisation of the
handling of cyclic transformations in OpenFOAM to improve robustness, usability
and maintainability.

Film sources have been simplified to avoid the need for fictitious boundary
conditions, in particular mappedFixedPushedInternalValueFvPatchField which has
been removed.

Film variables previously appended with an "f" for "film" rather than "face"
have been renamed without the unnecessary and confusing "f" as they are
localised to the film region and hence already directly associated with it.

All film tutorials have been updated to test and demonstrate the developments
and improvements listed above.

Henry G. Weller
CFD Direct Ltd.
2019-12-12 10:34:08 +00:00
01af447add Function1: Corrected header example for Sine and Square functions 2019-12-11 12:22:27 +00:00
1fb7d6e023 solidDisplacementFoam: Updated solver to use the temperature field stored in solidDisplacementThermo 2019-12-09 18:25:03 +00:00
5ae7052e12 Corrected typos in User Guide
Based on PDF provided by Herbert Tauber
Resolves bug-report https://bugs.openfoam.org/view.php?id=3405
2019-12-07 13:26:01 +00:00
309df896ad reacting*EulerFoam/.../BlendedInterfacialModel: Fixed typo
Corrected call to model2In1 in one of the evaluate methods

Patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2019-12-06 09:42:55 +00:00
45482d3902 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-12-05 22:40:33 +00:00
d32e012238 functionObjects::surfaceInterpolate: Corrected documentation
Resolves bug-report https://bugs.openfoam.org/view.php?id=3407
2019-12-05 22:39:52 +00:00
c0cffb357d foamCloneCase: fix test for case being decomposed 2019-12-04 16:30:49 +00:00
6d13edddfb Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-12-04 12:44:11 +00:00
8dd979f14b IOobject: Added modelName function to combine model and variable names: <model>:<name> 2019-12-04 12:43:11 +00:00
435b894d2c functionObjectList: Search for functions in multi-region cases in a more logical order
When operating on multi-region cases, function files are now searched
for in the following order:

 - First the $FOAM_CASE/system/<region> directory is searched

 - Second the $FOAM_CASE/system directory is searched

 - Finally a search is done through the preconfigured functions in
   $WM_PROJECT_DIR/etc

Previously, in a multi-region case, preconfigured objects were
considered before those in the case's (non-region) system directory.
This was considered counter-intuitive. Functions residing in the system
directory should always take precedence, whether they are in the region
subdirectory or not.
2019-12-04 11:43:37 +00:00
da50aba2c4 functionObjects::fieldExpression: fieldName is now const as it cannot be changed after construction 2019-11-29 16:54:54 +00:00
8a6800abfe functionObjects::fieldExpression: Rationalised setting the field and result names 2019-11-29 11:22:01 +00:00
ffb65bcee5 functionObject::fieldExpression: Corrected construction of the result field name 2019-11-28 19:03:05 +00:00
a2bb959e23 tutorials/combustion/XiFoam/RAS/moriyoshiHomogeneous: Simplification
Re-scripted the tutorials to take advantage of foamDictionary and .orig
2019-11-28 14:47:18 +00:00
c28eab7318 heheuPsiThermo: Utilised heThermo's templated field evaluation functions
This reduces code duplication within heheuPsiThermo. This also resolves
a Clang floating point error issue associated with loop vectorisation.
See commit 9675107f for the corresponding fix to heThermo.
2019-11-28 11:25:27 +00:00
7d229e7026 functionObject: Log by default to stdout when in postProcess mode, not otherwise
This change formalises the usage of the "log" keyword in function
objects. By default, logging to stdout is activated when running
"postProcess" or "<solver> -postProcess", and deactivated when a
function is being executed as part of a run.

This behaviour can now be overridden in the function object dictionary
when operating in either mode.
2019-11-27 16:27:27 +00:00
9675107f7e heThermo: Simplified initialisation and fixed Clang optimisation issue
The initialisation of energy in heThermo has been rewritten to use the
"he" method.

This has had the effect of resolving a floating point error in the
initialisation by disabling Clang's vectorisation of the loop in which
cell values of energy are calculated from the temperature field.
2019-11-27 15:46:43 +00:00
5eaf74c3a4 dictionary scalar lookup: simplified syntax using the type templated lookup function
Replaced
    readScalar(dict.lookup("name"))
with
    dict.lookup<scalar>("name")
2019-11-27 14:56:32 +00:00
d987648ef4 dictionary label lookup: simplified syntax using the type templated lookup function
Replaced
    readLabel(dict.lookup("name"))
with
    dict.lookup<label>("name)
2019-11-27 11:38:59 +00:00
f2f9fae27b thermophysicalFunction: Moved the operator<< to thermophysicalFunction.C 2019-11-26 20:05:32 +00:00
0f9578d53f thermophysicalProperties: Cleanup of IO and removal of redundant << operators 2019-11-26 19:53:22 +00:00
6ee3f7849e liquidProperties::H2O: Removed temporary diagnostic message 2019-11-26 18:10:22 +00:00
7aab12e0d8 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-11-26 17:57:03 +00:00
1ad75252de thermophysicalProperties: Rationalised write functions
and corrected output to be consistent with input.
2019-11-26 17:55:28 +00:00
d0768e6039 waves: Protected exponential and hyperbolic functions from overflow
Resolves bug report https://bugs.openfoam.org/view.php?id=3397
2019-11-26 16:26:32 +00:00
bce61e943e constantThermophysicalFunction: New constant liquid property function
Usage
    \constant
        Property    | Description
        value       | Constant property value
    \endconstant

    Example for the density of water between 280 and 350K
    \verbatim
    rho
    {
        type    constant;
        value   999.87;
    }
    \endverbatim
2019-11-26 14:50:03 +00:00
7055e0400e tableThermophysicalFunction: New tabulated liquid property function
Description
    Tabulated property function the linearly interpolates between
    the table values.

Usage
    \table
        Property    | Description
        Tlow        | Lower temperature limit of the table
        Thigh       | Upper temperature limit of the table
        values      | Property values, assumed uniformly distributed
    \endtable

    Example for the density of water between 280 and 350K
    \verbatim
    rho
    {
        type    table;

        Tlow    280;
        Thigh   350;

        values
        (
            999.87
            991.53
            973.7
        );
    }
    \endverbatim
2019-11-26 13:53:46 +00:00
f240507ae9 thermophysicalFunctions: Created a thermophysicalFunctions namespace and rationalised function names 2019-11-25 19:36:08 +00:00
e1daa5391f liquidProperties: Added support for multiple entries is mixture each of specified type
If the optional "type" entry is provided for the liquid specie that type is
looked-up rather than the entry name, e.g.

mixture
{
    H2O
    {
        type    liquid;

        W       18.015;
        Tc      647.13;
        Pc      2.2055e+7;
        Vc      0.05595;
        Zc      0.229;
        Tt      273.16;
        Pt      6.113e+2;
        Tb      373.15;
        dipm    6.1709e-30;
        omega   0.3449;
        delta   4.7813e+4;

        rho
        {
            type    NSRDSfunc5;
            a       98.343885;
            b       0.30542;
            c       647.13;
            d       0.081;
        }
        .
        .
        .
    }

    ethanol
    {
        type    liquid;

        W       46.07;
        .
        .
        .
    }
}
2019-11-25 14:43:22 +00:00
375e1f7c63 liquidProperties::liquid: New generic liquid thermophysical properties class
Description
    Generic thermophysical properties class for a liquid in which the
    functions and coefficients for each property are run-time selected.

Property functions need only be specified for properties that are actually used
in the simulation, e.g. in the thermophysicalProperties.water dictionary of the
tutorials/multiphase/compressibleInterFoam/laminar/depthCharge2D case the water
properties can be specified directly as

mixture
{
    liquid
    {
        W       18.015;
        Tc      647.13;
        Pc      2.2055e+7;
        Vc      0.05595;
        Zc      0.229;
        Tt      273.16;
        Pt      6.113e+2;
        Tb      373.15;
        dipm    6.1709e-30;
        omega   0.3449;
        delta   4.7813e+4;

        rho
        {
            type    NSRDSfunc5;
            a       98.343885;
            b       0.30542;
            c       647.13;
            d       0.081;
        }

        Cp
        {
            type    NSRDSfunc0;
            a       15341.1046350264;
            b       -116.019983347211;
            c       0.451013044684985;
            d       -0.000783569247849015;
            e       5.20127671384957e-07;
            f       0;
        }

        h
        {
            type    NSRDSfunc0;
            a       -17957283.7993676;
            b       15341.1046350264;
            c       -58.0099916736053;
            d       0.150337681561662;
            e       -0.000195892311962254;
            f       1.04025534276991e-07;
        }

        mu
        {
            type    NSRDSfunc1;
            a       -51.964;
            b       3670.6;
            c       5.7331;
            d       -5.3495e-29;
            e       10;
        }

        kappa
        {
            type    NSRDSfunc0;
            a       -0.4267;
            b       0.0056903;
            c       -8.0065e-06;
            d       1.815e-09;
            e       0;
            f       0;
        }

        sigma
        {
            type    NSRDSfunc6;
            Tc      647.13;
            a       0.18548;
            b       2.717;
            c       -3.554;
            d       2.047;
            e       0;
        }
    }
}
2019-11-24 23:05:28 +00:00
c78536f511 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-11-21 13:00:42 +00:00
e18c81e84f TDACChemistryModel: Removed CPU time accumulation between ISAT operations
Resolves feature request https://bugs.openfoam.org/view.php?id=3393
Patch contributed by Bulut Tekgul
2019-11-21 12:58:53 +00:00
b87fac2899 foamCloneCase: correction to -processor option check 2019-11-21 08:46:24 +00:00
6a17553516 foamCloneCase: correction to serial operation 2019-11-21 08:15:38 +00:00
f06e13a0bc foamCloneCase: added -processor and -add options and tidied code
-add <file1...N> copy 1 or more additional files/directories from source case
-processor       copies processor* directories of a decomposed case
2019-11-20 18:11:16 +00:00
4cf747f1b0 phaseForces: Simplified loop structure 2019-11-20 15:47:36 +00:00
ead5825cdd Revert "TDACChemistryModel: Removed CPU time accumulation between ISAT operations"
This reverts commit f66ea31584.
2019-11-20 13:54:30 +00:00
faa094ccc3 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2019-11-20 12:50:12 +00:00
f66ea31584 TDACChemistryModel: Removed CPU time accumulation between ISAT operations
Resolves feature request https://bugs.openfoam.org/view.php?id=3392
Patch contributed by Francesco Contino
2019-11-20 12:48:23 +00:00
6ad711057b reactingEulerFoam/.../coalescenceModels/PrinceBlanch: Added laminar shear contribution
Patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2019-11-19 14:30:08 +00:00
08ea2465c1 phaseForces: Additional check for existence of the sub-moodel
This fix ensures that the function still operates even if models only
exist on some interfaces.

Patch contributed by Institute of Fluid Dynamics,
Helmholtz-Zentrum Dresden - Rossendorf (HZDR)
2019-11-19 14:06:14 +00:00