Commit Graph

1940 Commits

Author SHA1 Message Date
241b4a60fc mappedFieldFvPatchField: Added base-class autoMap/rmap calls
Patch contributed by Mattijs Janssens
2018-06-19 14:06:57 +01:00
89f1053f82 Code style: Fixed formatting of banners 2018-06-19 12:01:50 +01:00
eca187e025 dictionaryListEntryIO: Trap errors when reading entries in the list
Resolves bug-report https://bugs.openfoam.org/view.php?id=2984
2018-06-18 10:24:29 +01:00
46821b553c kOmegaSST.H, nutkWallFunctionFvPatchScalarField.H: Updated documentation 2018-06-17 15:30:38 +01:00
21b3d19575 thermophysicalModels::Reaction: Refactored to remove unnecessary solid reaction specific functions 2018-06-15 16:15:42 +01:00
14a50c7d62 thermophysicalModels: Corrected the name of solidReaction -> SolidReaction
for consistency with the rest of the reaction system
2018-06-15 15:23:12 +01:00
4dc35c6810 thermophysicalModels: Implementation of the full algebraic Jacobian
including third-body and pressure dependent derivatives, and derivative of the
temperature term.  The complete Jacobian is more robust than the incomplete and
partially approximate form used previously and improves the efficiency of the
stiff ODE solvers which rely on the Jacobian.

Reaction rate evaluation moved from the chemistryModel to specie library to
simplfy support for alternative reaction rate expressions and associated
Jacobian terms.

Temperature clipping included in the Reaction class. This is inactive by default
but for most cases it is advised to provide temperature limits (high and
low). These are provided in the foamChemistryFile with the keywords Thigh and
Tlow. When using chemkinToFoam these values are set to the limits of the Janaf
thermodynamic data.  With the new Jacobian this temperature clipping has proved
very beneficial for stability and for some cases essential.

Improvement of the TDAC MRU list better integrated in add and grow functions.

To get the most out of this significant development it is important to re-tune
the ODE integration tolerances, in particular the absTol in the odeCoeffs
sub-dictionary of the chemistryProperties dictionary:

odeCoeffs
{
    solver          seulex;
    absTol          1e-12;
    relTol          0.01;
}

Typically absTol can now be set to 1e-8 and relTol to 0.1 except for ignition
time problems, and with theses settings the integration is still robust but for
many cases a lot faster than previously.

Code development and integration undertaken by
Francesco Contino
Henry G. Weller, CFD Direct
2018-06-15 12:26:59 +01:00
a3177bd759 twoPhaseMixtureThermo: Fix for collated file operation
twoPhaseMixtureThermo writes the temperatures during construction only
for them to be read again immediately after by construction of the
individual phases' thermo models. When running with collated file
handling this behaviour is not thread safe. This change deactivates
threading for the duration of this behaviour.

Patch contributed by Mattijs Janssens
2018-06-14 10:55:27 +01:00
268f1f612e hRef: Define height in opposite direction to gravity
The reference height is now defined in the direction of -g, whether as
previously it was defined in the direction cmptMag(g). This change makes
the behaviour consistent when the case is transformed. For a "typical"
case with g along one of the negative axes, this should make no
difference. None of the tutorials are affected.

Resolves bug report https://bugs.openfoam.org/view.php?id=2980
2018-06-14 10:49:15 +01:00
1fb1183478 ReactingMultiphaseParcel: Enable surface reactions when devolatilisation is inactive
Resolves bug report https://bugs.openfoam.org/view.php?id=2966
2018-06-13 10:37:19 +01:00
ee6a53adee seulex: Reverting change to stability/monotonicity check
This change cause some cases to fail, in particular
tutorials/lagrangian/sprayFoam/aachenBomb

Reopened https://bugs.openfoam.org/view.php?id=2972
2018-06-12 10:11:50 +01:00
2e1825a50f utilities: Remove unused case related options 2018-06-11 15:21:34 +01:00
712d4ca07d OpenFOAM: Added new removeCaseOptions.H convenience header 2018-06-11 15:20:15 +01:00
7e466cfbd7 foamDictionary, adiabaticFlameT, equilibriumFlameT: remove unused case related options 2018-06-11 14:31:36 +01:00
61363e74c6 Random: Declare member function specializations within the Foam namespace
Required for gcc-4.8.5
2018-06-11 14:21:58 +01:00
b06ab58a18 OSspecific: Removed unused random generator functions 2018-06-11 11:01:11 +01:00
002e7d7b06 Random: Replaced drand48 with an in-class implementation
This is faster than the library functionality that it replaces, as it
allows the compiler to do inlining. It also does not utilise any static
state so generators do not interfere with each other. It is also faster
than the the array lookup in cachedRandom. The cachedRandom class
therefore offers no advantage over Random and has been removed.
2018-06-11 11:01:11 +01:00
88a218ce84 treeBoundBox: Removed unecessary randomisation
Tree bound boxes are expanded asymmetrically to reduce the liklihood of
octree faces aliging with mesh faces and edges. The asymmetry is now
generated using hard-coded irrational numbers, rather than using a
random generator.

The asymmetry was effectively already hard coded. The random numbers are
only pseudo random, so the same numbers were being applied to the bound
boxes every time. This change simply removes the overhead of creating
the generator, and also gets rid of some duplicated code.
2018-06-11 11:01:11 +01:00
a6e159ae5f Make/options: Rationalized the layout of the EXE_INC statements 2018-06-10 17:11:22 +01:00
338af65685 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-06-08 23:02:33 +01:00
8ab5b6152e CSV: Updated writing of componentColumns for consistency with construction for binary IO
Resolves bug-report https://bugs.openfoam.org/view.php?id=2950
2018-06-08 23:01:24 +01:00
50a965f886 particle: Fixed topology error in locate method
Fixes problem introduced by commit 89de5349
2018-06-08 15:58:22 +01:00
89de534923 particle: Improved robustness of locate method 2018-06-07 12:10:29 +01:00
99bdbfae15 particle: Improved debugging for tracking on moving meshes 2018-06-07 09:23:01 +01:00
873d2c9c23 seulex: changed monotonicity check to correspond to original implementation
Resolves bug-report https://bugs.openfoam.org/view.php?id=2972
2018-06-06 15:13:08 +01:00
7f49d6e2cc scale: function object to multiply a field by a scale factor 2018-06-06 09:41:04 +01:00
1223da98f7 cyclicRepeatAMI: Added error message for zero-sized transform patch
Sometimes decomposition can remove a cyclic patch entirely, converting
it into a processor cyclic. If this patch is being used to specify the
transform for a cyclicRepeatAMI patch then the calculation will fail.
This change adds a check for this situation, and errors with the
suggestion that the transform patch be preserved during decomposition.
2018-06-04 10:50:56 +01:00
11a3b3b99f ConeInjection, ConeNozzleInjection: Synchronised random numbers
The use of random numbers for positioning within the cone injection
models has been made consistent across all cores. Some calls have been
synchronised by means of the globalSample methods, whilst others have
been replaced by non-randomised algorithms.

This resolves bug report https://bugs.openfoam.org/view.php?id=2956
2018-05-31 17:08:20 +01:00
1e4f0e06a9 POSIX::readDir: filter .orig from name of filtergz set 2018-05-31 16:47:15 +01:00
b989b81d16 VectorSpace, Vector: Added findMin, findMax and perpendicular functions
The functions findMin and findMax return the index of the minimum or
maximum component, consistently with the functions in ListOps.H. The
perpendicular function returns an arbitrary vector perpendicular to the
supplied vector, with the same magnitude.
2018-05-31 15:15:40 +01:00
e7d68ad8a4 radiationCoupledBase: Improved error message when solid region radiation is not defined 2018-05-30 16:54:43 +01:00
d5903c3897 fileName: moved file operation global function to fileOperation 2018-05-30 12:48:48 +01:00
64da5dab55 fileName: Added cpFiles function
//- Copy all the files from the source to the target directory
void cpFiles(const fileName& srcDir, const fileName& targetDir);
2018-05-28 22:14:22 +01:00
63a185450b genericPolyPatch: Avoid writing duplicate entry for "inGroups" and "faces"
Resolves bug-report https://bugs.openfoam.org/view.php?id=2955
2018-05-24 14:38:33 +01:00
f14637a965 regIOobject: Avoid segmentation fault when destroying objectRegistry with debug on 2018-05-24 13:29:11 +01:00
6c560795cb externalWallHeatFluxTemperature: Use the surface emissivity for both emission and absorption
Resolves bug-report https://bugs.openfoam.org/view.php?id=2953
2018-05-23 14:14:01 +01:00
567fc90492 Corrected "fileName" -> "file" in header documentation
Patch contributed by Bruno Santos
Resolves bug-report https://bugs.openfoam.org/view.php?id=2951
2018-05-22 22:30:46 +01:00
5caa5a3e9b snappyHexMesh::layerParameters: Increased the maximum number of layer expansion iterations to 100
Resolves bug-report https://bugs.openfoam.org/view.php?id=2938
2018-05-22 20:03:27 +01:00
314e464f7d Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-05-22 20:01:39 +01:00
26ec6f8ceb freestreamPressureFvPatchScalarField: Added support for supersonic freestream
Set the new optional switch "supersonic" to true if the freestream flow is
supersonic.
2018-05-22 20:00:30 +01:00
9dcdf23a6b waveSuperposition: Corrected copy construction of heightAboveWave flag
Resolves bug report https://bugs.openfoam.org/view.php?id=2930
2018-05-21 11:06:32 +01:00
ceebbf8740 semiPermeableBaffle: Spelling corrections 2018-05-21 09:01:51 +01:00
4bd59d64db pimpleLoop: Fixed bug when convergence occurs on last iteration
Resolves bug report https://bugs.openfoam.org/view.php?id=2940
2018-05-17 17:53:15 +01:00
c667687dd2 thermophysicalModels: Instantiations for reacting liquids
Stabilisation has also been added to the perfectFluid == operator to
allow for use of this equation of state in a reacting fluid.
2018-05-16 16:21:15 +01:00
598ea11563 PatchInteractionModel: Removed MultiInteraction
MultiInteraction appeared to have been written for combining the usual
patch interaction models with a model called
CoincidentBaffleInteraction, which was never released. None of the
remaining patch interaction models make sense operating in combination,
so the MultiInteraction model has been removed. All documentation
references to CoincidentBaffleInteraction have also been deleted.

Resolves bug report https://bugs.openfoam.org/view.php?id=2939
2018-05-16 12:55:50 +01:00
4e21098cb5 MPPICParcel: Retain effect of patch interactions on correction velocity
This prevents infinite loops occurring during correction steps as a
result of a fixed correction velocity repeatedly pushing the particle
towards a rebound patch.

Resolves bug report https://bugs.openfoam.org/view.php?id=2935
2018-05-16 11:52:34 +01:00
d0dfb1a843 decomposePar, reconstructPar: Rationalized the handling of the allRegions option 2018-05-14 19:51:54 +01:00
e57a62b400 solidificationMeltingSource: Improved documentation
Patch contributed by Lorenzo Trevisan
Resolves patch request https://bugs.openfoam.org/view.php?id=2932
2018-05-14 17:23:34 +01:00
d030bb35c3 fixedTemperatureConstraint: corrected documentation
Patch contributed by Bruno Santos
Resolves bug-report https://bugs.openfoam.org/view.php?id=2927
2018-05-14 16:52:05 +01:00
f9fc13da5c Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-05-14 16:49:54 +01:00