Commit Graph

3724 Commits

Author SHA1 Message Date
739b9e32fb reactingEulerFoam: Minor improvements to populationBalanceModel
Changed to using of UPtrList<Type> instead of List<*Type> for storing
reference to size and velocity groups, as this removes de-referencing
clutter. Fixed lookup of critical film thickness in PrinceBlanch
coalescence model. Added functionality calculating the overall diameter,
void fraction and void fraction weighted velocity for multiple velocity
groups.

Patch contributed by Institute of Fluid Dynamics, Helmholtz-Zentrum
Dresden - Rossendorf (HZDR)
2018-10-17 12:08:10 +01:00
63b641a068 interpolationCellPointWallModified: Restored interpolation method
This interpolation method was previously removed by commit fbf00209.

The intention of this method is to provide a slip-like wall boundary
condition for the velocity when interpolated to the location of a
Lagrangian element. This is difficult because any velocity which points
through the wall can cause a drag model and a rebound wall interaction
to "fight"; i.e., the drag pushes the particle to the wall, the wall
bounces it back. This can result in the program hanging.

This method extrapolates a vector field to the wall points and then
modifies the result so that it does not point through the wall. It does
this by rotating the vectors towards the (reversed) point normal. The
result is also scaled so that is reduced to zero if the necessary
rotation exceeds 90 degrees.

This provides an alternate resolution to bug report
https://bugs.openfoam.org/view.php?id=2826
2018-10-17 08:22:13 +01:00
7ead70d89a thermophysicalModels::equationOfState: Added E and Cv departure functions 2018-10-16 17:53:17 +01:00
fc00e4c0c9 thermophysicalModels: Added direct support for Es, Ea and Cv as thermodynamic primitives 2018-10-16 09:59:42 +01:00
a0addf5e8f etc/config.sh/aliases: use a direct call to $wmProjectDir/etc/config.sh/unset rather than the wmUnset alias
Patch contributed by Bruno Santos
Resolves patch request https://bugs.openfoam.org/view.php?id=3088
2018-10-15 10:31:01 +01:00
8102dd3e47 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-10-15 10:19:50 +01:00
849c11b637 gmvOutputParcels.H: Removed unused file
Resolved https://bugs.openfoam.org/view.php?id=3090
2018-10-15 10:18:58 +01:00
47efc8f898 cyclicAMIPointPatchField: Fixed type-detection for ACMI 2018-10-15 09:17:19 +01:00
45a4930538 rhoThermos: Instantiate liquid thermo packages on eConstThermo rather than hConstThermo
to provide better numerical behaviour of the conversion of internal energy to temperature.
2018-10-13 21:50:10 +01:00
7f16808709 eConstThermo: Improve consistency between the H and E functions
so that conversions between H and E and back again reproduce the original
values.
2018-10-13 21:46:48 +01:00
e1e7d4d763 nutkAtmRoughWallFunctionFvPatchScalarField: Minor improvement to documentation 2018-10-13 21:46:22 +01:00
c17e6dbfe4 KinematicParcel: Do not execute face/patch functions when inactive
Resolves bug report https://bugs.openfoam.org/view.php?id=3084
2018-10-12 08:57:10 +01:00
dffe3213d7 doc/Doxygen/Doxyfile: Increased FORMULA_FONTSIZE to 16 2018-10-07 10:24:52 +01:00
8f3f2f7365 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 20181008 2018-10-05 21:30:13 +01:00
ff2c2dfea3 turbulentTransportModel: Renamed template parameter
Resolves request https://bugs.openfoam.org/view.php?id=3081
2018-10-05 21:29:05 +01:00
94d5db7198 treeBoundBox: Improved asymmetry
This fixes a failure in the foamyHexMesh mixerVessel case
2018-10-05 16:06:26 +01:00
85cdf55073 conformalVoronoiMesh: Fixed processor patch reordering 2018-10-05 16:06:26 +01:00
77dd7556c9 offsetCylinder: New tutorial to demonstrate the generalizedNewtonian laminarModel
with the CrossPowerLaw viscosityModel
2018-10-05 11:28:34 +01:00
94d0b9ffe5 TurbulenceModels::generalizedNewtonian: New structure to support generalized Newtonian laminar transport
Within this structure the BirdCarreau, Casson, CrossPowerLaw, HerschelBulkley,
powerLaw and strainRateFunction strain-dependent viscosity based non-Newtonian
fluid models may be selected for incompressible or compressible flow.

In the case of compressible flow the strain-dependent viscosity functions are
applied to the temperature dependent viscosity so that if the WLF viscosity
model is chosen in conjunction with the CrossPowerLaw the effective model is
Cross-WLF which is commonly used for polymer flow.

These models are selected in the constant/turbulenceProperties file, e.g.

simulationType  laminar;

laminar
{
    laminarModel generalizedNewtonian;

    viscosityModel CrossPowerLaw;

    nuInf      10;
    m          0.4;
    n          3;
}

This new implementation is more general and flexible than the previous
incompressible only non-Newtonian viscosity models, which were selected in the
constant/transportProperties file.  This implementation is now deprecated and
will be phased-out.
2018-10-04 22:31:48 +01:00
79771811d8 thermophysicalModels/specie/transport: Added WLF transport model
Description
    Transport package using the Williams-Landel-Ferry model.

    Templated into a given thermodynamics package (needed for thermal
    conductivity).

    Dynamic viscosity [kg/m.s]
    \f[
        \mu = \mu_0 \exp \left(\frac{-C_1 ( T - T_r )}{C_2 + T - T_r}\right)
    \f]

    References:
    \verbatim
        Williams, M. L., Landel, R. F., & Ferry, J. D. (1955).
        The temperature dependence of relaxation mechanisms
        in amorphous polymers and other glass-forming liquids.
        Journal of the American Chemical society, 77(14), 3701-3707.
    \endverbatim
2018-10-04 22:29:38 +01:00
a7520838f9 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-10-04 22:25:11 +01:00
c9ae73f1e1 SingleKineticRateDevolatilisation.H: Corrected documentation 2018-10-04 22:24:09 +01:00
5dd31a06d8 sonicFoam: Corrected banner 2018-10-03 14:20:20 +01:00
6aa4fe45f8 Corrected line lengths over 80 characters 2018-10-03 12:18:58 +01:00
39ad49bc34 meshSearch: Prevent hang in calculation of line-boundary intersections
This fix changes how the intersections loop ignores previously
intersected faces. It now marks them by their index so that subsequent
iterations ignore them.

Before this change, after an intersection was found the start point was
advanced by a small amount to move the past the intersection. The
problem with this was if multiple boundary faces or the end point were
in close proximity to the intersection then the move forward might span
them. This could lead to intersections being missed or counted multiple
times, in some cases indefinitely.

Based on a patch contributed by Mattijs Janssens
Resolves bug report https://bugs.openfoam.org/view.php?id=1147
2018-10-03 08:48:21 +01:00
80df54208f foamMonitor: Added -ascii and -size options
These options add the ability to show the plot in the terminal, and at
any size. This is intended to facilitate monitoring on remote machines
where launching an X11 application may not be convenient or possible.

Resolves feature request https://bugs.openfoam.org/view.php?id=3080
2018-10-02 19:49:59 +01:00
507b209de6 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-10-02 14:25:46 +01:00
f1a742a130 Upgraded Scotch to 6.0.6 2018-10-02 14:25:18 +01:00
13fe8ed035 VectorSpace: Return result of normalise in the original form 2018-10-02 11:47:01 +01:00
ba83933aa2 template cases for rotating geometry: modify fields with AMI creation 2018-10-01 14:33:05 +01:00
5830a73334 template cases for rotating geometry: updated for #neg directive 2018-10-01 14:30:35 +01:00
ee3431d2c8 template cases: updated for change from pimpleDyMFoam to pimpleFoam 2018-10-01 14:26:21 +01:00
36ac553826 primitives:1️⃣ Specialize the '+' and '-' operators for scalar 2018-10-01 10:36:44 +01:00
de1621ee65 POSIX::readDir: Simplified handling of dirEntries 2018-09-29 10:33:50 +01:00
0c866b5e10 POSIX::readDir: Filter duplicates generated by the filtering of variants
Resolves bug-report https://bugs.openfoam.org/view.php?id=3078
2018-09-28 16:32:57 +01:00
774f76fc66 primitives/one: Corrected return type of '+' and '-' operators 2018-09-28 14:37:22 +01:00
fb173af944 postProcess: Updated to allow functionObjects to access fields on construction 2018-09-28 10:29:22 +01:00
6388a1d5d0 driftFluxFoam::BinghamPlastic: added limiter to avoid floating point exception for high phase fraction
Patch contributed by Juho Peltola, VTT.
2018-09-27 15:38:08 +01:00
441b7e041b MULES: Added optional boundaryExtremaCoeff
This provides more flexibility in specifying the allowed internal and boundary
extrema.

For driftFluxFoam and other settling problems it is beneficial to set the
boundaryExtremaCoeff to 1 to allow rapid accumulation of the partials on the
bottom wall (which was the previous default behaviour) but this is not suitable
for many Euler-Euler cases for which a uniform etrema coefficient is preferable,
either 0 or a small value.

Now by default boundaryExtremaCoeff is set to extremaCoeff which defaults to 0
which provides the behaviour before

OpenFOAM-dev commit cb2bc60fa5

and the driftFluxFoam tutorials have been updated adding

        boundaryExtremaCoeff 1;

to the MULES controls in fvSolution so reproduce the previous behaviour.
2018-09-27 15:03:01 +01:00
314336cb6e Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-09-25 11:07:10 +01:00
9d97dc9ffd tutorials/incompressible/SRF.*: Removed spurious "U" entries in BCs
Resolves bug-report https://bugs.openfoam.org/view.php?id=3076
2018-09-25 11:06:01 +01:00
f68b9cd80f InterfaceCompositionModel: Constant thermo instantiations 2018-09-25 09:33:48 +01:00
2a28182f87 Merge branch 'master' of github.com-OpenFOAM:OpenFOAM/OpenFOAM-dev 2018-09-25 08:29:44 +01:00
529010cb5b Doxyfile: Added amsmath to EXTRA_PACKAGES for complex equation formatting 2018-09-25 08:27:19 +01:00
e3672a7e4f reactingTwoPhaseEulerFoam: Prevent error in LBend tutorial
The LBend was set to run for 2 s, but at about 1.95 s the packed region
builds up to the inlet and the simulation diverges. The end time has
been reduced to 1.9 s so that this does not occur.
2018-09-24 15:26:58 +01:00
2d3e7e9981 reactingEulerFoam/phaseModels: Added multi-component isothermal phase 2018-09-24 11:24:25 +01:00
eaa089e38c InterfaceCompositionPhaseChangePhaseSystem: Two sided mass transfer fix
This change fixes an issue where mass transfer models were being looked
up on the wrong side of the interface. This also means that specifying
mass transfer just on one side of an interface is now possible without
generating errors.
2018-09-24 11:21:27 +01:00
819c24869e singleRegionCorrectorConvergenceControl: Typo in error message 2018-09-24 09:54:53 +01:00
1c0256ffab InterfaceCompositionPhaseChangePhaseSystem: Typo in error message 2018-09-24 09:54:34 +01:00
1c26ed2d31 particle: Added logic to break closed loops
When a part of the tetrahedral decomposition is inverted, tracking along
a straight line can result in a closed loop which never ends.

This change adds a limit to the number of tracks that are done that end
before or at the maximum distance already achieved. This breaks these
closed loops and prevents the simulation from hanging. The particles do,
however, end up in an incorrect position as a result of the tracking
being abandoned at an intermediate point in the step. A warning is
printed to indicate when this is occuring.

This resolves bug report https://bugs.openfoam.org/view.php?id=3056
2018-09-24 09:19:21 +01:00