Compare commits

...

2277 Commits

Author SHA1 Message Date
c10219da9e Merge pull request #4451 from akohlmey/next_release
Step version strings for next feature release
2025-02-04 13:31:31 -05:00
2777984355 Merge pull request #4461 from akohlmey/last-minute-fixes
Last minute fixes for next feature release
2025-02-04 09:51:39 -05:00
3fb8857be5 relax epsilon for tests on ARM64 2025-02-03 22:19:12 -05:00
113b2e47f0 must set val.iarg before processing any arguments 2025-02-03 22:18:45 -05:00
a01ac8c907 use byref() instead of pointer() to pass pointers to ctypes objects to C 2025-02-03 22:18:17 -05:00
995d6ab41f Merge branch 'develop' into next_release 2025-02-03 17:55:37 -05:00
87dae19019 Merge pull request #4459 from akohlmey/collected-small-fixes
Collected small fixes and changes
2025-02-03 17:43:41 -05:00
848a4300fe Merge branch 'develop' into collected-small-fixes 2025-02-03 14:54:38 -05:00
3b62892fc3 Merge pull request #4450 from rbberger/rberger/python_numpy_wrapper_fixes
python: numpy wrapper handle error cases
2025-02-03 14:53:52 -05:00
06506aa23b Merge pull request #4415 from evoyiatzis/patch-2
Allow definition of prism region using equal style variables
2025-02-03 14:50:00 -05:00
8a0027e788 improve phrase 2025-02-03 11:40:56 -05:00
b17699a56a Merge pull request #4460 from ndtrung81/fixed-failed-regression-tests
Fixed the failed regression test with Lost atoms in an EFF example input, and added reference log files
2025-02-03 11:38:53 -05:00
a0253fba2d update instructions for building static executable, add flatpak build info 2025-02-02 11:10:33 -05:00
e567e4cdd6 update notes on release processing steps 2025-02-02 04:41:32 -05:00
6dfc4f343c update copyright date 2025-02-02 04:41:02 -05:00
22eb984e68 expand deprecation warnings 2025-02-01 22:37:52 -05:00
d1e65d0b9a remove extra comma 2025-02-01 22:33:32 -05:00
54832b2091 plug file descriptor leak 2025-02-01 21:33:33 -05:00
38b1efa9d4 fix small memory leak 2025-02-01 20:16:34 -05:00
7f9423a1ee fix small memory leak 2025-02-01 17:48:45 -05:00
e9f07af140 added the reference log files for example inputs under PACKAGES/eff 2025-02-01 14:55:38 -06:00
d17186a8fa remove multi/old from docs and print deprecation warning when used
also convert error messages to use new error location indicator API
2025-02-01 15:29:27 -05:00
e9e4addacb remove remaining references to removed minimizer style fire/old 2025-02-01 11:46:35 -05:00
f89ba1f354 update ReaxFF reference log files for current version of LAMMPS and use consistent names 2025-02-01 11:22:59 -05:00
3f5630c073 clarify and explain that there may not be neighbor list statistics data 2025-02-01 09:19:33 -05:00
64ec02b87d convert fix ave/correlate/long and fix ave/grid to new error APIs 2025-02-01 09:03:56 -05:00
920337963b reduce compiler warnings from unused variables, modernize a few loops. 2025-02-01 04:48:00 -05:00
8f23701352 must build plugins on Windows, too. 2025-02-01 02:07:01 -05:00
ebf81c0363 add tests for dreiding h-bond potentials 2025-02-01 02:01:48 -05:00
62d703a1f4 fixed lost atoms error with smaller time step for energy conservation and added reference log files for PACKAGES/eff/Auger-Adamantane 2025-01-31 23:13:31 -06:00
8b8e10d54f update regex for Windows 2025-01-31 23:30:33 -05:00
8e90e77a64 remove accidentally renamed file 2025-01-31 23:21:54 -05:00
541f81ba93 use full path when loading plugins 2025-01-31 23:19:56 -05:00
3a58f9a5aa delegate handling of multi-config path to CMake (if version 3.20 or later) 2025-01-31 22:50:13 -05:00
52fcfcaab1 fix typo 2025-01-31 22:04:57 -05:00
d96136f23d cstdbool header is deprecated and no longer needed with recent compilers 2025-01-31 22:01:06 -05:00
21f77a9275 update docs for Error::ARGZERO constant 2025-01-31 21:53:29 -05:00
fdc3823969 fix typo 2025-01-31 21:50:22 -05:00
eb1174b54b try to work around the ambiguity of 0 and null pointers 2025-01-31 21:48:29 -05:00
29b5fce5e4 do not define __INTEL_COMPILER to __INTEL_LLVM_COMPILER instead test for either
This shortcut will create problems for features that do not exist for
the Intel LLVM based compiler.
2025-01-31 21:20:44 -05:00
381f141384 correct some overeager changes 2025-01-31 21:19:13 -05:00
6da7e4aa47 update molecule file tester for changed error messages 2025-01-31 21:06:11 -05:00
be1be668a2 modernize error messages for processing molecule files 2025-01-31 20:33:47 -05:00
1dc5f8739a bugfix from @jtclem for molecule files with multiple molecule IDs 2025-01-31 20:32:58 -05:00
7d7cdf3e08 get past spell checker 2025-01-31 17:50:06 -05:00
a83b45c0fb use simpler std::string concatenation instead of implicit fmt::format() processing 2025-01-31 17:49:59 -05:00
9eb3e35255 add error URLs for molecule files 2025-01-31 17:49:49 -05:00
6f6adc05ce reassign error URL numbers to match list in pull request 2025-01-31 17:49:24 -05:00
c5f287d747 Merge pull request #4453 from akohlmey/partial-error-explanations
Partial error explanation changes
2025-01-31 14:37:19 -05:00
ac21f24013 update fix ave/correlate for new error message features 2025-01-31 07:32:05 -05:00
2ea86efe67 simplify custom format processing 2025-01-31 07:22:22 -05:00
1df1b3e2fc Merge branch 'develop' into patch-2 2025-01-31 12:22:18 +02:00
4cfa2e4ed9 update fix ave/atom and fix ave/chunk to have errors with position indicator 2025-01-31 04:33:24 -05:00
2c7bd41b7b make error commands more explicit 2025-01-31 04:32:38 -05:00
3f952f53ce avoid segfault without expanded arguments 2025-01-31 04:04:52 -05:00
0c28dfad44 simplify 2025-01-31 04:04:13 -05:00
42e379a8de Merge remote-tracking branch 'github/develop' into add-error-explanations 2025-01-31 03:23:51 -05:00
ea1607f1d8 Merge pull request #4445 from stanmoore1/small_fixes
Collected small changes and fixes
2025-01-31 00:42:12 -05:00
6d997258e7 Merge branch 'small_fixes' of github.com:stanmoore1/lammps into small_fixes 2025-01-30 15:25:13 -08:00
9bb56d10b3 Move typedef unused for GPUs inside directive to prevent compiler warning 2025-01-30 15:25:05 -08:00
2099dabb49 Remove unused code 2025-01-30 15:16:30 -08:00
72542c1619 python: numpy wrapper returns None in error cases
lammps.numpy wrapper functions will now return None in error cases instead of
throwing exception with NULL pointer access errors. If nelem or dimension is zero
it will return an empty numpy array with the correct shape.
2025-01-30 16:00:01 -07:00
030ad0d5af set version string to 4Feb2025 2025-01-30 17:22:28 -05:00
aa9b2b415f remove sometimes misleading and often confusing warning 2025-01-30 16:20:29 -05:00
b98797ec2c Merge remote-tracking branch 'github/develop' into small_fixes 2025-01-30 16:19:38 -05:00
c2dd04b991 replace non-ASCII chars with ASCII equivalents 2025-01-30 16:05:08 -05:00
1d286f194e Fix bug in compute_stress_cartesian with periodic boundary conditions 2025-01-30 12:46:34 -08:00
48893236ec Merge pull request #4380 from rbberger/python_computes
Python and library API changes for computes
2025-01-30 14:21:25 -05:00
75b33ac436 Merge pull request #4443 from jrgissing/reaxff/species-issues
Reaxff/species issues
2025-01-30 14:20:01 -05:00
60c4cc08e9 Merge pull request #4448 from Becksteinlab/imdv3-fix
Fix broken IMDv3 `unwrap` option logic
2025-01-30 12:53:39 -05:00
4e3a41dc25 Merge pull request #4446 from jtclemm/small-patches
Miscellaneous small patches
2025-01-30 12:51:50 -05:00
c9241aa2be Merge pull request #4447 from akohlmey/recover-failed-tests
Updates to recover failed post-merge tests
2025-01-30 12:16:06 -05:00
363309a7d8 add tip for addressing memory management issues with ReaxFF 2025-01-30 03:57:30 -05:00
444c6d78f7 consistently use a :class: qualifier for admonitions 2025-01-30 03:54:26 -05:00
2b0a6419b7 add missing doc section for fix python/invoke 2025-01-29 23:57:44 -07:00
31720b2741 add missing init function to fix python/invoke 2025-01-29 23:53:23 -07:00
48f749fbdd exact copy of v2 unwrap logic 2025-01-29 23:16:44 -07:00
6685524fdb correctly apply environment variables 2025-01-29 23:39:30 -05:00
da1bbec0be set lmp pointer to NULL after delete to avoid using it or deleting it a second time 2025-01-29 23:32:52 -05:00
06bdb7b637 refactor catching exceptions during LAMMPS initialization
this will avoid the nasty segfaults with "cannot have multiple stdout capturers"
instead it will catch and display any exception thrown during init.
2025-01-29 23:09:48 -05:00
29891e06c0 correct dependency for efield/lepton tests 2025-01-29 20:52:34 -05:00
81e10bdd53 unused variable 2025-01-29 20:20:19 -05:00
4df3dead69 silence warning 2025-01-29 20:16:34 -05:00
3b5dfb0a05 properly unwrap positions 2025-01-29 20:16:26 -05:00
67e28c2bfd update for LAMMPS programming style 2025-01-29 20:15:59 -05:00
c4106f9d09 Merge remote-tracking branch 'github/develop' into recover-failed-tests 2025-01-29 19:39:58 -05:00
74dca2daad Merge pull request #4310 from EiPiFun/develop-eipifun-with-doc
Add angleoffset for hbond/dreiding/morse and hbond/dreiding/lj
2025-01-29 17:12:36 -05:00
f5a8019654 spelling fixes and updates for the manual 2025-01-29 16:39:53 -05:00
b4eee0c27a Marking scalar intensive in elec/stop/fit fix 2025-01-29 13:58:47 -07:00
d638f66b68 updating to match new 1d syntax 2025-01-29 13:29:15 -07:00
ff340cf409 Repairing srp wildcard logic 2025-01-29 13:09:49 -07:00
6c8d531f78 remove unused variables and related dead code 2025-01-29 05:51:24 -05:00
3f38635ecc restore "= 0.0" deleted by accident 2025-01-28 22:08:46 -05:00
229916e11f whitespace 2025-01-28 21:35:11 -05:00
201d1a59b5 the /angleoffset versions have their own different parameter file and reader 2025-01-28 21:33:44 -05:00
759a37cc75 update and synchronize with implementation of the non-OPENMP version 2025-01-28 21:33:03 -05:00
8b85ee22a3 use consistent formatting across all hbond/dreiding styles 2025-01-28 21:32:13 -05:00
f928df87a1 Merge branch 'develop' into develop-eipifun-with-doc 2025-01-28 19:42:13 -05:00
0a7e0dc388 Remove another unused variable 2025-01-28 17:23:39 -07:00
e728ca31d6 Remove unused variable 2025-01-28 16:35:16 -07:00
ec2b98448d Fix bug in compute stress/cartesian density profile with periodic boundary conditions 2025-01-28 16:33:19 -07:00
800a5f6310 Merge pull request #4409 from willzunker/mdr-rebase2
pair_style granular - MDR contact model
2025-01-28 16:33:27 -05:00
48f92a6404 Merge pull request #4440 from akohlmey/collected-small-changes
Collected small changes and fixes
2025-01-28 16:28:11 -05:00
005433c7e3 Merge branch 'develop' into develop-eipifun-with-doc 2025-01-28 12:45:16 -07:00
f8ac22ade7 add flags and set up inheritance 2025-01-28 12:42:34 -07:00
bb83497f61 add offset code to base omp files 2025-01-28 12:40:50 -07:00
1ebc109234 Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2025-01-28 12:21:06 -05:00
082fa6fae5 Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2025-01-28 10:14:36 -07:00
ab2c8af38d Fix issue with Kokkos QEq and ACKS2 when atoms are added and the neighlist isn't marked as rebuilt, original code by @alphataubio
Co-authored-by: Mitch Murphy <alphataubio@gmail.com>
Co-authored-by: Stan Moore <stanmoore1@gmail.com>
2025-01-28 10:14:28 -07:00
0f6ee5c8a1 improve error messages 2025-01-28 12:01:59 -05:00
334dab68f7 must flag function as override after adding virtual function in base class 2025-01-28 05:37:24 -05:00
2c3f0d65ac update docs 2025-01-27 20:58:49 -05:00
8f551df46a add fortran interface for lammps_addstep_compute() and lammps_addstep_compute_all() 2025-01-27 20:38:08 -05:00
026da76a3b cutoff radius related items 2025-01-27 14:16:18 -08:00
23045d62c5 add plugin wrapper and swig interface to new LAMMPS library functions 2025-01-27 14:29:15 -05:00
5d47c417ed add fortran interface for lammps_clearstep_compute() 2025-01-27 14:26:53 -05:00
77e6a6dcef Suppress compiler warning since return value can be safely ignored 2025-01-27 10:58:15 -07:00
d42f881c06 Remove unused variables to prevent compiler warnings 2025-01-27 10:43:44 -07:00
6398a7c7aa add test for the library interface to clearstep_compute and addstep_compute 2025-01-27 12:25:46 -05:00
0fde98cfbc use POINTER() captitalization consistently 2025-01-27 11:17:04 -05:00
a242511ce7 avoid segfaults 2025-01-27 11:16:27 -05:00
3a986fb50d Merge remote-tracking branch 'github/develop' into python_computes 2025-01-27 11:15:42 -05:00
6bb022853e avoid segfault on command line errors 2025-01-26 21:45:12 -05:00
8e2cb0f4c8 calculate molids on first timetstep of run
but do not delete molecules
2025-01-26 15:22:00 -05:00
4c22410548 docs: molIDs range from 1 to # molecules 2025-01-25 23:41:35 -05:00
991b8c11ff delete option: reset molecule ID to index from 1 2025-01-25 23:38:15 -05:00
464d9d82d6 return correct clusterIDs even on first timestep 2025-01-25 23:33:04 -05:00
baf9a9b2d2 need to update delete_Tcount before returning
needs to be every timestep, regarding of Nfreq, etc. settings
2025-01-25 23:14:09 -05:00
00054a8d97 Merge branch 'add-error-explanations' of github.com:lammps/lammps into add-error-explanations 2025-01-25 21:50:39 -05:00
28bc5fb2bd revise error messages to use pointers where possible and meaningful 2025-01-25 20:37:55 -05:00
f8750baf4e whitespace 2025-01-25 20:37:22 -05:00
281336800a Another error url for nbins 2025-01-25 15:05:50 -07:00
9fb8cc1d17 drafting error urls for nbin classes 2025-01-25 14:59:55 -07:00
8482d150e1 update label 2025-01-25 16:22:12 -05:00
ccc790265d geometric center -> com 2025-01-25 16:21:21 -05:00
ceac416f9a average charge -> total charge in pos file 2025-01-25 15:16:26 -05:00
0a954b0129 per-atom mass bugfix for delete keyword 2025-01-25 14:44:18 -05:00
cbd99d29cf update pointers in case changed at some point
is 'clusterID' name for per-atom property too general?
2025-01-25 14:17:20 -05:00
4bdc02ef3a bugfix for when not using variable Nlimit
for delete option
2025-01-24 23:41:00 -05:00
3a44a03f04 migrate clusterID to fix property/atom 2025-01-24 23:29:10 -05:00
563b5b0997 flush buffers after writing error messages 2025-01-24 20:43:12 -05:00
e039927a31 convert fix ave/histo to have improved error messages 2025-01-23 22:29:56 -05:00
8c6d0bef41 remove repeated code 2025-01-23 20:25:14 -05:00
6fb318f61c Merge branch 'develop' into collected-small-changes 2025-01-23 20:22:14 -05:00
a0fcbc9b71 Merge pull request #4442 from akohlmey/freeze-fmt-lib-prepare-std_format
Freeze fmt library at version 10.2.1 and add changes that prepare LAMMPS for transition to std::format
2025-01-23 20:21:42 -05:00
934bed29f5 Revert "apply workarounds for (probably bogus) warnings or errors from nvcc"
This reverts commit 5ddad0bbde.
2025-01-23 12:19:24 -05:00
b9a8ddbb8c add versionadded tag 2025-01-23 12:12:46 -05:00
b5da9ce3e2 Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-23 12:06:59 -05:00
0dfd5d821a Merge pull request #4401 from mala-project/mala
Kokkos versions of bispectrum and Gaussian descriptors on grid
2025-01-23 12:06:25 -05:00
f8484de195 more details about current and future compiler requirements 2025-01-23 12:02:51 -05:00
a771277a6c Merge branch 'develop' into add-error-explanations 2025-01-23 11:35:55 -05:00
a30b5f9345 add check for fmt::print() to GitHub style check workflow 2025-01-23 11:30:13 -05:00
dac011b865 add placeholders for versionadded tags for new functions 2025-01-23 11:21:09 -05:00
d7ffa16817 small correction 2025-01-23 11:20:36 -05:00
493ff3017c add tool for checking whether fmt::print() statements have crept in 2025-01-23 10:26:56 -05:00
49dc526bc8 doc fix for kspace_modify from @ndtrung81 2025-01-23 10:06:37 -05:00
790b124f6a correct help text 2025-01-23 08:52:27 -05:00
57cc7b6817 programming style and error message updates 2025-01-23 06:00:41 -05:00
5803a62822 add check to fix drude to detect if core atoms without drude atom id exist 2025-01-23 06:00:16 -05:00
d1dc0f7efc enable and apply clang-format 2025-01-23 04:54:45 -05:00
4be26c3480 add test whether drude particle was found locally and stop with error when not
this handles two cases:
1 the actual drude particle is not in the sub-domain
2 the drude particle was never assigned by fix drude
2025-01-23 04:54:21 -05:00
3e4a50fe63 remove backward compatibility for compute_modify extra and compute_modify dynamic
Now extra/dof and dynamic/dof are required
2025-01-23 04:52:05 -05:00
b016b135fa added Compute::modify_param() function.
This way individual computes can add custom keywords to compute_modify in
a similar fashion as fixes
2025-01-23 04:51:12 -05:00
048b96af65 Merge branch 'develop' into mala 2025-01-23 09:44:00 +01:00
55add23309 Merge pull request #7 from stanmoore1/mala
Fix issues with GNU Make build
2025-01-23 09:43:16 +01:00
5959a01abd Revert "import libfmt 11.0.1"
This reverts commit fbc6ba4ef4.
2025-01-23 03:41:29 -05:00
1aee093bfd revert workaround for compiling with C++20 and later 2025-01-23 00:19:06 -05:00
1fef98dc50 Revert "import code for fmtlib 11.1.0"
This reverts commit 833607f926.
2025-01-23 00:17:01 -05:00
b5e48f6769 Revert "bugfix update to version 11.1.1"
This reverts commit c9b69b00c5.
2025-01-23 00:16:47 -05:00
80d00e3b3c Revert "add bugfixes with update to version 11.1.2"
This reverts commit 9e4a51d568.
2025-01-23 00:16:29 -05:00
e26599c532 Revert "We no longer support Intel icc version 19 or older. Clean up checks/flags."
This reverts commit 906117ff47.
2025-01-23 00:15:48 -05:00
8f57539bab work around the requirement that fmt::format() needs a constexpr string as format
we need this change to make bot {fmt} compatible wth C++20 and later and also conform to std::format requirements
2025-01-23 00:13:27 -05:00
e4dbfee498 replace fmt::print() with utils::print() 2025-01-23 00:11:31 -05:00
8baec60155 implement an utils::print() function similar to fmt::print()
this doesn't have the constexpr requirement for the format string.
also it will help porting to std::format in C++20, which doesn't
have a similar functionality either.
2025-01-23 00:03:30 -05:00
3412c4744d fix fmt::format() missing argument bugs 2025-01-22 23:58:29 -05:00
b4f012057c fix fmt::format() missing argument bugs 2025-01-22 23:57:58 -05:00
c1662f64ca reaxff/species: post_integrate->end_of_step
fix for incorrect molecule IDs (variable: clusterID) output by reaxff/species vector

Co-Authored-By: mkanski <20713012+mkanski@users.noreply.github.com>
Co-Authored-By: Navraj <88741755+navlalli@users.noreply.github.com>
2025-01-22 23:52:52 -05:00
cc36947449 make use of new Error class APIs 2025-01-22 22:15:08 -05:00
3012e02de1 Merge branch 'develop' into add-error-explanations 2025-01-22 18:26:21 -05:00
5ddad0bbde apply workarounds for (probably bogus) warnings or errors from nvcc 2025-01-22 18:20:58 -05:00
94eee049b4 Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-22 18:01:43 -05:00
e548c656ce Merge pull request #4435 from athomps/hybrid-scaled-peratom
Hybrid scaled peratom
2025-01-22 18:00:18 -05:00
6b4ecfd719 Fix issues with GNU Make build 2025-01-22 15:33:09 -07:00
19d64fd0f9 Fix massive performance regression on GPUs with Kokkos version of fix npt 2025-01-22 14:22:09 -07:00
b00a2a2e1d Merge branch 'develop' into mala 2025-01-22 08:13:51 +01:00
c0be84356e Removed debugging output, added contributor, added files to Install.sh 2025-01-22 08:13:36 +01:00
b1b51307c0 silence CodeQL warnings about potential overflows 2025-01-21 22:41:41 -05:00
21bbd69b3c remove dead code 2025-01-21 22:41:12 -05:00
651c1b2bc2 Merge branch 'develop' into collected-small-changes 2025-01-21 20:06:50 -05:00
0767de7eeb Merge pull request #4439 from akohlmey/arm-cpu-unittest
Add Workflow for running ctest on Linuix with ARM64 CPU
2025-01-21 19:56:42 -05:00
4912f1347c Merge pull request #4399 from stanmoore1/kk_bug_fixes
Fix issues in KOKKOS package
2025-01-21 19:56:11 -05:00
4fdd85df4f Need local capture for lamdas on GPUs 2025-01-21 16:13:52 -07:00
fbfdcbbac1 Merge branch 'develop' into kk_bug_fixes 2025-01-21 14:50:34 -07:00
7c0254caee Limiting rho calculation for tait equation 2025-01-21 13:47:22 -07:00
c6adf793ab Fixing comment in example script 2025-01-21 13:05:02 -07:00
96d44c729b Fix more issues in Kokkos fix langevin gjf option 2025-01-21 10:51:40 -07:00
8c2d83c5eb avoid double initialization and potential double free 2025-01-21 11:24:01 -05:00
3bb26ae87b Merge branch 'develop' into mala 2025-01-21 17:11:43 +01:00
536aa7cadf Removed debug comments/old printfs etc. 2025-01-21 17:09:04 +01:00
f4b8200bcc download plumed-2.9.3 by default now 2025-01-21 10:39:08 -05:00
45222b3f9a run check only after merges (for now) 2025-01-21 10:03:51 -05:00
2d3cd6a646 skip known to be unstable unit tests 2025-01-21 01:46:08 -05:00
f10d1a30fc increase epsilon for passing tests on Linux ARM64 2025-01-21 01:45:49 -05:00
911fd0946c add github action to run unit tests on ARM64 2025-01-21 00:24:10 -05:00
3c02731362 Merge pull request #4438 from akohlmey/collected-small-fixes
Collected small changes and fixes
2025-01-21 00:01:42 -05:00
a7af0fc078 Fix warnings 2025-01-20 22:00:34 -07:00
d614aeb91d Fix small memory leak, add debug RNG 2025-01-20 17:37:32 -07:00
75f4d3deb7 Merge branch 'develop' into small-patches 2025-01-20 16:25:07 -07:00
9cb67de38f Merge branch 'develop' of github.com:lammps/lammps into kk_bug_fixes 2025-01-20 15:50:48 -07:00
29397b4a44 Fix more issues in fix langevin/kk pointed out by @ndtrung81
Co-authored-by: Trung Nguyen <ndactrung@gmail.com>
Co-authored-by: Stan Moore <stanmoore1@gmail.com>
2025-01-20 15:50:21 -07:00
292ae27f98 use ioffset variable to indicate the first argument that is not fixed
also, convert all error messages to use the new style.
2025-01-20 14:57:11 -05:00
2c82ce8142 library: update new function signatures to use void* instead of bigint 2025-01-19 16:06:33 -07:00
93e266f648 Merge remote-tracking branch 'origin/develop' into python_computes 2025-01-19 15:41:30 -07:00
a5b66f02d1 update docs 2025-01-18 22:19:43 -05:00
d99c960eb9 resolve unit test failures due to enhanced error handling 2025-01-18 21:40:48 -05:00
9cca8ab179 modernize 2025-01-18 15:54:34 -05:00
2817ad036f make coverity scan happy 2025-01-18 11:54:48 -05:00
c2bcf79196 avoid divisions 2025-01-18 11:45:27 -05:00
0501f76fcf follow LAMMPS programming style more closely 2025-01-18 11:37:53 -05:00
7b994801b5 constant was denormal. increase to become normal 2025-01-18 11:37:20 -05:00
23c63511f0 no hiden tabs, use string escapes instead. 2025-01-18 11:08:25 -05:00
7ffe04ca92 discuss that only turning off bonds can lead to "bond atom missing" errors
also make notes and this warning stand out more by using adminition boxes
2025-01-18 09:08:08 -05:00
efd5165707 avoid segfaults if there was no input processing 2025-01-17 23:27:36 -05:00
e38c13a764 add strcompress function and use it for error output 2025-01-17 22:59:44 -05:00
e350f28e26 refactor how error output is created and only print input and parsed line if they differ in text 2025-01-17 18:06:31 -05:00
fecf1c2f69 update morse coeff method, fix bug in flag 2025-01-17 15:59:28 -07:00
f540e8b9ff whitespace 2025-01-17 12:48:57 -07:00
72784262b1 Merge branch 'develop' into mdr-rebase2 2025-01-17 12:17:20 -07:00
9b443c9a4d add utility function to compare two string while ignoring whitespace 2025-01-17 14:06:30 -05:00
769b0b9211 Clarifying doc on svector for many models, resetting svector values in granular model 2025-01-17 11:56:37 -07:00
e6a84d5f2a Added mdr svector to doc and svector example in in.triaxial.compaction.12 2025-01-17 13:37:15 -05:00
90416b63fc move misplaced break statement 2025-01-17 13:14:51 -05:00
7900f24844 Adding contact area svector to mdr 2025-01-17 11:29:35 -05:00
ea9345444a Merge branch 'collected-small-fixes' of github.com:akohlmey/lammps into collected-small-fixes 2025-01-17 10:41:12 -05:00
b9dbfc6eb2 add support to flag failed arguments for calls to expand_args() 2025-01-17 10:40:34 -05:00
5a45ef6994 explain error message output for users 2025-01-17 10:35:34 -05:00
0cb64afc84 explain error message output for users 2025-01-17 09:13:55 -05:00
7c4649adbf update TODO list and changelog 2025-01-17 08:43:46 -05:00
a4cc00041c add notes about errors and warnings and log output 2025-01-17 05:13:25 -05:00
1e179b2432 address warnings reported by coverity scan 2025-01-17 05:12:40 -05:00
3b815c1bbe remove dead code 2025-01-16 22:02:11 -05:00
cf7695e99f add option to restart the LAMMPS instance to "Run" menu 2025-01-16 21:43:36 -05:00
1636a11054 fix minor issues 2025-01-16 21:22:41 -05:00
fa54fd1097 add option to suppress printing the last command 2025-01-16 21:11:27 -05:00
de5a41de7b simplifying svector handling for walls 2025-01-16 15:37:16 -07:00
57d47ebb4f Adding custom svector gransubmod quantities 2025-01-16 15:32:12 -07:00
b9a5557911 Added support for single() and born_matrix() 2025-01-16 14:36:44 -07:00
1bcbf6dc4b Error to warning for overlap check 2025-01-16 16:28:19 -05:00
95152b1eb6 Slight adjustments to overlap check 2025-01-16 16:00:16 -05:00
af8b873bf5 Adding error message for initial overlaps 2025-01-16 12:22:50 -07:00
da5a12fcd1 increase visibility of highlighting the failed argument 2025-01-16 11:39:53 -05:00
6c16b1de74 must not set to unique if request is for skip list. only check for smallest pair cutoff. 2025-01-16 10:26:48 -05:00
f273116681 prevent the neighbor list re-ordering from getting stuck 2025-01-16 10:18:16 -05:00
82598ab3ca display error messages with fixed width font 2025-01-16 00:39:02 -05:00
00f23d4829 revert workarounds in compute rdf and adf now that the issue is fixed at the root 2025-01-16 00:38:31 -05:00
36dcb294b3 we need tighter checks, also on the smallest pairwise cutoff, before we can re-use a default neighbor list for an occasional list with an explicit cutoff 2025-01-16 00:23:47 -05:00
f60139d374 some more fixes to address coverity scan warnings. 2025-01-15 23:12:39 -05:00
8c93986e47 add overloads for Error::all() and Error::one() that can point out the location of a faulty argument 2025-01-15 23:12:11 -05:00
b21f804e4e Fixing initialized overlap bug 2025-01-15 20:00:19 -07:00
6aa0c95c5e Removed more unnecessary input file lines 2025-01-15 21:46:42 -05:00
4cfe4831ed Removed unnecessary input file lines 2025-01-15 21:13:08 -05:00
0f462a60ff sign error, better variable name 2025-01-15 14:40:08 -07:00
c5e3ffed75 Fixed merge conflict 2025-01-15 14:14:51 -07:00
b8fcb927ee Added forward comm for atomscale values 2025-01-15 14:11:00 -07:00
50f932ba9e Updating const expressions 2025-01-15 13:06:10 -07:00
a5e3e755c2 Adding safety checks for some variables 2025-01-15 11:33:02 -07:00
7fa1bf39f3 shift settings check from angleoffset to base LJ 2025-01-15 10:24:25 -07:00
48f49837d8 fix some more minor memory issues flagged by coverity scan 2025-01-15 08:23:58 -05:00
c3ca6a8e56 Merge branch 'develop' into mala 2025-01-15 13:19:15 +01:00
4afdf493d7 integrate and adapt contents from PR #4028 by @alphataubio 2025-01-15 06:05:25 -05:00
66ffb1c39e whitespace 2025-01-15 04:55:36 -05:00
29fca919b1 apply clang-format 2025-01-15 04:49:34 -05:00
f1fb0906be correct class name 2025-01-15 04:49:21 -05:00
865ce67e83 use correct base class 2025-01-15 04:48:07 -05:00
bf0f149445 Merge pull request #6 from stanmoore1/mala
Fix compile issues from LAMMPS https://github.com/lammps/lammps/pull/4391
2025-01-15 10:46:54 +01:00
dfd8631394 remove debug output 2025-01-15 04:40:48 -05:00
11a790a04a angle_offset_one and cut_angle_one are only local variables 2025-01-15 04:36:51 -05:00
41555a66e9 correct documentation and add versionadded tag 2025-01-15 04:20:34 -05:00
58eca0eef4 Merge branch 'develop' into develop-eipifun-with-doc 2025-01-15 04:11:53 -05:00
3a2349fa32 add some troubleshooting suggestions 2025-01-15 00:02:11 -05:00
27540503ad Merge remote-tracking branch 'github/develop' into add-error-explanations 2025-01-14 22:30:34 -05:00
8b5c9a18fd Merge branch 'develop' into hybrid-scaled-peratom 2025-01-14 22:29:11 -05:00
2cbdaf8a6a fix some issues flagged by coverity scan 2025-01-14 22:23:24 -05:00
5f50278241 transfer workaround from compute rdf 2025-01-14 22:06:00 -05:00
781b40643c add deprecation warning for using accelerator offload with INTEL package 2025-01-14 20:49:00 -05:00
fbc66f75ac adjust epsilon (again) for macOS on ARM 2025-01-14 20:48:43 -05:00
5e90674fbe Merge commit 'ffa4765b154aea2027e438ac134f8d6ce742419a' into collected-small-fixes 2025-01-14 20:48:35 -05:00
ffa4765b15 Merge pull request #4241 from gsalkuin/develop
Add new fix to compute force and torque due to electric potential
2025-01-14 20:33:10 -05:00
34075ebb3f apply clang-format 2025-01-14 20:22:34 -05:00
494c2fc033 add atomvar array to restarts 2025-01-14 20:22:07 -05:00
e745b37a45 Merge branch 'develop' into hybrid-scaled-peratom 2025-01-14 20:05:28 -05:00
89370efe39 Merge branch 'develop' into develop 2025-01-14 19:12:14 -05:00
906399b14f Merge pull request #3 from srtee/efield_lepton_updates
Efield lepton updates
2025-01-14 19:11:09 -05:00
bbb7d86614 Merge pull request #4410 from soniasalomoni/pair_d3
pair_style d3 - D3 dispersion corrections
2025-01-14 18:21:52 -05:00
028367804e Finshed condensing equations 2025-01-14 16:09:43 -07:00
264c1c3140 Merge branch 'develop' of github.com:lammps/lammps into mala 2025-01-14 16:02:37 -07:00
eb5977dc66 Fix issues with host_flag 2025-01-14 15:57:15 -07:00
008bf14693 Fix compile issues from #4391 2025-01-14 15:49:40 -07:00
0ee4bf621f Fix some compile issues and remove unused variables 2025-01-14 14:35:42 -07:00
3101bb3263 Add new files to GNU Make build system 2025-01-14 14:34:59 -07:00
4611b84b6f Filled in mdr cite command 2025-01-14 16:20:37 -05:00
0fe7fbdb42 Merge branch 'develop' into pair_d3 2025-01-14 16:05:29 -05:00
b7c02d6a03 Starting to break down MDR equations 2025-01-14 13:49:56 -07:00
b2e35f1808 Doc spell check 2025-01-14 13:18:43 -05:00
853a8efa88 Remove README_MDR.md 2025-01-14 12:32:20 -05:00
14389cfd2c Reset ddelta_bar even during update->setupflag=true 2025-01-14 11:33:55 -05:00
9c7714e40f Simplified deltamax definition 2025-01-14 10:52:12 -05:00
a4f02fbad3 handle the case when pair-wise cutoff varies and neighbor list is not sufficient 2025-01-14 10:04:16 -05:00
b27aa31baa fix whitespace 2025-01-14 22:35:56 +10:00
276b8d9c93 streamline Lepton variable update process with ptr-vectors 2025-01-14 22:31:42 +10:00
1f7533029b deduplicate force and torque calculations 2025-01-14 22:08:16 +10:00
af1f442b97 increment bugfix for "inputs local" 2025-01-14 07:06:37 -05:00
edb068c43f Merge pull request #4426 from akohlmey/update-to-fmtlib-11.1
Update embedded fmtlib copy to version 11.1
2025-01-14 01:24:57 -05:00
e682f3d3e5 work on docs 2025-01-14 01:19:25 -05:00
783d21c19b these functions do not create errors or throw exceptions 2025-01-14 00:55:48 -05:00
a50343077d Merge remote-tracking branch 'github/develop' into python_computes 2025-01-14 00:53:19 -05:00
31d1addfad Merge pull request #4434 from akohlmey/collected-small-changes
Collected small changes and fixes
2025-01-14 00:41:10 -05:00
7b9f7be485 replace vecs with arrays since size known at compile-time; make phi and dphi flagging uniform 2025-01-14 14:47:33 +10:00
7c8c8c9d01 update patch for WHAM code 2025-01-13 22:07:44 -05:00
b56b8a016a Merge pull request #2 from akohlmey/efield_lepton_updates
Fix efield/lepton updates
2025-01-13 20:40:17 -05:00
c2868c448e Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-13 20:34:14 -05:00
754517dcf6 Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2025-01-13 20:32:01 -05:00
6d7926a026 add missing lammps_expand() function 2025-01-13 19:13:34 -05:00
663f812799 fix inconsistent backquotes 2025-01-13 19:05:04 -05:00
55a3b28f7d replace CR-LF with LF 2025-01-13 16:19:40 -05:00
8705a14b35 create logs for example input 2025-01-13 16:18:24 -05:00
ec669676d0 remove unused variables 2025-01-13 16:11:14 -05:00
742c869534 Merge branch 'develop' into gsalkuin/develop 2025-01-13 16:08:18 -05:00
be048fc636 cosmetic changes 2025-01-13 16:01:18 -05:00
ddff545a4c Merge pull request #4431 from Becksteinlab/imd-v3-integration
Interactive Molecular Dynamics [IMD] Version 3 implementation
2025-01-13 15:59:41 -05:00
2a5e20c1c1 Merge remote-tracking branch 'origin/develop' into hybrid-scaled-peratom 2025-01-13 12:20:53 -07:00
dd8cc3ebdd Merge remote-tracking branch 'upstream/develop' into develop 2025-01-13 12:18:51 -07:00
1d1320f648 Merge remote-tracking branch 'origin/develop' into python_computes 2025-01-13 10:51:33 -07:00
83a73ba0b9 library: add API for compute clearstep and addstep 2025-01-13 10:51:19 -07:00
62aa803d53 order list of removed commands and packages in reverse order of their removal date
also add an (automatic) table of contents simplify finding something
2025-01-13 12:03:31 -05:00
a22c58cd47 add missing update to invoked_bonds in ComputeReaxFFAtomKokkos 2025-01-13 00:17:05 -07:00
dc7f28c4c0 Merge branch 'develop' into add-error-explanations 2025-01-13 01:27:34 -05:00
686326a999 Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-13 01:05:48 -05:00
528770f07d Merge pull request #4344 from lammps/cmake-cpp-std-deprecation
Prepare development branch for requiring C++17 and deprecating GNU make support for some packages
2025-01-13 01:05:07 -05:00
d692a99e4d print PyLammps deprecation warning only once and only from MPI rank 0 2025-01-13 00:04:14 -05:00
dd6fea3fcd Merge branch 'develop' into cmake-cpp-std-deprecation 2025-01-12 23:54:50 -05:00
e20f3ec874 macOS does not like forward declarations for standard C++ classes 2025-01-12 23:50:33 -05:00
f50edb5a38 Merge pull request #4369 from rbberger/deprecate_pylammps
Python interface updates
2025-01-12 23:30:22 -05:00
0aadc4cf46 use mutex to avoid race condition when accessing thermo data during run 2025-01-12 23:27:17 -05:00
78850efaed also warn that KOKKOS will end support for legacy builds in Summer 2025 2025-01-12 21:57:25 -05:00
7c990f8b0e improve wording 2025-01-12 21:56:54 -05:00
2df402c4ff Merge branch 'develop' into cmake-cpp-std-deprecation 2025-01-12 21:47:02 -05:00
906117ff47 We no longer support Intel icc version 19 or older. Clean up checks/flags. 2025-01-12 21:46:04 -05:00
c476e6704b revert workarounds for Intel ICC 19.x 2025-01-12 20:13:24 -05:00
4519489f8b fix unit test and another workaround for intel compilers 2025-01-12 19:42:03 -05:00
fedb3fa6b8 Rearranged memory allocation 2025-01-12 16:28:56 -07:00
c8a46fe4ce make better use for std calls and improve error messages 2025-01-12 17:48:50 -05:00
943504fd98 move timespec2seconds exception handling to calling function 2025-01-12 17:48:20 -05:00
60b10c1588 Merge remote-tracking branch 'github/develop' into update-to-fmtlib-11.1 2025-01-12 16:52:56 -05:00
f34ae8a011 simplify 2025-01-12 16:49:49 -05:00
296f1ab29f alternate attempts to work around intel icc 19 limitations 2025-01-12 16:43:37 -05:00
7b60abf569 add LAMMPS customization for Intel compilers 2025-01-12 16:11:50 -05:00
9e4a51d568 add bugfixes with update to version 11.1.2 2025-01-12 15:41:37 -05:00
a5c3305c42 sync with lammps tutorials paper description 2025-01-12 15:09:42 -05:00
85dec585a6 add tests for lammps_eval() and its python counterpart 2025-01-12 14:49:07 -05:00
dce1231052 add a lammps_eval() function to the C library interface and all derived wrappers 2025-01-12 00:39:18 -05:00
be596cca0c revert setting to run flatpak builder test action only after merges 2025-01-11 19:31:31 -05:00
cf2e800aaa extract bundle from local flatpak repo and try to install it 2025-01-11 19:20:06 -05:00
672faf9fe5 operate on "develop" branch 2025-01-11 19:06:49 -05:00
fb1c090f19 revert to lammps repo 2025-01-11 18:59:22 -05:00
cb2acb633b update workflow 2025-01-11 18:56:59 -05:00
61c541ff92 add github action to build LAMMPS-GUI as flatpak 2025-01-11 18:47:35 -05:00
91dfa41494 Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-11 18:17:04 -05:00
a443fe4142 Merge pull request #4433 from farrelljd-iop/angle-mwlc
Angle style MWLC (meltable wormlike chain)
2025-01-11 18:07:36 -05:00
b508229bd2 adapt to LAMMPS programming style 2025-01-11 18:05:16 -05:00
8b2c852121 correct and update the Python Howto 2025-01-11 17:54:44 -05:00
994a631150 add "post no" for single-shot runs 2025-01-11 17:43:05 -05:00
283adb288b Converted tabs to blanks 2025-01-11 13:19:54 -07:00
a2f8e730a2 Adjusted white spcae 2025-01-11 12:32:45 -07:00
69e1bbae04 Updated doc page 2025-01-11 12:32:05 -07:00
be62d7e04b Merge pull request #4 from akohlmey/imd-v3-updates
Add separator comments
2025-01-11 11:51:08 -07:00
0d85c5c704 add separators 2025-01-11 11:13:47 -05:00
7520282568 First pass, compiled, not run 2025-01-10 19:31:03 -07:00
e3f930b33f Merge pull request #1 from akohlmey/angle-mwlc
Small updates to PR #4433
2025-01-11 10:04:12 +08:00
3126482c48 update variable command tests to include whitespace 2025-01-10 20:53:24 -05:00
c4a5906382 stop checking ML-PACE with coverity scan as recent CMake changes break it 2025-01-10 20:12:09 -05:00
4f6c3d12f7 avoid variable definition error: expected 3 arguments but found N 2025-01-10 20:10:53 -05:00
dbc6f77e53 Merge branch 'develop' into deprecate_pylammps 2025-01-10 16:01:06 -07:00
bc8c8f1c3f Merge remote-tracking branch 'upstream/develop' into develop 2025-01-10 12:10:52 -07:00
6732013935 apply clang-format 2025-01-10 12:17:29 -05:00
5a0222153a small doc updates and corrections 2025-01-10 12:15:24 -05:00
e858c8a78d Merge branch 'develop' into angle-mwlc 2025-01-10 14:33:50 +08:00
4af328cba1 added contributing author email 2025-01-10 14:08:34 +08:00
5490336543 added a unit test 2025-01-10 14:06:00 +08:00
6bdc58baaf improved the documentation 2025-01-10 14:05:19 +08:00
3731513576 example IMDv3 usage 2025-01-09 21:55:44 -07:00
c7ae973948 more edits to angle_mwlc documentation 2025-01-10 12:02:27 +08:00
2b688bb013 replace defines with static constexpr 2025-01-09 21:32:58 -05:00
38c3477d2f Merge pull request #4394 from rbberger/find-package-pace
ml-pace: allow linking to existing pace library
2025-01-09 19:41:19 -05:00
4330801a2f Merge pull request #4429 from akohlmey/collected-small-changes
Collected small changes and fixes
2025-01-09 19:33:52 -05:00
9f40bbc2b6 fix spelling 2025-01-09 14:36:18 -05:00
a17213fc62 add link and description paragraph for the "Out of range atoms" error 2025-01-09 12:29:54 -05:00
a769b3d6b2 Merge branch 'develop' into collected-small-changes 2025-01-09 11:17:05 -05:00
cb930d6470 Merge pull request #4405 from tylercollins5737/develop
vcm example script and log added
2025-01-09 10:20:16 -05:00
9c1da4cbc9 whitespace fix in doc 2025-01-08 22:45:38 -08:00
090e55b1d8 Merge branch 'develop' into develop 2025-01-08 22:42:31 -08:00
617f798199 make sure that retstr is always initialized since it is always communicated 2025-01-09 00:37:43 -05:00
ce05f0cd9d Merge pull request #3 from akohlmey/imd-v3-updates
Imd v3 Integration updates
2025-01-08 21:07:10 -07:00
9a513ca82c Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-08 21:54:04 -05:00
50bda6077c Merge pull request #4430 from akohlmey/update-linalg
Update linalg to version 1.4.2 corresponding to LAPACK 3.12.1
2025-01-08 21:53:33 -05:00
52d932df3b Merge pull request #4413 from stanmoore1/kk_update_4.5.0
Update Kokkos library in LAMMPS to v4.5.1
2025-01-08 21:23:19 -05:00
41e7cf7879 MPI bugfix for dump netcdf from Paul Coffman 2025-01-08 21:18:03 -05:00
494f58904c correct reference 2025-01-08 20:54:04 -05:00
1032c94c9f apply some more of LAMMPS' programming style guidelines and improve errors 2025-01-08 20:52:57 -05:00
6a363d441b small formatting tweaks, add versionadded tag 2025-01-08 20:52:45 -05:00
02a8a9d706 make LAMMPS_ASYNC_IMD a CMake variable, too, and document it properly 2025-01-08 20:50:16 -05:00
1ebf591592 Merge branch 'develop' into imd-v3-integration 2025-01-08 16:13:50 -07:00
0dacedd8b0 undo workflow changes 2025-01-08 16:12:58 -07:00
668435380b Make sure that yaml-cpp::yaml-cpp exists 2025-01-08 15:41:37 -07:00
748046089c add another couple of dependent functions 2025-01-08 16:32:56 -05:00
f3425ebfbf add one more missing dependency 2025-01-08 16:21:08 -05:00
e7d9244184 add missing dependency 2025-01-08 16:14:28 -05:00
8ec9f37611 update linalg to version 1.4 corresponding to LAPACK 3.12.1 2025-01-08 15:52:30 -05:00
ec7be395ea ml-pace: update tag 2025-01-08 11:48:34 -07:00
24763bfd8e add info on how to debug if LAMMPS seems stuck 2025-01-08 12:24:13 -05:00
ae6b2d85fb fix typo 2025-01-08 10:04:14 -05:00
cbab95e569 update for more clarity 2025-01-08 10:04:06 -05:00
1432df370b modernize access for fixes and computes 2025-01-08 08:53:12 -05:00
613c38d9e6 replace loops with explicit iterators with c++-11 auto loops 2025-01-08 08:29:53 -05:00
d66d1a2dd2 fix indexing bug in dump vtk that would ignore the first 5 custom properties 2025-01-08 08:19:09 -05:00
42adfc1ae3 Merge remote-tracking branch 'github/develop' into collected-small-changes 2025-01-08 02:28:51 -05:00
0abb371fbe Merge pull request #4428 from tadmor/fix-kim-single-proc-error-bug
Single process errors in pair style kim reported using error->one
2025-01-07 22:34:26 -05:00
de667de8eb Fixing setup order 2025-01-07 15:36:37 -07:00
2482cfafe9 Simplifying fncrit 2025-01-07 13:27:01 -07:00
d9e40a79c1 Removing psi_b peratom variable 2025-01-07 13:19:07 -07:00
2c64d3b711 Moving contact penalty update 2025-01-07 12:58:18 -07:00
a795ae35fd Single process errors in pair style kim reported using error->one
Errors during a KIM compute operation that occur on a single processor were reported using error->all, which causes LAMMPS to hang when running in parallel with more than one processor. This has been fixed by replacing error->all with error->one for those cases.
2025-01-07 12:29:34 -06:00
61bc514b38 removing end of step in fix mdr 2025-01-07 11:07:19 -07:00
8595d8f05c Merge branch 'develop' of github.com:lammps/lammps into kk_update_4.5.0 2025-01-07 10:04:43 -07:00
9e373e7cc1 Merge branch 'develop' of github.com:lammps/lammps into kk_bug_fixes 2025-01-07 10:02:34 -07:00
75543e27e4 Uncommenting update flag, whitespace 2025-01-07 08:56:50 -07:00
ccc57f85a3 Missed changes 2025-01-07 08:50:05 -07:00
6c7d3646c7 Moving newton error to fix mdr 2025-01-07 08:50:05 -07:00
36b041a9ae Removing EoS update in setup 2025-01-07 08:50:05 -07:00
b10a5427a1 Simplifying variable initialization/resetting 2025-01-07 08:50:01 -07:00
c528573b62 Simplified delta partition logic and commented update check 2025-01-06 22:37:22 -05:00
14be59d3cc Minor spelling errors and input modification 2025-01-06 19:48:16 -05:00
16f6fe315c Restoring deleted character 2025-01-06 14:06:57 -07:00
09735b29e7 Adding setup check to MDR submodel 2025-01-06 13:58:49 -07:00
53084018ae Removed uncessary property/atom's: contacts and adhesive_length 2025-01-06 15:35:34 -05:00
2c655db731 Cleaned up example mdr input files 2025-01-06 15:11:57 -05:00
cec242a421 remove trailing whitespace 2025-01-06 12:30:45 -07:00
e9057ae5c8 mdr radius update explaination added to pair_granular.rst 2025-01-06 14:18:36 -05:00
df75830d63 Added error msgs to fix_granular_mdr.cpp and completed first draft mdr pair_granular.rst 2025-01-04 20:38:23 -05:00
467ceee9cb update patch for WHAM 2025-01-04 18:18:27 -05:00
670447ea21 correct list of valid reference syntax to computes, fixes, and properties 2025-01-04 16:22:05 -05:00
119aa59016 Improving error checks 2025-01-03 16:47:29 -07:00
2b10fc153b Started adding mdr model to pair_granular.rst 2025-01-03 17:43:38 -05:00
534632a598 Answered commented questions 2025-01-03 14:29:14 -05:00
629cb9d0d3 Small updates and answers for MD 2025-01-03 10:34:48 -07:00
cd6ab17d36 Merge pull request #4427 from akohlmey/collected-small-changes
Collected small changes and fixes
2025-01-03 12:27:43 -05:00
bc30665689 update unit test for changes in units command error messages 2025-01-03 04:04:42 -05:00
1fcf1a7c56 add patch for customization of wham to support LAMMPS units 2025-01-02 19:39:02 -05:00
f7cea5e428 improve error messages 2025-01-02 19:38:10 -05:00
735606a0b5 document inclusion of WHAM 2025-01-02 18:03:56 -05:00
d87abc0d01 correct CMake script code for including WHAM executables in macOS app-bundle 2025-01-02 17:25:44 -05:00
31963900da Providing answers to commented questions 2025-01-02 16:45:05 -05:00
399d7111d5 include WHAM software in LAMMPS-GUI compilation 2025-01-02 00:38:04 -05:00
463452e6a0 README added 2024-12-29 22:40:05 -08:00
b246599654 uploaded dated stress output file 2024-12-29 22:33:24 -08:00
f809aee52f uploaded dated plot 2024-12-29 22:31:35 -08:00
908c2aaf5e Merge branch 'develop' into develop 2024-12-29 20:35:47 -08:00
8b32516b79 display a valid URL for the download location 2024-12-29 20:11:59 -05:00
78a897c1bf check if a downloaded (solution) file is a symlink placeholder and put a copy of the original in its place 2024-12-29 17:22:07 -05:00
4d36a84738 add check whether libcurl support was compiled into LAMMPS and geturl is functional 2024-12-29 17:22:00 -05:00
9dbb9d356d reformulate to avoid command-line 2024-12-29 12:05:07 -05:00
0bdaece1f0 add keyboard shortcut and context menu entry for jump to next warning 2024-12-29 11:35:44 -05:00
f6c0c73289 improve layout of warnings panel 2024-12-29 10:48:54 -05:00
7d67bcad22 compatibility with Qt 5.12 on Ubuntu 20.04LTS 2024-12-28 22:09:29 -05:00
d70b923c5a update tutorial info texts from paper 2024-12-28 20:34:45 -05:00
73eeda3b1d display panel with number or warnings and lines in output window, button for jumping to next warning 2024-12-28 18:44:44 -05:00
255e50cfc3 Style changes to gransubmod 2024-12-28 11:14:05 -07:00
f50b5d63f3 combine the first two and the second two wizard pages into one page each 2024-12-28 12:38:52 -05:00
be9ace068a show download progress in status line and progress bar 2024-12-28 12:38:45 -05:00
e5ee94a13c add overloads for automatic string style conversions 2024-12-28 12:38:39 -05:00
bbef7e3eac update TODO 2024-12-27 23:01:20 -05:00
211099b7ca small updates and corrections to the LAMMPS-GUI howto 2024-12-27 22:57:51 -05:00
90d1e4d45f add code paths for all 8 tutorial wizards. only descriptive text is missing. 2024-12-27 15:42:36 -05:00
86e0b7e1d1 Consolidating history access in gran sub mod 2024-12-27 12:58:58 -07:00
c9b69b00c5 bugfix update to version 11.1.1 2024-12-27 12:03:23 -05:00
9241f89582 avoid 32-bit integer overflow by reordering 2024-12-27 11:35:28 -05:00
f71fa8e94e logo images for all 8 currently supported tutorials 2024-12-27 10:20:18 -05:00
916e5a81fb more fix::init() checks and some clang-formatting for NH style classes 2024-12-27 08:44:02 -05:00
1d4e2d7867 another chunk of added/updated/modernized internal compute checks at Fix::init() 2024-12-27 04:18:01 -05:00
fb33541961 use command-line consistently where applicable and drop "line" where not 2024-12-27 04:03:41 -05:00
de0baba124 add updates/corrections, improve formatting 2024-12-27 03:50:51 -05:00
53c3fa2afd memcpymask is a constant and thus should be uppercase 2024-12-27 01:54:44 -05:00
332653d5ca output embedded fmt lib version info with help flag and info config command 2024-12-26 23:36:46 -05:00
5ece81323e suppress bogus compiler warnings about overflowing buffer size in memcpy() 2024-12-26 22:53:44 -05:00
833607f926 import code for fmtlib 11.1.0 2024-12-26 22:10:28 -05:00
c7d58a4eef whitespace 2024-12-26 18:57:05 -07:00
48178ccc50 highlight error and warning messages in output window 2024-12-26 17:19:12 -05:00
b762610944 make taper warnings consistent between Kokkos and CPU and avoid multiple outputs 2024-12-26 16:28:22 -05:00
5947e3e82c use LAMMPS' warning function from Error class 2024-12-26 16:27:20 -05:00
f3cbf55d3c update LAMMPS-GUI todo list 2024-12-26 16:26:51 -05:00
f9b00fb0b4 Removing seeminly unnecessary steps in gran wall update 2024-12-26 10:55:42 -07:00
c78c53b36f more checking on temperature and pressure computes plus bugfixes 2024-12-24 16:06:17 -05:00
77ab630080 update LAMMPS-GUI TODO list 2024-12-24 15:36:40 -05:00
f00addcfaf Merge pull request #4422 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-12-24 14:40:56 -05:00
940473af98 Merge branch 'kk_update_4.5.0' of github.com:stanmoore1/lammps into kk_update_4.5.0 2024-12-24 10:35:16 -07:00
a9ce245527 Converting history indices to an enum 2024-12-24 10:35:16 -07:00
e31ca3c9c5 Update CMake 2024-12-24 10:35:05 -07:00
a23dcb67d1 Merge branch 'develop' into kk_update_4.5.0 2024-12-24 09:59:33 -07:00
c27ca94660 Update Kokkos library in LAMMPS to v4.5.1 2024-12-24 09:58:51 -07:00
fbba20fa89 validate that a non-temperature compute has not been replaced without fix_modify 2024-12-23 20:24:24 -05:00
aecbc21123 Modified tableting sim parameters to reduce runtime 2024-12-22 18:04:33 -05:00
39efb67a7a removed 14 particle MPFEM and 20,000 tabeleting simulation 2024-12-22 17:43:38 -05:00
ecb0f9525b Clarifying contact penalty logic, minimizing use of std 2024-12-22 11:13:04 -07:00
6abbdfd740 minimize pair lookups, reducing indentation level, more misc clean ups 2024-12-22 08:00:45 -07:00
af4a731ef2 Update variable.rst documentation 2024-12-21 11:16:01 -08:00
78aee50de8 small cosmetic changes, simplify d2/d3 examples, and create consistent logs 2024-12-20 18:49:55 -05:00
8c6a1f01f5 Misc cleanups to MDR normal submod 2024-12-20 16:49:43 -07:00
1896244d96 Adding reference to deform/pressure in barostat howto 2024-12-19 15:15:39 -07:00
822f774fd0 Minor style clean ups 2024-12-19 11:50:57 -07:00
1717840c3f Fixing deconstructors 2024-12-19 11:38:22 -07:00
399f81cf46 Code by Aidan Thompson, I am only committing it; fixing the cyclical include that broke the build process after merging develop
Co-authored-by: Aidan Thompson <athomps@sandia.gov>
2024-12-19 19:20:41 +01:00
210f7d7225 check that the internal pressure compute has not been manually replaced with a non-pressure compute without using fix_modify 2024-12-19 12:08:21 -05:00
095d33dafb Added examples and references to the docs 2024-12-19 18:06:54 +01:00
1f61c9ba82 I forgot to include a change in merging develop that seems to be very important 2024-12-19 17:39:02 +01:00
824dcda382 Fixed two style issues in the docs, got rid of printf that's also deleted on develop 2024-12-19 17:22:36 +01:00
5f3ea61080 Merge branch 'develop' into mala 2024-12-19 17:16:05 +01:00
f06c4daee0 make format style variable tests unambiguous for rounding issues 2024-12-19 11:09:36 -05:00
aadc87279d Merge branch 'fix-doc-gpu-typo' of https://github.com/DanielYang59/lammps into collected-small-changes 2024-12-19 08:35:47 -05:00
74cf599778 work around bug in FindVTK.cmake shipped with VTK 9.1 (and possibly other versions) 2024-12-19 08:32:34 -05:00
bf10fcd2f5 fix GPU build typo 2024-12-19 21:17:01 +08:00
bff2e64bbc Docs and example updates by Aidan Thompson
I did NOT author this commit, I am only pushing it because for some reason, Github does not permit Aidan to do so

Co-authored-by: Aidan Thompson <athomps@sandia.gov>
2024-12-19 10:06:53 +01:00
82b0687a15 More robust dvector handling 2024-12-18 21:10:46 -07:00
844d3a6cab Minimizing changes to pair granular 2024-12-18 17:44:12 -07:00
3b21f69d70 Merge branch 'develop' into kk_bug_fixes 2024-12-18 16:02:14 -07:00
8cf03b0b1c Fix memory corruption in comm_tiled_kokkos 2024-12-18 15:59:42 -07:00
d764c367c7 Reorganizing MDR fix 2024-12-18 13:41:58 -07:00
ab6e3f6015 Combining fixes 2024-12-18 12:58:37 -07:00
b4a6be2623 more spelling and formatting 2024-12-18 05:24:16 -05:00
089e45375f small doc corrections and formatting fixes 2024-12-18 04:54:33 -05:00
3311e71a82 Merge branch 'develop' into develop 2024-12-17 20:27:13 -08:00
7cd6c49a0d added line linking example script 2024-12-17 20:26:12 -08:00
4b1a8d1a78 uncommented output line 2024-12-17 20:06:04 -08:00
03fff14922 example name suffix removed 2024-12-17 20:02:38 -08:00
6505a9052b make format style variable tests unambiguous for rounding issues 2024-12-17 21:48:34 -05:00
6fdc67e2a8 Merge remote-tracking branch 'github/develop' into pair_d3 2024-12-17 21:22:39 -05:00
e288163ea4 Merge branch 'develop' into pair_d3 2024-12-17 21:22:05 -05:00
a47503fd8b complete previous commit 2024-12-17 21:18:10 -05:00
cac3bdd175 move two more parameter arrays to header and make them static constexpr 2024-12-17 21:09:04 -05:00
7921aeda9e convert defines and arrays on the stack with static constexpr local arrays 2024-12-17 20:56:35 -05:00
61734a414c Remove unused includes 2024-12-17 18:40:48 -07:00
1ba8ec4a0a fixed adhesion in elastic limit by updating amax assignment 2024-12-17 18:56:59 -05:00
3c026df75d formatting docs 2024-12-17 14:36:59 -07:00
2c9ad698ca doc updates 2024-12-17 14:36:41 -07:00
3d29991947 fix async IO bug 2024-12-17 14:22:45 -07:00
aeb2190582 Merge pull request #4404 from abkein/experimental
Marked multitype's default constructor as noexcept
2024-12-17 15:22:33 -05:00
67a8120c44 Merge pull request #4403 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-12-17 15:17:28 -05:00
5e16a21d9e lower epsilon one more time 2024-12-17 13:53:35 -05:00
1e0a3f4601 lower epsilon for macOS 2024-12-17 12:15:38 -05:00
9732efa32c fix whitespace 2024-12-17 08:31:29 -08:00
6fe5f373d9 cleaned up remaining comments in pair_granular 2024-12-17 11:24:32 -05:00
a7ba185a4c cleaned up comments 2024-12-17 11:18:26 -05:00
faab36cbd0 Merge branch 'develop' into collected-small-changes 2024-12-17 10:39:55 -05:00
fe77596099 cosmetic 2024-12-17 10:39:24 -05:00
4bdf6b0e2e make consistent 2024-12-17 10:39:18 -05:00
8ee83bc926 Merge pull request #4391 from weinbe2/feature/snap-unify-codepaths
SNAP/Kokkos CPU+GPU code unification and other optimizations
2024-12-16 23:09:16 -05:00
8daad30ae1 Re-enable Kokkos OpenMP and Serial code paths for SNAP 2024-12-16 11:07:47 -07:00
abd9f71990 remove whitespace from region_prism.cpp 2024-12-16 19:57:41 +02:00
baa5fa6dfd remove whitespace from region_prism.h 2024-12-16 19:55:27 +02:00
a7561d3d28 Update region.rst 2024-12-16 19:53:10 +02:00
96e53c4714 Actual implementation in region_prism.cpp 2024-12-16 19:48:00 +02:00
5625f5f3e8 Variable definition in region_prism.h 2024-12-16 19:43:48 +02:00
c6e9e90e15 refactor to mirror airebo/morse class structure 2024-12-16 09:37:21 -07:00
97f19d9d54 revert fix_ave_chunk changes 2024-12-15 17:19:16 -08:00
5ffbf3934b use safe version of Domain::minimum_image() for large image flag counts. 2024-12-15 18:20:38 -05:00
7922c923e2 Use MY_PI from math_const.h (for Windows) 2024-12-15 12:26:17 -08:00
5d865598ed Fix data file path for large avicel sim 2024-12-15 11:56:58 -08:00
64c06e9673 revert verlet.cpp change 2024-12-15 11:53:48 -08:00
a6d53d8d13 fix incorrect extvector setting bug for using fix vector with fixes 2024-12-14 23:11:48 -05:00
861b1fb16f small doxygen updates 2024-12-14 21:40:47 -05:00
afe0d94122 small fixes for the manual 2024-12-14 17:12:51 -05:00
c9d0ebadd9 address spelling issues 2024-12-14 17:10:22 -05:00
5fa4be4597 correct references 2024-12-14 17:09:50 -05:00
4c33bf663d whitespace 2024-12-14 16:58:58 -05:00
e48f288e2b result of "make fix-whitespace" 2024-12-14 13:20:16 -08:00
70c5722e9f flatpak updates 2024-12-14 09:44:57 -05:00
1cb12e3753 update appdata for flatpak builds 2024-12-14 08:22:09 -05:00
6124631a65 updated readme example list order 2024-12-13 21:18:10 -08:00
1188c38e73 updated docs example page 2024-12-13 21:15:24 -08:00
0c91880192 updated compute_temp_chunk doc 2024-12-13 21:10:37 -08:00
e3b991c27a Merge branch 'develop' of github.com:lammps/lammps into feature/snap-unify-codepaths 2024-12-13 15:47:30 -07:00
f557b7b0e5 Need to update define for HIP unified memory 2024-12-13 11:45:12 -08:00
4c347a719e Update docs for Kokkos v4.5.0 2024-12-13 09:48:16 -07:00
9e3f7e55ee Update build systems for Kokkos v4.5.0 2024-12-13 09:32:45 -07:00
7f68aeb6d5 Update Kokkos library in LAMMPS to v4.5.0 2024-12-13 09:23:03 -07:00
2c1447dec6 Fix more issues 2024-12-13 09:22:07 -07:00
16e0a7788a Now actually added the correct log 2024-12-13 09:51:07 +01:00
754aa1c73f python: doc and example updates 2024-12-12 23:27:07 -07:00
e45ef5adc0 unittest: add Python command_wrapper test 2024-12-12 23:27:07 -07:00
24a4ff78b6 python: update examples and docs 2024-12-12 23:27:07 -07:00
d50a62f827 example readme updated 2024-12-12 18:32:46 -08:00
5134529ee0 Merge branch 'develop' into experimental 2024-12-13 02:14:33 +03:00
1b29f3dc6e Fix another issue with gjf flag 2024-12-12 13:32:53 -08:00
3986ca4289 Fix more GPU data movement issues with fix langevin/kk and gjf option 2024-12-12 11:46:09 -08:00
077a229cc8 merge develop into angle-mwlc 2024-12-12 16:04:09 +08:00
8f25a31dee adapted angle_mwlc to work with units other than lj 2024-12-12 15:38:34 +08:00
483111b637 remove references to nonexisting input 2024-12-12 00:22:51 -05:00
3aeb64de89 rename pair style and fully integrate into build and manual 2024-12-11 15:33:39 -05:00
b4acfd1e3b updated summary, comments, and name 2024-12-10 21:47:30 -08:00
0674f43364 correct references 2024-12-10 23:49:24 -05:00
eba7dfad36 address spelling issues 2024-12-10 23:48:33 -05:00
91c0d599f6 add note about age of SPH package PDF add-on docs. 2024-12-10 23:00:30 -05:00
0fa1255cc3 fix python/invoke: ensure computes have run 2024-12-10 20:57:45 -07:00
9da58b3ffc python: deprecated pylammps interface 2024-12-10 20:47:22 -07:00
49938456a3 Merge branch 'lammps:develop' into develop 2024-12-10 17:45:18 -08:00
335069f1ca implemented d3 pair style 2024-12-10 17:25:39 +01:00
02db7be6e2 Merge branch 'develop' into collected-small-changes 2024-12-10 09:07:57 -05:00
a78aee5731 Merge pull request #4407 from jtclemm/small-patches
Bug fix for domain class, minor edits to other classes
2024-12-10 08:30:18 -05:00
e902d19e06 Merge pull request #4366 from jtclemm/rheo
Updates for RHEO package, including new optional comm features
2024-12-10 08:23:31 -05:00
6f4466f300 Marked multitype's default constructor as noexcept, b/c it is 2024-12-10 08:19:38 -05:00
f59f084c37 Added logs for examples 2024-12-10 10:39:57 +01:00
93e04e3177 Add missing syncs to fix_langevin_kokkos 2024-12-09 17:18:39 -07:00
1b7bc59e51 Clarifying BPM eq dist logic 2024-12-09 11:51:12 -07:00
90f121e02c Clarifying ambiguous remap comment 2024-12-09 11:34:53 -07:00
6de8c38a83 Fix compile issues 2024-12-09 11:16:19 -07:00
fdfe6d54c6 Clarifying break no alternate 2024-12-09 11:14:29 -07:00
2562d3afc4 Updating bpm pour example with break no 2024-12-09 11:11:06 -07:00
4c496df934 Simplifying behavior of bpm bonds without breakage 2024-12-09 11:04:27 -07:00
bcd123c882 Removing extra x-lambda conversion 2024-12-09 10:36:05 -07:00
00ebe9a3e8 Squashed version of Will's commits. 2024-12-09 08:31:57 -08:00
e21ed49695 improve error messages 2024-12-09 09:08:22 -05:00
f93dd3273d Added link to PRB paper 2024-12-09 14:08:22 +01:00
80acfeebe7 Added documentation 2024-12-09 14:04:47 +01:00
3c6f4374ee removed some id info 2024-12-06 22:37:28 -08:00
f0c176c603 vcm example script and log added 2024-12-06 21:42:23 -08:00
5f3ee3100a Marked multitype's default constructor as noexcept, b/c it is 2024-12-07 01:56:28 +03:00
828f5b9a77 avoid uninitialized data access 2024-12-06 15:31:00 -05:00
aaa8431919 add comment to sync this file with the corresponding page of the LAMMPS homepage 2024-12-06 11:40:11 -05:00
2eb3084a8c add "Original author" tag to Steve's name 2024-12-06 11:17:45 -05:00
30d39c8fb3 Fixed formatting issues 2024-12-06 09:37:09 +01:00
2279763c05 Clarifying definition of knd for hooke 2024-12-05 12:35:23 -07:00
ade5289030 Redefining stiffness in coeff rest moodel 2024-12-05 12:31:03 -07:00
2185ffa428 Renamed files to be more consistent with other examples 2024-12-05 16:43:18 +01:00
b146a1d59b Merge remote-tracking branch 'refs/remotes/origin/develop' into mala
# Conflicts:
#	src/KOKKOS/kokkos_type.h
2024-12-05 15:23:21 +01:00
dc3a100141 remove unused variables 2024-12-05 08:58:02 -05:00
c2b6ce5786 remove src/KOKKOS/group_kokkos.cpp 2024-12-04 18:02:44 -05:00
50df32f6fe Fix issues in KOKKOS package 2024-12-03 16:20:34 -08:00
296941ede7 Missed file, whitespace 2024-12-02 10:05:12 -07:00
a7cfd4b934 Merge branch 'develop' into rheo 2024-11-28 10:19:35 -07:00
cd16308d71 Merge pull request #4389 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-11-27 14:27:14 -05:00
6102350eed shorten 2024-11-27 12:10:56 -05:00
7c87874f5e improve expanded fix external docs 2024-11-27 01:55:11 -05:00
ef4b070e6f fix typo 2024-11-27 01:45:42 -05:00
e9073e4e1d Missed changes 2024-11-26 16:19:19 -07:00
09cd209c62 typo 2024-11-26 15:56:03 -07:00
8aba26bd71 doc fixes 2024-11-26 15:55:08 -07:00
6b4f82dc31 Resetting variables in deform/pressure init 2024-11-26 13:04:26 -07:00
a420d04418 Unifying desc/code for tsuji and coeff restitution 2024-11-26 11:28:40 -07:00
461dd67bb4 Clarifying Tsuji damping doc, removing overloaded variable 2024-11-26 10:37:13 -07:00
1beb4b17ec Clarifying doc on arguments for coeff rest damping 2024-11-26 10:15:26 -07:00
aeb9003890 bug fixes 2024-11-25 18:22:44 -07:00
6f36dcecc6 Merge branch 'develop' into imd-v3-integration 2024-11-25 16:26:56 -07:00
88807c6ae6 ml-pace: allow linking to existing pace library 2024-11-25 16:18:50 -07:00
f7915109f9 minor bug fixes 2024-11-25 15:22:02 -07:00
c87e0735a9 Merge branch 'develop' into feature/snap-unify-codepaths 2024-11-25 09:27:38 -08:00
3f78ee72c6 get access to the applied external force from the fix 2024-11-24 22:25:38 -05:00
471fdf27cd Typo in bond failure subscripts 2024-11-22 14:59:51 -07:00
e4683c3134 typo in equation 2024-11-22 14:40:45 -07:00
10c429fe21 Separating background pressure from EoS definition 2024-11-22 14:37:47 -07:00
e7c995abcb Re-disabled SNAP Kokkos CPU path =( 2024-11-22 11:28:25 -08:00
ce6e0dbe68 Added templating over chemsnap for evaluate_beta_scaled 2024-11-21 14:33:30 -08:00
261abaa683 Added templating over chemsnap for ComputeYi and ComputeYiWithZlist 2024-11-21 14:17:40 -08:00
28e64fca94 Added templating over chemsnap for ComputeZi and ComputeBi 2024-11-21 14:06:10 -08:00
67470f236e Added a (default zero) extra launch bound arg to help with ComputeYi perf consistency 2024-11-21 13:48:04 -08:00
6c333837e0 Merge branch 'develop' into collected-small-changes 2024-11-21 02:57:08 -05:00
43fbdc2d93 Merge pull request #4388 from lichanghao/dump_image_bug_fix
Fixed a indexing bug in dump_image.cpp causing segmentation fault with body style particles
2024-11-21 01:18:02 -05:00
f3221ee2e1 Abstracted computation portion of compute_bi into a separate evaluate_bi 2024-11-20 11:10:13 -08:00
dde2c91a27 Refactored the beta calculation into separate linear and quadratic portions 2024-11-20 11:03:37 -08:00
78bd71760b Added a host vs device abstraction for SNAP kernel launches, greatly improves CPU launch perf 2024-11-20 10:53:33 -08:00
2d65365a67 Added additional parallelism to TagPairSNAPBeta 2024-11-20 10:42:43 -08:00
e8e2a0b012 Simplified the constuctor for SNAKokkos by passing PairSNAPKokkos in directly by reference 2024-11-20 10:36:01 -08:00
5dcadf5748 Created a simplifying abstraction to separately call host or device kernels where the code is identical 2024-11-20 10:29:02 -08:00
6e54d9326b Unify the CPU and GPU PreUi routines 2024-11-20 10:20:42 -08:00
98b67b8ea0 Unify the CPU and GPU ComputeYi and ComputeZi routines; extend ComputeYiWithZlist to the CPU 2024-11-20 10:13:11 -08:00
8a65f44237 Unify the CPU and GPU TransformUi routines 2024-11-20 09:58:50 -08:00
99c4d116b8 Flatten compute_ui_cpu and compute_duidrj_cpu into single functions 2024-11-20 09:48:20 -08:00
457e4c094b No actual changes; this code just rearranges sna_kokkos_impl to make the subsequent CPU/GPU unifications easier to follow. 2024-11-20 09:41:57 -08:00
30349d2a48 correct version header 2024-11-20 11:50:13 -05:00
7259082cbc flag development version 2024-11-20 11:17:14 -05:00
4296db4991 add link with more explanation to the illegal variable errors 2024-11-20 11:15:12 -05:00
8ba0d7bece more updates to release process 2024-11-20 10:21:00 -05:00
53b2930ef4 modified dump_image.cpp, line 1100, fixed an indexing bug causing rendering error 2024-11-19 23:50:50 -05:00
277fba1907 Removed unnecessary team parallelism from CPU routines; rearranged pair_snap_kokkos_impl to make the subsequent CPU/GPU unifications easier to follow. 2024-11-19 12:44:08 -08:00
976167e2e5 Greatly tightened up CPU ulist, dulist computation 2024-11-19 12:30:58 -08:00
cb548143ee Unified zlist and blist CPU and GPU structures; greatly simplified/fused compute_bi 2024-11-19 12:14:32 -08:00
cf6714ea33 Unified ulisttot CPU and GPU structures 2024-11-19 11:12:20 -08:00
abbcd86174 Unified ylist CPU and GPU structures 2024-11-19 11:03:01 -08:00
e6ed911be2 Merge pull request #4387 from akohlmey/next_release
Step version strings for next release
2024-11-19 14:02:02 -05:00
3c4a42ba72 Removed d_beta_pack; fully unified SNAPBeta and SNAPBetaCPU routines 2024-11-19 10:54:59 -08:00
2fc33f3fd4 Removed AoSoA from [ylist_re/ylist_im/zlist/blist] 2024-11-19 10:49:47 -08:00
120c4600cf Removed AoSoA from ulisttot_[re_/im_/]_pack 2024-11-19 10:44:30 -08:00
e95d1dec3f Removed AoSoA from a/b/da/db/sfac pack 2024-11-19 10:35:58 -08:00
c9754e5fd3 Added const to each of the snaKK routines; removed extra snaKK copies 2024-11-19 10:24:27 -08:00
e200d557ec replace static with const for compatibility with SYCL 2024-11-19 13:16:22 -05:00
58d70366c2 Added padding to non-AoSoA data structures to improve alignment 2024-11-19 10:12:47 -08:00
ce92b565b2 Made SNAP host_flag constexpr, took advantage of if constexpr to reduce compile time 2024-11-19 10:00:56 -08:00
a4d821197e Re-enable SNAP CPU codepaths to simplify verifying correctness 2024-11-19 08:56:36 -08:00
c50a8d83d1 New release date 19 November 2024 2024-11-19 02:13:54 -05:00
c926bfd156 start documenting individual steps for a LAMMPS release 2024-11-19 02:05:49 -05:00
2ac0d065a7 step version strings for next release 2024-11-19 02:05:49 -05:00
cf05700897 Merge pull request #4382 from jtclemm/small-patches
Minor clean up to doc conventions and dev workflow files
2024-11-17 22:17:46 -05:00
48c27365ee Merge pull request #4383 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-11-17 22:15:36 -05:00
18329ac86a avoid memory leaks 2024-11-17 12:14:28 -05:00
a635f20b1b whitespace 2024-11-17 12:14:14 -05:00
07a8806fd0 fix typo 2024-11-17 12:14:07 -05:00
f7b87a21c7 apply special treatment for fix colvars/kk as suggested by @stanmoore1 2024-11-16 11:14:18 -05:00
b3f88da939 document KOKKOS restriction of fix spring/self 2024-11-15 15:22:19 -05:00
35f1fb9d6d check equal style variable evaluation for bad values 2024-11-15 15:12:56 -05:00
ec129f167e error out in fix spring/self/kk with variable spring constant 2024-11-15 14:33:25 -05:00
bca2c4d245 add missing initializers 2024-11-15 14:26:10 -05:00
72b649ec2b whitespace 2024-11-15 14:14:53 -05:00
4dd1448dd0 support providing spring constant as equal or atom style variable 2024-11-15 14:12:19 -05:00
ae1c5651ef accept qtpie/reaxff also for reaxff/omp 2024-11-15 13:27:28 -05:00
55f53f06ba use utils::open_potential for gaussian exponent file 2024-11-15 13:27:11 -05:00
70f41341c9 add unit test for qtpie/reaxff 2024-11-15 13:26:34 -05:00
cf5c42889d avoid dereferencing reaxff object when no reaxff pair style in use 2024-11-15 13:01:23 -05:00
9a096f295f update/correct code owners list 2024-11-15 11:06:38 -05:00
38d53877c5 move citeme call(s) to places where labelmaps are used 2024-11-15 11:01:19 -05:00
6796dc34ad clang-format 2024-11-15 10:42:30 -05:00
0f70c528a1 avoid access to uninitialized per-atom data to make valgrind happy 2024-11-15 10:42:21 -05:00
74fea8ae08 must initialize copymode in base class 2024-11-15 06:24:29 -05:00
0f9f80ad45 update for fix colvars/kk 2024-11-14 15:32:07 -05:00
e3e502f095 add note that pair_coeff settings used for fix adapt must be set explicitly 2024-11-14 15:26:46 -05:00
9c290a0fac Minor edits to workflow doc 2024-11-14 08:22:13 -05:00
c06cab2696 extra space 2024-11-14 08:22:13 -05:00
d8bd1ae3b8 adding hyperlink 2024-11-14 08:22:13 -05:00
a06275d18e Pesky backticks 2024-11-14 08:22:13 -05:00
4dbb5ade76 avoid crashes with 180 degree angles 2024-11-14 08:22:07 -05:00
e192c4d583 Minor edits to workflow doc 2024-11-13 09:11:22 -07:00
8dfb63206e extra space 2024-11-13 08:56:23 -07:00
0463434ff9 adding hyperlink 2024-11-13 08:55:25 -07:00
0f2fd8a882 Pesky backticks 2024-11-13 08:51:57 -07:00
5928389c5e Merge pull request #4312 from navlalli/qtpie
Add fix qtpie/reaxff
2024-11-13 07:42:07 -05:00
69526c87d8 Merge pull request #4362 from ndtrung81/regression-test-update
Improve the Kokkos regression test workflow
2024-11-12 18:06:48 -05:00
92f2a743ef Merge pull request #4375 from akohlmey/collected-small-changes
Collected small changes and updates
2024-11-12 17:55:25 -05:00
3aef5ed12f Merge pull request #4374 from ndtrung81/gpu-threebody-neigh-no
Fixed bug in the GPU package when three-body pair styles are used with pair hybrid
2024-11-12 17:31:11 -05:00
940308ba59 run CI 2024-11-12 14:38:41 -07:00
15999f6518 initial commit 2024-11-12 14:30:10 -07:00
1b65fb5a1a avoid memory leak 2024-11-12 15:05:57 -05:00
cfadf10021 Merge pull request #4296 from alphataubio/alphataubio-kokkos-fixes
Add KOKKOS versions of fixes
2024-11-12 15:00:52 -05:00
2d2bc029a4 Merge branch 'develop' into qtpie 2024-11-12 11:37:40 -08:00
5673375d21 Add more related commands to docs 2024-11-12 12:32:37 -07:00
ea873c5c06 Merge pull request #1 from gsalkuin/name-change
Name change etc
2024-11-12 11:56:41 -05:00
fc805f470c Small change to simplify code 2024-11-12 08:42:38 -08:00
2bcd6d1f73 Name change, add example 2024-11-12 11:40:07 -05:00
92d4bec1a3 Add files via upload 2024-11-12 11:13:43 -05:00
7fdfa3d3dd Merge branch 'alphataubio-kokkos-fixes' of github.com:alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-11-12 08:10:00 -08:00
3acb0243a7 Merge branch 'lammps:develop' into develop 2024-11-12 11:08:21 -05:00
cb5bad7ece Dropping obsolete keyword 2024-11-11 21:22:48 -07:00
ecfda6042d correct error message 2024-11-11 18:52:56 -05:00
33128323d8 Adding shift example to rheo doc, clarifying speed of sound exception 2024-11-11 16:31:09 -07:00
9e0047ff06 Documenting new multi-type shifting options 2024-11-11 15:50:01 -07:00
8521ff0587 Simplifying logic for shifting two types 2024-11-11 15:20:54 -07:00
8809ed067f oops 2024-11-11 15:11:02 -05:00
1b2781db9b add syncs 2024-11-11 14:57:45 -05:00
0e90de7d95 Updaing rheo citeme 2024-11-11 11:52:21 -07:00
15767903b2 testing new argument description for fix rheo 2024-11-11 11:51:59 -07:00
59af94b8e3 Updating rheo citation information 2024-11-11 11:42:50 -07:00
c0edafc0cf Reorganizing optional subargs for fix rheo 2024-11-11 11:31:16 -07:00
bd9bcb3bf7 adding missing rheo coordination flag 2024-11-10 14:27:22 -07:00
009a976ae2 Adding multitype correction to rheo vshfit 2024-11-09 21:47:38 -07:00
a1a2a54f72 update linalg for ML-QUIP 2024-11-09 04:14:11 -05:00
324e795237 do not free a NULL communicator 2024-11-08 20:59:41 -05:00
fb758d951f synchronize neb/spin with bugfixes for neb 2024-11-08 20:59:24 -05:00
a8eb5fab14 Merge branch 'alphataubio-kokkos-fixes' of github.com:alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-11-08 15:04:50 -08:00
ab9a870065 Merge branch 'develop' into alphataubio-kokkos-fixes 2024-11-08 18:03:28 -05:00
aeca973f84 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-11-08 18:01:54 -05:00
b830f7806e Update fix_colvars_kokkos.cpp 2024-11-08 18:01:50 -05:00
f84b9f350e Merge branch 'develop' of https://github.com/lammps/lammps into alphataubio-kokkos-fixes 2024-11-08 14:53:37 -08:00
339c9654de Update GNU Make for new file 2024-11-08 14:42:59 -08:00
0ad6babead Fix another (already existing) bug when a proc has no atoms 2024-11-08 08:42:47 -08:00
a445545ffb Merge pull request #4371 from evoyiatzis/patch-2
fix typo in compute_temp_partial.rst
2024-11-08 09:30:26 -07:00
8f9e14c14f Merge branch 'develop' into gpu-threebody-neigh-no 2024-11-08 09:22:46 -06:00
9d80d963ed Merge pull request #4370 from jtclemm/small-patches
Fixing potential segfaults in granular/nstencil classes and other minor clean ups
2024-11-08 06:05:49 -05:00
e84c45c6e7 Fix whitespace 2024-11-08 10:38:49 +00:00
95899b53b8 Add fix qtpie/reaxff to pair_style reaxff docs 2024-11-08 10:26:47 +00:00
1c48d201b4 Remove unused pack_flag = 5 options 2024-11-08 10:07:16 +00:00
45ea55c06a Removing debug statements 2024-11-07 14:28:57 -07:00
6765c3b126 Relaxing errors in bond bpm, reusing update special for hybrid 2024-11-07 14:27:44 -07:00
b74096b2c4 Fix bug when a proc has no atoms/neighbors (existing issue) 2024-11-07 09:35:49 -08:00
572be91b76 fix typo in compute_temp_partial.rst 2024-11-06 11:27:45 +01:00
a93a930f2f Updating developer comm doc page to include bond and optional args 2024-11-05 15:53:48 -07:00
95509c4ef0 Referencing other methods compatible with BPM package 2024-11-05 15:47:59 -07:00
a832a4a1c9 fixed a bug with three_ilist when used with pair hybrid 2024-11-05 16:38:06 -06:00
755e71e5a2 Missing space between words 2024-11-04 16:09:10 -07:00
34113226ae Updating pair tracker example 2024-11-04 13:57:54 -07:00
5ce635757f Simplifying smoothing for bpm/rotational bond style 2024-11-04 13:42:09 -07:00
778693c300 Minor clean ups to BPM bonds 2024-11-04 13:31:51 -07:00
645d02d13b sph typo 2024-11-04 13:30:37 -07:00
3b3d39a8cd Minor granular include clean up 2024-11-04 13:29:32 -07:00
3e531b9842 Adding clarifying comment 2024-11-04 13:24:27 -07:00
bf888045d6 Fixing memory seg fault w/ multi occasional nlist 2024-11-04 13:16:07 -07:00
d2f761f8ed Avoiding potential segfault with granular rolling model 2024-11-04 12:42:04 -07:00
10767b1247 Merge branch 'develop' into small-patches 2024-11-04 12:37:57 -07:00
953762458c EMPTY_MASK 2024-11-02 16:36:50 -04:00
1f1491a71c Update fix_colvars_kokkos.cpp 2024-11-02 14:52:01 -04:00
03487707ae atomics 2024-11-02 14:24:36 -04:00
ecebf18791 wrap host functions with sync/modify for kokkos 2024-11-02 13:39:23 -04:00
7eccc56607 auto variables for lambda capture 2024-11-01 19:42:16 -04:00
c1ac0cea1d More rheo pressure EOS, allow variable cs 2024-11-01 17:04:32 -06:00
f483a90d8a Simplifying RHEO compute comm calls 2024-11-01 15:04:30 -06:00
14041bb20c Missing argument 2024-10-31 15:56:45 -06:00
a15a315341 Missing variable declaration 2024-10-31 15:38:54 -06:00
df882a9552 Adding optional size arg for forward/reverse comm methods to Kokkos 2024-10-31 15:27:22 -06:00
8695351e24 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-30 21:59:05 -04:00
22d08cbac0 whitespace 2024-10-30 21:58:50 -04:00
c057b36c15 Merge branch 'develop' into alphataubio-kokkos-fixes 2024-10-30 21:50:36 -04:00
9aa9e7079a cleanup 2024-10-30 21:44:27 -04:00
84e234921b fix cuda warning 2024-10-30 21:36:18 -04:00
41672f6ac9 this might work on cuda 2024-10-30 20:44:25 -04:00
5efd8ba11e run the Kokkos regression workflow after merge, not every push 2024-10-30 11:27:15 -05:00
50dd95e6e1 move d_ubuf to kokkos_type.h
https://matsci.org/t/a-few-kokkos-development-questions/56598/8 (Q11)
"More correct would be to use a union with ubuf as is done in the atom_vec styles, so that no precision is lost for converting a huge 64-bit integer to a double."
2024-10-30 11:32:24 -04:00
3fd4f9b7f3 Minor clean ups to BPM bonds 2024-10-30 08:56:07 -06:00
9e25c8610c Merge branch 'develop' into rheo 2024-10-30 08:24:54 -06:00
e1f14e1ee8 unifying comm for/rev method args 2024-10-30 08:02:35 -06:00
acebce0431 turn off verbose, reduce timeout 2024-10-29 23:07:35 -05:00
47e9a7fe79 Typo + style changes in rheo doc 2024-10-29 21:03:47 -06:00
6d634dc646 Merge pull request #4359 from jtclemm/BPM
Adding new force options to BPM package
2024-10-29 21:31:03 -04:00
0e1137aee7 add inertia() 2024-10-29 18:34:30 -04:00
08e460ece6 Update fix_cmap_kokkos.cpp 2024-10-29 14:09:48 -04:00
ae4cb00402 Update fix_cmap_kokkos.cpp 2024-10-29 14:09:11 -04:00
c17e2cd30d Update fix_cmap_kokkos.cpp 2024-10-29 13:58:13 -04:00
452ae4621d Update fix_cmap_kokkos.cpp 2024-10-29 13:29:48 -04:00
4941cf25c0 typo 2024-10-29 12:59:09 -04:00
586f2b626d Update fix_cmap_kokkos.cpp 2024-10-29 11:13:36 -04:00
a6ad1a837c Update fix_cmap_kokkos.cpp 2024-10-28 18:55:59 -04:00
97c6b063a7 Update fix_cmap_kokkos.cpp 2024-10-28 18:41:04 -04:00
7ffe6aefce Update fix_cmap_kokkos.cpp 2024-10-28 18:37:21 -04:00
e4a9b06320 Update fix_cmap_kokkos.cpp 2024-10-28 17:47:57 -04:00
c00700dec7 cuda sync 2024-10-28 15:30:14 -04:00
ef1148dfa0 remove write_data support from BPM bond styles again and consolidate names 2024-10-27 22:06:56 -04:00
b946e998b5 also split fix into 2 lists, using 6 jobs for the matrix strategy 2024-10-27 12:13:29 -05:00
dd0dfd3c7f split randomly the pair input list by batch size 2024-10-27 00:00:10 -05:00
67d1c7d17d set OMP_PROC_BIND=false and adjust timeout 2024-10-26 09:01:39 -05:00
b725c01c0d split pair list into 2 separate lists and use 5 jobs for more even time balancing 2024-10-25 23:22:25 -05:00
12f0eff7a6 make group kokkos aware 2024-10-25 20:06:13 -04:00
71bbc52feb recommit changes from @stanmoore1 2024-10-25 20:03:45 -04:00
ea7fd079ce add vcm() and angmom() 2024-10-25 19:14:20 -04:00
e91b5dce78 fix typos 2024-10-25 18:52:50 -04:00
e0c3022ec3 printf debugging 2024-10-25 14:55:51 -04:00
6d0e633edf Merge pull request #4352 from ndtrung81/regression-test-update
Add a KOKKOS workflow for GitHub actions and minor updates for the regression tester
2024-10-25 11:06:33 -04:00
a5ab8be0a2 Clarify restriction on periodic cell dimensions 2024-10-25 14:16:25 +01:00
cfb8b25c6e fix grammar 2024-10-24 13:33:42 -04:00
e1a129fbf2 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-24 12:20:14 -04:00
ce830fcdbd Update fix_cmap_kokkos.cpp 2024-10-24 12:20:02 -04:00
56ac4aeedf Merge branch 'develop' into alphataubio-kokkos-fixes 2024-10-24 12:12:12 -04:00
00ff895c0d Update fix_cmap_kokkos.cpp 2024-10-24 12:11:12 -04:00
e04be85b7e Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-24 12:07:42 -04:00
4a64b3d9ce add d_exchange_sendlist to pack_exchange_kokkos() 2024-10-24 12:04:41 -04:00
f18850397d whitespace 2024-10-24 09:43:36 -06:00
f09a9c1c2a fix typo in cmake command 2024-10-24 10:26:18 -05:00
25eaf38cee use the kokkos-openmp preset for brevity 2024-10-24 10:18:59 -05:00
a844959a07 Combine into a single -Xcudafe flag to simplify everything 2024-10-23 23:00:17 -06:00
3041443e5f Merge pull request #4357 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-10-23 23:25:26 -04:00
73c049459b spelling 2024-10-23 21:10:34 -04:00
fdd2fc4f5d move error check to Compute::init() so they cannot be bypassed by input commands 2024-10-23 21:08:07 -04:00
b682f52d11 fix typos 2024-10-23 21:07:39 -04:00
f207a571f3 allow fix DUMMY to be added without a box 2024-10-23 21:00:33 -04:00
40e5d53345 Prevent deduplication of -Xcudafe flag 2024-10-23 15:53:56 -06:00
820fe1ee8a Fix compile issue with gcc 2024-10-23 12:18:20 -06:00
3bac6d7cde Adding bpm pair write data method, blocking unreadable vol atom property in bond 2024-10-23 11:56:07 -06:00
b810053d02 document restrictions for bonded interactions 2024-10-23 12:35:50 -04:00
915f636d50 Update GNU Make for new files 2024-10-23 10:28:42 -06:00
ab961a006e Merge remote-tracking branch 'github/develop' into collected-small-changes 2024-10-23 12:25:22 -04:00
558b1c5197 apply clang-format, fix other minor formatting issues, use error->one() 2024-10-23 12:10:28 -04:00
077c77f402 contributions from bonded interactions is broken when running in parallel
see https://matsci.org/t/missing-bond-contributions-from-compute-stress-mop/58455
for details.
2024-10-23 12:09:35 -04:00
46c365f75c Merge branch 'develop' of github.com:lammps/lammps into alphataubio-kokkos-fixes 2024-10-23 09:32:27 -06:00
d2b1e22b4a added counter for timeout tests 2024-10-22 23:31:22 -05:00
06207fd91e modify how execute() returns 2024-10-22 23:21:37 -05:00
8e81ac8c42 Merge branch 'develop' into BPM 2024-10-22 22:21:57 -04:00
bef64fd602 use consistent fix id and create bond history fix only when required 2024-10-22 22:21:28 -04:00
53b1ba6131 rename id_fix to id_fix_prop_bond for consistency, fix bug when deleting/replacing fixes 2024-10-22 21:56:19 -04:00
e2214fc4d6 Merge branch 'develop' into regression-test-update 2024-10-22 21:10:22 -04:00
e214f60d4f Merge pull request #4358 from junghans/cmake_voro_rename
cmake: voro target to upstream name
2024-10-22 21:07:28 -04:00
81f71716ba Merge branch 'develop' into BPM 2024-10-22 20:59:12 -04:00
a5599f2b75 implement write_data(), delete created internal fix in destructor, formatting 2024-10-22 20:59:00 -04:00
1ec7ba547d Merge branch 'develop' into alphataubio-kokkos-fixes 2024-10-22 14:47:19 -04:00
22a15c7cf8 cuda bugfix again 2024-10-22 14:15:02 -04:00
5bdd616bcd cuda bugfix 2024-10-22 12:42:49 -04:00
83db9b8fe6 small cleanup and modernization 2024-10-22 10:25:22 -04:00
ec5dfcd0fb remove note that was obsoleted 5 years ago 2024-10-22 09:50:30 -04:00
1678e2af28 adjusting howto text to reflect additional BPM/spring options. 2024-10-21 21:21:15 -06:00
e8c5e58ab9 Adding clarifying comments 2024-10-21 16:25:38 -06:00
c8bbfc368a Initializing dvol array in bpm/spring 2024-10-21 16:23:35 -06:00
58ff8d3212 Suppressing dump output in bpm examples 2024-10-21 15:18:17 -06:00
4779cc44ef documenting bpm anharmonic 2024-10-21 15:07:24 -06:00
baf1733b9a documenting bpm multibody 2024-10-21 15:07:06 -06:00
722133b60c typo 2024-10-21 15:06:33 -06:00
289845b187 Adding anharmonic term to bpm/spring pair 2024-10-21 15:06:21 -06:00
a302bfed5a Adding multibody term to bpm/spring 2024-10-21 15:05:55 -06:00
05ee6bed3d Adding dividers for gran CoR model 2024-10-21 15:02:52 -06:00
5c07882a18 fix warning(s) 2024-10-20 18:30:19 -04:00
760d871b7a enabled and apply clang-format 2024-10-19 11:02:53 -04:00
34ab2f862a small tweaks 2024-10-18 22:09:25 -04:00
f128abe002 improve OPLS description 2024-10-18 21:51:43 -04:00
2074b0c400 add check to allow only valid swaps between hybrid sub-styles and document it 2024-10-18 21:49:55 -04:00
73eb7de7aa cmake: voro target to upstream name 2024-10-18 09:26:23 -06:00
86e18b8a24 fix copy-n-modify issue 2024-10-16 10:23:16 -04:00
2ce934fdb9 added section on OPLS-AA taken from https://matsci.org/t/issues-with-opls-force-field-for-ethylene-glycol-simulation/58296/11 2024-10-16 10:05:26 -04:00
d5c5e164e1 Merge branch 'develop' into cmake-cpp-std-deprecation 2024-10-15 17:40:59 -04:00
74e449605a add warning to PyLammps that it will be removed soon 2024-10-15 14:48:30 -04:00
6c31dbf86f add more packages to the build 2024-10-15 13:38:02 -05:00
8503cac2ce update README to explain how to set nprocs in the config file 2024-10-14 23:44:02 -05:00
6e32470cfa distinguish the error tests vs failed tests 2024-10-14 23:27:06 -05:00
9abfe38120 Merge branch 'develop' into collected-small-changes 2024-10-14 22:54:22 -04:00
59bbc5bcc1 Merge pull request #4356 from evoyiatzis/patch-1
add extract() function to few angle and bond styles
2024-10-14 19:25:29 -04:00
a354ad8d64 add pair back to the matrix entries 2024-10-14 17:20:04 -05:00
c533ca0af1 handle the cases where num steps do not match with the reference log files 2024-10-14 16:05:21 -05:00
b9e4c6e1e7 re-enable matrix tests 2024-10-14 14:55:26 -05:00
eadb2f2eb1 fix the workflow file for not turning on quick 2024-10-14 11:23:08 -05:00
b0f2484441 fix logic bug with allowing quick_max to run without requiring quick to be True 2024-10-14 10:45:53 -05:00
3e7642bc8c fix artifact names, allow to run quick test with a given input list 2024-10-14 09:43:08 -05:00
38500c647b move cursor to end of log buffer before inserting new text 2024-10-14 09:41:45 -04:00
db3416c4b3 Apply corrections from code review by @simongravelle
Co-authored-by: Simon Gravelle <simon.gravelle@live.fr>
2024-10-14 08:19:53 -04:00
6478cd98e9 add extract() function to angle_mesocnt.cpp 2024-10-14 11:30:20 +02:00
1a6544a04c add extract() function to angle_mesocnt.h 2024-10-14 11:29:47 +02:00
74af88bafd unit test for extract() in angle-amoeba.yaml 2024-10-14 09:43:07 +02:00
0c61cb02cc add extract() function to angle_amoeba.cpp 2024-10-14 09:42:04 +02:00
292ca89cb0 add extract() function to angle_amoeba.h 2024-10-14 09:41:23 +02:00
383ae086e5 skip in.icos due to the minimize command 2024-10-13 22:54:54 -05:00
1e63f031f0 remove empirical filter to remove outliers from corrupted data 2024-10-13 22:52:40 -04:00
1c9daad657 change tutorial download URL to tutorial website 2024-10-13 21:57:17 -04:00
f7291713f5 error out when fix nve is used with additional arguments 2024-10-13 19:34:56 -04:00
8156e56617 be more paranoid about Sphinx updates breaking extensions we use 2024-10-13 19:31:40 -04:00
c15c4d23bb fix spelling/syntax issues 2024-10-13 19:30:30 -04:00
eafef460e2 silence compiler warning 2024-10-13 19:24:35 -04:00
b3b9d032fa cleanup, clarification and re-wrap of doc file sections 2024-10-13 18:56:41 -04:00
03d10e6bbc correct documentation to add "inputs local" to compute reduce commands on local data 2024-10-13 18:56:07 -04:00
4773b3e7e4 fix indentation in the config files 2024-10-13 15:48:29 -05:00
0d894c33c4 adjust the workflow files and config file 2024-10-13 11:52:10 -05:00
c735dc7d53 skip in.min.box, ensure that input lists only contain unique entries 2024-10-13 08:21:00 -05:00
3e64966800 filter out examples/fire 2024-10-12 23:53:35 -05:00
0ae0afbae9 Merge branch 'develop' into cmake-cpp-std-deprecation 2024-10-12 20:11:28 -04:00
f8a8783044 Merge branch 'develop' into alphataubio-kokkos-fixes 2024-10-12 20:09:59 -04:00
f8db5ce2ea Merge pull request #4349 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-10-12 20:07:33 -04:00
1ac351c84e unit test for extract() in angle-cross.yaml 2024-10-12 15:19:08 +02:00
7cc5f1923d add extract() function to angle_cross.cpp 2024-10-12 15:17:07 +02:00
02d74417c1 add extract() function to angle_cross.h 2024-10-12 15:16:34 +02:00
29e6ca0044 filter out input scripts for testing, remove concurrent (matrix) testing 2024-10-11 16:18:33 -05:00
b960cb213f revert to building with basic.cmake preset and manually include packages, refactor the get_kokkos_input script 2024-10-11 15:36:18 -05:00
e9ff0d3402 modify the kokkos workflow file 2024-10-11 14:42:45 -05:00
8f76fcdc54 Added a python script to get the example inputs that contain KOKKOS styles and generate the input lists for regression tests 2024-10-11 14:18:43 -05:00
f1a79e7df5 Update fix_adapt.rst 2024-10-11 19:55:28 +02:00
e3ab697dd2 unit test for extract() in angle-gaussian.yaml 2024-10-11 19:49:24 +02:00
ae652b31da unit test for extract() in bond-gaussian.yaml 2024-10-11 19:48:18 +02:00
df50691488 small correction and clarifications 2024-10-11 06:54:46 -04:00
6d30557ec2 Update partially fix_adapt.rst 2024-10-11 11:08:32 +02:00
391f55b377 unit test for extract() in bond-nonlinear.yaml 2024-10-11 11:02:55 +02:00
856fd9d977 unit test for extract() in bond-morse.yaml 2024-10-11 11:01:57 +02:00
8bc89ef8a7 unit test for extract() in bond-class2.yaml 2024-10-11 10:59:29 +02:00
c8241dcab6 unit test for extract() in angle-class2_p6.yaml 2024-10-11 10:58:32 +02:00
b619cce773 add extract() function to bond_gaussian.cpp 2024-10-11 10:54:56 +02:00
7da8434d5b add extract() function to bond_gaussian.h 2024-10-11 10:54:24 +02:00
732ef6bd44 add extract() function to angle_gaussian.cpp 2024-10-11 10:53:45 +02:00
44625312ea add extract() function to angle_gaussian.h 2024-10-11 10:53:02 +02:00
4766ddbede Update bond_nonlinear.cpp 2024-10-11 10:52:21 +02:00
b5386d714e Update extract() function to bond_morse.cpp 2024-10-11 10:51:14 +02:00
87737c1a47 add extract() function to angle_cosine_buck6d.cpp 2024-10-11 10:49:45 +02:00
81ac3bbaf6 add extract() function to angle_cosine_buck6d.h 2024-10-11 10:49:13 +02:00
1db92ad34b add extract() function to angle_class2_p6.cpp 2024-10-11 10:48:19 +02:00
852c46ba0e add extract() function to angle_class2_p6.h 2024-10-11 10:47:30 +02:00
aeeacf0442 Update extract of bond_class2.cpp 2024-10-11 10:42:01 +02:00
5c82063376 Merge branch 'electrode' of github.com:robeme/lammps into collected-small-changes 2024-10-10 17:32:28 -04:00
9adf51f18e ignore python wheel build folder 2024-10-10 17:29:33 -04:00
49a850c8aa add cmake support for make-globbed-toc 2024-10-10 17:25:05 -04:00
7693e96828 change globbed toc script from bash to python 2024-10-10 17:24:23 -04:00
9835adcbfc allow use of Sphinx version 8.x as interface with breathe seems to have been updated 2024-10-10 13:36:53 -04:00
766ba94396 use script instead of globbing to avoid entering commands in multiple toctrees 2024-10-10 13:36:48 -04:00
d684f6eb9b Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-10 12:23:16 -04:00
bbafad145b fixed identation 2024-10-10 12:23:09 -04:00
505d519be2 Update affiliation for ELECTRODE in package details 2024-10-10 16:18:05 +02:00
393dbdc640 add missing constants to enumerators 2024-10-10 08:00:38 -04:00
56cc9d03bd skip tests that are unstable on GPU 2024-10-10 06:11:32 -04:00
df260b58dd Merge pull request #4353 from martok/cmake-win-shared
CMake: install shared libraries on Windows with correct target
2024-10-10 05:39:28 -04:00
948ee80169 potflag and phi are not used 2024-10-10 05:35:51 -04:00
482a6632e9 consolidate kspace communication enumerators in kspace.h 2024-10-10 05:35:01 -04:00
2935c17f78 avoid segfault in msm/dielectric 2024-10-10 05:19:32 -04:00
422ced4d82 silence compiler warnings 2024-10-09 20:55:00 -04:00
58989765f0 Install shared libraries on Windows with RUNTIME DESTINATION 2024-10-10 00:52:36 +02:00
a8c9b57b62 partial revert of refactoring that broke efield and setforce 2024-10-09 18:34:17 -04:00
a5b76410e1 cleanup 2024-10-09 18:32:54 -04:00
bc2267c9c8 Update fix_efield_kokkos.cpp 2024-10-09 18:32:38 -04:00
315ac762cc Update fix_setforce_kokkos.cpp 2024-10-09 18:32:32 -04:00
badb3eae5f add tests with region sphere 2024-10-09 18:06:24 -04:00
3b60ae43b3 fix nvcc option 2024-10-09 17:44:49 -04:00
79c9d69931 Update CMakeLists.txt 2024-10-09 17:26:30 -04:00
147cf7face -diag_suppress (single dash) 2024-10-09 17:22:35 -04:00
dd11385f6f all device function in headers to avoid device relocatable code with nvcc 2024-10-09 16:45:50 -04:00
b22797b752 refactor 2024-10-09 16:13:48 -04:00
fea0271d5a Update region_block_kokkos.cpp 2024-10-09 15:36:30 -04:00
2d94187606 sub3() and dot3() 2024-10-09 15:34:31 -04:00
e48d2f9a31 Update fix_wall_region_kokkos.cpp 2024-10-09 15:26:34 -04:00
08b0e8eab9 inside_face() 2024-10-09 15:19:05 -04:00
e4a92f96e1 match_kokkos() 2024-10-09 15:15:23 -04:00
b4b49f5dec point_on_line_segment() 2024-10-09 15:11:24 -04:00
1427ca1ff4 forward_transform() and find_closest_point() 2024-10-09 15:04:07 -04:00
0007e568fc KOKKOS_FUNCTION 2024-10-09 14:46:49 -04:00
ae0627b2f1 remove warning 2024-10-09 14:43:18 -04:00
5d90879f35 cleanup 2024-10-09 14:14:23 -04:00
bb5b8a1d34 functor templated on RegBlockKokkos and RegSphereKokkos 2024-10-09 13:50:17 -04:00
e6c9353ccf add missing dependency 2024-10-09 00:30:46 -04:00
bea76778bd silence compiler warning 2024-10-08 22:45:37 -04:00
80c8ecb7e7 Update fix_recenter_kokkos.cpp 2024-10-08 19:01:36 -04:00
1af3de1fad Update fix_recenter_kokkos.cpp 2024-10-08 18:59:17 -04:00
7d9bc3ea24 oops 2024-10-08 18:21:42 -04:00
64499bfcb2 _kokkos 2024-10-08 18:20:58 -04:00
183c99acc8 Update region_sphere_kokkos.h 2024-10-08 18:18:06 -04:00
f7afc63b53 Update region_block_kokkos.h 2024-10-08 18:18:03 -04:00
0f627059fc dynamic_cast 2024-10-08 18:14:06 -04:00
d13fb58311 surface_kokkos() 2024-10-08 17:55:03 -04:00
c84ed4189d Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2024-10-08 14:47:51 -04:00
b1928596ae should include <string> in utils.h 2024-10-08 14:47:11 -04:00
63a26b1770 add the missing log file using --gen-ref 2024-10-08 12:10:48 -05:00
63649979e3 revert the file names and the upload action step 2024-10-08 10:55:40 -05:00
0e3a6a7190 turned on verbose to check tolerances and also print that info out to the run.log file 2024-10-08 10:51:12 -05:00
e5ba430f5f re-enable KokkosOpenMP test 2024-10-07 20:07:09 -04:00
f19df37de3 Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2024-10-07 19:57:43 -04:00
f02b3aaf95 reset container with .clear() 2024-10-07 19:56:04 -04:00
a53840014c Update in.wall.sphere 2024-10-07 18:17:14 -04:00
4ed7528ddc add_contact() 2024-10-07 17:57:32 -04:00
e188b7d75f remove "tags: generated" 2024-10-07 17:56:59 -04:00
9d2e892c0e Update fix_wall_region_kokkos.cpp 2024-10-07 17:46:15 -04:00
900f472ea6 test logic to run with different nprocs than the ref files if nprocs is specified 2024-10-07 16:39:26 -05:00
5a7dd950fc Update region_sphere_kokkos.cpp 2024-10-07 17:28:45 -04:00
941b3dd566 add two examples for regression testing 2024-10-07 17:15:09 -04:00
b16ddfcdd4 add d_contact 2024-10-07 17:05:33 -04:00
74ac224dd9 Create fix-timestep-wall_region_sphere.yaml 2024-10-07 17:05:08 -04:00
e44d366d92 Update region.cpp 2024-10-07 17:04:28 -04:00
4492ecaf39 Update region_sphere.cpp 2024-10-07 17:04:21 -04:00
09a115cb89 add and switch to a workflow file dedicated for OpenMP backend for KOKKOS 2024-10-07 15:04:28 -05:00
0e1ee42b89 Update region_block_kokkos.cpp 2024-10-07 15:12:10 -04:00
177b04fb56 Update fix_wall_region_kokkos.cpp 2024-10-07 15:06:01 -04:00
ff66b42022 cleanup 2024-10-07 15:04:34 -04:00
af7f5a5b5e port surface() to KOKKOS 2024-10-07 15:03:13 -04:00
7b3762881e try with 4 procs 2024-10-07 13:14:35 -05:00
076bb056aa fixed leftover typos in the workflow file and the tester 2024-10-07 12:59:48 -05:00
e6118412b1 remove dead code in fix qeq/ctip 2024-10-07 13:56:04 -04:00
6a46fb034d Tweak comments 2024-10-07 11:11:12 -06:00
31f10f9675 add a workflow file for testing KOKKOS with the OpenMP backend 2024-10-07 12:04:29 -05:00
84c1492ce6 fix issues with invalid subfolders, with total walltime reference that may be zero, with the output of progress.yaml for easy parsing to dictionaries, modify config_kokkos.yaml for testing with the OpenMP backend 2024-10-07 12:01:59 -05:00
9aaab458e8 Change another shallow copy to alias 2024-10-07 10:54:28 -06:00
c44831ff90 Fix bug when Kokkos atom map is build on host using hash 2024-10-07 10:40:58 -06:00
8a176ac488 use MKL for FFTs and on Intel GPU 2024-10-06 15:09:06 -04:00
8c76600d47 anticipate change to C++ standard 2024-10-06 15:06:05 -04:00
a0990abb73 nout does not have to be a class member 2024-10-06 07:01:35 -04:00
e4c0457617 remove dead code 2024-10-06 06:55:38 -04:00
25dfb03386 apply clang-format 2024-10-06 00:25:53 -04:00
92deb5c8dc revert change that breaks backward compatibility 2024-10-05 23:15:50 -04:00
6295fa0b54 whitespace 2024-10-05 23:07:50 -04:00
7da8748e90 add region command to list of exceptions needing the accelerator include 2024-10-05 22:49:13 -04:00
bdf1a242da Merge branch 'develop' into alphataubio-kokkos-fixes 2024-10-05 22:34:01 -04:00
719a64d9dd apply clang-format 2024-10-05 22:25:07 -04:00
6ab0b2c249 use std::vector<>.data() to access underlying pointer 2024-10-05 21:58:47 -04:00
e142ad8dfa apply clang-format 2024-10-05 21:55:24 -04:00
45440abca4 consistently use std::vector<>.data() to access the underlying data pointer 2024-10-05 20:36:23 -04:00
bcb500894c compute_scalar() bugfix 2024-10-05 18:49:39 -04:00
af03836dfa Update fix_cmap.cpp 2024-10-05 17:03:50 -04:00
a8157fc68e relax epsilon for kokkos_omp to pass 2024-10-05 16:41:02 -04:00
0bc554a694 remove FIXME 2024-10-05 16:40:32 -04:00
1f61c42745 add GroupKokkos 2024-10-05 16:40:10 -04:00
58bea0691b oops 2024-10-05 13:55:33 -04:00
da659c5168 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-05 12:02:24 -04:00
2d261388c8 Update fix_wall_region.cpp 2024-10-05 12:02:00 -04:00
de8396ea55 Update fix_wall_region.h 2024-10-05 12:01:34 -04:00
84b50bfd26 Update region_sphere_kokkos.cpp 2024-10-05 11:59:50 -04:00
81f96d3ea3 Update fix_recenter_kokkos.h 2024-10-05 11:48:18 -04:00
03c3bfec3a Update fix_nve_limit_kokkos.cpp 2024-10-05 11:45:41 -04:00
95c18c5373 Update fix_cmap_kokkos.cpp 2024-10-05 11:44:57 -04:00
4da644958e IntelLLVM is not ABI compatible with generic BLAS libraries. Use linalg instead 2024-10-05 03:39:00 -04:00
c3c5370570 use std::vector.data() to access the underlying arrays 2024-10-05 03:38:25 -04:00
ca6e9abefa update a few more tests for IntelLLVM 2024-10-05 03:37:33 -04:00
e4dcdcd221 skip KokkosOpenMP tests when Kokkos includes GPU support 2024-10-05 03:05:04 -04:00
248070c4b8 use -fp-model precise for IntelLLVM to avoid miscompilation 2024-10-05 02:41:03 -04:00
cdd538e24e relax epsilon for IntelLLVM compiler 2024-10-05 02:41:03 -04:00
39f42d4c12 simplify 2024-10-05 01:56:31 -04:00
c468537030 correct access to raw vector data and use resize() instead of reserve() for better compatibility 2024-10-05 01:56:19 -04:00
01e9fb04b6 must use fabs() for floating point numbers 2024-10-05 01:55:17 -04:00
0cb64f8bf3 Merge branch 'develop' into collected-small-changes 2024-10-05 01:53:22 -04:00
a73baf81b1 update settings 2024-10-05 01:04:39 -04:00
166f0cb5ea print warning only when package selected 2024-10-05 01:04:26 -04:00
0ed18c1203 Merge branch 'develop' into cmake-cpp-std-deprecation 2024-10-04 21:41:11 -04:00
224468d946 Merge pull request #4346 from cjknight/lubricate_patch
features + bug fixes for granular simulations w/ Kokkos
2024-10-04 20:54:12 -04:00
70cbf051fe apply clang-format 2024-10-04 19:41:59 -04:00
47b918499f silence compiler warnings, remove dead code 2024-10-04 19:05:35 -04:00
7aade6e14c Merge branch 'develop' of github.com:lammps/lammps into alphataubio-kokkos-fixes 2024-10-04 16:24:43 -06:00
2c738669ff compute_temp_sphere does not modify positions 2024-10-04 16:16:02 -06:00
d29533447a silence compiler warnings, remove dead code 2024-10-04 18:09:06 -04:00
b494a486a1 cosmetic 2024-10-04 17:59:44 -04:00
5786914b67 Merge branch 'lubricate_patch' of github.com:cjknight/lammps into lubricate_patch 2024-10-04 17:35:06 -04:00
27954609b8 Disallow newton on with full neigh list 2024-10-04 15:25:38 -06:00
aec43d0f00 Merge branch 'develop' into lubricate_patch 2024-10-04 17:09:27 -04:00
8874fd4cbf Merge branch 'develop' into cmake-cpp-std-deprecation 2024-10-04 16:03:01 -04:00
0a3d213ed9 turn hard requirement for CMake 3.20 into a warning for now 2024-10-04 16:02:53 -04:00
36dd4de3bc Merge pull request #4348 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-10-04 15:57:47 -04:00
8827dec5a9 Small refactor 2024-10-04 13:04:20 -06:00
0a6d25881b update documentation according to accelerated style include check 2024-10-04 13:54:04 -04:00
25afdcc325 add check for missing or unneeded accelerated style include 2024-10-04 13:52:12 -04:00
485cddf303 Update fix_wall_region.rst 2024-10-04 13:06:32 -04:00
921d9df574 Update fix_recenter.rst 2024-10-04 13:05:48 -04:00
d27026c364 Update fix_nve_limit.rst 2024-10-04 13:05:26 -04:00
39def85b48 Update fix_cmap.rst 2024-10-04 13:04:52 -04:00
9108168ea3 doc 2024-10-04 11:35:46 -05:00
b2e8648e6c enable deprecated APIs for HDF5 2024-10-04 12:32:09 -04:00
08266b65e4 doc 2024-10-04 15:45:16 +00:00
c4b4b7b874 suppress nvcc warnings with libfmt version 11.0.2 2024-10-04 11:33:33 -04:00
f7cf859670 doc 2024-10-04 15:32:47 +00:00
130548156d Merge branch 'develop' of github.com:lammps/lammps into alphataubio-kokkos-fixes 2024-10-04 09:30:33 -06:00
2ae4062a6b Merge pull request #4343 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-10-04 03:59:49 -04:00
01468e2720 Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2024-10-04 01:41:57 -04:00
6d8529f1f7 Merge branch 'develop' into collected-small-changes 2024-10-04 01:24:30 -04:00
1263a23e9c Merge pull request #4345 from akohlmey/update-fmtlib
Update embedded copy of libfmt to version 11.0.2
2024-10-04 01:22:51 -04:00
d1a1a57bd9 Merge pull request #4339 from jtclemm/small-patches
Fixing bugs in GRANULAR and mistakes in RHEO documentation
2024-10-03 22:01:21 -04:00
13ceebe82c fix recenter test skipped for respa 2024-10-03 18:45:52 -04:00
70dad28481 Update fix_recenter.cpp 2024-10-03 18:45:12 -04:00
1799f887d2 Update test_atom_styles.cpp 2024-10-03 18:36:39 -04:00
3776ff938d Need to use vflag_either instead of vflag_global 2024-10-03 16:36:05 -06:00
59db2e0af8 Update atom_vec_template.cpp 2024-10-03 18:35:28 -04:00
86fc79d2de Update fix-timestep-wall_lj93_const.yaml 2024-10-03 18:20:09 -04:00
6f068fc067 Update fix-timestep-wall_region_harmonic.yaml 2024-10-03 18:19:53 -04:00
bf12caf37a Update fix-timestep-wall_region_lj126.yaml 2024-10-03 18:18:02 -04:00
98ad09b0c9 Tighten up check even more 2024-10-03 16:17:39 -06:00
c059961b8f Update fix-timestep-wall_region_lj1043.yaml 2024-10-03 18:17:39 -04:00
d0f6f21c39 Use wrapper and remove sync to host 2024-10-03 16:17:06 -06:00
81db0a4a80 Update fix-timestep-wall_region_morse.yaml 2024-10-03 18:16:41 -04:00
a26c81d73b Revert changes to pair lubricate base class 2024-10-03 15:59:27 -06:00
e06be9b030 propagate new c++ standard handling from main CMakeLists.txt to plugin version 2024-10-03 15:39:33 -04:00
d6562b7514 fix-whitespace 2024-10-03 19:30:09 +00:00
0e10ed24fe fix compilation issue with MSVC++ 2024-10-03 15:19:56 -04:00
f25c530c04 recover compilation with MSVC++ 2024-10-03 14:56:28 -04:00
fbc6ba4ef4 import libfmt 11.0.1 2024-10-03 14:43:19 -04:00
4bf92cc846 update kokkos install to include brownian 2024-10-03 18:35:02 +00:00
3338433615 Merge remote-tracking branch 'upstream/develop' into develop 2024-10-03 12:06:22 -06:00
4ee07bcdaf Recreate dump file for MS-MEAM due to changes to the code. 2024-10-03 11:54:26 -06:00
2c2ce1b327 Update create_atoms.cpp 2024-10-03 13:15:13 -04:00
9ad3e59c8f Update test_atom_styles.cpp 2024-10-03 12:38:32 -04:00
5c8552f4ce Update atom_vec_template.cpp 2024-10-03 12:21:10 -04:00
a0f09a42bf remove lubricate/Simple ; not ready for primetime 2024-10-03 15:48:12 +00:00
0edf9d42b0 remove white space changes 2024-10-03 15:46:44 +00:00
5fe5fc0b10 remove old logic 2024-10-03 15:43:26 +00:00
3c5b4ebccb Delete charmm36.py 2024-10-03 11:43:08 -04:00
b7d529d945 remove white space changes 2024-10-03 15:41:43 +00:00
47e8093e07 remove white space changes 2024-10-03 15:41:10 +00:00
4b43f90bd6 revert changes requested by @akohlmey 2024-10-03 11:39:24 -04:00
8ef30fe05b remove white space changes 2024-10-03 15:39:09 +00:00
1d2ef17786 remove white space changes 2024-10-03 15:35:30 +00:00
28d02cf2ab remove _NO_RANDOM debug from brownian styles 2024-10-03 15:32:03 +00:00
131b40c806 Merge branch 'develop' into cmake-cpp-std-deprecation 2024-10-03 10:48:17 -04:00
b5fdd8f0ae Revert "update atom_style template test for added charge"
This reverts commit 3ea74b1725.
2024-10-03 10:26:24 -04:00
c4df843550 Merge branch 'develop' of https://github.com/lammps/lammps into lubricate 2024-10-03 14:13:23 +00:00
29eafa999b Update src/region_sphere.h
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-10-03 09:49:56 -04:00
9c06e8265f Update src/create_atoms.cpp
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-10-03 09:48:12 -04:00
a9dd61f62e detect C++23 standard 2024-10-03 07:38:44 -04:00
adebe773d0 bump check to C++23 and rename workflow file 2024-10-03 07:26:40 -04:00
299e0bafff revert deform refactor to only sync when needed 2024-10-03 05:38:20 +00:00
e4aedfda85 add test for C++20 compatibility 2024-10-02 21:56:15 -04:00
7e02951fc4 disable making functions in libfmt consteval with C++20 and beyond 2024-10-02 21:48:54 -04:00
0f8b825424 fix up spelling issues in CTIP 2024-10-02 19:43:43 -04:00
a3c23f2ce8 Cleaning up rheo kernels 2024-10-02 17:35:27 -06:00
a1bb42bd6e Merge remote-tracking branch 'github/develop' into collected-small-changes 2024-10-02 19:29:35 -04:00
8a7572fd5a Merge pull request #4181 from gplummer317/ctip
Charge Transfer Interatomic Potential (CTIP) pair style and qeq fix
2024-10-02 19:26:09 -04:00
cac22c216a update kk index entries 2024-10-02 14:37:03 -04:00
26aadc25ad Update fix_cmap.rst 2024-10-02 14:31:54 -04:00
26b83602be Update Commands_fix.rst 2024-10-02 13:56:21 -04:00
8a25871db5 Update region.rst 2024-10-02 13:45:59 -04:00
fff1456553 Update fix_wall_region.rst 2024-10-02 13:43:23 -04:00
89346740e1 Update fix_recenter.rst 2024-10-02 13:42:13 -04:00
a8acd9b573 Update fix_nve_limit.rst 2024-10-02 13:41:41 -04:00
75d3566a69 move brownian to KOKKOS directory 2024-10-02 15:35:33 +00:00
948faafa0e Merge branch 'develop' of https://www.github.com/lammps/lammps into lubricate 2024-10-02 15:27:39 +00:00
715a0c3d18 sync 2024-10-02 15:27:17 +00:00
e61d9f08ee regenerate fix wall/region tests 2024-10-01 13:00:59 -04:00
8332d89a4a regenerate fix recenter tests 2024-10-01 12:46:33 -04:00
384d8cf51f compute_vector() bugfix 2024-10-01 12:43:57 -04:00
e3768f9ab0 Limiting coordination calculation in RHEO 2024-10-01 10:01:12 -06:00
51e273affd punt drude too 2024-10-01 03:30:05 -04:00
e32a2fa71a punt again 2024-10-01 02:39:17 -04:00
e29b06095d remove whitespace 2024-10-01 02:36:22 -04:00
91fc94fc1e Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-10-01 02:31:56 -04:00
9330ccf6f9 punt to later 2024-10-01 02:30:01 -04:00
9daa1b715a Merge branch 'lammps:develop' into alphataubio-kokkos-fixes 2024-10-01 02:13:26 -04:00
9f33efc1b9 resolve conflict 2024-10-01 02:12:49 -04:00
53914162a7 rename log file to match expected naming scheme 2024-10-01 00:24:40 -04:00
5322b172bd Merge pull request #4331 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-10-01 00:22:11 -04:00
b12aeb79b0 Merge branch 'develop' into collected-small-changes 2024-09-30 22:10:14 -04:00
2749e091c7 update nemd example so it is reproducible 2024-09-30 22:10:00 -04:00
1dad5db38c remove ineffectual workflow changes 2024-09-30 21:46:16 -04:00
75f86a68a7 Merge pull request #4190 from alphataubio/kokkos-unit-testing
Improve Kokkos unit testing
2024-09-30 19:50:08 -04:00
c4b32f4b38 remove debugging lines, screen.* are inside the subfolders downloaded from the runs 2024-09-30 17:25:19 -05:00
4c91dcff3f list artifacts subfolders 2024-09-30 17:16:55 -05:00
29e995f137 keep debugging the artifacts downloaded 2024-09-30 17:09:28 -05:00
db4c6fbaaa restore changes from Kokkos upstream to support GFX1103 chips (Radeon 7xxM and 8xxM) with HIP 2024-09-30 17:59:40 -04:00
a5b94f0870 more debugging to list all files inside the artifacts folder 2024-09-30 16:46:34 -05:00
cb72f19595 temporarily put some debug lines in the workflow file 2024-09-30 16:25:24 -05:00
f5507c252d need to download the artifacts from cloud to the merge job 2024-09-30 16:10:09 -05:00
2fbfec0d11 use zipgrep for the merged zip artifact 2024-09-30 15:39:47 -05:00
97920f9fc3 try again with the github step summary 2024-09-30 15:15:30 -05:00
af2f9c06dc add #include "kokkos_few.h" 2024-09-30 15:51:37 -04:00
a199289e23 cuda bugfix 2024-09-30 15:47:06 -04:00
b25e370e63 some more fixes and rewording 2024-09-30 15:42:34 -04:00
a31f083bab update read_dump docs with respect to reading xyz style dump files 2024-09-30 14:54:35 -04:00
4cfc407605 Merge branch 'develop' of github.com:lammps/lammps into kokkos-unit-testing 2024-09-30 10:51:59 -06:00
ec392d5613 Remove failed attempts to create a job summary 2024-09-30 10:56:49 -04:00
3cefa5c9f1 try another approach for creating job summaries 2024-09-30 10:46:27 -04:00
d5f630db6c Fix sign used for atom-style potential
A positive sign in front of the electric potential is consistent with
E = -grad(electric potential).
2024-09-30 12:28:16 +01:00
d86de2862b Make signs consistent with efield = -grad(phi) 2024-09-30 12:10:33 +01:00
d33ecd6bbf reorder ctip style 2024-09-29 05:58:02 -06:00
622e3ed4d2 add notice after merge 2024-09-28 17:35:12 -04:00
2f53ea37e5 try printing GitHub job summary style 3 2024-09-28 13:31:56 -04:00
c16759ffc3 try printing GitHub job summary style 2 2024-09-28 13:24:41 -04:00
c1040ad9bb try printing GitHub job summary style 1 2024-09-28 13:13:43 -04:00
98834a3e27 fix cut-n-paste error 2024-09-27 20:06:27 -04:00
8b899d60fe Clarifying scoping for iterators in compute rheo/kernel 2024-09-27 15:32:54 -06:00
ba071fe55a Merge branch 'develop' into small-patches 2024-09-27 15:30:31 -06:00
c0d7b9975e avoid using std::shared_ptr. use new/delete for MPI rank 0 instead 2024-09-27 14:38:28 -04:00
65cacc7ef4 recreate log files for MS-MEAM due to changes to the code. 2024-09-27 14:29:05 -04:00
7276d5301b update unit test for change in MS-MEAM 2024-09-27 14:18:18 -04:00
51d104975a whitespace 2024-09-27 13:59:18 -04:00
0445936ac4 Added one-line change to make meam/ms correct for L12 lattice 2024-09-27 11:26:36 -06:00
7ccb7876f6 initialize *all* allocated iterms, even if we don't use them. 2024-09-27 12:40:39 -04:00
10e5f4270f Swapping srcmp to utils method
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-09-26 20:36:17 -06:00
13591dbdb0 Changing pour insertion note box 2024-09-26 20:02:47 -06:00
94f5f3cfa5 Fix compile issue with HIP 2024-09-26 15:25:32 -07:00
4436197081 PAdding possible note to fix pour doc 2024-09-26 16:14:57 -06:00
4035c3561e Merge branch 'develop' into collected-small-changes 2024-09-26 16:38:11 -04:00
ec2fece8db Merge pull request #4322 from stanmoore1/kk_update_4.4.0
Update Kokkos library in LAMMPS to v4.4.1
2024-09-26 16:29:31 -04:00
350551ecac Fix whitespace 2024-09-26 21:27:53 +01:00
5ee63d7afe documenting fix nonaffine/disp's incompatability with rerun 2024-09-26 13:06:32 -06:00
5d0f1aeeaf Expand documentation 2024-09-26 17:21:16 +01:00
d64be895e6 Allow for output of effective electronegativities 2024-09-26 16:42:01 +01:00
15e513958e clarification of min/max keywords in fix gcmc 2024-09-26 11:08:59 -04:00
ddaba91d12 Typo 2024-09-25 21:02:40 -06:00
c6fdd8ddb6 get rid of some non-ASCII characters 2024-09-25 22:01:42 -04:00
f30842ca11 first draft 2024-09-25 20:57:09 -04:00
e29e943ae6 apply clang-format 2024-09-25 18:48:47 -04:00
e44e462da6 remove redundant enum definition 2024-09-25 17:58:51 -04:00
725f6db5c1 skip no longer needed 2024-09-25 17:58:34 -04:00
e17e6e7a9d restore dihedral test 2024-09-25 17:58:22 -04:00
fee06d0d12 Merge branch 'develop' into kokkos-unit-testing 2024-09-25 17:52:59 -04:00
3a53b01ed9 Restricting options in fix wall/gran 2024-09-25 15:49:32 -06:00
2c2eb31362 Updating example logs affected by fix pour 2024-09-25 15:39:44 -06:00
149e92d1b9 Merge branch 'develop' into kokkos-unit-testing 2024-09-25 17:25:38 -04:00
7036930360 Patches to fix pour 2024-09-25 15:17:43 -06:00
385a0da892 update and correct description of running LAMMPS on Windows 2024-09-25 12:29:26 -04:00
17c5643d66 cosmetic 2024-09-25 11:59:30 -04:00
a420f1c42a Merge branch 'collected-small-changes' of github.com:akohlmey/lammps into collected-small-changes 2024-09-24 10:57:10 -04:00
bb0ead0ee3 fix cut-n-paste bug 2024-09-24 10:56:46 -04:00
d09ea909e5 Merge branch 'develop' of https://www.github.com/lammps/lammps into angle-mwlc 2024-09-24 10:34:32 +08:00
38e4df45ef mwlc angle documentation 2024-09-24 10:33:08 +08:00
9cd7d32a1c mwlc angle potential 2024-09-24 10:32:44 +08:00
80832ce763 Merge branch 'develop' of github.com:lammps/lammps into kk_update_4.4.0 2024-09-23 16:14:12 -06:00
7e31a4f482 Simplify view deallocation code 2024-09-23 16:14:06 -06:00
e95de835c0 Tweak build defaults 2024-09-23 15:38:29 -06:00
2e05cfeea9 Small code cleanup 2024-09-23 15:12:30 -06:00
2429c89eae Fix deadlock by always deallocating views of views in serial 2024-09-23 14:59:51 -06:00
e68851edae fix cut-n-modify issue 2024-09-23 14:54:54 -04:00
b9600c5a67 Merge remote-tracking branch 'github/develop' into collected-small-changes 2024-09-23 14:50:45 -04:00
d787ecdcb3 clarify docs for XYZ file format 2024-09-23 14:44:16 -04:00
cfe96064e8 Fixing errors in RHEO doc files 2024-09-23 12:39:16 -06:00
b95f7c2ab2 Merge pull request #4333 from evoyiatzis/patch-4
add extract() function to several angle styles
2024-09-23 14:27:47 -04:00
6f6e365682 unit test for extract() in angle-cosine_periodic.yaml 2024-09-22 20:24:26 +02:00
11aa128951 unit test for extract() in angle-fourier_simple.yaml 2024-09-22 20:23:32 +02:00
950bcba592 unit test for extract() in angle-fourier.yaml 2024-09-22 20:22:43 +02:00
8355d3796a unit test for extract() in angle-cosine_squared_restricted.yaml 2024-09-22 20:09:37 +02:00
662ea3a191 unit test for extract() in angle-quartic.yaml 2024-09-22 20:08:52 +02:00
517b4f4342 unit test for extract() in angle-dipole.yaml 2024-09-22 20:06:17 +02:00
d6d63b87d1 unit test for extract() in angle-class2.yaml 2024-09-22 20:05:32 +02:00
1287977bee unit test for extract() in angle-spica.yaml 2024-09-22 20:04:32 +02:00
cd4bada16f unit test for extract() in angle-charmm.yaml 2024-09-22 20:03:33 +02:00
25c9f5a6ff unit test for extract() in angle-mm3.yaml 2024-09-22 20:01:52 +02:00
96d99e3dd6 unit test for extract() in bond-fene_expand.yaml 2024-09-22 15:33:46 +02:00
0d6abcb86a unit test for extract() in bond-mm3.yaml 2024-09-22 15:31:01 +02:00
abb8b5ae45 reorder to avoid overflows 2024-09-22 00:11:03 -04:00
2a6fdfec02 improve error message and labelmap detection 2024-09-21 22:20:24 -04:00
12b67e0fd1 update ASPHERE/line example to follow conventions and avoid crashes. 2024-09-21 17:48:17 -04:00
061c80104a add docs to mention using a type labels for xyz files with string labels 2024-09-21 12:24:41 -04:00
d16d744550 enable and apply clang-format 2024-09-21 12:12:27 -04:00
29fce19c19 support typelabels for parsing xyz file with non-numeric types 2024-09-21 11:57:01 -04:00
8294bea7a7 Update angle section of fix_adapt.rst 2024-09-21 10:02:06 +02:00
5290779554 Merge branch 'develop' into collected-small-changes 2024-09-21 00:01:28 -04:00
3c8b846a66 Merge pull request #4330 from akohlmey/rheo-gsl-to-lapack
Convert RHEO package to use plain LAPACK instead of GSL
2024-09-21 00:00:13 -04:00
20f3b5a7db update readme 2024-09-20 21:44:52 -04:00
68548cbb0d Update angle_spica.cpp 2024-09-20 20:53:22 +02:00
d8c0691684 Update bond section of fix_adapt.rst 2024-09-20 19:55:07 +02:00
b2a2cefc02 add extract() function to bond_fene_expand.cpp 2024-09-20 19:38:58 +02:00
423b058820 add extract() function to bond_fene_expand.h 2024-09-20 19:38:22 +02:00
7f0ff96324 add extract() function to angle_class2.cpp 2024-09-20 19:37:12 +02:00
b49f3412df add extract() function to angle_class2.h 2024-09-20 19:36:35 +02:00
c5e62b4a47 add extract() function to angle_dipole.cpp 2024-09-20 19:35:46 +02:00
873030982d add extract() function to angle_dipole.h 2024-09-20 19:35:11 +02:00
3ce4c782d1 add extract() function to angle_spica.cpp 2024-09-20 19:34:16 +02:00
8e07149593 add extract() function to angle_spica.h 2024-09-20 19:33:41 +02:00
8a2564fff1 add extract() function to bond_mm3.cpp 2024-09-20 19:32:41 +02:00
4272d4a390 add extract() function to bond_mm3.h 2024-09-20 19:32:05 +02:00
83b2e88b73 add extract() function to angle_mm3.cpp 2024-09-20 19:31:20 +02:00
c65a6e8b59 add extract() function to angle_mm3.h 2024-09-20 19:30:42 +02:00
cc9f45af88 add extract() function to angle_cosine_squared_restricted.cpp 2024-09-20 19:29:34 +02:00
25f12bf800 add extract() function to angle_cosine_squared_restricted.h 2024-09-20 19:28:56 +02:00
f916a0cc63 add extract() function to angle_cosine_periodic.cpp 2024-09-20 19:27:58 +02:00
42f0940aee add extract() function to angle_cosine_periodic.h 2024-09-20 19:27:18 +02:00
7b37f1ae17 add extract() function to angle_fourier.cpp 2024-09-20 19:26:25 +02:00
bf9cb26afb add extract() function to angle_fourier.h 2024-09-20 19:25:49 +02:00
1e00249b73 add extract() function to angle_quartic.cpp 2024-09-20 19:25:04 +02:00
df533d97cb add extract() function to angle_quartic.h 2024-09-20 19:24:20 +02:00
3b73f56d79 add extract() function to angle_fourier_simple.cpp 2024-09-20 19:22:29 +02:00
9d1a0240d6 add extract() function to angle_fourier_simple.h 2024-09-20 19:21:32 +02:00
438a8c9335 add extract() function to angle_charmm.cpp 2024-09-20 19:19:47 +02:00
cc24f3d240 add extract() function to angle_charmm.h 2024-09-20 19:16:55 +02:00
958f2ae58b add tests for library interface and python 2024-09-20 03:57:12 -04:00
e35a00258e add lammps_expand() to swig interface file 2024-09-20 03:56:36 -04:00
3902215018 add lammps_expand to plugin wrapper 2024-09-20 03:56:19 -04:00
95afe40f55 add lammps_expand() to Fortran wrapper 2024-09-20 03:46:36 -04:00
3905cfd0a6 avoid memory leak 2024-09-20 00:58:40 -04:00
5e15eb6949 add lammps_expand() method and make available in python 2024-09-20 00:17:06 -04:00
a43a3a50e0 ELECTRODE is going CMake-only as well 2024-09-19 09:59:53 -04:00
11838801d6 add extract() function to angle style cosine/squared 2024-09-19 07:21:15 -04:00
6f10648d5f update unit test 2024-09-19 05:03:37 -04:00
586e6bb410 must run apt-get update before installing packages to avoid failures 2024-09-19 04:55:49 -04:00
b1eefe71c7 add extract() method to bond style harmonic/shift/cut 2024-09-19 04:53:04 -04:00
3d2a344dd5 we no longer need to install GSL for workflows with RHEO 2024-09-19 03:36:09 -04:00
d23b8aa17f try to work around macOS issue 2024-09-18 23:29:49 -04:00
4eb1b1f606 clarify docs 2024-09-18 23:14:27 -04:00
bf469b347e add missing override 2024-09-18 20:51:12 -04:00
42bcc43ece add missing line in Install.sh file 2024-09-18 20:22:17 -04:00
d909b205c7 update docs for building the RHEO package 2024-09-18 20:14:43 -04:00
1ac9f0801c update build support for using LAPACK with RHEO instead of GSL 2024-09-18 19:55:59 -04:00
b16b683cb4 replace calls to GSL with calls to LAPACK 2024-09-18 19:26:00 -04:00
9f867b5f54 add LAPACK functions for matrix inversion via Cholesky decomposition 2024-09-18 19:13:37 -04:00
7263bb49b6 deprecate ML-POD from using GNU make build 2024-09-18 16:38:16 -04:00
3d4a73a739 deprecate COMPRESS and VTK package from GNU build 2024-09-18 16:22:34 -04:00
906ae818da add package removal warnings and GNU make deprecation warnings 2024-09-18 15:43:56 -04:00
3bed50c1c3 Add text that we favor now CMake based builds 2024-09-18 15:18:41 -04:00
ce13d22656 enable and apply clang-format, modernize access to list of fixes 2024-09-18 11:33:03 -04:00
575c1014d4 bugfix in lammps-open.py unit test 2024-09-17 22:13:07 -06:00
3effab8024 Merge branch 'lammps:develop' into develop 2024-09-17 13:47:55 -04:00
ae80dba958 Remove even more whitespace 2024-09-17 13:02:26 -04:00
bf492c108b Remove more whitespace 2024-09-17 12:29:12 -04:00
2d86e6b4f0 Remove whitespace 2024-09-17 11:12:06 -04:00
e1f36275f1 Update fix-timestep-epot_lepton.yaml 2024-09-17 10:49:44 -04:00
995ccd494e Update fix-timestep-epot_lepton_region.yaml 2024-09-17 10:46:17 -04:00
805c2ae131 Merge pull request #4326 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-09-17 08:48:46 -04:00
6503f297d4 support angle style hybrid with fix adapt 2024-09-16 21:21:20 -04:00
47bb1a8748 update unit test 2024-09-16 21:04:22 -04:00
516d988deb update fix adapt docs 2024-09-16 20:59:04 -04:00
5d40a9640d add support for bond style hybrid to fix adapt 2024-09-16 20:49:44 -04:00
11365e7b2e add extract method to bond style harmonic/shift 2024-09-16 20:48:41 -04:00
804aa4ee85 improve error message 2024-09-16 20:38:50 -04:00
80cd9ace57 remove documentation check (for now) 2024-09-16 01:07:38 -04:00
4a9b7b1ba7 fix typo 2024-09-16 00:59:43 -04:00
f8eac87724 make programming style check and doc info check a github action 2024-09-16 00:56:09 -04:00
44d86c378b relax epsilon or mark unstable based on test results on non-x86 architectures 2024-09-16 00:34:28 -04:00
0db24828a5 first draft delete_atoms/kk 2024-09-15 12:20:12 -04:00
4d55c53c10 update rst kk 2024-09-14 21:01:06 -04:00
1f28ac4f54 oops 2024-09-14 20:50:30 -04:00
0db92ea135 auto variables for lambda capture 2024-09-14 20:48:20 -04:00
0a9137272d replace ubuf with static_cast 2024-09-14 20:33:40 -04:00
0921c8e087 pack/unpack on device 2024-09-14 19:51:43 -04:00
ae7fa643fd oops 2024-09-14 18:08:57 -04:00
94eed6e10a sort on device 2024-09-14 18:02:33 -04:00
78b2b7a024 explicit warning(s) exchange_comm_device=0 2024-09-14 17:29:56 -04:00
02b6fa088d explicit warning(s) which fix sort_device=0 2024-09-14 17:22:11 -04:00
f133b8a4a0 cleanup 2024-09-14 17:14:57 -04:00
813fd880cd tagged operators 2024-09-14 17:09:21 -04:00
63483b3fc2 KOKKOS_CLASS_LAMBDA 2024-09-14 16:09:56 -04:00
8dfc6207c2 fix warnings 2024-09-14 16:04:15 -04:00
2556788ed2 thanks @crtrott 2024-09-14 15:02:55 -04:00
8c4e67c10b add concurrency group feature to unit test workflows, too. 2024-09-14 06:07:07 -04:00
79fbd46bd9 try out concurrency group feature on quick regression as suggested by @junghans 2024-09-14 06:04:35 -04:00
1587473ab5 fix comparison for missing arguments when using wildcards 2024-09-14 05:11:51 -04:00
bdca275f10 correct indexing when filling lmp_firstneigh array 2024-09-14 02:25:03 -04:00
fe8611bfc8 sync author info with LAMMPS home page 2024-09-13 22:55:05 -04:00
0729c04dc1 document that GNU make build support is no longer required for new contributions 2024-09-13 22:38:20 -04:00
861be216a1 parallel_scan 2024-09-13 14:38:12 -04:00
5075c7cfa1 Update CMake 2024-09-13 12:16:58 -06:00
487f7ade68 Update Kokkos library in LAMMPS to v4.4.1 2024-09-13 12:14:49 -06:00
96c776c51f Add log files for qtpie/reaxff examples 2024-09-13 18:08:14 +01:00
3f232caf9b Fix whitespace 2024-09-13 17:13:59 +01:00
af6efcc514 Add fix qtpie/reaxff documentation 2024-09-13 16:43:13 +01:00
bd07f1e8e0 Change qeq to qtpie 2024-09-13 15:56:16 +01:00
8ec010f8ca Remove unused header file 2024-09-13 15:54:12 +01:00
d56f43b4e6 Remove unnecessary tests 2024-09-13 15:50:44 +01:00
62f82a7fe1 Remove additional fix name 2024-09-13 15:46:27 +01:00
3079d51eaf enforce that Pair::map is always initialized 2024-09-13 05:34:40 -04:00
97627bd77a fix indexing error 2024-09-13 05:34:15 -04:00
92bd9fc161 fix linking a URL and fix spelling 2024-09-13 02:20:26 -04:00
1adaab80aa make certain values for LAMMPS variables are initialized 2024-09-13 00:11:13 -04:00
f93281d868 Implement CMake upgrade and C++ standard deprecation as we did with C++11 2024-09-12 23:49:48 -04:00
2995cb76ae Merge pull request #4324 from rbberger/cmake_optional_docenv
Make CMake Doc build docenv optional
2024-09-12 17:57:45 -04:00
9339da075b Merge pull request #4299 from evoyiatzis/patch-3
Allow the definition of point in region plane using variables
2024-09-12 17:52:30 -04:00
36d73e8976 Merge branch 'kk_update_4.4.0' of https://github.com/stanmoore1/lammps into kk_update_4.4.0 2024-09-12 17:34:28 -04:00
5699e3c8cf add overridable settings 2024-09-12 17:34:12 -04:00
72024e90c9 Only check dynamic rank 2024-09-12 14:18:31 -06:00
d67d237386 Update author contributions 2024-09-12 19:41:12 +01:00
7b19228299 Make realloc_kokkos function safer, suggested in discussion with @weinbe2 2024-09-12 11:30:11 -06:00
0abcec1b22 Merge branch 'kk_update_4.4.0' of github.com:stanmoore1/lammps into kk_update_4.4.0 2024-09-12 10:50:45 -06:00
dc15e4ae81 Enforce options in CMake 2024-09-12 10:50:19 -06:00
18f1d32f8e Apply suggestions from code review
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-09-12 09:00:55 -06:00
58272bca00 move and update ctip example 2024-09-12 00:17:21 -04:00
5a12c762f3 Merge branch 'develop' into ctip 2024-09-11 23:36:16 -04:00
0ebd4f5ddb Make CMake Doc build docenv optional 2024-09-11 21:33:07 -06:00
9525dae7b9 Merge branch 'develop' into kk_update_4.4.0 2024-09-11 13:35:32 -04:00
fcbc37d5a4 Merge pull request #4321 from akohlmey/collected-small-fixes
Collected small changes and fixes
2024-09-11 13:07:02 -04:00
64db592a84 Update Kokkos version in CMake 2024-09-11 09:45:21 -06:00
cfcd7ddfbc Add KOKKOS_ENABLE_ATOMICS_BYPASS 2024-09-11 09:31:54 -06:00
a44955dd2e Update Kokkos library in LAMMPS to v4.4.0 2024-09-11 09:20:36 -06:00
e8184e63a5 create dummy output files to prevent test job failures 2024-09-11 09:15:05 -04:00
c3a62833c7 update 2024-09-11 06:54:06 -04:00
9f2bc30ba6 rename source files to be consistent with naming conventions 2024-09-11 06:46:51 -04:00
6b2a47d9c6 fix typo 2024-09-11 06:34:15 -04:00
4b7045d9ba Merge remote-tracking branch 'github/develop' into collected-small-fixes 2024-09-11 00:31:46 -04:00
16b19c71c1 Merge pull request #4207 from stanmoore1/kk_reaxff_overflow
Fix integer overflow for large QEq systems with KOKKOS package
2024-09-11 00:31:01 -04:00
0f4aedaf39 Merge pull request #4318 from weinbe2/bugfix/reaxff-bond-int-overflow
Fixes to ReaxFF/Kokkos integer overflow issues for bond tables + cleanup of unused compute
2024-09-11 00:30:25 -04:00
3308915a7b Merge remote-tracking branch 'github/develop' into collected-small-fixes 2024-09-11 00:11:43 -04:00
fde43d5079 Merge pull request #4143 from hagertnl/hagerty_issue4140_kokkos_collective
Implement kspace_modify collective yes in KOKKOS package
2024-09-11 00:07:10 -04:00
b74ef238c9 Merge branch 'develop' into collected-small-fixes 2024-09-10 23:32:37 -04:00
4a11b96635 update with upstream 2024-09-10 23:31:37 -04:00
94e3351e4f Merge pull request #4308 from lammps/quick-regression
Add a quick and full regression test as GitHub Actions
2024-09-10 23:28:49 -04:00
d76e10d2ca remove some more VLAs 2024-09-10 22:12:22 -04:00
ac5d2d560d remove redundant code 2024-09-10 21:49:21 -04:00
88ceae303f documentation integration and version tags 2024-09-10 21:41:20 -04:00
55fc12a5d1 add force style test 2024-09-10 21:31:27 -04:00
89f314fec2 Pair::single() is not supported 2024-09-10 21:31:14 -04:00
6b2dc5d3e8 make consistent 2024-09-10 21:23:20 -04:00
0ac23fddd3 avoid variable length arrays 2024-09-10 21:22:56 -04:00
a15c51a8c4 make reading of QEq parameters compatible with all QEq styles 2024-09-10 21:16:12 -04:00
2b1bef39e4 bring back changes from develop that were wiped out 2024-09-10 21:15:37 -04:00
6488fd2a48 reorganize example, potentials, logfiles 2024-09-10 21:14:52 -04:00
2b03a1ce17 move VLA arrays to header and initialize them only once 2024-09-10 20:31:58 -04:00
ddaba8a2c4 must not free memory that was obtained by extract() 2024-09-10 20:31:17 -04:00
1de74b46cd modernize 2024-09-10 20:30:49 -04:00
12abaf83cc Changes from @sjplimp 2024-09-10 16:25:06 -06:00
b39386afe5 count all the runs with error and failed num checks as failed 2024-09-10 17:00:57 -05:00
cbbea47718 fix the incorrect keys 2024-09-10 16:22:35 -05:00
8e2dacd0e3 put some cosmetic stuffs 2024-09-10 15:51:04 -05:00
847ce1e363 enable generating new reference log files if desirable 2024-09-10 15:39:52 -05:00
8e99835100 Merge pull request #4319 from ndtrung81/gpu_max_num_blocks
Enable large numbers of atoms per proc with the GPU package
2024-09-10 12:35:22 -04:00
6f2c4aaf0b Remove unused code 2024-09-10 16:40:19 +01:00
25f33e8721 Add water examples featuring fix qtpie/reaxff 2024-09-10 16:20:51 +01:00
b16bb27184 revert to using the max number of blocks on device for each pass, as the number of blocks (32767 or 65535) already saturates the number of SMs anyway 2024-09-10 09:47:07 -05:00
c63c88f8b6 reduced the max number of blocks for each transpose 2024-09-10 08:58:42 -05:00
5e8ecf9cb4 Rename variables and function for min exponent 2024-09-10 14:45:16 +01:00
7006e19d59 Update fix_cmap_kokkos.cpp 2024-09-10 07:57:51 -04:00
f398add7d5 fixed the value of shift being the number of rows processed in each chunk (g2y_m * b2y) 2024-09-10 00:36:13 -05:00
23bdc5ddc2 Allowed number of blocks greater than 65,535 for k_transpose 2024-09-10 00:18:50 -05:00
a6b9c17010 update reference.yaml 2024-09-09 22:30:09 -04:00
50d0eace23 more consistent conversions 2024-09-09 21:47:30 -04:00
29bd3fc11b apply clang-format 2024-09-09 21:12:03 -04:00
68e134773c move pair style and fix whitespace 2024-09-09 20:58:01 -04:00
a4a8f99471 forgot to update the --analyze step to 8 runners 2024-09-09 20:50:16 -04:00
48689d1925 Merge branch 'develop' into ctip 2024-09-09 20:46:09 -04:00
c3162b4488 increase timeout for full regression to 180 seconds. use 8 runners. 2024-09-09 20:29:23 -04:00
f875b1e110 Tweak error message to use correct style 2024-09-09 17:51:19 -06:00
f7553779ff Merge branch 'develop' of github.com:lammps/lammps into kk_reaxff_overflow 2024-09-09 15:55:02 -06:00
2be54aa454 Cleaned up the spurious calculations in Cdbo, Cdbopi, Cdbopi2 and removed the overallocations 2024-09-09 12:56:59 -07:00
8b9e2544f0 Verified that some unused data gets written to extra space in Cdbo, Cdbopi, Cdbopi2 via moving them to 3-d Views 2024-09-09 12:56:57 -07:00
fced73ffd7 Converted d_bo_list and d_hb_list to 2-d Views, removed integer overflow checks 2024-09-09 12:18:10 -07:00
8e56f37d3d Removed the variables bo_first_i, hb_first_i from build_bo/hb_list, replacing them with the strided offset calculation 2024-09-09 12:14:44 -07:00
c05390209e Removed d_bo_first, d_hb_first, replacing it with the strided offsets to the bonds for atom i 2024-09-09 12:10:13 -07:00
274112834b remove double quotes 2024-09-08 17:11:02 -05:00
4d04d8492d report the number of abs and rel diff checks failed 2024-09-08 17:09:05 -05:00
9cfd809b6e feeble attempt 2024-09-08 17:03:40 -04:00
3dcfb3f755 replace error->all() with kokkos::abort() 2024-09-08 16:54:44 -04:00
29e0ec3809 revert to original cmap plus minimal changes for kk 2024-09-08 16:46:16 -04:00
7724502e90 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-09-08 16:40:42 -04:00
b67b38ab68 kokkos parallel_for 2024-09-08 16:36:39 -04:00
4e8e84a1e4 Merge branch 'lammps:develop' into alphataubio-kokkos-fixes 2024-09-08 13:48:43 -04:00
bce51ea2c9 Update fix_nve_limit_kokkos.cpp 2024-09-08 12:53:49 -04:00
77bf224b3f report if a run is timeout to progress.yaml 2024-09-08 00:24:33 -05:00
397ca4bd25 correct the file names in examples phonon that are actually not LAMMPS input 2024-09-07 09:10:25 -05:00
6b68656a74 fix a typo 2024-09-07 09:06:22 -05:00
57353566d6 one more fix (it is getting late...) 2024-09-07 00:35:57 -04:00
fa5a3446c0 add forgotten file 2024-09-07 00:28:59 -04:00
5aea0a061f provide updated reference and update command line 2024-09-07 00:22:56 -04:00
e5c870fcd2 switch full regression back to serial execution 2024-09-06 23:15:32 -04:00
c853b8d81a switch quick run back to serial 2024-09-06 23:14:09 -04:00
b6e78c1f20 another attempt to avoid oversubscription error 2024-09-06 21:46:18 -04:00
6cd710444d add dedicated config for quick regression test. allow oversubscription. 2024-09-06 21:34:10 -04:00
6e0c44a25c temporarily run the full test with the pull request 2024-09-06 21:18:58 -04:00
afc9f72887 whitespace 2024-09-06 21:18:31 -04:00
6214182fd0 remove unused imports, reformat 2024-09-06 21:06:01 -04:00
93b4e91801 update docs and add ref 2024-09-06 20:51:56 -04:00
0b92bf2c0c oops 2024-09-06 19:40:21 -04:00
d19f5e0e8e bugfix 2024-09-06 19:30:15 -04:00
bca271a286 mention regression tester in Build_development 2024-09-06 17:34:35 -05:00
b09e88a179 Merge pull request #4314 from akohlmey/collected-small-changes
Collected small changes and fixes
2024-09-06 16:24:31 -04:00
8fcdb5c271 silence compiler warnings 2024-09-06 14:58:42 -04:00
42a7294bc1 silence compiler warnings 2024-09-06 14:00:27 -04:00
d20ce26bd8 Merge pull request #4313 from cjknight/aurora_updates
Intel GPU updates: kspace & cmake
2024-09-06 13:51:43 -04:00
932f10e3b6 update README for syntax and added arguments in run_tests.py 2024-09-06 12:46:42 -05:00
1683205fed cleanup 2024-09-06 13:42:33 -04:00
b4e01aaa45 fix warnings 2024-09-06 13:42:16 -04:00
2a2ea89524 fix warnings 2024-09-06 13:40:47 -04:00
e65fb63a97 match base class in kokkos 2024-09-06 13:39:18 -04:00
eedcbc6b5f Revert "match base class in kokkos"
This reverts commit 36494af3c7.
2024-09-06 13:36:34 -04:00
36494af3c7 match base class in kokkos 2024-09-06 13:36:13 -04:00
638bba5319 fix warnings 2024-09-06 13:27:08 -04:00
1335774593 Update fix_recenter_kokkos.cpp 2024-09-06 13:24:13 -04:00
8eeba71f5f cleanup 2024-09-06 13:19:47 -04:00
b468e1cb9a kokkos atan2 2024-09-06 13:04:31 -04:00
74e61c05b9 fix warnings 2024-09-06 12:42:49 -04:00
78342e5b6f fix typo 2024-09-06 12:28:46 -04:00
6b83ef8d33 auto var lambda capture 2024-09-06 12:21:29 -04:00
e25979386a Update fix_nve_limit_kokkos.cpp 2024-09-06 12:18:33 -04:00
bbc3dc2958 auto atomKK variables for lambda capture 2024-09-06 11:56:19 -04:00
842896040d Merge branch 'develop' into aurora_updates, resolve merge conflicts 2024-09-06 11:20:29 -04:00
0c788f831e Merge pull request #4294 from rbberger/add_kspace_nvpl_support
Add Kspace NVPL FFT support
2024-09-06 11:04:51 -04:00
b2cc2582e1 switch to config.yaml in actual runs in quick and full tests 2024-09-06 09:33:23 -05:00
de8dc82801 report walltime normalized by the reference walltime for completed runs in the progress.yaml file 2024-09-06 09:19:00 -05:00
e1d6bb91a8 get reference walltime from running bench/in.lj, guess the default config file if not specified from the command line args 2024-09-06 09:06:45 -05:00
bafe7c91fa switch to using config.yaml with 4 procs for testing 2024-09-06 08:29:55 -05:00
f179f2a80d update a few reference data files for current LAMMPS 2024-09-06 07:32:19 -04:00
513fc95f81 update msi2lmp manpage 2024-09-06 07:30:50 -04:00
93de00f649 move kspace style definition after reading the data file to comply with needs of recent LAMMPS versions 2024-09-06 07:25:52 -04:00
683643c248 sort lists of bonds, angles, dihedrals and impropers by atom IDs before comparing 2024-09-06 07:25:01 -04:00
4554c0367b use memcpy() instead of strncpy() to avoid issues with adding a terminal zero and array boundaries 2024-09-06 07:24:07 -04:00
3e2f929f31 must call Error::all() from all MPI ranks. 2024-09-05 23:22:04 -04:00
360fdabc19 small clarification 2024-09-05 23:05:25 -04:00
d67e0e6a41 consolidate spelling 2024-09-05 21:47:35 -04:00
03631aab00 whitespace and spelling fixes 2024-09-05 21:46:32 -04:00
95cb7d7dd8 Merge branch 'develop' into quick-regression 2024-09-05 17:23:52 -04:00
3357889d57 install MPI 2024-09-05 17:21:42 -04:00
5881a60f50 Revert change to fix shake that is no longer needed 2024-09-05 14:42:51 -06:00
688cff71e6 print out more info for failed tests if verbose is True, indent output 2024-09-05 11:22:00 -05:00
dfd0772aff list the failed tests (including crashed, with error, or numerical checks) into a separate file 2024-09-05 10:38:32 -05:00
e22ff76132 fix cuda warnings 2024-09-05 08:32:21 -04:00
33080199e7 fix cuda warnings 2024-09-05 08:29:08 -04:00
3312ef9793 KOKKOS_INLINE_FUNCTION powint() to replace MathSpecial::powint 2024-09-05 08:25:13 -04:00
04ff7b4736 add missing import 2024-09-05 04:18:23 -04:00
79dc5ee130 Merge branch 'python-lint' into collected-small-changes 2024-09-05 04:04:52 -04:00
274f86b142 Merge branch 'develop' into python-lint 2024-09-05 04:03:06 -04:00
e3ced6d26f docs 2024-09-04 23:44:44 -05:00
29cd430da6 no longer need the warnings module since the deprecated functions were removed 2024-09-04 23:09:10 -04:00
7e6eb96422 Merge branch 'alphataubio-kokkos-fixes' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-fixes 2024-09-04 22:38:24 -04:00
9932c4e38b add 3d float views to ArrayTypes<LMPHostType> 2024-09-04 22:38:19 -04:00
ee602a7daa Merge branch 'lammps:develop' into alphataubio-kokkos-fixes 2024-09-04 21:05:58 -04:00
4ed5dfe88d reported the total wall time of each run in the progress.yaml file 2024-09-04 15:32:20 -05:00
ab10f2d723 Update fix_efield.cpp 2024-09-04 16:12:23 -04:00
49d2a4026d Update fix_efield.h 2024-09-04 16:11:17 -04:00
18514f404f docs: mentiond build options for NVPL FFT 2024-09-04 12:00:31 -06:00
37e6f3ef21 kspace: add NVPL FFT support 2024-09-04 12:00:31 -06:00
9e8a1f4734 Remove comment 2024-09-04 11:15:59 -06:00
26af8878c9 More general fix 2024-09-04 11:13:35 -06:00
7a1dd6e82e Merge branch 'develop' of github.com:lammps/lammps into aurora_updates 2024-09-04 11:08:12 -06:00
7d93460717 add commented example for implementing a command style 2024-09-04 08:23:29 -04:00
311cac0348 Add document describing how to implement a new command style 2024-09-04 05:47:59 -04:00
ec98481d01 move check for libcurl to EXTRA-COMMAND.cmake package CMake module 2024-09-04 04:22:49 -04:00
597c53756e update plumed library to version 2.9.2 2024-09-03 22:33:39 -04:00
e240619b94 update pace plugin loader to include the two additional styles added 2024-09-03 22:30:32 -04:00
7b025e1a1f Merge branch 'develop' into qtpie 2024-09-03 17:31:16 -04:00
4aefb894bb remove comments 2024-09-03 15:56:16 -05:00
9243959ca4 Merge pull request #4304 from akohlmey/collected-small-changes
Add lammps_extract_atom_size() call to library interface and equivalent to python and fortran modules
2024-09-03 16:43:37 -04:00
42b6c0f62c enable cmake support 2024-09-03 20:10:29 +00:00
2f7a7d1edb forgot shake header 2024-09-03 20:07:53 +00:00
3a5e764730 Fix whitespace 2024-09-03 17:50:14 +01:00
787c49d841 Add information about mixing and shift into doc and improve code format 2024-09-03 21:14:10 +08:00
49dcb679f6 Change names of orbital exponents 2024-09-03 12:22:10 +01:00
a48b67baae Fix angle cutoff logical error
Angle should > angle cutoff instead of <
2024-09-03 11:09:35 +08:00
731847b4dc report proper style name in error messages 2024-09-02 21:21:14 -04:00
4b56e81b66 fix typo 2024-09-02 21:03:16 -04:00
61ffe1ece1 correct link 2024-09-02 21:00:02 -04:00
9cfbf3dcdd fix link and grammar 2024-09-02 20:58:40 -04:00
e763f9e052 use correct style in error messages 2024-09-02 20:49:41 -04:00
6aa592d286 build system integration 2024-09-02 20:43:48 -04:00
9f2e542c80 integrate into manual build 2024-09-02 20:42:33 -04:00
7c13562c41 spelling 2024-09-02 20:42:15 -04:00
9f73494c91 correct ReStructuredText and LaTeX formatting issues 2024-09-02 20:42:05 -04:00
5fab9e665f Update with changes made to fix_qeq_reaxff.cpp 2024-09-02 16:59:07 +01:00
ba2217a4b4 Improve exceptions in reading of gauss file 2024-09-02 16:12:23 +01:00
dff91accb0 Correct calculation of cut off distance 2024-09-02 16:12:23 +01:00
f3e5e4b4c1 Rename misleading variable name 2024-09-02 16:12:23 +01:00
79cc70c9da Rename variable for sum of local and ghost atoms 2024-09-02 16:12:23 +01:00
62b14aa702 Remove unused include 2024-09-02 16:12:23 +01:00
c2e4816717 Update contributing authors 2024-09-02 16:12:23 +01:00
6dd45ccfdb Add fix_qtpie_reaxff 2024-09-02 16:12:23 +01:00
eb6e5b438a Remove virtual keyword 2024-09-02 16:12:23 +01:00
149d9b310d Remove dual as a possible keyword argument 2024-09-02 16:12:23 +01:00
5021c8c971 Replace qeq with qtpie 2024-09-02 16:12:23 +01:00
27e911cd10 Remove chi_field 2024-09-02 16:12:23 +01:00
6d47e41741 Update calculation of chi_eff
chi_eff can now be calculated when atom or equal style variables are
used for the electric field, under the restriction that the electric
field is applied to all atoms.
2024-09-02 16:12:23 +01:00
8c8882927c Rename variables in calc_chi_eff() 2024-09-02 16:12:23 +01:00
bfb1c64b64 Add functionality for calculating chi_eff 2024-09-02 16:12:23 +01:00
be43a2bdeb Allow for reading of Gaussian exponents from file 2024-09-02 16:12:23 +01:00
d9151d745a Create fix qtpie/reaxff 2024-09-02 16:12:23 +01:00
bb1624b20d Add documentation for modified pair_hbond_dreiding with angleoffset 2024-09-02 20:33:34 +08:00
7c80b00f23 small corrections in the DIFFRACTION package, mostly cosmetic 2024-09-02 06:26:27 -04:00
27d5ad1714 convert string to int 2024-09-01 08:49:13 -04:00
a9573551a7 run 100 quick test inputs at the most 2024-09-01 08:43:16 -04:00
14dc326160 fix typo 2024-09-01 08:36:50 -04:00
6aa6ed86be Curb number of (randomly) selected tests for quick regression run 2024-09-01 08:33:12 -04:00
da98d30cf7 update README 2024-09-01 08:31:52 -04:00
1b5413189d Add more details to documentation of GitHub CLI "gh" 2024-09-01 08:15:58 -04:00
a143e0a183 small corrections 2024-09-01 08:15:26 -04:00
f6f7122041 Merge branch 'doc-modified' into collected-small-changes 2024-09-01 08:09:45 -04:00
898d97e603 Add angle offset for pair_hbond_dreiding 2024-09-01 16:13:20 +08:00
d2b5f55737 Copy and rename base files 2024-09-01 16:10:29 +08:00
93d11c376d Fix small typo and errors, unifiy example inputs 2024-09-01 15:48:34 +08:00
aa901b205d only run quick regression if there are actual input files to process 2024-09-01 00:59:15 -04:00
d3d9094ad0 update settings when the actions will be triggered automatically 2024-09-01 00:44:23 -04:00
3ea0612795 small cleanups 2024-09-01 00:39:27 -04:00
af747ac6c0 restore old code structure so we can test subsets again 2024-09-01 00:17:25 -04:00
0f1b7b5bd6 simplify even more 2024-09-01 00:09:19 -04:00
f39e795bca revert changes to create_box 2024-08-31 23:19:16 -04:00
591d20b00d Merge branch 'develop' into quick-regression 2024-08-31 23:16:27 -04:00
6fb50cbdc1 integrate quick regression support into regression tester 2024-08-31 23:16:02 -04:00
62bfd7dc74 Move Linux unit test workflow to PR #4304 2024-08-31 16:05:55 -04:00
2e58e4c428 Simplify some more. don't install undetected MPI. 2024-08-31 15:57:34 -04:00
debda72170 print ccache statistics after compilation again 2024-08-31 15:51:52 -04:00
8023074650 build release version 2024-08-31 15:30:40 -04:00
0b7ba6f8c1 let ninja decide how many processes to launch 2024-08-31 15:23:55 -04:00
b372aa0bdc try to skip using Fortran 2024-08-31 15:18:27 -04:00
06bee65a1a use windows style pathnames 2024-08-31 15:10:11 -04:00
34bd2c4f2a use our own fork 2024-08-31 14:58:53 -04:00
b890aee7de update alternate action from GitHub marketplace 2024-08-31 14:55:01 -04:00
11172b1c62 use different structure 2024-08-31 14:42:50 -04:00
73fdd66f03 correct syntax issue 2024-08-31 14:40:31 -04:00
d85380476d alternate approach for using ninja with MSVC++ 2024-08-31 14:38:12 -04:00
6e612f68c2 remove misplaced comma 2024-08-31 14:09:47 -04:00
6d55da7207 bring back multi-config 2024-08-31 14:00:51 -04:00
6c40e8dc79 revert back to MSBuild and report launcher, if active 2024-08-31 13:57:54 -04:00
2998d88edb prefer MSVC++ over MinGW 2024-08-31 13:48:10 -04:00
72acea291a switch to ninja-build and single configuration setup 2024-08-31 13:42:55 -04:00
0d7305672b use chocolatey instead of winget 2024-08-31 12:48:09 -04:00
55a549a2fb try speed up windows compilation with ccache 2024-08-31 12:43:50 -04:00
56ae7e465e Merge branch 'develop' of https://github.com/lammps/lammps into aurora_updates 2024-08-31 11:33:51 -05:00
7492ab7541 sync forces on step 0 2024-08-31 11:18:43 -05:00
78597a9c39 add fortran module tests for extracting atom properties with array dimensions 2024-08-31 12:16:27 -04:00
6f114eddea Fix typo in CMakeLists.txt 2024-08-31 11:14:50 -04:00
84fa26ee2c update test checking tool 2024-08-31 11:13:53 -04:00
2c05378815 expand python module unit tests for extract_atom() 2024-08-31 07:04:59 -04:00
7d176cb66e fix logic bug 2024-08-31 07:04:53 -04:00
70a62d5ebf make certain that the mass and mass_setflag arrays are fully initialized (to zero) 2024-08-31 06:20:44 -04:00
6ebdb0b982 some more tweaks to the workflows 2024-08-31 04:53:09 -04:00
e5f8a4bec5 must install mpi for compiling with mpi 2024-08-31 04:47:03 -04:00
fb2c060d63 add unit test run on GitHub with -DLAMMPS_BIGBIG 2024-08-31 04:40:25 -04:00
abc621ddbd Add GitHub workflow to check for variable length arrays 2024-08-31 04:33:31 -04:00
a764930998 consolidate replicated enum to base class header and inside the class definition 2024-08-31 02:00:30 -04:00
d908010ead Merge branch 'develop' into patch-3 2024-08-31 01:54:29 -04:00
b2ce4051aa Consistent spacing after full stops. 2024-08-31 01:53:54 -04:00
59fdfaf884 consistent indentation 2024-08-31 01:50:58 -04:00
70b8b987ca add noreturn attribute to templated version of error->one and error->all 2024-08-31 00:57:59 -04:00
35c36bb16e step version number for LAMMPS-GUI 2024-08-31 00:55:22 -04:00
dab9d4bc59 Merge branch 'develop' into hagerty_issue4140_kokkos_collective 2024-08-31 00:08:30 -04:00
cdd2640101 remove double delete[] 2024-08-30 23:22:29 -04:00
0cdf8f2658 swap rows/cols for less confusion 2024-08-30 23:16:37 -04:00
b426556632 replace bogus allocation 2024-08-30 22:51:31 -04:00
3e7123e21e make compatible with comm_modify vel yes 2024-08-30 22:51:08 -04:00
9d9e591b54 first try at implementing lammps_extract_atom_size() 2024-08-30 22:50:42 -04:00
1fe905d8a2 update types 2024-08-30 15:15:18 -05:00
9a11570836 cleanup 2024-08-30 19:08:35 +00:00
d9e6dff93b cleanup 2024-08-30 14:05:36 -05:00
d95d65bb69 Major updates 2024-08-30 13:47:25 -04:00
e921af8efa fix bug where custom property dimension was not reported 2024-08-30 10:40:58 -04:00
f3f69da328 expand tests on properties including custom properties 2024-08-30 10:29:41 -04:00
742e6d4ff4 Update doc/src/fix_epot_lepton.rst
Co-authored-by: Shern Tee <shernren@gmail.com>
2024-08-30 09:38:20 -04:00
6b1aec981e exceptions are always enabled now 2024-08-29 22:33:40 -04:00
02f16251d4 flag development version 2024-08-29 22:09:11 -04:00
2d8e473807 Merge branch 'develop' of github.com:lammps/lammps into kk_reaxff_overflow 2024-08-29 14:37:16 -06:00
0c753d92ba single & double support ; fix plan bug 2024-08-29 18:21:26 +00:00
f0513bad4c cleanup 2024-08-29 18:20:41 +00:00
af560356fe Merge branch 'develop' of https://github.com/lammps/lammps into aurora_updates 2024-08-29 12:50:17 -05:00
ba51b59add first pass on MKL FFT for Intel GPUs; rhodo benchmark results are close to CPU... 2024-08-29 12:28:54 -05:00
2d3cd2a0b9 fix typo in the per-job artifact names 2024-08-28 17:22:13 -05:00
a1a3e4e5b7 name the artifacts with their matrix idx 2024-08-28 16:45:00 -05:00
04bd62a677 add another job with the action merge 2024-08-28 16:13:10 -05:00
796a0f18d3 upload per-job artifacts, try action merge in a separate job 2024-08-28 16:07:13 -05:00
5306f5ff18 provide path to the artifacts 2024-08-28 15:35:25 -05:00
aa088da59b pack test output into separate artifacts 2024-08-28 14:43:27 -05:00
4e40b4ba63 upload the artifacts of the full regression test workflow 2024-08-28 14:11:23 -05:00
c60e69ea1e have a single job definition with matrix strategy, the build and env do not persist between jobs 2024-08-28 14:06:40 -05:00
f5ffb28a1f use the log file with 1 proc in serial runs, removed examples/bpm/impact/brokenDump 2024-08-28 12:57:58 -05:00
e3119155e1 Update doc/src/region.rst
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-08-28 18:20:18 +02:00
709ab8fbe9 Update region.rst 2024-08-28 11:04:47 +02:00
40cd70465c Code for variable point definition in region_plane.cpp 2024-08-28 10:57:02 +02:00
5c11c5ead8 include variable definitions in region_plane.h 2024-08-28 10:48:12 +02:00
a59ac7ec86 Reduced the timeout for quick reg tests 2024-08-26 17:43:36 -05:00
1148f5f5c8 cast into PosixPath to str before writing to file 2024-08-25 16:41:26 -05:00
9f20e5b7f7 put a timeout for a run, specified in the config file 2024-08-25 16:19:52 -05:00
04400e10a8 Updated the regression tester run_tests.py to handle list of input scripts 2024-08-25 16:02:16 -05:00
37c312bf8a added pair coeffs 2024-08-24 05:28:38 -04:00
149ae74631 debug matrix strategy 2024-08-23 17:06:11 -05:00
afb1e499af debugging the issue with the runs, list index out of range for run 7 2024-08-23 16:28:51 -05:00
d09e9d46fa specify the config file when analyzing the examples folder 2024-08-23 16:00:15 -05:00
5a9b742086 experiment with the matrix feature at the job level 2024-08-23 15:52:41 -05:00
9e172665f2 enable full regression tests 2024-08-23 15:45:13 -05:00
380447c6ba updated regression test config files 2024-08-23 14:44:08 -05:00
b69a9847f7 add a config file for running regression tests in serial (no mpirun), modify run_tests.py to handle this case 2024-08-23 14:40:07 -05:00
e1b324a3e9 upload artifacts 2024-08-23 14:18:40 -05:00
0d00578978 move download artifacts to a separate step 2024-08-23 14:03:25 -05:00
b1d40014a6 allow to download artifact from the regression test 2024-08-23 14:00:13 -05:00
ebe3bd2f7e activate the env before running the python scripts 2024-08-23 11:59:16 -05:00
7475e5a5ef run the regression tester tool with the list of suggested inputs 2024-08-23 11:49:20 -05:00
40cae6e79a first draft charmm_c36_jul24.gz to LAMMPS data converter 2024-08-22 21:06:04 -04:00
abbfa9470e remove debug print() statement 2024-08-22 17:07:12 -04:00
bda862a3a2 actually honor the branch argument 2024-08-22 16:50:03 -04:00
dc4e4988a9 do not fetch specific commit hash 2024-08-22 16:37:35 -04:00
a204f8e69f refer to branch with origin/develop 2024-08-22 16:30:02 -04:00
613e053373 check out whole history 2024-08-22 16:23:57 -04:00
1c5c3b41a9 more debugging 2024-08-22 16:20:27 -04:00
50cd510e79 no merge commit so we get differences 2024-08-22 16:16:26 -04:00
f1f7eb01c8 tweak settings in action 2024-08-22 16:15:06 -04:00
f3df42ec02 include debug info 2024-08-22 16:07:26 -04:00
27ff1fa5d4 pass string instead of compiled regexp 2024-08-22 15:57:28 -04:00
db9a618a7b more fault tolerance 2024-08-22 15:51:15 -04:00
66d6804d23 apply clang-format to some pair style headers 2024-08-22 15:43:55 -04:00
022d1d7959 get-quick-list.py script is feature complete 2024-08-22 15:41:31 -04:00
1916d0be06 add incomplete draft of quick input file lister 2024-08-22 11:41:56 -04:00
61fd2ba25c apply clang-format to have some files with changes 2024-08-22 11:40:26 -04:00
10dce38a76 small tweaks 2024-08-22 11:40:01 -04:00
664c6f908a must use different ccache keys to avoid conflicts between concurrent jobs 2024-08-22 11:02:43 -04:00
8c6351b6b9 remove unneeded stuff from quick regression test 2024-08-22 10:43:30 -04:00
8adc90b71f add Linux unit test with -DLAMMPS_BIGBIG 2024-08-22 10:41:54 -04:00
d5c245cb3b add workflow for full regression testing 2024-08-22 10:40:19 -04:00
9d80c22a0b install a few extra packages 2024-08-22 09:43:43 -04:00
5562d66931 need sudo for software installation 2024-08-22 08:43:07 -04:00
b540f572a3 prototype workflow for a quick regression test 2024-08-22 08:40:24 -04:00
4a115d66e0 update region doc for sphere/kk 2024-08-21 20:54:08 -04:00
d07e1b918e update email and fix typo 2024-08-21 20:07:43 -04:00
623e1d68e5 oops 2024-08-21 20:07:14 -04:00
5ea26e6cc1 added RegSphereKokkos to bugfix dynamic_cast in FixWallRegionKokkos 2024-08-21 20:07:04 -04:00
3ea74b1725 update atom_style template test for added charge 2024-08-21 16:20:17 -04:00
c968787c41 fix molecule add for MESH and remove 'not compatible' error message 2024-08-21 16:19:09 -04:00
3aadd8bd84 fix typo in comment 2024-08-20 19:12:27 -04:00
cac0c56687 add charge to atom style template 2024-08-20 19:12:09 -04:00
d75fe348f1 bugfix for compute_scalar() to work, test PASSED 2024-08-20 05:40:02 -04:00
5f5e2d9a64 added fix nve/limit/kk 2024-08-19 20:58:41 -04:00
90aaaea75a cleanup 2024-08-09 03:05:23 -04:00
ce4e01fb78 author information only in cpp, kokkos version needs protected instead of private variables 2024-08-07 00:12:11 -04:00
5509cd4a19 remove include/using/enum's no longer needed 2024-08-06 11:32:18 -04:00
3c524871f7 Revert "remove include/using/enum's no longer needed"
This reverts commit 83ce042a86.
2024-08-06 11:26:02 -04:00
83ce042a86 remove include/using/enum's no longer needed 2024-08-06 11:25:47 -04:00
056e3c0853 comply with @akohlmey's request
- revert my DBL_EPSILON change to EXPECT_FP_LE_WITH_EPS macro

- round the reference data for global_vector() to zeros for 2 unit tests to pass
2024-08-06 02:12:52 -04:00
1166531594 add 4 units tests for fix wall/region/kk 2024-08-06 01:24:21 -04:00
83ab240921 remove whitespaces 2024-08-06 01:21:02 -04:00
a98e9edd30 cleanup 2024-08-06 01:10:45 -04:00
7d6ef008e0 uncomment after debugging done 2024-08-06 00:58:49 -04:00
fa4c1d6190 oops 2024-08-06 00:51:11 -04:00
cac6b5dc02 bugfix for gpu and simplify by replacing functor with operator() 2024-08-06 00:43:07 -04:00
f73a7bca5f "Not necessary, the variable is the same." 2024-08-05 22:10:05 -04:00
88a32e6916 refactor domain and fix_deform for KOKKOS 2024-08-05 22:01:40 -04:00
f6ea649585 add fix wall/region/kk 2024-08-05 06:30:01 -04:00
ab558fb174 remove whitespace 2024-08-04 23:39:57 -04:00
ea6905a4b7 bugfix for NPH target temperature ptemp 2024-08-04 23:33:19 -04:00
093490afad Update fix-timestep-nph_sphere.yaml 2024-08-04 23:21:29 -04:00
b83521b22e regenerated unit tests with run_torque 2024-08-04 23:15:33 -04:00
90cdb023dd added dipole support to kokkos version, plus 2 unit tests 2024-08-04 22:57:05 -04:00
af203f7fc7 added run_torque and EXPECT_TORQUES 2024-08-04 22:40:36 -04:00
d1804fc776 Merge branch 'alphataubio-kokkos-bio' of https://github.com/alphataubio/lammps-alphataubio into alphataubio-kokkos-bio 2024-08-04 17:38:21 -04:00
c2e192e734 call the plumber to fix some leaks 2024-08-04 17:33:11 -04:00
0ebb56e5e8 remove commented out code 2024-08-04 17:14:20 -04:00
298329dc74 bugfix dilate option, test now passes 2024-08-04 03:29:34 -04:00
0e9a419593 updated find_fix to get_fix_by_id for kokkos_omp test 2024-08-04 01:53:08 -04:00
84afef94f6 added "fix_modify test virial yes" and regenerated yaml files 2024-08-04 01:52:15 -04:00
c8c9e34e2d significant rewrite, all 3 tests pass 2024-08-04 01:51:26 -04:00
755fdc5986 fix false negative floating point test 2024-08-04 00:07:01 -04:00
62a2486d95 virial bugfix 2024-08-02 23:59:03 -04:00
2ef1e9936f partial bugfix (kokkos_omp test passes, fix_modify test virial yes still crashes) 2024-08-02 11:59:57 -04:00
24fc761396 remove nodiscard warning 2024-08-01 19:55:54 -04:00
f62d1b5d55 complete rewrite of kokkos version
- array of structs set[i] from base class, converted to view- Host, converted to execution_space
- atom->nlocal converted to atomKK->nlocal- domain converted to domainKK- class now templated for DeviceType- SCALE not implemented in kokkos version
... actually by the time i was done it was a complete rewrite of the kokkos version
2024-08-01 18:55:16 -04:00
99a2bd799e Merge branch 'develop' into kokkos-unit-testing 2024-08-01 16:23:35 -04:00
d0b023e6b5 Merge branch 'lammps:develop' into alphataubio-kokkos-bio 2024-08-01 16:18:15 -04:00
4bec1788a6 make operator and inline functions const, plus remove printf debugging 2024-08-01 01:31:11 -04:00
fbf1451a2f add more crossterms to cmap unit test 2024-08-01 01:28:57 -04:00
3da8e9a9a5 add cmap unit test 2024-07-31 12:59:24 -04:00
4f89b0b783 first draft fix cmap/kk 2024-07-31 12:58:14 -04:00
4a972c4311 fix recenter/kk works with coords, init, null plus 3 tests 2024-07-30 04:28:40 -04:00
53ae731e09 first draft fix recenter/kk and unit test 2024-07-30 03:30:38 -04:00
bbe1ba4499 Merge branch 'lammps:develop' into alphataubio-kokkos-bio 2024-07-30 02:09:44 -04:00
8751d07375 fix bug in dihedral_charmmfsw_kokkos and update tests 2024-07-27 23:38:03 -04:00
16fabe83ae Merge branch 'develop' into kokkos-unit-testing 2024-07-27 03:27:35 -04:00
91f462e70b Add #include
Add #include that prevents Windows compile
minor touch-ups
2024-07-26 21:13:08 -04:00
282183dc57 Update fix_epot_lepton.cpp
Add flags for .getVariableReference()
Add initialization in constructor
2024-07-25 17:52:24 -04:00
c25f9032ad add unit test inputs for fix epot/lepton 2024-07-25 05:24:40 -04:00
5d418e90a5 version is still TBD 2024-07-25 05:16:24 -04:00
4af280c9f0 small fixups 2024-07-25 05:14:46 -04:00
2251ac9127 apply clang-format 2024-07-25 05:12:11 -04:00
339911eeed whitespace 2024-07-25 05:11:14 -04:00
efdaf57058 Merge remote-tracking branch 'github/develop' into gsalkuin_develop 2024-07-25 05:10:21 -04:00
f2b778aa5e add new fix to .gitignore 2024-07-25 05:09:59 -04:00
c75b9a929c Fix typo 2024-07-24 20:35:12 -04:00
fa2db39c55 Edit docs 2024-07-24 19:43:18 -04:00
8ef96f6ff8 Add new fix 2024-07-24 19:05:44 -04:00
884b9dd9bd add PALS env var 2024-07-19 15:34:02 +00:00
bae822fea7 update Makefiles 2024-07-19 15:23:49 +00:00
7739c7ad90 Add files via upload 2024-07-02 14:50:12 -07:00
2b84cd0524 Add files via upload 2024-07-02 14:47:48 -07:00
44ff2698c5 Delete examples/log.ctip 2024-07-02 14:47:12 -07:00
b6a007b769 Delete examples/in.ctip 2024-07-02 14:47:01 -07:00
a170ecc202 Delete examples/data.ctip 2024-07-02 14:46:49 -07:00
567d492121 Delete examples/NiO.eam.fs 2024-07-02 14:46:35 -07:00
ba675c0806 Delete examples/NiO.ctip 2024-07-02 14:46:20 -07:00
b98b82fb09 Create in.ctip 2024-07-02 14:45:34 -07:00
6dd47fbbb0 Add files via upload 2024-07-02 14:40:26 -07:00
5bd4b92826 Merge branch 'lammps:develop' into ctip 2024-07-02 14:39:24 -07:00
9513c0edac small cleanup 2024-07-02 13:28:46 -06:00
9d529c6995 Merge branch 'hagerty_issue4140_kokkos_collective' of github.com:hagertnl/lammps-fork into hagerty_issue4140_kokkos_collective 2024-07-02 15:10:58 -04:00
d630fc67ab Updated remap kokkos to remove unused recv_proc and recv_bufloc buffers 2024-07-02 15:10:44 -04:00
abcc9ed08d Merge branch 'develop' of github.com:lammps/lammps into hagerty_issue4140_kokkos_collective 2024-07-01 12:33:17 -06:00
09c121ebbc Prevent overflow in neighbor output 2024-06-26 14:56:28 -06:00
7da7e69ccb Fix integer overflow for large ReaxFF systems with KOKKOS package 2024-06-26 15:14:55 -04:00
69b9deca39 Merge branch 'develop' of github.com:athomps/lammps into develop 2024-06-25 13:49:30 -06:00
53f39eeae4 Rolled back a premature update for MS-MEAM 2024-06-25 13:46:12 -06:00
663aa8aa80 fix missing pairs within same bin 2024-06-20 22:33:11 -05:00
f9a95f7256 fix virial accumulate for gran/hooke/history/kokkos 2024-06-19 16:55:18 -05:00
b217bf4b24 Resolving conflict in src/MEAM/meam_force.cpp 2024-06-18 10:03:39 -06:00
241d36b14e skip kokkos_omp test for dihedral_style_charmmfsw
pair_style lj/charmmfsw/coul/charmmfsh is not available in kokkos so the kokkos unit test for dihedral_style charmmfsw fails.
2024-06-14 14:48:57 -04:00
1c4b2d460b remove respa from kokkos_omp tests 2024-06-14 14:47:56 -04:00
360d59fc88 Create dihedral-charmmfsw-kokkos.yaml 2024-06-13 12:32:09 -04:00
424fb7ce06 Revert "Update dihedral-charmmfsw.yaml"
This reverts commit 1eb8afcba4.
2024-06-13 12:28:49 -04:00
af9d97ea07 Revert "added dihedral charmfsw kokkos test"
This reverts commit 95af3cdab2.
2024-06-13 12:27:56 -04:00
95af3cdab2 added dihedral charmfsw kokkos test 2024-06-13 12:27:08 -04:00
f915c144fd Revert "added dihedral charmfsw kokkos test"
This reverts commit 55b1b5d008.
2024-06-13 12:17:41 -04:00
55b1b5d008 added dihedral charmfsw kokkos test 2024-06-13 12:16:49 -04:00
bdf243e36a more kokkos tests 2024-06-07 19:41:58 -04:00
1eb8afcba4 Update dihedral-charmmfsw.yaml 2024-06-07 16:25:52 -04:00
0f4065f6cd Update test_improper_style.cpp 2024-06-07 15:41:14 -04:00
c4b1704bd3 added kokkos_omp tests 2024-06-07 11:13:41 -04:00
3defe567df Merge branch 'develop' of github.com:lammps/lammps into hagerty_issue4140_kokkos_collective 2024-06-07 07:28:58 -06:00
8573152988 Update src/QEQ/fix_qeq_ctip.cpp
Co-authored-by: Axel Kohlmeyer <akohlmey@gmail.com>
2024-06-03 11:11:40 -07:00
e2e17b1326 CTIP pair style and qeq fix implemented 2024-05-31 13:29:49 -07:00
b5f8d4b46c fix memory leak for fix_dynamic(a.k.a. neigh/history) 2024-05-30 14:34:15 -05:00
bdbfa7f6e2 track pair_brownian changes in COLLOID 2024-05-29 03:29:37 +00:00
8abaf20ae6 Merge branch 'develop' of https://github.com/lammps/lammps into lubricate 2024-05-29 03:18:36 +00:00
13d42b7955 update sphere_flag to radius_flag 2024-05-28 22:11:52 -05:00
c9049c090d Cleaned up memory deallocation logic, improved comments on remap_kokkos.h for collective fields 2024-05-13 15:47:25 -04:00
bd52e31128 Added optimization to collective to local copy to self 2024-05-11 20:58:47 -04:00
4889f1b9fd remove print statements 2024-05-01 15:55:35 +00:00
8cee2604eb remove debug output 2024-05-01 15:55:35 +00:00
7261c833df clean up & fix virial 2024-05-01 15:55:35 +00:00
8002f985da enable half neighlist + kk support; correct except for neighbor list difference... 2024-05-01 15:55:35 +00:00
26f52f7552 enable base classes to support Kokkos style 2024-05-01 15:55:35 +00:00
ed18f3014a fix virial when both global and per-atom requested 2024-05-01 15:55:35 +00:00
83c9d47f5e correct forces + virial 2024-05-01 15:55:35 +00:00
9749c0658a need to update velocities on host for non-kokkos computes 2024-05-01 15:55:34 +00:00
1be59745fb correct forces and per-atom virials, but thermo still off 2024-05-01 15:55:34 +00:00
8d3c7cca94 add PairBrownianKokkos::init_one() 2024-05-01 15:55:34 +00:00
e9f7b62f04 fix FULL (as much as it can since not conservative) 2024-05-01 15:55:34 +00:00
8ddceeb7af fix instantiation of compute; now correct pressure on step zero and support for FULL 2024-05-01 15:55:34 +00:00
a4b3eea189 brownian/kk almost correct on cpu 2024-05-01 15:55:34 +00:00
8c3dab03b7 downgrade macOS to version 13 2024-04-27 02:49:52 -04:00
3f9d96d38d make pip install packages in virtual environment 2024-04-27 02:49:52 -04:00
71f82e70ef Refactored kspace+kokkos collective remap. Need to go back and tidy up memory allocations 2024-04-25 13:16:03 -04:00
1a431b02ae Split collective and non-collective into conditionals. Multi-node test passing. Beginning optimization of collective 2024-04-24 09:23:29 -04:00
65e8a5c981 Relocated send & recv initializations to occur together, since they are independent 2024-04-23 14:59:42 -04:00
f9e349a2bc Fix load balancing issue with 2D FFTs 2024-04-23 13:42:46 -04:00
5c5dd1efb4 Updated kspace kokkos to use input file for collective setting 2024-04-22 10:26:34 -04:00
f43fec417d Updated collective flag keyword in KOKKOS PPPM to use setting from input file 2024-04-22 10:23:14 -04:00
0af4fe2702 Enable collective comm for PPPMKokkos 2024-04-20 09:39:41 -06:00
3116250da9 Initial port of kspace_modify collective yes to KOKKOS package 2024-04-19 16:00:58 -04:00
38874c5aaa make more consistent 2024-04-18 00:27:38 -04:00
d16d3ee02b replace wildcard imports with explicit ones 2024-04-18 00:21:53 -04:00
ebd77afd58 initialize in the constructor for the class that defines variable 2024-04-18 00:09:07 -04:00
6683976ce0 use explicit imports instead of wildcards 2024-04-17 04:45:16 -04:00
44c8f722a3 Merge remote-tracking branch 'upstream/develop' into develop 2024-02-24 14:32:03 -07:00
2ef030f33c Fixed error in forces that only affects non-zero t1m MS-MEAM models 2024-02-24 14:14:52 -07:00
1c9d62543b Merge pull request #3 from rohskopf/sna-grid-kokkos
Kokkos SNAP grid local compute
2024-02-22 13:58:21 +01:00
dd99ea371d Merge remote-tracking branch 'upstream/develop' into develop 2023-11-22 10:30:51 -07:00
a5b262aefa Hotfixing a small bug in the Kokkos Gaussian Compute
Co-authored-by: Drew Rohskopf <<drew.rohskopf@gmail.com>
2023-09-08 00:20:45 +02:00
36e24d00d1 Merge remote-tracking branch 'upstream/stable' into develop 2023-08-14 14:42:11 -06:00
27d065a682 sync with develop 2023-08-03 11:33:14 -04:00
f1dd7f1415 Merge tag 'patch_2Aug2023' into maintenance
LAMMPS feature release 2 August 2023
2023-08-03 11:14:29 -04:00
79e05595db Remove destructor prints 2023-07-11 13:11:50 -06:00
63a3c3f30c Merge branch 'lammps:develop' into mala 2023-07-11 15:43:30 +02:00
cb915cdce7 Fill local sna/grid array 2023-07-10 10:22:52 -06:00
b5dc7d58a8 Destruct sna/grid/local/kk properly and use local arrays 2023-07-09 10:20:45 -06:00
3f9cc8f0fd Initial sna/grid/local/kk implement 2023-07-07 17:08:41 -06:00
2fc1844443 Merge pull request #2 from rohskopf/sna-grid-kokkos
Kokkos Gaussian grid
2023-07-03 14:26:20 +02:00
be5eb198c3 Clean up debug prints 2023-06-27 11:50:00 -06:00
969cc5dc03 Tweak TeamPolicy settings for speedup 2023-06-26 17:41:13 -06:00
c871fe8505 Fill grid geometry info 2023-06-26 17:03:05 -06:00
9eb26e4cd0 Shallow copy Kokkos written array to returned array variable 2023-06-26 16:43:28 -06:00
5885f49b75 Prevent polymorphic destructor calls with copymode 2023-06-26 14:50:44 -06:00
fc5e583c56 Initial Gaussian grid implementation 2023-06-24 15:56:54 -06:00
5e01ffe6a6 Merge pull request #1 from rohskopf/sna-grid-kokkos
compute sna/grid/kokkos
2023-06-07 13:57:50 +02:00
904fde8189 Merge remote-tracking branch 'fork_drew/sna-grid-kokkos' into sna-grid-kokkos 2023-06-06 15:28:48 +02:00
788fd3a9ac Re-Adding Gaussian grid again, originally authored by Aidan Thompson
Co-authored-by: Aidan Thompson <athomps@sandia.gov>
2023-06-06 15:28:41 +02:00
b1105a231b Add triclinic cell conversion 2023-06-04 05:03:06 -06:00
b1ffcbcd41 Fix cutoff factor when switchflag = 0 2023-06-02 17:38:48 -06:00
be5476e442 Loop over chunks on GPU to write values properly when using default chunk size 2023-06-02 15:10:45 -06:00
95e39ba89a Clean up kernels 2023-05-30 22:53:24 -06:00
1037e4a4eb Use normal loop over ntotal inside neighbor team policy 2023-05-30 22:40:12 -06:00
709da60474 Replace limited parallel for with normal for for now 2023-05-30 11:08:43 -06:00
e169327162 Merge branch 'lammps:develop' into mala 2023-05-23 10:23:42 +02:00
59e8b9370f plug memory leak in FixNHIntel class 2023-04-24 20:58:33 -04:00
39fa2021e2 avoid 32-bit integer overflow when allocating memory for neighbor list copy 2023-04-24 20:45:49 -04:00
83f492a195 must initialize vest_temp to null to avoid segfaults 2023-04-24 20:44:44 -04:00
933457acbe Templated functions calling math libraries should use type-aware calls 2023-04-24 19:55:39 -04:00
06f4099566 Vector masking is part of AVX512, not limited to Intel compiler 2023-04-24 19:54:19 -04:00
5624a78b17 Fix uninitialized memebr 2023-04-24 19:53:57 -04:00
66def742c4 Organize deallocator calls 2023-04-24 11:29:04 -06:00
47e875142f update version string 2023-04-22 18:37:52 -04:00
62c844d5ac update version string for stable release update 2023-04-22 14:56:44 -04:00
263b6d4d6f compilation fix for Fedora 38 from upstream 2023-04-22 14:32:11 -04:00
4acca38a65 remove text that only applies to newer LAMMPS versions 2023-04-22 12:19:37 -04:00
4cf642b526 correct docs for fix edpd/source and fix tdpd/source 2023-04-22 12:12:38 -04:00
470581d469 Organize sna method calls and clean up 2023-04-10 17:18:00 -06:00
52fc8f05ee update CMake script for PLUMED package to support cross-compilation to Windows 2023-04-10 09:23:19 -04:00
40db9b1701 Agreement between Kokkos and original compute sna/grid with switchflag = 1; note that switchflag = 0 gives wrongly zeroed values for Kokkos because of bug in compute_s_dsfac function of sna_kokkos_impl.h causing sfac to be zero 2023-04-09 15:54:47 -06:00
d75ceabfb0 Fix neighbor criteria so atoms sharing positions with gridpoints aren't included as neighbors 2023-04-08 21:55:04 -06:00
a720328770 Matching descriptors when no neighbors, good checkpoint for debugging 2023-04-08 21:32:46 -06:00
a3d8ab3088 Add cutoff view properly 2023-04-08 19:03:25 -06:00
02122c809c Change ntotal to n_ninside 2023-04-08 17:52:35 -06:00
bd1134c083 Debug inability to deep copy 2023-04-08 17:21:27 -06:00
7539264846 Sync device and host compute arrays 2023-04-08 13:08:24 -06:00
212b864052 Add all SNAP computations and 4D view Kokkos memory allocator 2023-04-08 11:19:07 -06:00
047df9aa9e mark as maintenance branch version 2023-03-31 09:52:58 -04:00
fb3bd20dff update fmtlib to version 9.1.0 to avoid compilation issues with PGI/NVHPC compilers 2023-03-23 18:34:42 -04:00
c7d62c4709 fix ids once bug in compute chunk/atom 2023-03-22 22:21:13 -04:00
b18008c58d add useful comments 2023-03-22 22:18:29 -04:00
9469321e3d Fixed bug in fep tools 2023-03-22 22:18:04 -04:00
a4a9efeefc Fixed bug in fep tools 2023-03-22 22:17:55 -04:00
70744f10e0 backport fix property/atom bugfix for KOKKOS 2023-03-22 22:17:10 -04:00
9bea55bd77 update fix mscg example 2023-03-16 14:55:20 -04:00
73525b3bbc Download the latest MSCG snapshot to address bug in library. 2023-03-16 14:55:05 -04:00
9cf67699cc include fixes and updates from upstream 2023-03-16 12:44:18 -04:00
666fe4cfbe fix two bugs in the ndx2group command 2023-03-16 12:35:53 -04:00
ed7bd50500 must recompile main.o when MDI package is installed/uninstalled 2023-03-12 22:31:06 -04:00
de4dbec661 Remove swo 2023-03-12 20:03:35 -06:00
584a6200f5 Mimic pair snap kokkos pattern 2023-03-12 20:02:57 -06:00
a0a7f14db5 Remove swo 2023-03-12 17:01:20 -06:00
234346c37d Experiment with different implementations 2023-03-12 17:00:48 -06:00
e1e7984822 Start ComputeSNAGridKokkos implementation 2023-03-10 16:19:24 -07:00
d241e26d03 allow dynamic groups with fix oneway 2023-02-25 12:03:40 -05:00
73e7163ed6 don't store topology information with ghost atoms. they will be ignored. 2023-02-24 22:56:17 -05:00
5a5a86684a Fix the adios2::ADIOS constructor calls that were deprecated in adios 2.8 and removed in 2.9. The fix is backward compatible with older adios2 versions as well. 2023-02-23 15:39:01 -05:00
ae3f57e89a fix bug in fix wall/morse that was computing forces incorrectly 2023-02-23 15:38:20 -05:00
fff7b2a859 update unit test for correct fix wall/morse 2023-02-23 15:37:58 -05:00
83ba1c9d20 Merge pull request #3645 from akohlmey/more-backports-to-stable
More backports of fixes to stable release
2023-02-17 16:27:13 -05:00
ce10614cab backport region check move to init() function for fix gcmc and fix widom 2023-02-17 12:44:58 -05:00
facbeac052 move definition of MAXBIGINT_DOUBLE to variable.cpp 2023-02-17 12:29:17 -05:00
188ee5af15 use MAXBIGINT_DOUBLE which does not overflow when casting back to bigint 2023-02-12 04:08:11 -05:00
f176b8b14c consistently support special_bonds settings in pair style gauss 2023-02-10 05:09:58 -05:00
2396b2feea Fixed bugs with gauss/gpu in bonded systems, including factor_lj in forces and energies 2023-02-10 05:02:43 -05:00
4399c1b6c1 Merge pull request #3593 from akohlmey/maintenance-2022-06-23
Third round of maintenance fixes and backports for the stable release
2023-02-09 22:53:11 -05:00
fd046c8fd8 Merge branch 'maintenance' into maintenance-2022-06-23 2023-02-09 20:17:06 -05:00
09b7694601 Merge pull request #3595 from akohlmey/maintenance-many-files
Additional non-functional maintenance changes for the stable version
2023-02-09 20:09:28 -05:00
df20503434 make fallback url function available to plugin compilations 2023-02-09 08:14:23 -05:00
f4aa24a36a roll back changes for vec3_scale() and vec3_scaleadd() and use temporary vector 2023-02-08 20:33:38 -05:00
007c04bc97 correct preprocessor logic for non-Linux machines 2023-02-08 16:45:48 -05:00
418d1e16e1 recover compilation of tersoff kernels with CUDA 2023-02-08 11:17:09 -05:00
6471d781d0 recover kernel failure for tersoff with mixed and single precision 2023-02-08 09:14:37 -05:00
97ddc5917c another OpenCL bugfix attempt from Trung 2023-02-08 08:26:22 -05:00
a95ff20647 swap nvcc default arch from Maxwell to Pascal
This is to avoid deprecation warnings with CUDA 11.6 and later
2023-02-07 08:34:01 -05:00
9e0a9e2601 correct logic 2023-02-07 00:00:17 -05:00
8b34d65970 add download fallback handling 2023-02-07 00:00:07 -05:00
0a1c2bcccc fix failing unit tests with OpenCL 2023-02-06 18:40:07 -05:00
c9442c591c re-enable new neighbor lists for CUDA 12.0 and later 2023-02-05 03:01:46 -05:00
b7d316031d nullify freed pointers in list of dump data 2023-02-03 20:39:47 -05:00
361e9f3ea5 avoid illegal memory access in destructor after variables have been deleted 2023-02-03 20:26:42 -05:00
28120793b8 backport PR #3631 2023-02-02 22:21:15 -05:00
f32ce8377e change default arch in nvcc_wrapper, so it can still run with cuda 12 2023-02-01 11:35:59 -05:00
9021b8bc6a implement download fallback for traditional make build 2023-02-01 06:53:53 -05:00
838fe3020d add support for building a static lammps-shell executable with Linux/MUSL 2023-01-31 22:23:41 -05:00
b4d4dcbcbc simplify 2023-01-31 20:35:18 -05:00
52a892ec46 simplify 2023-01-31 20:32:41 -05:00
0ee3d9da5d port triclinic region vs box check from fix gcmc to fix widom 2023-01-31 20:29:18 -05:00
50afb292b0 compare region extent with box bounds for triclinic 2023-01-31 20:28:25 -05:00
275ef9da17 update n2p2 lib version for traditional make, too. 2023-01-31 20:28:15 -05:00
b6a87390a3 revert MD5 hash to current value after GitHub reversed its change 2023-01-31 20:28:04 -05:00
72178631c5 update N2P2 library to version 2.2.0 2023-01-31 20:27:57 -05:00
f8859c5fca implement download fallback URLs pointing to download.lammps.org for CMake 2023-01-31 20:22:06 -05:00
979119a29b backport fixes to KOKKOS and REAXFF from PR #3621 2023-01-31 20:18:38 -05:00
bc66572275 Fix out of bounds access in pair_vashishta_kokkos with skip list 2023-01-31 20:00:45 -05:00
609231675f Allow neighbor class to set newton flag in Kokkos neigh list 2023-01-31 19:55:07 -05:00
d9675b5da4 Fix QUIP compilation with Intel compilers. 2023-01-30 08:11:52 -05:00
7d32b4f42a make Kokkos lib compatible with musl-libc
Note: this was adapted from https://github.com/kokkos/kokkos/pull/5678
to be usable without requiring C++17
2023-01-27 12:21:39 -05:00
697e5b15ec forcibly disable COMPRESS package is zlib is not found 2023-01-27 07:29:25 -05:00
ade0718c11 make compatible to non-glibc Linux 2023-01-27 07:26:23 -05:00
31033ff6e0 must initialize "np" in constructor 2023-01-26 18:34:21 -05:00
9a598ba5a8 backport fix pimd bugfix from develop 2023-01-26 15:59:26 -05:00
ff20448b1d add image to the cover page of the PDF version of the manual 2023-01-26 11:23:46 -05:00
af5229ba58 swap constexpr back to const 2023-01-26 09:58:26 -05:00
b180200c48 check if variable value is a valid number before converting it 2023-01-26 07:10:50 -05:00
27441cf2ea update developer contact info in a few more files 2023-01-25 22:24:22 -05:00
db61bf609b plug memory leaks in couple examples 2023-01-25 21:48:29 -05:00
015fa4cb0a update embedded docs 2023-01-25 21:44:04 -05:00
62f6f91146 minor typo and rewording 2023-01-25 21:42:37 -05:00
e163b0b1d7 portability improvements for Solaris/OpenIndiana 2023-01-25 21:40:23 -05:00
169a886898 cannot test PYTHON package if it is not installed 2023-01-25 21:37:22 -05:00
cbd276c49d correct prototype for documentation 2023-01-25 21:32:03 -05:00
183c6c06ff small tweaks to the "breadcrumbs" part of the theme to avoid double inserting a separation character 2023-01-25 21:28:18 -05:00
93a46da58e add image to the cover page of the PDF version of the manual 2023-01-25 21:24:27 -05:00
6b6a47bd3c Small tweaks 2023-01-25 21:21:08 -05:00
4a0a98a0fd Small bugfixes for Kokkos 2023-01-25 21:20:59 -05:00
369ea4fd26 Add this 2023-01-25 21:17:30 -05:00
d63c002bf5 Use group for Kokkos nvt temp compute 2023-01-25 21:17:22 -05:00
e931d3153b small improvements from upstream 2023-01-13 17:52:28 -05:00
2913c063d4 whitespace 2023-01-13 14:51:21 -05:00
5606b57646 Update SECURITY.md
I found the overlapping meanings of release/update/patch a bit confusing, especially when sometimes referring to a branch name and sometimes used as a general description.  So I reworked it, trying to preserve meaning. I deleted the last sentence, because I did not understand it, it may need to be added again.
2023-01-13 11:30:07 -07:00
0fafe34008 import updates to library plugin loader from upstream 2023-01-13 05:21:33 -05:00
a9a1640d67 reorder 2023-01-12 18:28:17 -05:00
812363fb99 lammpsplugin bugfix from Stan 2023-01-12 18:24:04 -05:00
b40e0be1c9 reset to current state of the library interface and remove parts from upstream that have crept in 2023-01-12 12:08:00 -05:00
be94176c03 Re-starting MALA branch in MALA fork 2023-01-12 15:44:04 +01:00
1be973da07 update from upstream 2023-01-11 22:31:06 -05:00
aca2c52795 update LAMMPS developer contact info 2023-01-11 22:25:25 -05:00
536b2ab7e5 restore accidentally deleted file 2023-01-11 22:16:31 -05:00
ccef293161 remove obsolete comment 2023-01-11 22:11:53 -05:00
4b0de87813 silence compiler warning 2023-01-11 21:59:35 -05:00
fa22aef31b Fix obscure bug in Kokkos neigh list build 2023-01-11 21:53:16 -05:00
cb7544a615 import modernization from upstream 2023-01-11 21:41:58 -05:00
a9be4906b7 import safer ghost cutoff determination for manybody GPU styles from upstream 2023-01-11 21:41:43 -05:00
6f36d21a04 GPU library updates 2023-01-11 21:34:42 -05:00
c55a15c4dc make AWPMD compatible with MSVC and c++-linalg on Windows 2023-01-11 21:23:03 -05:00
8f01dad1a9 add tools/tabulate 2023-01-11 21:21:51 -05:00
db6e1aa20d some more documentation updates 2023-01-11 21:21:03 -05:00
3cee69a077 correct Kokkos device/arch info ouput in CMake summary 2023-01-11 18:15:56 -05:00
69ffe71595 update unit tests for code corrections 2023-01-11 07:45:50 -05:00
16fa033111 fix issues with bundled meam/spline potentials 2023-01-11 06:40:54 -05:00
8e494aa771 updates and bugfixes for liblammpsplugin plugin loader for LAMMPS shared lib 2023-01-11 06:11:46 -05:00
d203cce8b5 documentation updates from upstream 2023-01-11 06:07:19 -05:00
f8de1b1a75 use official API for utils::logmesg(), stricter/consistent checking for integer and floats 2023-01-11 05:54:35 -05:00
de89a25a25 final CMake sync with upstream 2023-01-11 05:03:00 -05:00
f982e95267 update developer info in unittest tree 2023-01-11 01:28:52 -05:00
293d0cdb58 fix typo 2023-01-11 01:26:54 -05:00
011f2651ee update 2023-01-11 01:26:48 -05:00
a8d3c43a77 update version 2023-01-11 01:26:35 -05:00
c19641f8b3 synchronize CMake scripting with upstream 2023-01-11 01:04:32 -05:00
6596b343ff sync docs with fire minimizer code features 2023-01-10 21:55:56 -05:00
b6dbb0330c update list of commands in pygments LAMMPS lexer 2023-01-10 21:55:56 -05:00
0dd138666a update for accelerated versions 2023-01-10 21:55:56 -05:00
33b9fec150 synchronize sphinx configuration with upstream 2023-01-10 21:55:56 -05:00
32b020a165 Increase communication cutoff for TIP4P pair styles, if needed
This avoids error of H atom not found when the O atom is a ghost.
2023-01-10 21:55:56 -05:00
c1db230331 Fix bug in Kokkos ReaxFF on GPUs 2023-01-10 21:55:56 -05:00
254c052ecc Fix GPU tag issues in other Kokkos styles 2023-01-10 21:55:56 -05:00
8e889dfa7c offset is not used (by construction of the potential) 2023-01-10 21:55:55 -05:00
5b6a52a646 correct suffix handling with compute fep 2023-01-10 21:55:55 -05:00
55f56deb63 bugfix for minimization with KOKKOS when using fix box/relax 2023-01-10 21:55:55 -05:00
bfe127a720 cosmetic 2023-01-10 21:55:55 -05:00
d95c8911a3 tweak intel compiler settings 2023-01-10 21:55:55 -05:00
0380f9d854 consistently prefix deep_copy() with Kokkos:: 2023-01-10 21:55:55 -05:00
71b1d60363 bugfix for gaussian bond/angle styles to avoid premature truncation of potential 2023-01-10 21:55:55 -05:00
8b1f92fabd better error handling when reading table files 2023-01-10 21:55:55 -05:00
419af0cf28 dead code removal 2023-01-10 21:55:45 -05:00
9030c59932 bugfix for nm/cut argument parsing 2023-01-10 21:55:21 -05:00
ee88078150 bugfix for DPD with exclusions other than 0.0 or 1.0 2023-01-10 21:55:21 -05:00
04451f6072 recover compilation 2023-01-10 21:55:21 -05:00
2364f7f08b bugfix for incorrect stress tally in dihedral style table 2023-01-10 21:55:21 -05:00
7f82a58f51 auto loop optimizations 2023-01-10 21:55:21 -05:00
1caf074ba1 avoid excess string copy in auto loops 2023-01-10 21:55:20 -05:00
34677f78c2 initialize ADIOS dumps only the first time when used in multiple runs 2023-01-10 21:55:20 -05:00
e095609ac6 update lammps theme base theme from read-the-docs version 1.0.0 to 1.1.1 2023-01-10 21:54:35 -05:00
1122408957 dynamic cast whitespace 2023-01-10 21:53:53 -05:00
5f9b78ca01 update developer reference text 2023-01-10 21:53:09 -05:00
fe138fc75c add support for building/using the ADIOS package without MPI
This needs the ADIOS2 installation being configured accordingly.
2023-01-10 12:38:20 -05:00
31c324ff61 remove references to long obsolete .d dependency files 2023-01-10 12:32:22 -05:00
30564ed8b7 import traditional build system updates and fixes from develop branch 2023-01-10 12:16:59 -05:00
f05bfe45a8 Synchronize GitHub related files and settings with develop branch 2023-01-10 11:50:49 -05:00
88c8b6ec6f Merge pull request #3460 from akohlmey/maintenance-2022-06-23
Second round of maintenance fixes and backports for the stable release
2022-11-03 12:21:59 -04:00
f01e28f574 add missing parts to ELECTRODE package docs for traditional make. sync with upstream. 2022-10-27 16:29:28 -04:00
96627d27b1 add support to detect the BuildID of Windows 10 22H2 2022-10-27 12:56:30 -04:00
b3fc574a6a use googletest aliased targets consistently 2022-10-26 22:46:31 -04:00
8a3f7560c9 drop special OpenMP flags from presets. Will be detected by FindOpenMP. 2022-10-26 22:46:21 -04:00
8406e92a9a downgrade KOKKOS OpenMP check to version 3.1
need to apply special exception for NVHPC/PGI compilers
2022-10-26 22:46:13 -04:00
3b376b4448 modernize OpenMP detection and check for omp.h in CMake 2022-10-26 22:46:03 -04:00
ca3b7be623 add compatibility to VTK version 9.0 and above 2022-10-24 16:25:25 -04:00
c825c52d2f update required version 2022-10-23 03:45:57 -04:00
0ea0e4ce59 modernize calls to access the list of fixes in the Modify class 2022-10-23 03:16:26 -04:00
d53d4b4d99 use inline insertion sort for short array 2022-10-23 03:16:13 -04:00
b37cd14dd1 avoid superfluous calls to utils::strdup and improve error messages 2022-10-23 03:15:58 -04:00
a921a6bdc1 silence compiler warning about not copying the final null byte 2022-10-23 03:15:47 -04:00
51a0345941 Update fix_bond_react.rst 2022-10-23 03:15:35 -04:00
8d70960e2d bond/react: create atoms error check
check that post-reaction template has 'Coords' section if it has 'CreateIDs' section
2022-10-23 03:15:12 -04:00
5661703b30 Update pair_threebody_table.cpp
Correcting for hard coded ntheta = 79 in the extreme case that theta is exactly equal to 180.0 degrees.
2022-10-23 03:13:50 -04:00
bc30304f72 update plumed package version to 2.8.1 2022-10-22 23:01:47 -04:00
c76da483fb must bootstrap centos 7 from dockerhub now 2022-10-22 22:59:52 -04:00
036a1e47d2 replace one more suffix 2022-10-22 22:28:35 -04:00
5430c3b592 add workaround for missing links to fortran functions in sphinx output 2022-10-21 19:01:31 -04:00
9b7cb8200c small sphinx tweaks. require sphinx 5.2 or later. 2022-10-21 19:01:24 -04:00
550eedbb1f make Linux behavior default for loading Python shared lib
This adds portability to platforms like FreeBSD
2022-10-21 15:52:26 -04:00
3a058f278d Python support in ML-IAP requires NumPy. Check for it if CMake supports it. 2022-10-21 15:50:08 -04:00
0f7f0b5f86 find cythonize executable on recent FreeBSD versions 2022-10-21 11:39:02 -04:00
3de7534b84 try to make more portable (in case this ever gets ported to windows) 2022-10-21 11:38:50 -04:00
7065462faf add md5sums for plumed 2.7.5 and 2.8.1, update default version to 2.8.1 2022-10-21 11:38:40 -04:00
2e9d8e1ccb preserve pair/only package setting during clear command 2022-10-19 14:50:27 -04:00
19b84f7cbd delete atomfile variables when using the clear command 2022-10-19 14:44:10 -04:00
9b7c445a15 include non-buffered flag 2022-10-19 14:44:04 -04:00
91e56444ce add CMake check that will refuse compilation of unit tests or skip tests
This is mainly because the default compilers on RHEL/CentOS 7.x are
not sufficient to compile googletest. Also some Fortran module test
requires a working F90 module and others are more recent Fortran compiler.
2022-10-17 18:12:21 -04:00
9b3c8c36bd update version 2022-10-14 21:35:16 -04:00
3403520967 Fix issue with KSpace slab correction energy with non-neutral systems 2022-10-11 16:37:45 -04:00
d8f969f1df update python package requirements for building the manual 2022-09-30 20:18:05 -04:00
3487deccb6 update broken URLs 2022-09-27 08:03:11 -04:00
0926fc627d step update counter 2022-09-25 09:04:45 -04:00
7999778d94 initialize sllod fixes consistently 2022-09-25 07:02:35 -04:00
b4ef4c1ff2 correct indentation 2022-09-25 07:02:35 -04:00
72b08e4b87 backport dump fixes from develop 2022-09-25 07:02:28 -04:00
faa64a84e8 bugfixes and updates to the DIELECTRIC package from upstream 2022-09-09 19:42:01 -04:00
32b67fff2b print an error if the filename before '*' is too long for the regex matcher 2022-09-07 21:06:19 -04:00
f3dbf4122d extend the length to which the regex matcher checks strings to 256 chars. 2022-09-07 20:47:16 -04:00
e25ac786da must apply bond/angle offsets when determining shake bond/angle types 2022-09-05 10:52:06 -04:00
f30fba0061 support paths with blanks and avoid race condition when updating potentials 2022-09-02 21:33:30 -04:00
03f319604f recover dump_modify every behavior 2022-08-31 17:26:09 -04:00
0782dab1ec properly initialize result storage for per-chunk arrays 2022-08-29 13:04:40 -04:00
c43cce54ab re-initialize neighbor lists at end to clear out the occasional list entry 2022-08-28 11:47:27 -04:00
281a368702 correct pair coeff mixing diagnostic for CLASS2 pair styles 2022-08-28 05:51:38 -04:00
f28d69b429 bugfix for writing data files with atom style dielectric 2022-08-19 16:18:38 -04:00
e674e0c927 correctly handle the case where there are no atoms in the fix group 2022-08-14 03:53:02 -04:00
eebabf99b8 adjust location of local ref targets for recent sphinx versions 2022-08-05 22:09:01 -04:00
23a19f4431 need new CSS hack to hide duplicate headers derived from the navigation bar 2022-08-05 21:46:38 -04:00
d618b0ffc0 Merge pull request #3324 from akohlmey/maintenance-2022-06-23
First round of maintenance fixes for the stable release
2022-08-05 16:57:43 -04:00
ffc71b8733 energy is not an array 2022-08-05 08:23:23 -04:00
564df78698 fix typo 2022-08-05 08:22:59 -04:00
8db0b5ca39 fix index copy-n-paste error 2022-08-05 08:22:09 -04:00
79e26fe829 correct bond style bpm/rotational example 2022-08-05 03:24:29 -04:00
523d4b0242 correct issues in fix adapt and fix adapt/fep related to using fix STORE 2022-08-04 10:19:26 -04:00
fe39a3e581 Documentation updates for simulations including dipoles 2022-08-03 16:47:29 -04:00
081cc1f992 clarification on what constituets single, double, and triple quotes. 2022-08-03 01:51:43 -04:00
53c80c2c00 match pow(0,0) = 1.0 behavior in powint() 2022-07-31 18:52:08 -04:00
554b64a147 avoid deprecation warning and update PyPy package requirements 2022-07-30 17:37:35 -04:00
dc08dba592 update embedded search box 2022-07-28 18:58:58 -04:00
0eaa2775cd document missing call 2022-07-27 22:13:33 -04:00
852673ce41 fix off-by-one bug 2022-07-27 21:44:22 -04:00
8c711e405a correct make command line example 2022-07-27 08:38:37 -04:00
25b9f95061 add check on extracting elements twice from the library to avoid opaque error later 2022-07-26 15:01:03 -04:00
ee66a6f8c1 correct formatting 2022-07-26 12:34:05 -04:00
b694a5f582 add reference 2022-07-26 12:33:57 -04:00
7ab3fce93f correct typos 2022-07-26 12:33:48 -04:00
1f9509cb6f strip off -pendantic-errors flag when compiling with nvcc_wrapper to fix error compiling ML-PACE 2022-07-18 14:00:53 -04:00
cad1d8ece4 correct unit tests for dump local 2022-07-17 12:16:01 -04:00
b709d75f80 add support for dump_modify colname to dump local 2022-07-17 11:52:15 -04:00
5839909061 fix cut-n-paste error and improve error message 2022-07-17 11:46:51 -04:00
30f374de58 clarify 2022-07-16 06:42:19 -04:00
0f9fec05fb disallow use of variable functions vdisplace(), swiggle(), and cwiggle() with fix dt/reset 2022-07-16 06:42:11 -04:00
972a86f0ec fix cut-n-paste typo 2022-07-15 19:06:14 -04:00
7338ebfc94 Update Errors_warnings.rst 2022-07-15 12:28:07 -04:00
7132152693 Update Errors_messages.rst 2022-07-15 12:27:57 -04:00
c9925f64f7 cosmetic changes, silence warnings, avoid temporary char buffers 2022-07-15 12:27:48 -04:00
6da523c8b8 very-small-templates bugfix 2022-07-15 12:27:36 -04:00
0522284589 bugfix: specials update corner case 2022-07-15 12:27:26 -04:00
e10a66dabc allow ramp(x,y) to be used in between runs (returning x) and avoid division by zero on run 0 2022-07-15 05:41:12 -04:00
51dd631a76 Fix bug in vtk dump 2022-07-15 04:29:54 -04:00
d37249787e work around issues with Intel compilers compiling the GPU package 2022-07-12 00:38:51 -04:00
f44841de69 update unit test 2022-07-07 10:32:47 -04:00
54c5337d2d apply clang-format 2022-07-07 10:32:32 -04:00
efb0e63bf6 correct force and energy for excluded pairs 2022-07-07 10:32:20 -04:00
13d78c3afa Update Kokkos version in CMake 2022-07-04 10:49:03 -04:00
f2910b1d9c Update Kokkos library in LAMMPS to v3.6.1 2022-07-04 10:48:51 -04:00
78b22a64aa formatting corrections and minor tweaks to the Argon viscosity howto 2022-07-01 09:27:43 -04:00
8bb1880c9d Fixed temperature in argon GK example 2022-07-01 09:27:36 -04:00
e7b36c7b90 make certain to switch to the expected source folder when building n2p2 lib 2022-07-01 05:49:07 -04:00
d7804e3770 MPI may need to include multiple folders (e.g. on Ubuntu with OpenMPI) 2022-06-30 23:53:57 -04:00
8d0f9695d2 update googletest to version 1.12.1 2022-06-30 14:57:22 -04:00
52b2e4f364 add Update 1 string to version info 2022-06-29 17:44:29 -04:00
41140149ea whitespace 2022-06-29 17:06:11 -04:00
85e556ac8f add more unit tests for boolean expressions 2022-06-29 17:05:37 -04:00
cd5437a7e2 fix bug in recent bugfix 2022-06-29 17:05:27 -04:00
00cc82ac94 update and expand unit tests for if() command boolean evaluation 2022-06-29 17:04:49 -04:00
20f87e3f1d change boolean = single string to an error 2022-06-29 17:04:34 -04:00
97e34f0667 better error strings 2022-06-29 17:04:23 -04:00
3e5da9b09a more consistency checks 2022-06-29 17:04:12 -04:00
a62fcca7a4 Boolean expression corner case 2022-06-29 17:04:01 -04:00
778d59fa6b whitespace 2022-06-29 05:19:10 -04:00
3833a85d7a Add missing grow to Kokkos unpack_exchange 2022-06-29 05:17:55 -04:00
6d961ab29f Fix small memory leak in SNAP 2022-06-29 05:17:46 -04:00
001824e0f6 Small tweaks 2022-06-29 05:17:36 -04:00
953d32f9b3 Prevent view bounds error when a proc has no atoms 2022-06-29 05:17:26 -04:00
edba922665 Add missing GPU <--> CPU data transfer in minimize Kokkos 2022-06-29 05:17:17 -04:00
53806d4601 Add more missing Kokkos data movement 2022-06-29 05:17:06 -04:00
67597722d5 intergrate references to dump cfg/uef into the dump command docs 2022-06-25 06:19:04 -04:00
337794a9e9 add crosscompiling with MPI support to plugins package 2022-06-24 06:52:08 -04:00
5f5fb895ff add "package" target to support building a windows installer with NSIS 2022-06-24 01:25:54 -04:00
0302d03bc6 must set thirdparty download URL variable for downloading MPICH4Win 2022-06-23 23:20:49 -04:00
0a4fef369f may check for MPI library Fortran support only if MPI is enabled 2022-06-23 15:57:54 -04:00
7d5fc356fe Merge pull request #3311 from akohlmey/next-stable-release
Update stable branch to next stable release
2022-06-22 17:33:34 -04:00
8103e5a18f Merge branch 'release' into next-stable-release 2022-06-22 16:29:19 -04:00
e5b56b67fe Merge branch 'next_patch_release' into next-stable-release 2022-06-21 09:00:40 -04:00
8ffb7e5f89 Merge branch 'collected-small-fixes' into next-stable-release 2022-06-21 09:00:31 -04:00
cb9ab48ce7 Merge branch 'develop' into next-stable-release 2022-06-21 09:00:12 -04:00
1ebb1cee40 Merge branch 'release' into next-stable-release 2022-06-02 21:49:47 -04:00
f0e7101bd2 Merge branch 'develop' into next-stable-release 2022-05-18 06:35:57 -04:00
6fd8b2b177 Merge pull request #3122 from akohlmey/maintenance-2021-09-29
Third round of maintenance fixes for the stable release
2022-03-24 14:20:52 -04:00
6edaf42b3d fix temperature initialization bug in KOKKOS nose-hoover code 2022-03-24 11:44:24 -04:00
79c047487d fix parallel execution bug for shell command 2022-03-24 07:38:44 -04:00
ac5acb9abf update threebody example 2022-03-24 07:31:02 -04:00
87fbbd3b13 small kokkos fixes from upstream 2022-03-24 07:18:24 -04:00
8ac0ec6473 Changes needed to compile LAMMPS with latest Kokkos develop 2022-03-24 06:09:03 -04:00
8acba74c4d correct input to load potential file from local folder 2022-03-22 22:32:39 -04:00
34bcbdf41d update extep potential file 2022-03-22 22:31:48 -04:00
d519ca0213 add missing reaxff files to purge list 2022-03-21 14:34:14 -04:00
a392e8dc09 accept infile with 0 lines, so we can create a template from the restart 2022-03-21 00:33:40 -04:00
a4d4f77bc2 run setup_bodies_dynamic() before processing infile in case that is not resetting all data 2022-03-21 00:32:49 -04:00
83a8f72d83 fix off-by-one bug when writing restart files for rigid bodies 2022-03-20 19:14:13 -04:00
3c54b56cfe update overlooked date stamp 2022-03-19 21:00:14 -04:00
ff1a08f148 fixes to CMake build for ML-QUIP package from upstream 2022-03-17 18:07:12 -04:00
5a53b0fc03 import python3 compatibility changes to tools/python from upstream 2022-03-16 13:24:53 -04:00
e550600ebe Error fixed. Epsilon and sigma must also be symmetric 2022-03-16 09:09:52 -04:00
7cb13be52a fix bug where it was not possible to use an absolute path for write_coeff 2022-03-16 09:08:47 -04:00
ab56d7ecd7 augment cmake library search path to include the CUDA stubs library folder
this will help configuring and compiling LAMMPS with CUDA support on
machines where there is no CUDA driver installed
2022-03-10 23:02:57 -05:00
bd6ac3ee6d for 2d systems, rigid bodies always have a moment of inertia and no DOFs need to be subtracted 2022-03-02 16:41:35 -05:00
27ca0a8f41 trigger building an "intel" style neighbor list so that buffers are allocated 2022-02-27 14:50:48 -05:00
f688b9b6b5 use consistent names, avoid memory leaks, fix off-by-1 error in fourier dihedral 2022-02-27 12:25:32 -05:00
16c61b3cc0 add support for plumed 2.6.5, 2.6.6, 2.7.3, 2.7.4, and 2.8.0 (default 2.7.4) 2022-02-25 16:37:00 -05:00
fb480f22fc make cythonize detection compatible with /bin/dash on ubunutu 2022-02-24 21:24:04 -05:00
d0507559a4 when updating ML-IAP due to adding/removing PYTHON we need to delete and re-add cythonize support 2022-02-24 20:40:55 -05:00
ali
58eb331b08 Python 3 compatibility for log commands in tools/python 2022-02-23 10:22:29 -05:00
c68015ca87 Bug fix for Intel package skip lists with multiple runs. 2022-02-18 05:11:34 -05:00
583c22d6e0 update tools/eam_database from upstream 2022-02-16 11:46:11 -05:00
58a4694d92 Remove incorrect error check in ReaxFF 2022-02-11 16:19:00 -05:00
97cf345528 don't allow exceptions to "escape" a destructor 2022-02-10 21:13:26 -05:00
0658abbdd4 silence possible warnings about missing files on "make clean-all" 2022-02-10 21:10:34 -05:00
72026a58bf make certain that "offset" is always initialized 2022-02-10 21:05:12 -05:00
7152231a10 plug memory leak 2022-02-10 20:56:51 -05:00
8fe8a667b6 update create.f with changes from NIST database
also add parameters for Cr and document in README file and change
the code to create output files with .eam.alloy extension
2022-02-10 20:45:16 -05:00
560c543e69 add extra communication of special neighbors when using angle constraints 2022-02-10 20:44:39 -05:00
c5e6650924 import bugfixes for crashes and memory leaks in MSM kspace style from develop 2022-02-10 20:36:35 -05:00
10373ea5c9 avoid failures with "most" presets 2022-02-10 20:11:00 -05:00
992b1cf582 label as update #3 2022-01-25 07:42:00 -05:00
1505f3de06 fix tag caching issue in INTEL package 2022-01-25 07:41:37 -05:00
566efe04f2 always fall back to using the .so extension if available in the LAMMPS module folder 2022-01-19 10:12:50 -05:00
7586adbb6a Merge pull request #3029 from akohlmey/maintenance-2021-09-29
Second round of maintenance fixes for the stable release
2022-01-06 19:58:51 -05:00
69d6ddccc5 create missing de,df table elements from linear extrapolation 2022-01-05 15:34:30 -05:00
5ae496dcef backport array dimension bugfix for NETCDF package in simplified form 2022-01-03 19:55:23 -05:00
bc5d742623 explain that the computed force in python pair is force/r same as in Pair:single() 2022-01-03 10:12:38 -05:00
882e699163 Incorporate bugfixes from issue #3074, a few additional cleanups 2022-01-03 10:11:18 -05:00
9c725d79d6 correct code example for current code 2022-01-01 16:42:28 -05:00
79fbf437a3 correct format string for Error::one() 2021-12-29 16:19:10 -05:00
d130aa4289 address segfault issue with fix nve/gpu when group is not "all" 2021-12-29 14:06:52 -05:00
5d8b83a251 backport GPU package build system updates from upstream 2021-12-27 20:30:43 -05:00
5a2548a83d have internal fix/compute ids include the fix id for fix reaxff/species
this allows using the fix multiple times
also remove code and warning that checks for multiple fix instances

# Conflicts:
#	src/REAXFF/fix_reaxff_species.cpp
2021-12-23 11:36:28 -05:00
a85b310e1f add missing fclose() 2021-12-23 11:28:24 -05:00
e51fd40547 correct names of the pack/unpack routines for forward communication 2021-12-09 18:33:13 -05:00
62f271658b correct setting forward/reverse buffer size info 2021-12-08 13:58:12 -05:00
0aa742934f correct docs for pair style local/density 2021-12-08 00:51:52 -05:00
a26a709a7b correct handling of data packing for forward and reverse communication 2021-12-08 00:51:52 -05:00
027293d285 whitespace 2021-11-24 15:47:05 -05:00
f7d049ac2d generate atom tags for newly created atoms, if tags are enabled. triclinic support. 2021-11-24 15:36:16 -05:00
ea0ff1c8f7 Update CMake utility function get_lammps_version()
With the introduction of LAMMPS_UPDATE, version.h is no longer a single line
file. With this change the CMake utility will only process the LAMMPS_VERSION
line. Fixes issue #3038
2021-11-23 10:44:40 -05:00
5c1bb5f13a Write dump header after sort to fix incorrect atom count for multiproc 2021-11-22 15:52:27 -05:00
24d9b4b611 Update lebedeva potential file and docs based on email on mailing list
https://matsci.org/t/lammps-users-webpage-and-parameter-file-for-the-lebedeva-potential/39059
2021-11-17 08:45:55 -05:00
a0e75c9006 correct unit description of eta_n0 parameters. fixes #3016 2021-11-17 08:38:09 -05:00
2435b953e1 increment update counter 2021-11-17 07:04:44 -05:00
c042e12323 clarifications and corrections for the discussion of the main git branches 2021-11-17 07:04:13 -05:00
e9efe46db9 update branch names 2021-11-17 07:03:56 -05:00
ecc14b7308 update documentation to refer to the new branch names (develop, release) 2021-11-17 07:03:27 -05:00
0152fe5cdf fix segfault when using atom style smd as part of a hybrid style
also remove redundant for clearing
2021-11-16 21:49:56 -05:00
892d17af22 plug memory leaks 2021-11-16 21:49:41 -05:00
2cca00203e Avoid file name collisions in dump unit tests
# Conflicts:
#	unittest/formats/test_dump_atom.cpp
2021-11-16 15:08:27 -05:00
9f4626a62a correct uninitialized data access bug due to shadowing of a base class member 2021-11-16 10:51:46 -05:00
e890a0b45e Merge pull request #2999 from akohlmey/maintenance-2021-09-29
Maintenance fixes for the stable release
2021-11-09 15:11:19 -05:00
68223f0385 mention that dump sorting is limited to less than 2 billion atoms 2021-11-07 08:31:15 -05:00
1291a88bff skip MPI tests if they would be oversubscribing the available processors 2021-11-07 08:30:19 -05:00
d9b687450a account for increased floating point errors when summing numbers to zero 2021-11-07 08:30:04 -05:00
bd950b37d7 change git:// protocol for accessing github to https:// protocol
https://github.blog/2021-09-01-improving-git-protocol-security-github/
2021-11-02 15:30:27 -04:00
21fcdf8c56 Fix bug in Kokkos neighborlist where stencil wasn't updated for occasional list 2021-11-02 13:17:28 -04:00
6b400fb4bf fix indexing bug 2021-10-31 16:19:17 -04:00
d982298ab2 update new LAMMPS paper citation info 2021-10-28 10:09:01 -04:00
765fd7f763 Use correct sizeof in memset 2021-10-27 17:46:37 -04:00
0325047c01 update a few GPU kernels so they can be compiled on GPUs without double precisions support 2021-10-21 07:34:05 -04:00
2dce8923ee more direct version of clearing out loaded plugins 2021-10-19 08:28:19 -04:00
8d1ba074be wipe out all loaded plugins before destroying the LAMMPS instance 2021-10-18 18:06:09 -04:00
4675a3b560 Only check for GPU double precision support if a GPU is present 2021-10-18 13:44:37 -04:00
8999b1f69f add a LAMMPS_UPDATE string define to signal updates to stable releases 2021-10-17 18:06:04 -04:00
6c2b19c11b Add support for an "Update #" appendix to the version string
This is for informative output only, so that any code depending
on the LAMMPS_VERSION define will not have to be changed and no
warnings will be printed etc.
2021-10-17 18:05:29 -04:00
a425334928 port dump vtk to correctly support custom per-atom arrays and fix some bugs 2021-10-17 11:00:33 -04:00
db2faf2789 fix bugs related to custom per-atom properties in dump style custom 2021-10-17 11:00:21 -04:00
fdbb7d0da4 Report only compatible GPU, i.e. no GPU if mixed/double precision is requested by the hardware does not support it 2021-10-15 20:26:47 -04:00
52cd99918f pppm kspace styles also require -DFFT_SINGLE when using GPUs in single precision 2021-10-15 20:24:47 -04:00
a3e6a95ffb allow single precision FFT introspection 2021-10-15 20:24:47 -04:00
5b65169997 correct expansion of fix/compute/variable arguments to avoid bogus thermo outpu 2021-10-15 20:23:57 -04:00
5f3bf69e30 plug memory leaks 2021-10-15 17:00:46 -04:00
507c02b9af must set define to "see" the lammps_open() library function 2021-10-09 10:21:31 -04:00
b7fe47ba48 Fix bugs and compilation issues in KOKKOS 2021-10-08 09:39:53 -04:00
7dfd11da4b re-freeze Sphinx and other pip installed packages for doc build
The change relative to the stable release fixes a bug with python 3.10 support
2021-10-05 10:52:34 -04:00
97ba95f30e fix a couple more bugs like in 5246cedda6 2021-10-05 10:39:03 -04:00
c1945b4ec9 Fix misplaced MPI calls bug in pair style drip 2021-10-04 07:12:50 -04:00
c4291a4b8e unfreeze versions of python packages used to build the documentation 2021-10-02 23:57:23 -04:00
5b5dfa86c5 also update eigen download for traditional build 2021-10-02 23:56:28 -04:00
3ca3f6959f update eigen3 to the latest release and move download to our own server 2021-10-02 22:55:06 -04:00
f7b7bfa406 Avoid assertions in PythonCapabilities check when using external KOKKOS 2021-10-01 12:05:59 -04:00
3d2f29c92d fix memory allocation bug causing memory corruption on 32-bit arches 2021-10-01 01:16:45 -04:00
2161 changed files with 257726 additions and 70086 deletions

3
.github/CODEOWNERS vendored
View File

@ -101,7 +101,8 @@ src/group.* @sjplimp
src/improper.* @sjplimp
src/info.* @akohlmey
src/kspace.* @sjplimp
src/lmptyp.h @sjplimp
src/lmptype.h @sjplimp
src/label_map.* @jrgissing @akohlmey
src/library.* @sjplimp @akohlmey
src/main.cpp @sjplimp
src/min_*.* @sjplimp

199
.github/release_steps.md vendored Normal file
View File

@ -0,0 +1,199 @@
# LAMMPS Release Steps
The following notes chronicle the current steps for preparing and
publishing LAMMPS releases. For definitions of LAMMPS versions and
releases, please refer to [the corresponding section in the LAMMPS
manual](https://docs.lammps.org/Manual_version.html).
## LAMMPS Feature Release
A LAMMPS feature release is currently prepared after about 500 to 750
commits to the 'develop' branch or after a period of four weeks up to
two months. This is not a fixed rule, though, since external
circumstances can cause delays in preparing a release, or pull requests
that are desired to be merged for the release are not yet completed.
### Preparing a 'next\_release' branch
Create a 'next\_release' branch off 'develop' and make the following changes:
- set the LAMMPS\_VERSION define to the planned release date in
src/version.h in the format "D Mmm YYYY" or "DD Mmm YYYY"
- remove the LAMMPS\_UPDATE define in src/version.h
- update the release date in doc/lammps.1
- update all TBD arguments for ..versionadded::, ..versionchanged::
..deprecated:: to the planned release date in the format "DMmmYYYY" or
"DDMmmYYYY"
- check release notes for merged new features and check if
..versionadded:: or ..versionchanged:: are missing and need to be
added
Submit this pull request, rebase if needed. This is the last pull
request merged for the release and should not contain any other
changes. (Exceptions: this document, last minute trivial(!) changes).
This PR shall not be merged before **all** pending tests have completed
and cleared. We currently use a mix of automated tests running on
either Temple's Jenkins cluster or GitHub workflows. Those include time
consuming tests not run on pull requests. If needed, a bugfix pull
request should be created and merged to clear all tests.
### Create release on GitHub
When all pending pull requests for the release are merged and have
cleared testing, the 'next\_release' branch is merged into 'develop'.
Check out or update the 'develop' branch locally, pull the latest
changes, merge them into 'release' with a fast forward(!) merge, and
apply a suitable release tag (for historical reasons the tag starts with
"patch_" followed by the date, and finally push everything back to
GitHub. There should be no commits made to 'release' but only
fast forward merges. Example:
```
git checkout develop
git pull
git checkout release
git pull
git merge --ff-only develop
git tag -s -m "LAMMPS feature release 19 November 2024" patch_19Nov2024
git push git@github.com:lammps/lammps.git --tags develop release
```
Applying this tag will trigger two actions on the Temple Jenkins cluster:
- The online manual at https://docs.lammps.org/ will be updated to the
state of the 'release' branch. Merges to the 'develop' branch will
trigger updating https://docs.lammps.org/latest/ so by reviewing the
version of the manual under the "latest" URL, it is possible to preview
what the updated release documentation will look like.
- A downloadable tar archive of the LAMMPS distribution that includes the
html format documentation and a PDF of the manual will be created and
uploaded to the download server at https://download.lammps.org/tars
Note that the file is added, but the `index.html` file is not updated,
so it is not yet publicly visible.
Go to https://github.com/lammps/lammps/releases and create a new (draft)
release page with a summary of all the changes included and references
to the pull requests they were merged from or check the existing draft
for any necessary changes from pull requests that were merged but are
not listed. Then select the applied tag for the release in the "Choose
a tag" dropdown list. Go to the bottom of the list and select the "Set
as pre-release" checkbox. The "Set as the latest release" button is
reserved for stable releases and updates to them.
If everything is in order, you can click on the "Publish release"
button. Otherwise, click on "Save draft" and finish pending tasks until
you can return to edit the release page and publish it.
### Prepare pre-compiled packages, update packages to GitHub
Build a fully static LAMMPS installation using a musl-libc
cross-compiler, install into a lammps-static folder, and create a
tarball called lammps-linux-x86_64-19Nov2024.tar.gz (or using a
corresponding date with a future release) from the lammps-static folder.
A suitable build environment is provided with the
https://download.lammps.org/static/fedora37_musl.sif container image.
``` sh
rm -rf release-packages
mkdir release-packages
cd release-packages
wget https://download.lammps.org/static/fedora41_musl.sif
apptainer shell fedora41_musl.sif
git clone -b release --depth 10 https://github.com/lammps/lammps.git lammps-release
cmake -S lammps-release/cmake -B build-release -G Ninja -D CMAKE_INSTALL_PREFIX=$PWD/lammps-static -D CMAKE_TOOLCHAIN_FILE=/usr/musl/share/cmake/linux-musl.cmake -C lammps-release/cmake/presets/most.cmake -C lammps-release/cmake/presets/kokkos-openmp.cmake -D DOWNLOAD_POTENTIALS=OFF -D BUILD_MPI=OFF -D BUILD_TESTING=OFF -D CMAKE_BUILD_TYPE=Release -D PKG_ATC=ON -D PKG_AWPMD=ON -D PKG_MANIFOLD=ON -D PKG_MESONT=ON -D PKG_MGPT=ON -D PKG_ML-PACE=ON -D PKG_ML-RANN=ON -D PKG_MOLFILE=ON -D PKG_PTM=ON -D PKG_QTB=ON -D PKG_SMTBQ=ON
cmake --build build-release --target all
cmake --build build-release --target install
/usr/musl/bin/x86_64-linux-musl-strip lammps-static/bin/*
tar -czvvf lammps-linux-x86_64-19Nov2024.tar.gz lammps-static
exit # fedora 41 container
```
The resulting tar archive can be uploaded to the GitHub release page with:
```
gh release upload patch_19Nov2024 lammps-linux-x86_64-19Nov2024.tar.gz
```
Make sure you have the `flatpak` and `flatpak-builder` packages
installed locally (they cannot be used from the container) and build a
LAMMPS and LAMMPS-GUI flatpak bundle in the `release-packages` folder
with:
``` sh
flatpak --user remote-add --if-not-exists flathub https://dl.flathub.org/repo/flathub.flatpakrepo
flatpak-builder --force-clean --verbose --repo=$PWD/flatpak-repo --install-deps-from=flathub --state-dir=$PWD --user --ccache --default-branch=release flatpak-build lammps-release/tools/lammps-gui/org.lammps.lammps-gui.yml
flatpak build-bundle --runtime-repo=https://flathub.org/repo/flathub.flatpakrepo --verbose $PWD/flatpak-repo LAMMPS-Linux-x86_64-GUI-19Nov2024.flatpak org.lammps.lammps-gui release
```
The resulting flatpak bundle file can be uploaded to the GitHub release page with:
```
gh release upload patch_19Nov2024 LAMMPS-Linux-x86_64-GUI-19Nov2024.flatpak
```
Also build serial executable packages that also include LAMMPS-GUI for
Linux, macOS, and Windows, and upload them to the GitHub release.
Clean up:
``` sh
cd ..
rm -r release-packages
```
TODO:
- add detailed commands for building GUI packages on Ubuntu 20.04LTS (move to 22.04LTS?),
macOS, and Windows cross-compiler and upload to GitHub
- build all Windows cross-compiled installer packages using lammps-packages repo
### Update download website
Check out the LAMMPS website repo
https://github.com/lammps/lammps-website.git and edit the file
`src/download.txt` for the new release. Test translation with `make
html` and review `html/download.html` Then add and commit to git and
push the changes to GitHub. The Temple Jenkis cluster will
automatically update https://www.lammps.org/download.html accordingly.
Notify Steve of the release so he can update `src/bug.txt` on the
website from the available release notes.
## LAMMPS Stable Release
A LAMMPS stable release is prepared about once per year in the months
July, August, or September. One (or two, if needed) feature releases
before the stable release shall contain only bug fixes or minor feature
updates in optional packages. Also substantial changes to the core of
the code shall be applied rather toward the beginning of a development
cycle between two stable releases than toward the end. The intention is
to stablilize significant change to the core and have outside users and
developers try them out during the development cycle; the sooner the
changes are included, the better chances for spotting peripheral bugs
and issues.
### Prerequesites
Before making a stable release all remaining backported bugfixes shall
be released as a (final) stable update release (see below).
A LAMMPS stable release process starts like a feature release (see
above), only that this feature release is called a "Stable Release
Candidate" and no assets are uploaded to GitHub.
### Synchronize 'maintenance' branch with 'release'
The state of the 'release' branch is then transferred to the
'maintenance' branch (which will have diverged significantly from
'release' due to the selectively backported bug fixes).
### Fast-forward merge of 'maintenance' into 'stable' and apply tag
At this point it should be possible to do a fast-forward merge of
'maintenance' to 'stable' and then apply the stable\_DMmmYYYY tag.
### Push branches and tags
## LAMMPS Stable Update Release

92
.github/workflows/check-cpp23.yml vendored Normal file
View File

@ -0,0 +1,92 @@
# GitHub action to build LAMMPS on Linux with gcc and C++23
name: "Check for C++23 Compatibility"
on:
push:
branches:
- develop
pull_request:
branches:
- develop
workflow_dispatch:
jobs:
build:
name: Build with C++23 support enabled
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache \
libeigen3-dev \
libcurl4-openssl-dev \
mold \
mpi-default-bin \
mpi-default-dev \
ninja-build \
python3-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-cpp23-ccache-${{ github.sha }}
restore-keys: linux-cpp23-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install numpy
python3 -m pip install pyyaml
cmake -S cmake -B build \
-C cmake/presets/most.cmake \
-C cmake/presets/kokkos-openmp.cmake \
-D CMAKE_CXX_STANDARD=23 \
-D CMAKE_CXX_COMPILER=g++ \
-D CMAKE_C_COMPILER=gcc \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D CMAKE_BUILD_TYPE=Debug \
-D CMAKE_CXX_FLAGS_DEBUG="-Og -g" \
-D DOWNLOAD_POTENTIALS=off \
-D BUILD_MPI=on \
-D BUILD_SHARED_LIBS=on \
-D BUILD_TOOLS=off \
-D ENABLE_TESTING=off \
-D MLIAP_ENABLE_ACE=on \
-D MLIAP_ENABLE_PYTHON=off \
-D PKG_AWPMD=on \
-D PKG_GPU=on \
-D GPU_API=opencl \
-D PKG_KOKKOS=on \
-D PKG_LATBOLTZ=on \
-D PKG_MDI=on \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=off \
-D PKG_MOLFILE=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s

89
.github/workflows/check-vla.yml vendored Normal file
View File

@ -0,0 +1,89 @@
# GitHub action to build LAMMPS on Linux with gcc and -Werror=vla
name: "Check for Variable Length Arrays"
on:
push:
branches:
- develop
pull_request:
branches:
- develop
workflow_dispatch:
jobs:
build:
name: Build with -Werror=vla
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache \
libeigen3-dev \
libcurl4-openssl-dev \
mold \
mpi-default-bin \
mpi-default-dev \
ninja-build \
python3-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-vla-ccache-${{ github.sha }}
restore-keys: linux-vla-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install numpy
python3 -m pip install pyyaml
cmake -S cmake -B build \
-C cmake/presets/most.cmake \
-D CMAKE_CXX_COMPILER=g++ \
-D CMAKE_C_COMPILER=gcc \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D CMAKE_BUILD_TYPE=Debug \
-D CMAKE_CXX_FLAGS_DEBUG="-Og -g -Werror=vla" \
-D DOWNLOAD_POTENTIALS=off \
-D BUILD_MPI=on \
-D BUILD_SHARED_LIBS=off \
-D BUILD_TOOLS=off \
-D ENABLE_TESTING=off \
-D MLIAP_ENABLE_ACE=on \
-D MLIAP_ENABLE_PYTHON=off \
-D PKG_AWPMD=on \
-D PKG_GPU=on \
-D GPU_API=opencl \
-D PKG_LATBOLTZ=on \
-D PKG_MDI=on \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=off \
-D PKG_MOLFILE=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s

View File

@ -1,5 +1,5 @@
# GitHub action to build LAMMPS on Windows with Visual C++
name: "Native Windows Compilation and Unit Tests"
# GitHub action to test LAMMPS on Windows with Visual C++
name: "Windows Unit Tests"
on:
push:
@ -11,11 +11,17 @@ on:
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: Windows Compilation Test
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: windows-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
steps:
- name: Checkout repository
@ -23,36 +29,41 @@ jobs:
with:
fetch-depth: 2
- name: Enable MSVC++
uses: lammps/setup-msvc-dev@v3
with:
arch: x64
- name: Install Ccache
run: |
choco install ccache ninja -y
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: win-unit-ccache-${{ github.sha }}
restore-keys: win-unit-ccache-
- name: Select Python version
uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m pip install numpy
python3 -m pip install pyyaml
nuget install MSMPIsdk
nuget install MSMPIDIST
cmake -C cmake/presets/windows.cmake \
-D DOWNLOAD_POTENTIALS=off \
-D PKG_PYTHON=on \
-D WITH_PNG=off \
-D WITH_JPEG=off \
-S cmake -B build \
-D BUILD_SHARED_LIBS=on \
-D LAMMPS_EXCEPTIONS=on \
-D ENABLE_TESTING=on
cmake --build build --config Release --parallel 2
cmake -C cmake\presets\windows.cmake -D CMAKE_CXX_COMPILER=cl -D CMAKE_CXX_COMPILER_LAUNCHER=ccache -D CMAKE_C_COMPILER=cl -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_Fortran_COMPILER="" -D DOWNLOAD_POTENTIALS=off -D PKG_PYTHON=on -D WITH_PNG=off -D WITH_JPEG=off -S cmake -B build -D BUILD_SHARED_LIBS=on -D ENABLE_TESTING=on -D CMAKE_BUILD_TYPE=Release -G Ninja
cmake --build build
ccache -s
- name: Run LAMMPS executable
shell: bash
run: |
./build/Release/lmp.exe -h
./build/Release/lmp.exe -in bench/in.lj
build\lmp.exe -h
build\lmp.exe -in bench\in.lj
- name: Run Unit Tests
working-directory: build
shell: bash
run: ctest -V -C Release -E FixTimestep:python_move_nve
run: ctest -V -E FixTimestep:python_move_nve

View File

@ -67,7 +67,6 @@ jobs:
-D PKG_MANIFOLD=on \
-D PKG_MDI=on \
-D PKG_MGPT=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=on \
-D PKG_MOLFILE=on \
-D PKG_NETCDF=on \

109
.github/workflows/full-regression.yml vendored Normal file
View File

@ -0,0 +1,109 @@
# GitHub action to build LAMMPS on Linux and run regression tests
name: "Full Regression Test"
on:
push:
branches:
- develop
workflow_dispatch:
jobs:
build:
name: Build LAMMPS
# restrict to official LAMMPS repository
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
strategy:
max-parallel: 8
matrix:
idx: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
show-progress: false
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache ninja-build libeigen3-dev \
libcurl4-openssl-dev python3-dev \
mpi-default-bin mpi-default-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-full-ccache-${{ github.sha }}
restore-keys: linux-full-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install numpy pyyaml junit_xml
cmake -S cmake -B build \
-C cmake/presets/gcc.cmake \
-C cmake/presets/most.cmake \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D BUILD_SHARED_LIBS=off \
-D DOWNLOAD_POTENTIALS=off \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s
- name: Run Full Regression Tests
shell: bash
run: |
source linuxenv/bin/activate
python3 tools/regression-tests/run_tests.py \
--lmp-bin=build/lmp \
--config-file=tools/regression-tests/config_serial.yaml \
--examples-top-level=examples --analyze --num-workers=8
python3 tools/regression-tests/run_tests.py \
--lmp-bin=build/lmp \
--config-file=tools/regression-tests/config_serial.yaml \
--list-input=input-list-${{ matrix.idx }}.txt \
--output-file=output-${{ matrix.idx }}.xml \
--progress-file=progress-${{ matrix.idx }}.yaml \
--log-file=run-${{ matrix.idx }}.log
tar -cvf full-regression-test-${{ matrix.idx }}.tar run-${{ matrix.idx }}.log progress-${{ matrix.idx }}.yaml output-${{ matrix.idx }}.xml
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: full-regression-test-artifact-${{ matrix.idx }}
path: full-regression-test-${{ matrix.idx }}.tar
merge:
runs-on: ubuntu-latest
needs: build
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: merged-full-regresssion-artifact
pattern: full-regression-test-artifact-*

126
.github/workflows/kokkos-regression.yaml vendored Normal file
View File

@ -0,0 +1,126 @@
# GitHub action to build LAMMPS on Linux and run selected regression tests
name: "Kokkos OpenMP Regression Test"
on:
push:
branches:
- develop
workflow_dispatch:
jobs:
build:
name: Build LAMMPS with Kokkos OpenMP
# restrict to official LAMMPS repository
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
strategy:
max-parallel: 6
matrix:
idx: [ 'pair-0', 'pair-1', 'fix-0', 'fix-1', 'compute', 'misc' ]
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
show-progress: false
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache ninja-build libeigen3-dev \
libcurl4-openssl-dev python3-dev \
mpi-default-bin mpi-default-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-kokkos-ccache-${{ github.sha }}
restore-keys: linux-kokkos-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install numpy pyyaml junit_xml
cmake -S cmake -B build \
-C cmake/presets/gcc.cmake \
-C cmake/presets/basic.cmake \
-C cmake/presets/kokkos-openmp.cmake \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D BUILD_SHARED_LIBS=off \
-D DOWNLOAD_POTENTIALS=off \
-D PKG_AMOEBA=on \
-D PKG_ASPHERE=on \
-D PKG_BROWNIAN=on \
-D PKG_CLASS2=on \
-D PKG_COLLOID=on \
-D PKG_CORESHELL=on \
-D PKG_DIPOLE=on \
-D PKG_DPD-BASIC=on \
-D PKG_EXTRA-COMPUTE=on \
-D PKG_EXTRA-FIX=on \
-D PKG_EXTRA-MOLECULE=on \
-D PKG_EXTRA-PAIR=on \
-D PKG_GRANULAR=on \
-D PKG_LEPTON=on \
-D PKG_MC=on \
-D PKG_MEAM=on \
-D PKG_POEMS=on \
-D PKG_PYTHON=on \
-D PKG_QEQ=on \
-D PKG_REAXFF=on \
-D PKG_REPLICA=on \
-D PKG_SRD=on \
-D PKG_SPH=on \
-D PKG_VORONOI=on \
-G Ninja
cmake --build build
ccache -s
- name: Run Regression Tests for Selected Examples
shell: bash
run: |
source linuxenv/bin/activate
python3 tools/regression-tests/get_kokkos_input.py \
--examples-top-level=examples --batch-size=50 \
--filter-out="balance;fire;gcmc;granregion;hyper;mc;mdi;mliap;neb;pace;prd;pour;python;rigid;snap;streitz;shear;ttm"
export OMP_PROC_BIND=false
python3 tools/regression-tests/run_tests.py \
--lmp-bin=build/lmp \
--config-file=tools/regression-tests/config_kokkos_openmp.yaml \
--list-input=input-list-${{ matrix.idx }}-kk.txt \
--output-file=output-${{ matrix.idx }}.xml \
--progress-file=progress-${{ matrix.idx }}.yaml \
--log-file=run-${{ matrix.idx }}.log \
--quick-max=100
tar -cvf kokkos-regression-test-${{ matrix.idx }}.tar run-${{ matrix.idx }}.log progress-${{ matrix.idx }}.yaml output-${{ matrix.idx }}.xml
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: kokkos-regression-test-artifact-${{ matrix.idx }}
path: kokkos-regression-test-${{ matrix.idx }}.tar
merge:
runs-on: ubuntu-latest
needs: build
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: merged-kokkos-regresssion-artifact
pattern: kokkos-regression-test-artifact-*

View File

@ -0,0 +1,53 @@
# GitHub action to build LAMMPS-GUI as a flatpak bundle
name: "Build LAMMPS-GUI as flatpak bundle"
on:
push:
branches:
- develop
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: LAMMPS-GUI flatpak build
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache \
libeigen3-dev \
libcurl4-openssl-dev \
mold \
ninja-build \
python3-dev \
flatpak \
flatpak-builder
- name: Set up access to flatpak repo
run: flatpak --user remote-add --if-not-exists flathub https://dl.flathub.org/repo/flathub.flatpakrepo
- name: Build flatpak
run: |
mkdir flatpack-state
sed -i -e 's/branch:.*/branch: develop/' tools/lammps-gui/org.lammps.lammps-gui.yml
flatpak-builder --force-clean --verbose --repo=flatpak-repo \
--install-deps-from=flathub --state-dir=flatpak-state \
--user --ccache --default-branch=${{ github.ref_name }} \
flatpak-build tools/lammps-gui/org.lammps.lammps-gui.yml
flatpak build-bundle --runtime-repo=https://flathub.org/repo/flathub.flatpakrepo \
--verbose flatpak-repo LAMMPS-Linux-x86_64-GUI.flatpak \
org.lammps.lammps-gui ${{ github.ref_name }}
flatpak install -y -v --user LAMMPS-Linux-x86_64-GUI.flatpak

118
.github/workflows/quick-regression.yml vendored Normal file
View File

@ -0,0 +1,118 @@
# GitHub action to build LAMMPS on Linux and run selected regression tests
name: "Quick Regression Test"
on:
pull_request:
branches:
- develop
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: Build LAMMPS
# restrict to official LAMMPS repository
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
strategy:
max-parallel: 4
matrix:
idx: [ 0, 1, 2, 3 ]
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0
show-progress: false
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache ninja-build libeigen3-dev \
libcurl4-openssl-dev python3-dev \
mpi-default-bin mpi-default-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-quick-ccache-${{ github.sha }}
restore-keys: linux-quick-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install numpy pyyaml junit_xml
cmake -S cmake -B build \
-C cmake/presets/gcc.cmake \
-C cmake/presets/most.cmake \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D BUILD_SHARED_LIBS=off \
-D DOWNLOAD_POTENTIALS=off \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s
- name: Run Regression Tests for Modified Styles
shell: bash
run: |
source linuxenv/bin/activate
python3 tools/regression-tests/run_tests.py \
--lmp-bin=build/lmp \
--config-file=tools/regression-tests/config_quick.yaml \
--examples-top-level=examples \
--quick-reference=tools/regression-tests/reference.yaml \
--quick --quick-branch=origin/develop --quick-max=100 --num-workers=4
if [ -f input-list-${{ matrix.idx }}.txt ]
then \
python3 tools/regression-tests/run_tests.py \
--lmp-bin=build/lmp \
--config-file=tools/regression-tests/config_quick.yaml \
--list-input=input-list-${{ matrix.idx }}.txt \
--output-file=output-${{ matrix.idx }}.xml \
--progress-file=progress-${{ matrix.idx }}.yaml \
--log-file=run-${{ matrix.idx }}.log
fi
tar -cvf quick-regression-test-${{ matrix.idx }}.tar run-${{ matrix.idx }}.log progress-${{ matrix.idx }}.yaml output-${{ matrix.idx }}.xml
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: quick-regression-test-artifact-${{ matrix.idx }}
path: quick-regression-test-${{ matrix.idx }}.tar
merge:
runs-on: ubuntu-latest
needs: build
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: merged-quick-regresssion-artifact
pattern: quick-regression-test-artifact-*

38
.github/workflows/style-check.yml vendored Normal file
View File

@ -0,0 +1,38 @@
# GitHub action to run checks from tools/coding_standard
name: "Check for Programming Style Conformance"
on:
push:
branches:
- develop
pull_request:
branches:
- develop
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: Programming Style Conformance
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Run Tests
working-directory: src
shell: bash
run: |
make check-whitespace
make check-permissions
make check-homepage
make check-errordocs
make check-fmtlib

81
.github/workflows/unittest-arm64.yml vendored Normal file
View File

@ -0,0 +1,81 @@
# GitHub action to build LAMMPS on Linux with ARM64 and run standard unit tests
name: "Unittest for Linux on ARM64"
on:
push:
branches: [develop]
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: Linux ARM64 Unit Test
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-22.04-arm
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache \
libeigen3-dev \
libcurl4-openssl-dev \
mold \
ninja-build \
python3-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-unit-ccache-${{ github.sha }}
restore-keys: linux-unit-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install numpy
python3 -m pip install pyyaml
cmake -S cmake -B build \
-C cmake/presets/gcc.cmake \
-C cmake/presets/most.cmake \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D BUILD_SHARED_LIBS=on \
-D DOWNLOAD_POTENTIALS=off \
-D ENABLE_TESTING=on \
-D MLIAP_ENABLE_ACE=on \
-D MLIAP_ENABLE_PYTHON=off \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s
- name: Run Tests
working-directory: build
shell: bash
run: ctest -V -LE unstable

86
.github/workflows/unittest-linux.yml vendored Normal file
View File

@ -0,0 +1,86 @@
# GitHub action to build LAMMPS on Linux and run standard unit tests
name: "Unittest for Linux /w LAMMPS_BIGBIG"
on:
push:
branches:
- develop
pull_request:
branches:
- develop
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: Linux Unit Test
if: ${{ github.repository == 'lammps/lammps' }}
runs-on: ubuntu-latest
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 2
- name: Install extra packages
run: |
sudo apt-get update
sudo apt-get install -y ccache \
libeigen3-dev \
libcurl4-openssl-dev \
mold \
ninja-build \
python3-dev
- name: Create Build Environment
run: mkdir build
- name: Set up ccache
uses: actions/cache@v4
with:
path: ${{ env.CCACHE_DIR }}
key: linux-unit-ccache-${{ github.sha }}
restore-keys: linux-unit-ccache-
- name: Building LAMMPS via CMake
shell: bash
run: |
ccache -z
python3 -m venv linuxenv
source linuxenv/bin/activate
python3 -m pip install numpy
python3 -m pip install pyyaml
cmake -S cmake -B build \
-C cmake/presets/gcc.cmake \
-C cmake/presets/most.cmake \
-D CMAKE_CXX_COMPILER_LAUNCHER=ccache \
-D CMAKE_C_COMPILER_LAUNCHER=ccache \
-D BUILD_SHARED_LIBS=on \
-D LAMMPS_SIZES=bigbig \
-D DOWNLOAD_POTENTIALS=off \
-D ENABLE_TESTING=on \
-D MLIAP_ENABLE_ACE=on \
-D MLIAP_ENABLE_PYTHON=off \
-D PKG_MANIFOLD=on \
-D PKG_ML-PACE=on \
-D PKG_ML-RANN=on \
-D PKG_RHEO=on \
-D PKG_PTM=on \
-D PKG_PYTHON=on \
-D PKG_QTB=on \
-D PKG_SMTBQ=on \
-G Ninja
cmake --build build
ccache -s
- name: Run Tests
working-directory: build
shell: bash
run: ctest -V

View File

@ -11,6 +11,10 @@ on:
workflow_dispatch:
concurrency:
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{github.event_name == 'pull_request'}}
jobs:
build:
name: MacOS Unit Test

View File

@ -3,6 +3,9 @@
# CMake build system
# This file is part of LAMMPS
cmake_minimum_required(VERSION 3.16)
if(CMAKE_VERSION VERSION_LESS 3.20)
message(WARNING "LAMMPS is planning to require at least CMake version 3.20 by Summer 2025. Please upgrade!")
endif()
########################################
# set policy to silence warnings about ignoring <PackageName>_ROOT but use it
if(POLICY CMP0074)
@ -118,7 +121,7 @@ endif()
# silence excessive warnings for new Intel Compilers
if(CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM")
set(CMAKE_TUNE_DEFAULT "-Wno-tautological-constant-compare -Wno-unused-command-line-argument")
set(CMAKE_TUNE_DEFAULT "-fp-model precise -Wno-tautological-constant-compare -Wno-unused-command-line-argument")
endif()
# silence excessive warnings for PGI/NVHPC compilers
@ -141,19 +144,31 @@ endif()
# silence nvcc warnings
if((PKG_KOKKOS) AND (Kokkos_ENABLE_CUDA) AND NOT (CMAKE_CXX_COMPILER_ID STREQUAL "Clang"))
set(CMAKE_TUNE_DEFAULT "${CMAKE_TUNE_DEFAULT} -Xcudafe --diag_suppress=unrecognized_pragma")
set(CMAKE_TUNE_DEFAULT "${CMAKE_TUNE_DEFAULT}" "-Xcudafe --diag_suppress=unrecognized_pragma,--diag_suppress=128")
endif()
# we require C++11 without extensions. Kokkos requires at least C++17 (currently)
# we *require* C++11 without extensions but prefer C++17.
# Kokkos requires at least C++17 (currently)
if(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 11)
if(cxx_std_17 IN_LIST CMAKE_CXX_COMPILE_FEATURES)
set(CMAKE_CXX_STANDARD 17)
else()
set(CMAKE_CXX_STANDARD 11)
endif()
endif()
if(CMAKE_CXX_STANDARD LESS 11)
message(FATAL_ERROR "C++ standard must be set to at least 11")
endif()
if(CMAKE_CXX_STANDARD LESS 17)
message(WARNING "Selecting C++17 standard is preferred over C++${CMAKE_CXX_STANDARD}")
endif()
if(PKG_KOKKOS AND (CMAKE_CXX_STANDARD LESS 17))
set(CMAKE_CXX_STANDARD 17)
endif()
# turn off C++17 check in lmptype.h
if(LAMMPS_CXX11)
add_compile_definitions(LAMMPS_CXX11)
endif()
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF CACHE BOOL "Use compiler extensions")
# ugly hacks for MSVC which by default always reports an old C++ standard in the __cplusplus macro
@ -165,6 +180,7 @@ if(MSVC)
add_compile_options(/wd4267)
add_compile_options(/wd4250)
add_compile_options(/EHsc)
add_compile_options(/utf-8)
endif()
add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
endif()
@ -346,6 +362,17 @@ foreach(PKG ${STANDARD_PACKAGES} ${SUFFIX_PACKAGES})
option(PKG_${PKG} "Build ${PKG} Package" OFF)
endforeach()
set(DEPRECATED_PACKAGES AWPMD ATC POEMS)
foreach(PKG ${DEPRECATED_PACKAGES})
if(PKG_${PKG})
message(WARNING
"The ${PKG} package will be removed from LAMMPS in Summer 2025 due to lack of "
"maintenance and use of code constructs that conflict with modern C++ compilers "
"and standards. Please contact developers@lammps.org if you have any concerns "
"about this step.")
endif()
endforeach()
######################################################
# packages with special compiler needs or external libs
######################################################
@ -474,13 +501,13 @@ if(BUILD_OMP)
if(CMAKE_VERSION VERSION_LESS 3.28)
get_filename_component(_exe "${CMAKE_CXX_COMPILER}" NAME)
if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang") AND (_exe STREQUAL "crayCC"))
set(CMAKE_SHARED_LINKER_FLAGS_${BTYPE} "${CMAKE_SHARED_LINKER_FLAGS_${BTYPE} -fopenmp")
set(CMAKE_STATIC_LINKER_FLAGS_${BTYPE} "${CMAKE_STATIC_LINKER_FLAGS_${BTYPE} -fopenmp")
set(CMAKE_SHARED_LINKER_FLAGS_${BTYPE} "${CMAKE_SHARED_LINKER_FLAGS_${BTYPE}} -fopenmp")
set(CMAKE_STATIC_LINKER_FLAGS_${BTYPE} "${CMAKE_STATIC_LINKER_FLAGS_${BTYPE}} -fopenmp")
endif()
else()
if(CMAKE_CXX_COMPILER_ID STREQUAL "CrayClang")
set(CMAKE_SHARED_LINKER_FLAGS_${BTYPE} "${CMAKE_SHARED_LINKER_FLAGS_${BTYPE} -fopenmp")
set(CMAKE_STATIC_LINKER_FLAGS_${BTYPE} "${CMAKE_STATIC_LINKER_FLAGS_${BTYPE} -fopenmp")
set(CMAKE_SHARED_LINKER_FLAGS_${BTYPE} "${CMAKE_SHARED_LINKER_FLAGS_${BTYPE}} -fopenmp")
set(CMAKE_STATIC_LINKER_FLAGS_${BTYPE} "${CMAKE_STATIC_LINKER_FLAGS_${BTYPE}} -fopenmp")
endif()
endif()
endif()
@ -497,7 +524,7 @@ if((CMAKE_CXX_COMPILER_ID STREQUAL "Intel") AND (CMAKE_CXX_STANDARD GREATER_EQUA
PROPERTIES COMPILE_OPTIONS "-std=c++14")
endif()
if(PKG_ATC OR PKG_AWPMD OR PKG_ML-QUIP OR PKG_ML-POD OR PKG_ELECTRODE OR BUILD_TOOLS)
if(PKG_ATC OR PKG_AWPMD OR PKG_ML-QUIP OR PKG_ML-POD OR PKG_ELECTRODE OR PKG_RHEO OR BUILD_TOOLS)
enable_language(C)
if (NOT USE_INTERNAL_LINALG)
find_package(LAPACK)
@ -515,14 +542,6 @@ if(PKG_ATC OR PKG_AWPMD OR PKG_ML-QUIP OR PKG_ML-POD OR PKG_ELECTRODE OR BUILD_T
endif()
endif()
find_package(CURL QUIET COMPONENTS HTTP HTTPS)
option(WITH_CURL "Enable libcurl support" ${CURL_FOUND})
if(WITH_CURL)
find_package(CURL REQUIRED COMPONENTS HTTP HTTPS)
target_compile_definitions(lammps PRIVATE -DLAMMPS_CURL)
target_link_libraries(lammps PRIVATE CURL::libcurl)
endif()
# tweak jpeg library names to avoid linker errors with MinGW cross-compilation
set(JPEG_NAMES libjpeg libjpeg-62)
find_package(JPEG QUIET)
@ -580,12 +599,22 @@ else()
endif()
foreach(PKG_WITH_INCL KSPACE PYTHON ML-IAP VORONOI COLVARS ML-HDNNP MDI MOLFILE NETCDF
PLUMED QMMM ML-QUIP SCAFACOS MACHDYN VTK KIM COMPRESS ML-PACE LEPTON RHEO)
PLUMED QMMM ML-QUIP SCAFACOS MACHDYN VTK KIM COMPRESS ML-PACE LEPTON EXTRA-COMMAND)
if(PKG_${PKG_WITH_INCL})
include(Packages/${PKG_WITH_INCL})
endif()
endforeach()
# settings for misc packages and styles
if(PKG_MISC)
option(LAMMPS_ASYNC_IMD "Asynchronous IMD processing" OFF)
mark_as_advanced(LAMMPS_ASYNC_IMD)
if(LAMMPS_ASYNC_IMD)
target_compile_definitions(lammps PRIVATE -DLAMMPS_ASYNC_IMD)
message(STATUS "Using IMD in asynchronous mode")
endif()
endif()
# optionally enable building script wrappers using swig
option(WITH_SWIG "Build scripting language wrappers with SWIG" OFF)
if(WITH_SWIG)
@ -595,13 +624,8 @@ endif()
set(CMAKE_TUNE_FLAGS "${CMAKE_TUNE_DEFAULT}" CACHE STRING "Compiler and machine specific optimization flags (compilation only)")
separate_arguments(CMAKE_TUNE_FLAGS)
foreach(_FLAG ${CMAKE_TUNE_FLAGS})
target_compile_options(lammps PRIVATE ${_FLAG})
# skip these flags when linking the main executable
if(NOT (("${_FLAG}" STREQUAL "-Xcudafe") OR (("${_FLAG}" STREQUAL "--diag_suppress=unrecognized_pragma"))))
target_compile_options(lmp PRIVATE ${_FLAG})
endif()
endforeach()
target_compile_options(lammps PRIVATE ${CMAKE_TUNE_FLAGS})
target_compile_options(lmp PRIVATE ${CMAKE_TUNE_FLAGS})
########################################################################
# Basic system tests (standard libraries, headers, functions, types) #
########################################################################
@ -830,9 +854,15 @@ foreach(_DEF ${LAMMPS_DEFINES})
set(LAMMPS_API_DEFINES "${LAMMPS_API_DEFINES} -D${_DEF}")
endforeach()
if(BUILD_SHARED_LIBS)
install(TARGETS lammps EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
install(TARGETS lammps EXPORT LAMMPS_Targets
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
if(NOT BUILD_MPI)
install(TARGETS mpi_stubs EXPORT LAMMPS_Targets LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})
install(TARGETS mpi_stubs EXPORT LAMMPS_Targets
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
endif()
configure_file(pkgconfig/liblammps.pc.in ${CMAKE_CURRENT_BINARY_DIR}/liblammps${LAMMPS_MACHINE}.pc @ONLY)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/liblammps${LAMMPS_MACHINE}.pc DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
@ -973,6 +1003,9 @@ message(STATUS "<<< Compilers and Flags: >>>
C++ Standard: ${CMAKE_CXX_STANDARD}
C++ Flags: ${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_${BTYPE}}
Defines: ${DEFINES}")
if(CMAKE_CXX_COMPILER_LAUNCHER)
message(STATUS " Launcher: ${CMAKE_CXX_COMPILER_LAUNCHER}")
endif()
get_target_property(OPTIONS lammps COMPILE_OPTIONS)
if(OPTIONS)
message(" Options: ${OPTIONS}")
@ -991,6 +1024,9 @@ if(_index GREATER -1)
Type: ${CMAKE_C_COMPILER_ID}
Version: ${CMAKE_C_COMPILER_VERSION}
C Flags: ${CMAKE_C_FLAGS} ${CMAKE_C_FLAGS_${BTYPE}}")
if(CMAKE_C_COMPILER_LAUNCHER)
message(STATUS " Launcher: ${CMAKE_C_COMPILER_LAUNCHER}")
endif()
endif()
message(STATUS "<<< Linker flags: >>>")
message(STATUS "Executable name: ${LAMMPS_BINARY}")
@ -1078,12 +1114,15 @@ if(BUILD_TOOLS)
message(STATUS "<<< Building Tools >>>")
endif()
if(BUILD_LAMMPS_GUI)
message(STATUS "<<< Building LAMMPS GUI >>>")
message(STATUS "<<< Building LAMMPS-GUI >>>")
if(LAMMPS_GUI_USE_PLUGIN)
message(STATUS "Loading LAMMPS library as plugin at run time")
else()
message(STATUS "Linking LAMMPS library at compile time")
endif()
if(BUILD_WHAM)
message(STATUS "<<< Building WHAM >>>")
endif()
endif()
if(ENABLE_TESTING)
message(STATUS "<<< Building Unit Tests >>>")

View File

@ -4,6 +4,8 @@
option(BUILD_DOC "Build LAMMPS HTML documentation" OFF)
if(BUILD_DOC)
option(BUILD_DOC_VENV "Build LAMMPS documentation virtual environment" ON)
mark_as_advanced(BUILD_DOC_VENV)
# Current Sphinx versions require at least Python 3.8
# use default (or custom) Python executable, if version is sufficient
if(Python_VERSION VERSION_GREATER_EQUAL 3.8)
@ -18,14 +20,6 @@ if(BUILD_DOC)
find_package(Doxygen 1.8.10 REQUIRED)
file(GLOB DOC_SOURCES CONFIGURE_DEPENDS ${LAMMPS_DOC_DIR}/src/[^.]*.rst)
add_custom_command(
OUTPUT docenv
COMMAND ${VIRTUALENV} docenv
)
set(DOCENV_BINARY_DIR ${CMAKE_BINARY_DIR}/docenv/bin)
set(DOCENV_REQUIREMENTS_FILE ${LAMMPS_DOC_DIR}/utils/requirements.txt)
set(SPHINX_CONFIG_DIR ${LAMMPS_DOC_DIR}/utils/sphinx-config)
set(SPHINX_CONFIG_FILE_TEMPLATE ${SPHINX_CONFIG_DIR}/conf.py.in)
set(SPHINX_STATIC_DIR ${SPHINX_CONFIG_DIR}/_static)
@ -44,14 +38,32 @@ if(BUILD_DOC)
# configure paths in conf.py, since relative paths change when file is copied
configure_file(${SPHINX_CONFIG_FILE_TEMPLATE} ${DOC_BUILD_CONFIG_FILE})
add_custom_command(
OUTPUT ${DOC_BUILD_DIR}/requirements.txt
DEPENDS docenv ${DOCENV_REQUIREMENTS_FILE}
COMMAND ${CMAKE_COMMAND} -E copy ${DOCENV_REQUIREMENTS_FILE} ${DOC_BUILD_DIR}/requirements.txt
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install --upgrade pip
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install --upgrade ${LAMMPS_DOC_DIR}/utils/converters
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install -r ${DOC_BUILD_DIR}/requirements.txt --upgrade
)
if(BUILD_DOC_VENV)
add_custom_command(
OUTPUT docenv
COMMAND ${VIRTUALENV} docenv
)
set(DOCENV_BINARY_DIR ${CMAKE_BINARY_DIR}/docenv/bin)
set(DOCENV_REQUIREMENTS_FILE ${LAMMPS_DOC_DIR}/utils/requirements.txt)
add_custom_command(
OUTPUT ${DOC_BUILD_DIR}/requirements.txt
DEPENDS docenv ${DOCENV_REQUIREMENTS_FILE}
COMMAND ${CMAKE_COMMAND} -E copy ${DOCENV_REQUIREMENTS_FILE} ${DOC_BUILD_DIR}/requirements.txt
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install --upgrade pip
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install --upgrade ${LAMMPS_DOC_DIR}/utils/converters
COMMAND ${DOCENV_BINARY_DIR}/pip $ENV{PIP_OPTIONS} install -r ${DOC_BUILD_DIR}/requirements.txt --upgrade
)
set(DOCENV_DEPS docenv ${DOC_BUILD_DIR}/requirements.txt)
if(NOT TARGET Sphinx::sphinx-build)
add_executable(Sphinx::sphinx-build IMPORTED GLOBAL)
set_target_properties(Sphinx::sphinx-build PROPERTIES IMPORTED_LOCATION "${DOCENV_BINARY_DIR}/sphinx-build")
endif()
else()
find_package(Sphinx)
endif()
set(MATHJAX_URL "https://github.com/mathjax/MathJax/archive/3.1.3.tar.gz" CACHE STRING "URL for MathJax tarball")
set(MATHJAX_MD5 "b81661c6e6ba06278e6ae37b30b0c492" CACHE STRING "MD5 checksum of MathJax tarball")
@ -97,8 +109,9 @@ if(BUILD_DOC)
endif()
add_custom_command(
OUTPUT html
DEPENDS ${DOC_SOURCES} docenv ${DOC_BUILD_DIR}/requirements.txt ${DOXYGEN_XML_DIR}/index.xml ${BUILD_DOC_CONFIG_FILE}
COMMAND ${DOCENV_BINARY_DIR}/sphinx-build ${SPHINX_EXTRA_OPTS} -b html -c ${DOC_BUILD_DIR} -d ${DOC_BUILD_DIR}/doctrees ${LAMMPS_DOC_DIR}/src ${DOC_BUILD_DIR}/html
DEPENDS ${DOC_SOURCES} ${DOCENV_DEPS} ${DOXYGEN_XML_DIR}/index.xml ${BUILD_DOC_CONFIG_FILE}
COMMAND ${Python3_EXECUTABLE} ${LAMMPS_DOC_DIR}/utils/make-globbed-tocs.py -d ${LAMMPS_DOC_DIR}/src
COMMAND Sphinx::sphinx-build ${SPHINX_EXTRA_OPTS} -b html -c ${DOC_BUILD_DIR} -d ${DOC_BUILD_DIR}/doctrees ${LAMMPS_DOC_DIR}/src ${DOC_BUILD_DIR}/html
COMMAND ${CMAKE_COMMAND} -E create_symlink Manual.html ${DOC_BUILD_DIR}/html/index.html
COMMAND ${CMAKE_COMMAND} -E copy_directory ${LAMMPS_DOC_DIR}/src/PDF ${DOC_BUILD_DIR}/html/PDF
COMMAND ${CMAKE_COMMAND} -E remove -f ${DOXYGEN_XML_DIR}/run.stamp

View File

@ -0,0 +1,29 @@
# Find sphinx-build
find_program(Sphinx_EXECUTABLE NAMES sphinx-build
PATH_SUFFIXES bin
DOC "Sphinx documenation build executable")
mark_as_advanced(Sphinx_EXECUTABLE)
if(Sphinx_EXECUTABLE)
execute_process(COMMAND ${Sphinx_EXECUTABLE} --version
OUTPUT_VARIABLE sphinx_version
OUTPUT_STRIP_TRAILING_WHITESPACE
RESULT_VARIABLE _sphinx_version_result)
if(_sphinx_version_result)
message(WARNING "Unable to determine sphinx-build verison: ${_sphinx_version_result}")
else()
string(REGEX REPLACE "sphinx-build ([0-9.]+).*"
"\\1"
Sphinx_VERSION
"${sphinx_version}")
endif()
if(NOT TARGET Sphinx::sphinx-build)
add_executable(Sphinx::sphinx-build IMPORTED GLOBAL)
set_target_properties(Sphinx::sphinx-build PROPERTIES IMPORTED_LOCATION "${Sphinx_EXECUTABLE}")
endif()
endif()
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Sphinx REQUIRED_VARS Sphinx_EXECUTABLE VERSION_VAR Sphinx_VERSION)

View File

@ -21,9 +21,9 @@ if(VORO_FOUND)
set(VORO_LIBRARIES ${VORO_LIBRARY})
set(VORO_INCLUDE_DIRS ${VORO_INCLUDE_DIR})
if(NOT TARGET VORO::VORO)
add_library(VORO::VORO UNKNOWN IMPORTED)
set_target_properties(VORO::VORO PROPERTIES
if(NOT TARGET VORO::voro++)
add_library(VORO::voro++ UNKNOWN IMPORTED)
set_target_properties(VORO::voro++ PROPERTIES
IMPORTED_LOCATION "${VORO_LIBRARY}"
INTERFACE_INCLUDE_DIRECTORIES "${VORO_INCLUDE_DIR}")
endif()

View File

@ -0,0 +1,10 @@
# the geturl command needs libcurl
find_package(CURL QUIET COMPONENTS HTTP HTTPS)
option(WITH_CURL "Enable libcurl support" ${CURL_FOUND})
if(WITH_CURL)
find_package(CURL REQUIRED COMPONENTS HTTP HTTPS)
target_compile_definitions(lammps PRIVATE -DLAMMPS_CURL)
target_link_libraries(lammps PRIVATE CURL::libcurl)
endif()

View File

@ -3,7 +3,7 @@ enable_language(C)
# we don't use the parallel i/o interface.
set(HDF5_PREFER_PARALLEL FALSE)
find_package(HDF5 REQUIRED)
find_package(HDF5 COMPONENTS C REQUIRED)
# parallel HDF5 will import incompatible MPI headers with a serial build
if((NOT BUILD_MPI) AND HDF5_IS_PARALLEL)

View File

@ -72,6 +72,10 @@ if(INTEL_ARCH STREQUAL "KNL")
if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
message(FATAL_ERROR "Must use Intel compiler with INTEL for KNL architecture")
endif()
message(WARNING, "Support for Intel Xeon Phi accelerators and Knight's Landing CPUs "
"will be removed from LAMMPS in Summer 2025 due to lack of available machines "
"in labs and HPC centers and removed support in recent compilers "
"Please contact developers@lammps.org if you have any concerns about this step.")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -xHost -qopenmp -qoffload")
set(MIC_OPTIONS "-qoffload-option,mic,compiler,\"-fp-model fast=2 -mGLOB_default_function_attrs=\\\"gather_scatter_loop_unroll=4\\\"\"")
target_compile_options(lammps PRIVATE -xMIC-AVX512 -qoffload -fno-alias -ansi-alias -restrict -qoverride-limits ${MIC_OPTIONS})

View File

@ -7,10 +7,13 @@ endif()
########################################################################
# consistency checks and Kokkos options/settings required by LAMMPS
if(Kokkos_ENABLE_CUDA)
message(STATUS "KOKKOS: Enabling CUDA LAMBDA function support")
set(Kokkos_ENABLE_CUDA_LAMBDA ON CACHE BOOL "" FORCE)
if(Kokkos_ENABLE_HIP)
option(Kokkos_ENABLE_HIP_MULTIPLE_KERNEL_INSTANTIATIONS "Enable multiple kernel instantiations with HIP" ON)
mark_as_advanced(Kokkos_ENABLE_HIP_MULTIPLE_KERNEL_INSTANTIATIONS)
option(Kokkos_ENABLE_ROCTHRUST "Use RoCThrust library" ON)
mark_as_advanced(Kokkos_ENABLE_ROCTHRUST)
endif()
# Adding OpenMP compiler flags without the checks done for
# BUILD_OMP can result in compile failures. Enforce consistency.
if(Kokkos_ENABLE_OPENMP)
@ -18,6 +21,15 @@ if(Kokkos_ENABLE_OPENMP)
message(FATAL_ERROR "Must enable BUILD_OMP with Kokkos_ENABLE_OPENMP")
endif()
endif()
if(Kokkos_ENABLE_SERIAL)
if(NOT (Kokkos_ENABLE_OPENMP OR Kokkos_ENABLE_THREADS OR
Kokkos_ENABLE_CUDA OR Kokkos_ENABLE_HIP OR Kokkos_ENABLE_SYCL
OR Kokkos_ENABLE_OPENMPTARGET))
option(Kokkos_ENABLE_ATOMICS_BYPASS "Disable atomics for Kokkos Serial Backend" ON)
mark_as_advanced(Kokkos_ENABLE_ATOMICS_BYPASS)
endif()
endif()
########################################################################
option(EXTERNAL_KOKKOS "Build against external kokkos library" OFF)
@ -45,8 +57,8 @@ if(DOWNLOAD_KOKKOS)
list(APPEND KOKKOS_LIB_BUILD_ARGS "-DCMAKE_CXX_EXTENSIONS=${CMAKE_CXX_EXTENSIONS}")
list(APPEND KOKKOS_LIB_BUILD_ARGS "-DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}")
include(ExternalProject)
set(KOKKOS_URL "https://github.com/kokkos/kokkos/archive/4.3.01.tar.gz" CACHE STRING "URL for KOKKOS tarball")
set(KOKKOS_MD5 "243de871b3dc2cf3990c1c404032df83" CACHE STRING "MD5 checksum of KOKKOS tarball")
set(KOKKOS_URL "https://github.com/kokkos/kokkos/archive/4.5.01.tar.gz" CACHE STRING "URL for KOKKOS tarball")
set(KOKKOS_MD5 "4d832aa0284169d9e3fbae3165286bc6" CACHE STRING "MD5 checksum of KOKKOS tarball")
mark_as_advanced(KOKKOS_URL)
mark_as_advanced(KOKKOS_MD5)
GetFallbackURL(KOKKOS_URL KOKKOS_FALLBACK)
@ -71,7 +83,7 @@ if(DOWNLOAD_KOKKOS)
add_dependencies(LAMMPS::KOKKOSCORE kokkos_build)
add_dependencies(LAMMPS::KOKKOSCONTAINERS kokkos_build)
elseif(EXTERNAL_KOKKOS)
find_package(Kokkos 4.3.01 REQUIRED CONFIG)
find_package(Kokkos 4.5.01 REQUIRED CONFIG)
target_link_libraries(lammps PRIVATE Kokkos::kokkos)
else()
set(LAMMPS_LIB_KOKKOS_SRC_DIR ${LAMMPS_LIB_SOURCE_DIR}/kokkos)
@ -127,7 +139,7 @@ if(PKG_KSPACE)
${KOKKOS_PKG_SOURCES_DIR}/grid3d_kokkos.cpp
${KOKKOS_PKG_SOURCES_DIR}/remap_kokkos.cpp)
set(FFT_KOKKOS "KISS" CACHE STRING "FFT library for Kokkos-enabled KSPACE package")
set(FFT_KOKKOS_VALUES KISS FFTW3 MKL HIPFFT CUFFT)
set(FFT_KOKKOS_VALUES KISS FFTW3 MKL NVPL HIPFFT CUFFT MKL_GPU)
set_property(CACHE FFT_KOKKOS PROPERTY STRINGS ${FFT_KOKKOS_VALUES})
validate_option(FFT_KOKKOS FFT_KOKKOS_VALUES)
string(TOUPPER ${FFT_KOKKOS} FFT_KOKKOS)
@ -137,10 +149,8 @@ if(PKG_KSPACE)
message(FATAL_ERROR "The CUDA backend of Kokkos requires either KISS FFT or CUFFT.")
elseif(FFT_KOKKOS STREQUAL "KISS")
message(WARNING "Using KISS FFT with the CUDA backend of Kokkos may be sub-optimal.")
target_compile_definitions(lammps PRIVATE -DFFT_KOKKOS_KISS)
elseif(FFT_KOKKOS STREQUAL "CUFFT")
find_package(CUDAToolkit REQUIRED)
target_compile_definitions(lammps PRIVATE -DFFT_KOKKOS_CUFFT)
target_link_libraries(lammps PRIVATE CUDA::cufft)
endif()
elseif(Kokkos_ENABLE_HIP)
@ -152,10 +162,21 @@ if(PKG_KSPACE)
elseif(FFT_KOKKOS STREQUAL "HIPFFT")
include(DetectHIPInstallation)
find_package(hipfft REQUIRED)
target_compile_definitions(lammps PRIVATE -DFFT_KOKKOS_HIPFFT)
target_link_libraries(lammps PRIVATE hip::hipfft)
endif()
elseif(FFT_KOKKOS STREQUAL "MKL_GPU")
if(NOT Kokkos_ENABLE_SYCL)
message(FATAL_ERROR "Using MKL_GPU FFT currently requires the SYCL backend of Kokkos.")
endif()
find_package(MKL REQUIRED)
target_link_libraries(lammps PRIVATE mkl_sycl_dft mkl_intel_ilp64 mkl_tbb_thread mkl_core tbb)
elseif(FFT_KOKKOS STREQUAL "MKL")
find_package(MKL REQUIRED)
elseif(FFT_KOKKOS STREQUAL "NVPL")
find_package(nvpl_fft REQUIRED)
target_link_libraries(lammps PRIVATE nvpl::fftw)
endif()
target_compile_definitions(lammps PRIVATE -DFFT_KOKKOS_${FFT_KOKKOS})
endif()
if(PKG_ML-IAP)

View File

@ -10,7 +10,7 @@ if(${FFTW}_FOUND)
else()
set(FFT "KISS" CACHE STRING "FFT library for KSPACE package")
endif()
set(FFT_VALUES KISS FFTW3 MKL)
set(FFT_VALUES KISS FFTW3 MKL NVPL)
set_property(CACHE FFT PROPERTY STRINGS ${FFT_VALUES})
validate_option(FFT FFT_VALUES)
string(TOUPPER ${FFT} FFT)
@ -41,6 +41,10 @@ elseif(FFT STREQUAL "MKL")
target_compile_definitions(lammps PRIVATE -DFFT_MKL_THREADS)
endif()
target_link_libraries(lammps PRIVATE MKL::MKL)
elseif(FFT STREQUAL "NVPL")
find_package(nvpl_fft REQUIRED)
target_compile_definitions(lammps PRIVATE -DFFT_NVPL)
target_link_libraries(lammps PRIVATE nvpl::fftw)
else()
# last option is KISSFFT
target_compile_definitions(lammps PRIVATE -DFFT_KISS)

View File

@ -1,50 +1,62 @@
# PACE library support for ML-PACE package
find_package(pace QUIET)
# set policy to silence warnings about timestamps of downloaded files. review occasionally if it may be set to NEW
if(POLICY CMP0135)
cmake_policy(SET CMP0135 OLD)
endif()
set(PACELIB_URL "https://github.com/ICAMS/lammps-user-pace/archive/refs/tags/v.2023.11.25.fix.tar.gz" CACHE STRING "URL for PACE evaluator library sources")
set(PACELIB_MD5 "b45de9a633f42ed65422567e3ce56f9f" CACHE STRING "MD5 checksum of PACE evaluator library tarball")
mark_as_advanced(PACELIB_URL)
mark_as_advanced(PACELIB_MD5)
GetFallbackURL(PACELIB_URL PACELIB_FALLBACK)
# LOCAL_ML-PACE points to top-level dir with local lammps-user-pace repo,
# to make it easier to check local build without going through the public github releases
if(LOCAL_ML-PACE)
set(lib-pace "${LOCAL_ML-PACE}")
if(pace_FOUND)
find_package(pace)
target_link_libraries(lammps PRIVATE pace::pace)
else()
# download library sources to build folder
if(EXISTS ${CMAKE_BINARY_DIR}/libpace.tar.gz)
file(MD5 ${CMAKE_BINARY_DIR}/libpace.tar.gz DL_MD5)
endif()
if(NOT "${DL_MD5}" STREQUAL "${PACELIB_MD5}")
message(STATUS "Downloading ${PACELIB_URL}")
file(DOWNLOAD ${PACELIB_URL} ${CMAKE_BINARY_DIR}/libpace.tar.gz STATUS DL_STATUS SHOW_PROGRESS)
file(MD5 ${CMAKE_BINARY_DIR}/libpace.tar.gz DL_MD5)
if((NOT DL_STATUS EQUAL 0) OR (NOT "${DL_MD5}" STREQUAL "${PACELIB_MD5}"))
message(WARNING "Download from primary URL ${PACELIB_URL} failed\nTrying fallback URL ${PACELIB_FALLBACK}")
file(DOWNLOAD ${PACELIB_FALLBACK} ${CMAKE_BINARY_DIR}/libpace.tar.gz EXPECTED_HASH MD5=${PACELIB_MD5} SHOW_PROGRESS)
# set policy to silence warnings about timestamps of downloaded files. review occasionally if it may be set to NEW
if(POLICY CMP0135)
cmake_policy(SET CMP0135 OLD)
endif()
else()
message(STATUS "Using already downloaded archive ${CMAKE_BINARY_DIR}/libpace.tar.gz")
endif()
set(PACELIB_URL "https://github.com/ICAMS/lammps-user-pace/archive/refs/tags/v.2023.11.25.fix2.tar.gz" CACHE STRING "URL for PACE evaluator library sources")
set(PACELIB_MD5 "a53bd87cfee8b07d9f44bc17aad69c3f" CACHE STRING "MD5 checksum of PACE evaluator library tarball")
mark_as_advanced(PACELIB_URL)
mark_as_advanced(PACELIB_MD5)
GetFallbackURL(PACELIB_URL PACELIB_FALLBACK)
# LOCAL_ML-PACE points to top-level dir with local lammps-user-pace repo,
# to make it easier to check local build without going through the public github releases
if(LOCAL_ML-PACE)
set(lib-pace "${LOCAL_ML-PACE}")
else()
# download library sources to build folder
if(EXISTS ${CMAKE_BINARY_DIR}/libpace.tar.gz)
file(MD5 ${CMAKE_BINARY_DIR}/libpace.tar.gz DL_MD5)
endif()
if(NOT "${DL_MD5}" STREQUAL "${PACELIB_MD5}")
message(STATUS "Downloading ${PACELIB_URL}")
file(DOWNLOAD ${PACELIB_URL} ${CMAKE_BINARY_DIR}/libpace.tar.gz STATUS DL_STATUS SHOW_PROGRESS)
file(MD5 ${CMAKE_BINARY_DIR}/libpace.tar.gz DL_MD5)
if((NOT DL_STATUS EQUAL 0) OR (NOT "${DL_MD5}" STREQUAL "${PACELIB_MD5}"))
message(WARNING "Download from primary URL ${PACELIB_URL} failed\nTrying fallback URL ${PACELIB_FALLBACK}")
file(DOWNLOAD ${PACELIB_FALLBACK} ${CMAKE_BINARY_DIR}/libpace.tar.gz EXPECTED_HASH MD5=${PACELIB_MD5} SHOW_PROGRESS)
endif()
else()
message(STATUS "Using already downloaded archive ${CMAKE_BINARY_DIR}/libpace.tar.gz")
endif()
# uncompress downloaded sources
execute_process(
COMMAND ${CMAKE_COMMAND} -E remove_directory lammps-user-pace*
COMMAND ${CMAKE_COMMAND} -E tar xzf libpace.tar.gz
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
)
get_newest_file(${CMAKE_BINARY_DIR}/lammps-user-pace-* lib-pace)
endif()
add_subdirectory(${lib-pace} build-pace)
set_target_properties(pace PROPERTIES CXX_EXTENSIONS ON OUTPUT_NAME lammps_pace${LAMMPS_MACHINE})
if(CMAKE_PROJECT_NAME STREQUAL "lammps")
target_link_libraries(lammps PRIVATE pace)
# uncompress downloaded sources
execute_process(
COMMAND ${CMAKE_COMMAND} -E remove_directory lammps-user-pace*
COMMAND ${CMAKE_COMMAND} -E tar xzf libpace.tar.gz
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
)
get_newest_file(${CMAKE_BINARY_DIR}/lammps-user-pace-* lib-pace)
endif()
# some preinstalled yaml-cpp versions don't provide a namespaced target
find_package(yaml-cpp QUIET)
if(TARGET yaml-cpp AND NOT TARGET yaml-cpp::yaml-cpp)
add_library(yaml-cpp::yaml-cpp ALIAS yaml-cpp)
endif()
add_subdirectory(${lib-pace} build-pace)
set_target_properties(pace PROPERTIES CXX_EXTENSIONS ON OUTPUT_NAME lammps_pace${LAMMPS_MACHINE})
if(CMAKE_PROJECT_NAME STREQUAL "lammps")
target_link_libraries(lammps PRIVATE pace)
endif()
endif()

View File

@ -32,9 +32,9 @@ endif()
# Note: must also adjust check for supported API versions in
# fix_plumed.cpp when version changes from v2.n.x to v2.n+1.y
set(PLUMED_URL "https://github.com/plumed/plumed2/releases/download/v2.9.1/plumed-src-2.9.1.tgz"
set(PLUMED_URL "https://github.com/plumed/plumed2/releases/download/v2.9.3/plumed-src-2.9.3.tgz"
CACHE STRING "URL for PLUMED tarball")
set(PLUMED_MD5 "c3b2d31479c1e9ce211719d40e9efbd7" CACHE STRING "MD5 checksum of PLUMED tarball")
set(PLUMED_MD5 "ee1249805fe94bccee17d10610d3f6f1" CACHE STRING "MD5 checksum of PLUMED tarball")
mark_as_advanced(PLUMED_URL)
mark_as_advanced(PLUMED_MD5)

View File

@ -1,2 +0,0 @@
find_package(GSL 2.6 REQUIRED)
target_link_libraries(lammps PRIVATE GSL::gsl)

View File

@ -54,5 +54,5 @@ else()
if(NOT VORO_FOUND)
message(FATAL_ERROR "Voro++ library not found. Help CMake to find it by setting VORO_LIBRARY and VORO_INCLUDE_DIR, or set DOWNLOAD_VORO=ON to download it")
endif()
target_link_libraries(lammps PRIVATE VORO::VORO)
target_link_libraries(lammps PRIVATE VORO::voro++)
endif()

View File

@ -1,3 +1,5 @@
# FindVTK requires that C support is enabled when looking for MPI support
enable_language(C)
find_package(VTK REQUIRED NO_MODULE)
target_compile_definitions(lammps PRIVATE -DLAMMPS_VTK)
if (VTK_MAJOR_VERSION VERSION_LESS 9.0)

View File

@ -0,0 +1,29 @@
# preset that enables KOKKOS and selects SYCL compilation with OpenMP
# enabled as well. Also sets some performance related compiler flags.
set(PKG_KOKKOS ON CACHE BOOL "" FORCE)
set(Kokkos_ENABLE_SERIAL ON CACHE BOOL "" FORCE)
set(Kokkos_ENABLE_OPENMP ON CACHE BOOL "" FORCE)
set(Kokkos_ENABLE_CUDA OFF CACHE BOOL "" FORCE)
set(Kokkos_ENABLE_SYCL ON CACHE BOOL "" FORCE)
set(FFT "MKL" CACHE STRING "" FORCE)
set(FFT_KOKKOS "MKL_GPU" CACHE STRING "" FORCE)
unset(USE_INTERNAL_LINALG)
unset(USE_INTERNAL_LINALG CACHE)
set(BLAS_VENDOR "Intel10_64_dyn")
# hide deprecation warnings temporarily for stable release
set(Kokkos_ENABLE_DEPRECATION_WARNINGS OFF CACHE BOOL "" FORCE)
set(CMAKE_CXX_COMPILER icpx CACHE STRING "" FORCE)
set(CMAKE_C_COMPILER icx CACHE STRING "" FORCE)
set(CMAKE_Fortran_COMPILER "" CACHE STRING "" FORCE)
set(MPI_CXX_COMPILER "mpicxx" CACHE STRING "" FORCE)
set(CMAKE_CXX_STANDARD 17 CACHE STRING "" FORCE)
# Silence everything
set(CMAKE_CXX_FLAGS "-w" CACHE STRING "" FORCE)
#set(CMAKE_EXE_LINKER_FLAGS "-fsycl -flink-huge-device-code -fsycl-targets=spir64_gen " CACHE STRING "" FORCE)
#set(CMAKE_TUNE_FLAGS "-O3 -fsycl -fsycl-device-code-split=per_kernel -fsycl-targets=spir64_gen" CACHE STRING "" FORCE)
set(CMAKE_EXE_LINKER_FLAGS "-fsycl -flink-huge-device-code " CACHE STRING "" FORCE)
set(CMAKE_TUNE_FLAGS "-O3 -fsycl -fsycl-device-code-split=per_kernel " CACHE STRING "" FORCE)

View File

@ -67,6 +67,7 @@ set(WIN_PACKAGES
REACTION
REAXFF
REPLICA
RHEO
RIGID
SHOCK
SMTBQ

View File

@ -60,6 +60,7 @@ set(ALL_PACKAGES
REACTION
REAXFF
REPLICA
RHEO
RIGID
SHOCK
SPH

View File

@ -3,26 +3,9 @@
set(CMAKE_CXX_COMPILER "icpx" CACHE STRING "" FORCE)
set(CMAKE_C_COMPILER "icx" CACHE STRING "" FORCE)
set(CMAKE_Fortran_COMPILER "ifx" CACHE STRING "" FORCE)
set(CMAKE_CXX_FLAGS_DEBUG "-Wall -Wextra -g" CACHE STRING "" FORCE)
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-Wall -Wextra -g -O2 -DNDEBUG" CACHE STRING "" FORCE)
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG" CACHE STRING "" FORCE)
set(CMAKE_Fortran_FLAGS_DEBUG "-Wall -Wextra -g" CACHE STRING "" FORCE)
set(CMAKE_Fortran_FLAGS_RELWITHDEBINFO "-Wall -Wextra -g -O2 -DNDEBUG" CACHE STRING "" FORCE)
set(CMAKE_Fortran_FLAGS_RELEASE "-O3 -DNDEBUG" CACHE STRING "" FORCE)
set(CMAKE_C_FLAGS_DEBUG "-Wall -Wextra -g" CACHE STRING "" FORCE)
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-Wall -Wextra -g -O2 -DNDEBUG" CACHE STRING "" FORCE)
set(CMAKE_C_FLAGS_RELEASE "-O3 -DNDEBUG" CACHE STRING "" FORCE)
set(MPI_CXX "icpx" CACHE STRING "" FORCE)
set(MPI_CXX_COMPILER "mpicxx" CACHE STRING "" FORCE)
unset(HAVE_OMP_H_INCLUDE CACHE)
set(OpenMP_C "icx" CACHE STRING "" FORCE)
set(OpenMP_C_FLAGS "-qopenmp;-qopenmp-simd" CACHE STRING "" FORCE)
set(OpenMP_C_LIB_NAMES "omp" CACHE STRING "" FORCE)
set(OpenMP_CXX "icpx" CACHE STRING "" FORCE)
set(OpenMP_CXX_FLAGS "-qopenmp;-qopenmp-simd" CACHE STRING "" FORCE)
set(OpenMP_CXX_LIB_NAMES "omp" CACHE STRING "" FORCE)
set(OpenMP_Fortran_FLAGS "-qopenmp;-qopenmp-simd" CACHE STRING "" FORCE)
set(OpenMP_omp_LIBRARY "libiomp5.so" CACHE PATH "" FORCE)
# force using internal BLAS/LAPCK since external ones may not be ABI compatible
set(USE_INTERNAL_LINALG ON CACHE BOOL "" FORCE)

View File

@ -60,6 +60,7 @@ set(WIN_PACKAGES
REACTION
REAXFF
REPLICA
RHEO
RIGID
SHOCK
SMTBQ

7
doc/.gitignore vendored
View File

@ -17,3 +17,10 @@
*.el
/utils/sphinx-config/_static/mathjax
/utils/sphinx-config/_static/polyfill.js
/src/pairs.rst
/src/bonds.rst
/src/angles.rst
/src/dihedrals.rst
/src/impropers.rst
/src/computes.rst
/src/fixes.rst

View File

@ -83,7 +83,10 @@ $(SPHINXCONFIG)/conf.py: $(SPHINXCONFIG)/conf.py.in
-e 's,@LAMMPS_PYTHON_DIR@,$(BUILDDIR)/../python,g' \
-e 's,@LAMMPS_DOC_DIR@,$(BUILDDIR),g' $< > $@
html: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
globbed-tocs:
$(PYTHON) $(BUILDDIR)/utils/make-globbed-tocs.py -d $(RSTDIR)
html: xmlgen globbed-tocs $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
@if [ "$(HAS_BASH)" == "NO" ] ; then echo "bash was not found at $(OSHELL)! Please use: $(MAKE) SHELL=/path/to/bash" 1>&2; exit 1; fi
@$(MAKE) $(MFLAGS) -C graphviz all
@(\
@ -113,7 +116,7 @@ html: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
@rm -rf html/PDF/.[sg]*
@echo "Build finished. The HTML pages are in doc/html."
fasthtml: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
fasthtml: xmlgen globbed-tocs $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
@if [ "$(HAS_BASH)" == "NO" ] ; then echo "bash was not found at $(OSHELL)! Please use: $(MAKE) SHELL=/path/to/bash" 1>&2; exit 1; fi
@$(MAKE) $(MFLAGS) -C graphviz all
@mkdir -p fasthtml
@ -132,7 +135,7 @@ fasthtml: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK) $(MATHJAX)
@rm -rf fasthtml/PDF/.[sg]*
@echo "Fast HTML build finished. The HTML pages are in doc/fasthtml."
spelling: xmlgen $(SPHINXCONFIG)/conf.py $(VENV) $(SPHINXCONFIG)/false_positives.txt
spelling: xmlgen globbed-tocs $(SPHINXCONFIG)/conf.py $(VENV) $(SPHINXCONFIG)/false_positives.txt
@if [ "$(HAS_BASH)" == "NO" ] ; then echo "bash was not found at $(OSHELL)! Please use: $(MAKE) SHELL=/path/to/bash" 1>&2; exit 1; fi
@(\
. $(VENV)/bin/activate ; \
@ -143,7 +146,7 @@ spelling: xmlgen $(SPHINXCONFIG)/conf.py $(VENV) $(SPHINXCONFIG)/false_positives
)
@echo "Spell check finished."
epub: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK)
epub: xmlgen globbed-tocs $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK)
@if [ "$(HAS_BASH)" == "NO" ] ; then echo "bash was not found at $(OSHELL)! Please use: $(MAKE) SHELL=/path/to/bash" 1>&2; exit 1; fi
@$(MAKE) $(MFLAGS) -C graphviz all
@mkdir -p epub/JPG
@ -166,7 +169,7 @@ mobi: epub
@ebook-convert LAMMPS.epub LAMMPS.mobi
@echo "Conversion finished. The MOBI manual file is created."
pdf: xmlgen $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK)
pdf: xmlgen globbed-tocs $(VENV) $(SPHINXCONFIG)/conf.py $(ANCHORCHECK)
@if [ "$(HAS_BASH)" == "NO" ] ; then echo "bash was not found at $(OSHELL)! Please use: $(MAKE) SHELL=/path/to/bash" 1>&2; exit 1; fi
@$(MAKE) $(MFLAGS) -C graphviz all
@if [ "$(HAS_PDFLATEX)" == "NO" ] ; then echo "PDFLaTeX or latexmk were not found! Please check README for further instructions" 1>&2; exit 1; fi

View File

@ -10,7 +10,7 @@ Last change: 2022-12-30
In fall 2019, the LAMMPS documentation file format has changed from a
home grown markup designed to generate HTML format files only, to
[reStructuredText](https://docutils.sourceforge.io/rst.html>. For a
[reStructuredText](https://docutils.sourceforge.io/rst.html>). For a
transition period all files in the old .txt format were transparently
converted to .rst and then processed. The `txt2rst tool` is still
included in the distribution to obtain an initial .rst file for legacy
@ -45,8 +45,7 @@ what kind of information and sections are needed.
## Formatting conventions
For headlines we try to follow the conventions posted here:
https://documentation-style-guide-sphinx.readthedocs.io/en/latest/style-guide.html#headings
For headlines we try to follow the conventions posted [here](https://documentation-style-guide-sphinx.readthedocs.io/en/latest/style-guide.html#headings).
It seems to be sufficient to have this consistent only within
any single file and it is not (yet) enforced strictly, but making
this globally consistent makes it easier to move sections around.
@ -64,7 +63,7 @@ Groups of shell commands or LAMMPS input script or C/C++/Python source
code should be typeset into a `.. code-block::` section. A syntax
highlighting extension for LAMMPS input scripts is provided, so `LAMMPS`
can be used to indicate the language in the code block in addition to
`bash`, `c`, `c++`, `console`, `csh`, `diff', `fortran`, `json`, `make`,
`bash`, `c`, `c++`, `console`, `csh`, `diff`, `fortran`, `json`, `make`,
`perl`, `powershell`, `python`, `sh`, or `tcl`, `text`, or `yaml`. When
no syntax style is indicated, no syntax highlighting is performed. When
typesetting commands executed on the shell, please do not prefix
@ -84,7 +83,7 @@ block can be used, followed by multiple `.. tab::` blocks, one
for each alternative. This is only used for HTML output. For other
outputs, the `.. tabs::` directive is transparently removed and
the individual `.. tab::` blocks will be replaced with an
`.. admonition::`` block. Thus in PDF and ePUB output those will
`.. admonition::` block. Thus in PDF and ePUB output those will
be realized as sequential and plain notes.
Special remarks can be highlighted with a `.. note::` block and

View File

@ -2,7 +2,7 @@
DOXYFILE_ENCODING = UTF-8
PROJECT_NAME = "LAMMPS Programmer's Guide"
PROJECT_NUMBER = "4 May 2022"
PROJECT_NUMBER = "19 November 2024"
PROJECT_BRIEF = "Documentation of the LAMMPS library interface and Python wrapper"
PROJECT_LOGO = lammps-logo.png
CREATE_SUBDIRS = NO

View File

@ -6,7 +6,9 @@ choices the LAMMPS developers have agreed on. Git and GitHub provide the
tools, but do not set policies, so it is up to the developers to come to
an agreement as to how to define and interpret policies. This document
is likely to change as our experiences and needs change, and we try to
adapt it accordingly. Last change 2023-02-10.
adapt it accordingly.
Last change: 2023-02-10
## Table of Contents
@ -72,7 +74,7 @@ be assigned to signal urgency to merge this pull request quickly.
People can be assigned to review a pull request in two ways:
* They can be assigned manually to review a pull request
by the submitter or a LAMMPS developer
by the submitter or a LAMMPS developer.
* They can be automatically assigned, because a developer's GitHub
handle matches a file pattern in the `.github/CODEOWNERS` file,
which associates developers with the code they contributed and
@ -86,9 +88,9 @@ required before merging, in addition to passing all automated
compilation and unit tests. Merging counts as implicit approval, so
does submission of a pull request (by a LAMMPS developer). So the person
doing the merge may not also submit an approving review. The GitHub
feature, that reviews from code owners are "hard" reviews (i.e. they
must all approve before merging is allowed), is currently disabled.
It is in the discretion of the merge maintainer to assess when a
feature that reviews from code owners are "hard" reviews (i.e. they
must all approve before merging is allowed) is currently disabled.
It is at the discretion of the merge maintainer to assess when a
sufficient degree of approval has been reached, especially from external
collaborators. Reviews may be (automatically) dismissed, when the
reviewed code has been changed. Review may be requested a second time.
@ -147,7 +149,8 @@ only contain bug fixes, feature additions to peripheral functionality,
and documentation updates. In between stable releases, bug fixes and
infrastructure updates are back-ported from the "develop" branch to the
"maintenance" branch and occasionally merged into "stable" and published
as update releases.
as update releases. Further explanation of LAMMPS versions can be found
[in the documentation](https://docs.lammps.org/Manual_version.html).
## Project Management

View File

@ -1,7 +1,7 @@
.TH LAMMPS "1" "29 August 2024" "2024-08-29"
.TH LAMMPS "1" "4 February 2025" "2025-02-04"
.SH NAME
.B LAMMPS
\- Molecular Dynamics Simulator. Version 29 August 2024
\- Molecular Dynamics Simulator. Version 4 February 2025
.SH SYNOPSIS
.B lmp
@ -311,7 +311,7 @@ the chapter on errors in the
manual gives some additional information about error messages, if possible.
.SH COPYRIGHT
© 2003--2024 Sandia Corporation
© 2003--2025 Sandia Corporation
This package is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License version 2 as

View File

@ -1,4 +1,4 @@
.TH MSI2LMP "1" "v3.9.10" "2023-03-10"
.TH MSI2LMP "1" "v3.9.11" "2024-09-06"
.SH NAME
.B MSI2LMP
\- Converter for Materials Studio files to LAMMPS
@ -101,7 +101,7 @@ msi2lmp decane -c 0 -f oplsaa
.SH COPYRIGHT
© 2003--2022 Sandia Corporation
© 2003--2024 Sandia Corporation
This package is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License version 2 as

View File

@ -1,10 +1,14 @@
Build LAMMPS
============
LAMMPS is built as a library and an executable from source code using
either traditional makefiles for use with GNU make (which may require
manual editing), or using a build environment generated by CMake (Unix
Makefiles, Ninja, Xcode, Visual Studio, KDevelop, CodeBlocks and more).
LAMMPS is built as a library and an executable from source code using a
build environment generated by CMake (Unix Makefiles, Ninja, Xcode,
Visual Studio, KDevelop, CodeBlocks and more depending on the platform).
Using CMake is the preferred way to build LAMMPS. In addition, LAMMPS
can be compiled using the legacy build system based on traditional
makefiles for use with GNU make (which may require manual editing).
Support for the legacy build system is slowly being phased out and may
not be available for all optional features.
As an alternative, you can download a package with pre-built executables
or automated build trees, as described in the :doc:`Install <Install>`

View File

@ -160,7 +160,7 @@ with the OpenMP 3.1 semantics used in LAMMPS for maximal compatibility
with compiler versions in use. If compilation with OpenMP enabled fails
because of your compiler requiring strict OpenMP 4.0 semantics, you can
change the behavior by adding ``-D LAMMPS_OMP_COMPAT=4`` to the
``LMP_INC`` variable in your makefile, or add it to the command line
``LMP_INC`` variable in your makefile, or add it to the command-line flags
while configuring with CMake. LAMMPS will auto-detect a suitable setting
for most GNU, Clang, and Intel compilers.
@ -196,13 +196,18 @@ LAMMPS.
.. tab:: CMake build
By default CMake will use the compiler it finds according to
By default CMake will use the compiler it finds according to its
internal preferences, and it will add optimization flags
appropriate to that compiler and any :doc:`accelerator packages
<Speed_packages>` you have included in the build. CMake will
check if the detected or selected compiler is compatible with the
C++ support requirements of LAMMPS and stop with an error, if this
is not the case.
is not the case. A C++11 compatible compiler is currently
required, but a transition to require C++17 is in progress and
planned to be completed in Summer 2025. Currently, setting
``-DLAMMPS_CXX11=yes`` is required when configuring with CMake while
using a C++11 compatible compiler that does not support C++17,
otherwise setting ``-DCMAKE_CXX_STANDARD=17`` is preferred.
You can tell CMake to look for a specific compiler with setting
CMake variables (listed below) during configuration. For a few
@ -223,6 +228,8 @@ LAMMPS.
-D CMAKE_C_COMPILER=name # name of C compiler
-D CMAKE_Fortran_COMPILER=name # name of Fortran compiler
-D CMAKE_CXX_STANDARD=17 # put compiler in C++17 mode
-D LAMMPS_CXX11=yes # enforce compilation in C++11 mode
-D CMAKE_CXX_FLAGS=string # flags to use with C++ compiler
-D CMAKE_C_FLAGS=string # flags to use with C compiler
-D CMAKE_Fortran_FLAGS=string # flags to use with Fortran compiler
@ -321,15 +328,23 @@ LAMMPS.
you would have to install a newer compiler that supports C++11;
either as a binary package or through compiling from source.
If you build LAMMPS with any :doc:`Speed_packages` included,
there may be specific compiler or linker flags that are either
required or recommended to enable required features and to
achieve optimal performance. You need to include these in the
``CCFLAGS`` and ``LINKFLAGS`` settings above. For details, see the
documentation for the individual packages listed on the
:doc:`Speed_packages` page. Or examine these files in the
``src/MAKE/OPTIONS`` directory. They correspond to each of the 5
accelerator packages and their hardware variants:
While a C++11 compatible compiler is currently sufficient to compile
LAMMPS, a transition to require C++17 is in progress and planned to
be completed in Summer 2025. Currently, setting ``-DLAMMPS_CXX11``
in the ``LMP_INC =`` line in the machine makefile is required when
using a C++11 compatible compiler that does not support C++17.
Otherwise, to enable C++17 support (if not enabled by default) using
a compiler flag like ``-std=c++17`` in CCFLAGS may needed.
If you build LAMMPS with any :doc:`Speed_packages` included,
there may be specific compiler or linker flags that are either
required or recommended to enable required features and to
achieve optimal performance. You need to include these in the
``CCFLAGS`` and ``LINKFLAGS`` settings above. For details, see the
documentation for the individual packages listed on the
:doc:`Speed_packages` page. Or examine these files in the
``src/MAKE/OPTIONS`` directory. They correspond to each of the 5
accelerator packages and their hardware variants:
.. code-block:: bash
@ -502,6 +517,8 @@ using CMake or Make.
# chain.x, micelle2d.x, msi2lmp, phana,
# stl_bin2txt
-D BUILD_LAMMPS_GUI=value # yes or no (default). Build LAMMPS-GUI
-D BUILD_WHAM=value # yes (default). Download and build WHAM;
# only available for BUILD_LAMMPS_GUI=yes
The generated binaries will also become part of the LAMMPS installation
(see below).

View File

@ -8,7 +8,7 @@ packages. Links to those pages on the :doc:`Build overview <Build>`
page.
The following text assumes some familiarity with CMake and focuses on
using the command line tool ``cmake`` and what settings are supported
using the command-line tool ``cmake`` and what settings are supported
for building LAMMPS. A more detailed tutorial on how to use CMake
itself, the text mode or graphical user interface, to change the
generated output files for different build tools and development
@ -16,7 +16,7 @@ environments is on a :doc:`separate page <Howto_cmake>`.
.. note::
LAMMPS currently requires that CMake version 3.16 or later is available.
LAMMPS currently requires that CMake version 3.20 or later is available.
.. warning::
@ -32,22 +32,22 @@ environments is on a :doc:`separate page <Howto_cmake>`.
Advantages of using CMake
^^^^^^^^^^^^^^^^^^^^^^^^^
CMake is an alternative to compiling LAMMPS in the traditional way
through :doc:`(manually customized) makefiles <Build_make>`. Using
CMake has multiple advantages that are specifically helpful for
people with limited experience in compiling software or for people
that want to modify or extend LAMMPS.
CMake is the preferred way of compiling LAMMPS in contrast to the legacy
build system based on GNU make and through :doc:`(manually customized)
makefiles <Build_make>`. Using CMake has multiple advantages that are
specifically helpful for people with limited experience in compiling
software or for people that want to modify or extend LAMMPS.
- CMake can detect available hardware, tools, features, and libraries
and adapt the LAMMPS default build configuration accordingly.
- CMake can generate files for different build tools and integrated
development environments (IDE).
- CMake supports customization of settings with a command line, text
- CMake supports customization of settings with a command-line, text
mode, or graphical user interface. No manual editing of files,
knowledge of file formats or complex command line syntax is required.
knowledge of file formats or complex command-line syntax is required.
- All enabled components are compiled in a single build operation.
- Automated dependency tracking for all files and configuration options.
- Support for true out-of-source compilation. Multiple configurations
- Support for true out-of-source compilation. Multiple configurations
and settings with different choices of LAMMPS packages, settings, or
compilers can be configured and built concurrently from the same
source tree.
@ -68,7 +68,7 @@ that purpose you can use either the command-line utility ``cmake`` (or
graphical utility ``cmake-gui``, or use them interchangeably. The
second step is then the compilation and linking of all objects,
libraries, and executables using the selected build tool. Here is a
minimal example using the command line version of CMake to build LAMMPS
minimal example using the command-line version of CMake to build LAMMPS
with no add-on packages enabled and no customization:
.. code-block:: bash
@ -131,7 +131,7 @@ file called ``CMakeLists.txt`` (for LAMMPS it is located in the
configuration step. The cache file contains all current CMake settings.
To modify settings, enable or disable features, you need to set
*variables* with either the ``-D`` command line flag (``-D
*variables* with either the ``-D`` command-line flag (``-D
VARIABLE1_NAME=value``) or change them in the text mode of the graphical
user interface. The ``-D`` flag can be used several times in one command.
@ -141,11 +141,11 @@ a different compiler tool chain. Those are loaded with the ``-C`` flag
(``-C ../cmake/presets/basic.cmake``). This step would only be needed
once, as the settings from the preset files are stored in the
``CMakeCache.txt`` file. It is also possible to customize the build
by adding one or more ``-D`` flags to the CMake command line.
by adding one or more ``-D`` flags to the CMake command.
Generating files for alternate build tools (e.g. Ninja) and project files
for IDEs like Eclipse, CodeBlocks, or Kate can be selected using the ``-G``
command line flag. A list of available generator settings for your
command-line flag. A list of available generator settings for your
specific CMake version is given when running ``cmake --help``.
.. _cmake_multiconfig:

View File

@ -138,12 +138,27 @@ during development:
The status of this automated testing can be viewed on `https://ci.lammps.org
<https://ci.lammps.org>`_.
The scripts and inputs for integration, run, and regression testing
are maintained in a
`separate repository <https://github.com/lammps/lammps-testing>`_
of the LAMMPS project on GitHub. A few tests are also run as GitHub
Actions and their configuration files are in the ``.github/workflows/``
folder of the LAMMPS git tree.
The scripts and inputs for integration, run, and legacy regression
testing are maintained in a `separate repository
<https://github.com/lammps/lammps-testing>`_ of the LAMMPS project on
GitHub. A few tests are also run as GitHub Actions and their
configuration files are in the ``.github/workflows/`` folder of the
LAMMPS git tree.
Regression tests can also be performed locally with the :ref:`regression
tester tool <regression>`. The tool checks if a given LAMMPS binary run
with selected input examples produces thermo output that is consistent
with the provided log files. The script can be run in one pass over all
available input files, but it can also first create multiple lists of
inputs or folders that can then be run with multiple workers
concurrently to speed things up. Another mode allows to do a quick
check of inputs that contain commands that have changes in the current
checkout branch relative to a git branch. This works similar to the two
pass mode, but will select only shorter runs and no more than 100 inputs
that are chosen randomly. This ensures that this test runs
significantly faster compared to the full test run. These test runs can
also be performed with instrumented LAMMPS binaries (see previous
section).
The unit testing facility is integrated into the CMake build process of
the LAMMPS source code distribution itself. It can be enabled by
@ -248,9 +263,9 @@ will be skipped if prerequisite features are not available in LAMMPS.
time. Preference is given to parts of the code base that are easy to
test or commonly used.
Tests as shown by the ``ctest`` program are command lines defined in the
Tests as shown by the ``ctest`` program are commands defined in the
``CMakeLists.txt`` files in the ``unittest`` directory tree. A few
tests simply execute LAMMPS with specific command line flags and check
tests simply execute LAMMPS with specific command-line flags and check
the output to the screen for expected content. A large number of unit
tests are special tests programs using the `GoogleTest framework
<https://github.com/google/googletest/>`_ and linked to the LAMMPS
@ -405,7 +420,7 @@ during MD timestepping and manipulate per-atom properties like
positions, velocities, and forces. For those fix styles, testing can be
done in a very similar fashion as for force fields and thus there is a
test program `test_fix_timestep` that shares a lot of code, properties,
and command line flags with the force field style testers described in
and command-line flags with the force field style testers described in
the previous section.
This tester will set up a small molecular system run with verlet run
@ -627,14 +642,38 @@ The following target are available for both, GNU make and CMake:
.. _gh-cli:
GitHub command line interface
GitHub command-line interface
-----------------------------
GitHub is developing a `tool for the command line
<https://cli.github.com>`_ that interacts with the GitHub website via a
command called ``gh``. This can be extremely convenient when working
with a Git repository hosted on GitHub (like LAMMPS). It is thus highly
recommended to install it when doing LAMMPS development.
GitHub has developed a `command-line tool <https://cli.github.com>`_
to interact with the GitHub website via a command called ``gh``.
This is extremely convenient when working with a Git repository hosted
on GitHub (like LAMMPS). It is thus highly recommended to install it
when doing LAMMPS development. To use ``gh`` you must be within a git
checkout of a repository and you must obtain an authentication token
to connect your checkout with a GitHub user. This is done with the
command: ``gh auth login`` where you then have to follow the prompts.
Here are some examples:
The capabilities of the ``gh`` command is continually expanding, so
please see the documentation at https://cli.github.com/manual/
.. list-table::
:header-rows: 1
:widths: 34 66
* - Command
- Description
* - ``gh pr list``
- List currently open pull requests
* - ``gh pr checks 404``
- Shows the status of all checks for pull request #404
* - ``gh pr view 404``
- Shows the description and recent comments for pull request #404
* - ``gh co 404``
- Check out the branch from pull request #404; set up for pushing changes
* - ``gh issue list``
- List currently open issues
* - ``gh issue view 430 --comments``
- Shows the description and all comments for issue #430
The capabilities of the ``gh`` command are continually expanding, so
for more details please see the documentation at https://cli.github.com/manual/
or use ``gh --help`` or ``gh <command> --help`` for embedded help.

View File

@ -7,6 +7,8 @@ in addition to
.. list-table::
:align: center
:header-rows: 1
:widths: 50 50
:width: 80%
* - CMake build
- Traditional make
@ -46,6 +48,7 @@ This is the list of packages that may require additional steps.
* :ref:`LEPTON <lepton>`
* :ref:`MACHDYN <machdyn>`
* :ref:`MDI <mdi>`
* :ref:`MISC <misc>`
* :ref:`ML-HDNNP <ml-hdnnp>`
* :ref:`ML-IAP <mliap>`
* :ref:`ML-PACE <ml-pace>`
@ -115,7 +118,7 @@ GPU package
To build with this package, you must choose options for precision and
which GPU hardware to build for. The GPU package currently supports
three different types of backends: OpenCL, CUDA and HIP.
three different types of back ends: OpenCL, CUDA and HIP.
CMake build
^^^^^^^^^^^
@ -205,9 +208,9 @@ necessary for ``hipcc`` and the linker to work correctly.
.. versionadded:: 3Aug2022
Using the CHIP-SPV implementation of HIP is supported. It allows one to
run HIP code on Intel GPUs via the OpenCL or Level Zero backends. To use
run HIP code on Intel GPUs via the OpenCL or Level Zero back ends. To use
CHIP-SPV, you must set ``-DHIP_USE_DEVICE_SORT=OFF`` in your CMake
command line as CHIP-SPV does not yet support hipCUB. As of Summer 2022,
command-line as CHIP-SPV does not yet support hipCUB. As of Summer 2022,
the use of HIP for Intel GPUs is experimental. You should only use this
option in preparations to run on Aurora system at Argonne.
@ -230,7 +233,7 @@ option in preparations to run on Aurora system at Argonne.
.. code:: bash
# CUDA target (not recommended, use GPU_ARCH=cuda)
# CUDA target (not recommended, use GPU_API=cuda)
# !!! DO NOT set CMAKE_CXX_COMPILER !!!
export HIP_PLATFORM=nvcc
export HIP_PATH=/path/to/HIP/install
@ -419,9 +422,10 @@ minutes to hours) to build. Of course you only need to do that once.)
cmake build system. The ``lib/kim/Install.py`` script supports a
``CMAKE`` environment variable if the cmake executable is named other
than ``cmake`` on your system. Additional environment variables may be
provided on the command line for use by cmake. For example, to use the
``cmake3`` executable and tell it to use the gnu version 11 compilers
to build KIM, one could use the following command line.
set with the ``make`` command for use by cmake. For example, to use the
``cmake3`` executable and tell it to use the GNU version 11 compilers
called ``g++-11``, ``gcc-11`` and ``gfortran-11`` to build KIM, one
could use the following command.
.. code-block:: bash
@ -544,16 +548,7 @@ They must be specified in uppercase.
- Local machine
* - AMDAVX
- HOST
- AMD 64-bit x86 CPU (AVX 1)
* - ZEN
- HOST
- AMD Zen class CPU (AVX 2)
* - ZEN2
- HOST
- AMD Zen2 class CPU (AVX 2)
* - ZEN3
- HOST
- AMD Zen3 class CPU (AVX 2)
- AMD chip
* - ARMV80
- HOST
- ARMv8.0 Compatible CPU
@ -569,105 +564,126 @@ They must be specified in uppercase.
* - A64FX
- HOST
- ARMv8.2 with SVE Support
* - ARMV9_GRACE
- HOST
- ARMv9 NVIDIA Grace CPU
* - SNB
- HOST
- Intel Sandy/Ivy Bridge CPU (AVX 1)
- Intel Sandy/Ivy Bridge CPUs
* - HSW
- HOST
- Intel Haswell CPU (AVX 2)
- Intel Haswell CPUs
* - BDW
- HOST
- Intel Broadwell Xeon E-class CPU (AVX 2 + transactional mem)
* - SKL
- HOST
- Intel Skylake Client CPU
* - SKX
- HOST
- Intel Skylake Xeon Server CPU (AVX512)
- Intel Broadwell Xeon E-class CPUs
* - ICL
- HOST
- Intel Ice Lake Client CPU (AVX512)
- Intel Ice Lake Client CPUs (AVX512)
* - ICX
- HOST
- Intel Ice Lake Xeon Server CPU (AVX512)
* - SPR
- Intel Ice Lake Xeon Server CPUs (AVX512)
* - SKL
- HOST
- Intel Sapphire Rapids Xeon Server CPU (AVX512)
- Intel Skylake Client CPUs
* - SKX
- HOST
- Intel Skylake Xeon Server CPUs (AVX512)
* - KNC
- HOST
- Intel Knights Corner Xeon Phi
* - KNL
- HOST
- Intel Knights Landing Xeon Phi
* - SPR
- HOST
- Intel Sapphire Rapids Xeon Server CPUs (AVX512)
* - POWER8
- HOST
- IBM POWER8 CPU
- IBM POWER8 CPUs
* - POWER9
- HOST
- IBM POWER9 CPU
- IBM POWER9 CPUs
* - ZEN
- HOST
- AMD Zen architecture
* - ZEN2
- HOST
- AMD Zen2 architecture
* - ZEN3
- HOST
- AMD Zen3 architecture
* - RISCV_SG2042
- HOST
- SG2042 (RISC-V) CPU
- SG2042 (RISC-V) CPUs
* - RISCV_RVA22V
- HOST
- RVA22V (RISC-V) CPUs
* - KEPLER30
- GPU
- NVIDIA Kepler generation CC 3.0 GPU
- NVIDIA Kepler generation CC 3.0
* - KEPLER32
- GPU
- NVIDIA Kepler generation CC 3.2 GPU
- NVIDIA Kepler generation CC 3.2
* - KEPLER35
- GPU
- NVIDIA Kepler generation CC 3.5 GPU
- NVIDIA Kepler generation CC 3.5
* - KEPLER37
- GPU
- NVIDIA Kepler generation CC 3.7 GPU
- NVIDIA Kepler generation CC 3.7
* - MAXWELL50
- GPU
- NVIDIA Maxwell generation CC 5.0 GPU
- NVIDIA Maxwell generation CC 5.0
* - MAXWELL52
- GPU
- NVIDIA Maxwell generation CC 5.2 GPU
- NVIDIA Maxwell generation CC 5.2
* - MAXWELL53
- GPU
- NVIDIA Maxwell generation CC 5.3 GPU
- NVIDIA Maxwell generation CC 5.3
* - PASCAL60
- GPU
- NVIDIA Pascal generation CC 6.0 GPU
- NVIDIA Pascal generation CC 6.0
* - PASCAL61
- GPU
- NVIDIA Pascal generation CC 6.1 GPU
- NVIDIA Pascal generation CC 6.1
* - VOLTA70
- GPU
- NVIDIA Volta generation CC 7.0 GPU
- NVIDIA Volta generation CC 7.0
* - VOLTA72
- GPU
- NVIDIA Volta generation CC 7.2 GPU
- NVIDIA Volta generation CC 7.2
* - TURING75
- GPU
- NVIDIA Turing generation CC 7.5 GPU
- NVIDIA Turing generation CC 7.5
* - AMPERE80
- GPU
- NVIDIA Ampere generation CC 8.0 GPU
- NVIDIA Ampere generation CC 8.0
* - AMPERE86
- GPU
- NVIDIA Ampere generation CC 8.6 GPU
- NVIDIA Ampere generation CC 8.6
* - ADA89
- GPU
- NVIDIA Ada Lovelace generation CC 8.9 GPU
- NVIDIA Ada generation CC 8.9
* - HOPPER90
- GPU
- NVIDIA Hopper generation CC 9.0 GPU
- NVIDIA Hopper generation CC 9.0
* - AMD_GFX906
- GPU
- AMD GPU MI50/MI60
- AMD GPU MI50/60
* - AMD_GFX908
- GPU
- AMD GPU MI100
* - AMD_GFX90A
- GPU
- AMD GPU MI200
* - AMD_GFX940
- GPU
- AMD GPU MI300
* - AMD_GFX942
- GPU
- AMD GPU MI300
* - AMD_GFX942_APU
- GPU
- AMD APU MI300A
* - AMD_GFX1030
- GPU
- AMD GPU V620/W6800
@ -676,7 +692,7 @@ They must be specified in uppercase.
- AMD GPU RX7900XTX
* - AMD_GFX1103
- GPU
- AMD Phoenix APU with Radeon 740M/760M/780M/880M/890M
- AMD APU Phoenix
* - INTEL_GEN
- GPU
- SPIR64-based devices, e.g. Intel GPUs, using JIT
@ -699,7 +715,7 @@ They must be specified in uppercase.
- GPU
- Intel GPU Ponte Vecchio
This list was last updated for version 4.3.0 of the Kokkos library.
This list was last updated for version 4.5.1 of the Kokkos library.
.. tabs::
@ -751,14 +767,27 @@ This list was last updated for version 4.3.0 of the Kokkos library.
platform-appropriate vendor library: rocFFT on AMD GPUs or cuFFT on
NVIDIA GPUs.
To simplify compilation, five preset files are included in the
For Intel GPUs using SYCL, set these variables:
.. code-block:: bash
-D Kokkos_ARCH_HOSTARCH=yes # HOSTARCH = HOST from list above
-D Kokkos_ARCH_GPUARCH=yes # GPUARCH = GPU from list above
-D Kokkos_ENABLE_SYCL=yes
-D Kokkos_ENABLE_OPENMP=yes
-D FFT_KOKKOS=MKL_GPU
This will enable FFTs on the GPU using the oneMKL library.
To simplify compilation, six preset files are included in the
``cmake/presets`` folder, ``kokkos-serial.cmake``,
``kokkos-openmp.cmake``, ``kokkos-cuda.cmake``,
``kokkos-hip.cmake``, and ``kokkos-sycl.cmake``. They will enable
the KOKKOS package and enable some hardware choices. For GPU
support those preset files must be customized to match the
hardware used. So to compile with CUDA device parallelization with
some common packages enabled, you can do the following:
``kokkos-hip.cmake``, ``kokkos-sycl-nvidia.cmake``, and
``kokkos-sycl-intel.cmake``. They will enable the KOKKOS
package and enable some hardware choices. For GPU support those
preset files must be customized to match the hardware used. So
to compile with CUDA device parallelization with some common
packages enabled, you can do the following:
.. code-block:: bash
@ -830,6 +859,18 @@ This list was last updated for version 4.3.0 of the Kokkos library.
FFT_INC = -DFFT_HIPFFT # enable use of hipFFT (optional)
FFT_LIB = -lhipfft # link to hipFFT library
For Intel GPUs using SYCL:
.. code-block:: make
KOKKOS_DEVICES = SYCL
KOKKOS_ARCH = HOSTARCH,GPUARCH # HOSTARCH = HOST from list above that is
# hosting the GPU
# GPUARCH = GPU from list above
FFT_INC = -DFFT_KOKKOS_MKL_GPU # enable use of oneMKL for Intel GPUs (optional)
# link to oneMKL FFT library
FFT_LIB = -lmkl_sycl_dft -lmkl_intel_ilp64 -lmkl_tbb_thread -mkl_core -ltbb
Advanced KOKKOS compilation settings
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -1991,7 +2032,7 @@ TBB and MKL.
.. _mdi:
MDI package
-----------------------------
-----------
.. tabs::
@ -2018,6 +2059,37 @@ MDI package
----------
.. _misc:
MISC package
------------
The :doc:`fix imd <fix_imd>` style in this package can be run either
synchronously (communication with IMD clients is done in the main
process) or asynchronously (the fix spawns a separate thread that can
communicate with IMD clients concurrently to the LAMMPS execution).
.. tabs::
.. tab:: CMake build
.. code-block:: bash
-D LAMMPS_ASYNC_IMD=value # Run IMD server asynchronously
# value = no (default) or yes
.. tab:: Traditional make
To enable asynchronous mode the ``-DLAMMPS_ASYNC_IMD`` define
needs to be added to the ``LMP_INC`` variable in the
``Makefile.machine`` you are using. For example:
.. code-block:: make
LMP_INC = -DLAMMPS_ASYNC_IMD -DLAMMPS_MEMALIGN=64
----------
.. _molfile:
MOLFILE package
@ -2164,7 +2236,7 @@ verified to work in February 2020 with Quantum Espresso versions 6.3 to
from the sources in the *lib* folder (including the essential
libqmmm.a) are not included in the static LAMMPS library and
(currently) not installed, while their code is included in the
shared LAMMPS library. Thus a typical command line to configure
shared LAMMPS library. Thus a typical command to configure
building LAMMPS for QMMM would be:
.. code-block:: bash
@ -2224,28 +2296,38 @@ verified to work in February 2020 with Quantum Espresso versions 6.3 to
RHEO package
------------
To build with this package you must have the `GNU Scientific Library
(GSL) <https://www.gnu.org/software/gsl/>` installed in locations that
are accessible in your environment. The GSL library should be at least
version 2.7.
This package depends on the BPM package.
.. tabs::
.. tab:: CMake build
If CMake cannot find the GSL library or include files, you can set:
.. code-block:: bash
-D GSL_ROOT_DIR=path # path to root of GSL installation
-D PKG_RHEO=yes # enable the package itself
-D PKG_BPM=yes # the RHEO package requires BPM
-D USE_INTERNAL_LINALG=value # prefer internal LAPACK if true
Some features in the RHEO package are dependent on code in the BPM
package so the latter one *must* be enabled as well.
The RHEO package also requires LAPACK (and BLAS) and CMake
can identify their locations and pass that info to the RHEO
build script. But on some systems this may cause problems when
linking or the dependency is not desired. By using the setting
``-D USE_INTERNAL_LINALG=yes`` when running the CMake
configuration, you will select compiling and linking the bundled
linear algebra library and work around the limitations.
.. tab:: Traditional make
LAMMPS will try to auto-detect the GSL compiler and linker flags
from the corresponding ``pkg-config`` file (``gsl.pc``), otherwise
you can edit the file ``lib/rheo/Makefile.lammps``
to specify the paths and library names where indicated by comments.
This must be done **before** the package is installed.
The RHEO package requires LAPACK (and BLAS) which can be either
a system provided library or the bundled "linalg" library. This
is a subset of LAPACK translated to C++. For that, one of the
provided ``Makefile.lammps.<config>`` files needs to be copied
to ``Makefile.lammps`` and edited as needed. The default file
uses the bundled "linalg" library, which can be built by
``make lib-linalg args='-m serial'`` in the ``src`` folder.
----------

View File

@ -8,6 +8,10 @@ Building LAMMPS with traditional makefiles requires that you have a
for customizing your LAMMPS build with a number of global compilation
options and features.
This build system is slowly being phased out and may not support all
optional features and packages in LAMMPS. It is recommended to switch
to the :doc:`CMake based build system <Build_cmake>`.
Requirements
^^^^^^^^^^^^

View File

@ -49,6 +49,7 @@ packages:
* :ref:`LEPTON <lepton>`
* :ref:`MACHDYN <machdyn>`
* :ref:`MDI <mdi>`
* :ref:`MISC <misc>`
* :ref:`ML-HDNNP <ml-hdnnp>`
* :ref:`ML-IAP <mliap>`
* :ref:`ML-PACE <ml-pace>`

View File

@ -67,10 +67,10 @@ libraries and better pipelining for packing and communication.
.. code-block:: bash
-D FFT=value # FFTW3 or MKL or KISS, default is FFTW3 if found,
# else KISS
-D FFT_KOKKOS=value # FFTW3 or MKL or KISS or CUFFT or HIPFFT,
# default is KISS
-D FFT=value # FFTW3 or MKL or NVPL or KISS,
# default is FFTW3 if found, else KISS
-D FFT_KOKKOS=value # FFTW3 or MKL or NVPL or KISS or CUFFT
# or HIPFFT or MKL_GPU, default is KISS
-D FFT_SINGLE=value # yes or no (default), no = double precision
-D FFT_PACK=value # array (default) or pointer or memcpy
-D FFT_USE_HEFFTE=value # yes or no (default), yes links to heFFTe
@ -103,6 +103,8 @@ libraries and better pipelining for packing and communication.
-D FFT_HEFFTE_BACKEND=value # FFTW or MKL or empty/undefined for the stock
# heFFTe back end
-D Heffte_ROOT=path # path to an existing heFFTe installation
-D nvpl_fft_INCLUDE_DIR=path # path to NVPL FFT include files
-D nvpl_fft_LIBRARY_DIR=path # path to NVPL FFT libraries
.. note::
@ -121,9 +123,10 @@ libraries and better pipelining for packing and communication.
.. code-block:: make
FFT_INC = -DFFT_<NAME> # where <NAME> is KISS (default), FFTW3,
# FFTW (same as FFTW3), or MKL
# FFTW (same as FFTW3), NVPL, or MKL
FFT_INC = -DFFT_KOKKOS_<NAME> # where <NAME> is KISS (default), FFTW3,
# FFTW (same as FFTW3), MKL, CUFFT, or HIPFFT
# FFTW (same as FFTW3), NVPL, MKL, CUFFT,
# HIPFFT, or MKL_GPU
FFT_INC = -DFFT_SINGLE # do not specify for double precision
FFT_INC = -DFFT_FFTW_THREADS # enable using threaded FFTW3 libraries
FFT_INC = -DFFT_MKL_THREADS # enable using threaded FFTs with MKL libraries
@ -141,6 +144,9 @@ libraries and better pipelining for packing and communication.
# cuFFT either precision
FFT_LIB = -lcufft
# MKL_GPU either precision
FFT_LIB = -lmkl_sycl_dft -lmkl_intel_ilp64 -lmkl_tbb_thread -lmkl_core -ltbb
# FFTW3 double precision
FFT_LIB = -lfftw3
@ -165,6 +171,10 @@ libraries and better pipelining for packing and communication.
# MKL with automatic runtime selection of interface libs
FFT_LIB = -lmkl_rt
# threaded NVPL FFT
FFT_LIB = -lnvpl_fftw
As with CMake, you do not need to set paths in ``FFT_INC`` or
``FFT_PATH``, if the compiler can find the FFT header and library
files in its default search path. You must specify ``FFT_LIB``
@ -218,10 +228,15 @@ The Intel MKL math library is part of the Intel compiler suite. It
can be used with the Intel or GNU compiler (see the ``FFT_LIB`` setting
above).
The NVIDIA Performance Libraries (NVPL) FFT library is optimized for NVIDIA
Grace Armv9.0 architecture. You can download it from https://docs.nvidia.com/nvpl/
The cuFFT and hipFFT FFT libraries are packaged with NVIDIA's CUDA and
AMD's HIP installations, respectively. These FFT libraries require the
Kokkos acceleration package to be enabled and the Kokkos back end to be
GPU-resident (i.e., HIP or CUDA).
GPU-resident (i.e., HIP or CUDA). Similarly, GPU offload of FFTs on
Intel GPUs with oneMKL currently requires the Kokkos acceleration
package to be enabled with the SYCL back end.
Performing 3d FFTs in parallel can be time-consuming due to data access
and required communication. This cost can be reduced by performing

View File

@ -100,9 +100,9 @@ procedure.
It is possible to use both the integrated CMake support of the Visual
Studio IDE or use an external CMake installation (e.g. downloaded from
cmake.org) to create build files and compile LAMMPS from the command line.
cmake.org) to create build files and compile LAMMPS from the command-line.
Compilation via command line and unit tests are checked automatically
Compilation via command-line and unit tests are checked automatically
for the LAMMPS development branch through
`GitHub Actions <https://github.com/lammps/lammps/actions/workflows/compile-msvc.yml>`_.
@ -115,7 +115,7 @@ for the LAMMPS development branch through
Please note, that for either approach CMake will create a so-called
:ref:`"multi-configuration" build environment <cmake_multiconfig>`, and
the command lines for building and testing LAMMPS must be adjusted
the commands for building and testing LAMMPS must be adjusted
accordingly.
The LAMMPS cmake folder contains a ``CMakeSettings.json`` file with

View File

@ -4,7 +4,7 @@ LAMMPS Class
The LAMMPS class is encapsulating an MD simulation state and thus it is
the class that needs to be created when starting a new simulation system
state. The LAMMPS executable essentially creates one instance of this
class and passes the command line flags and tells it to process the
class and passes the command-line flags and tells it to process the
provided input (a file or ``stdin``). It shuts the class down when
control is returned to it and then exits. When using LAMMPS as a
library from another code it is required to create an instance of this

View File

@ -90,6 +90,7 @@ OPT.
* :doc:`lepton (o) <angle_lepton>`
* :doc:`mesocnt <angle_mesocnt>`
* :doc:`mm3 <angle_mm3>`
* :doc:`mwlc <angle_mwlc>`
* :doc:`quartic (o) <angle_quartic>`
* :doc:`spica (ko) <angle_spica>`
* :doc:`table (o) <angle_table>`

View File

@ -58,6 +58,7 @@ KOKKOS, o = OPENMP, t = OPT.
* :doc:`fep/ta <compute_fep_ta>`
* :doc:`force/tally <compute_tally>`
* :doc:`fragment/atom <compute_cluster_atom>`
* :doc:`gaussian/grid/local (k) <compute_gaussian_grid_local>`
* :doc:`global/atom <compute_global_atom>`
* :doc:`group/group <compute_group_group>`
* :doc:`gyration <compute_gyration>`
@ -140,8 +141,8 @@ KOKKOS, o = OPENMP, t = OPT.
* :doc:`smd/vol <compute_smd_vol>`
* :doc:`snap <compute_sna_atom>`
* :doc:`sna/atom <compute_sna_atom>`
* :doc:`sna/grid <compute_sna_atom>`
* :doc:`sna/grid/local <compute_sna_atom>`
* :doc:`sna/grid (k) <compute_sna_atom>`
* :doc:`sna/grid/local (k) <compute_sna_atom>`
* :doc:`snad/atom <compute_sna_atom>`
* :doc:`snav/atom <compute_sna_atom>`
* :doc:`sph/e/atom <compute_sph_e_atom>`

View File

@ -43,7 +43,7 @@ OPT.
* :doc:`brownian/asphere <fix_brownian>`
* :doc:`brownian/sphere <fix_brownian>`
* :doc:`charge/regulation <fix_charge_regulation>`
* :doc:`cmap <fix_cmap>`
* :doc:`cmap (k) <fix_cmap>`
* :doc:`colvars <fix_colvars>`
* :doc:`controller <fix_controller>`
* :doc:`damping/cundall <fix_damping_cundall>`
@ -58,6 +58,7 @@ OPT.
* :doc:`dt/reset (k) <fix_dt_reset>`
* :doc:`edpd/source <fix_dpd_source>`
* :doc:`efield (k) <fix_efield>`
* :doc:`efield/lepton <fix_efield_lepton>`
* :doc:`efield/tip4p <fix_efield>`
* :doc:`ehex <fix_ehex>`
* :doc:`electrode/conp (i) <fix_electrode>`
@ -134,7 +135,7 @@ OPT.
* :doc:`nve/dot <fix_nve_dot>`
* :doc:`nve/dotc/langevin <fix_nve_dotc_langevin>`
* :doc:`nve/eff <fix_nve_eff>`
* :doc:`nve/limit <fix_nve_limit>`
* :doc:`nve/limit (k) <fix_nve_limit>`
* :doc:`nve/line <fix_nve_line>`
* :doc:`nve/manifold/rattle <fix_nve_manifold_rattle>`
* :doc:`nve/noforce <fix_nve_noforce>`
@ -178,6 +179,7 @@ OPT.
* :doc:`python/move <fix_python_move>`
* :doc:`qbmsst <fix_qbmsst>`
* :doc:`qeq/comb (o) <fix_qeq_comb>`
* :doc:`qeq/ctip <fix_qeq>`
* :doc:`qeq/dynamic <fix_qeq>`
* :doc:`qeq/fire <fix_qeq>`
* :doc:`qeq/point <fix_qeq>`
@ -186,10 +188,11 @@ OPT.
* :doc:`qeq/slater <fix_qeq>`
* :doc:`qmmm <fix_qmmm>`
* :doc:`qtb <fix_qtb>`
* :doc:`qtpie/reaxff <fix_qtpie_reaxff>`
* :doc:`rattle <fix_shake>`
* :doc:`reaxff/bonds (k) <fix_reaxff_bonds>`
* :doc:`reaxff/species (k) <fix_reaxff_species>`
* :doc:`recenter <fix_recenter>`
* :doc:`recenter (k) <fix_recenter>`
* :doc:`restrain <fix_restrain>`
* :doc:`rheo <fix_rheo>`
* :doc:`rheo/oxidation <fix_rheo_oxidation>`
@ -267,7 +270,7 @@ OPT.
* :doc:`wall/piston <fix_wall_piston>`
* :doc:`wall/reflect (k) <fix_wall_reflect>`
* :doc:`wall/reflect/stochastic <fix_wall_reflect_stochastic>`
* :doc:`wall/region <fix_wall_region>`
* :doc:`wall/region (k) <fix_wall_region>`
* :doc:`wall/region/ees <fix_wall_ees>`
* :doc:`wall/srd <fix_wall_srd>`
* :doc:`wall/table <fix_wall>`

View File

@ -69,7 +69,7 @@ WARNING message is printed. The :doc:`Errors <Errors>` page gives
more information on what errors mean. The documentation for each
command lists restrictions on how the command can be used.
You can use the :ref:`-skiprun <skiprun>` command line flag
You can use the :ref:`-skiprun <skiprun>` command-line flag
to have LAMMPS skip the execution of any ``run``, ``minimize``, or similar
commands to check the entire input for correct syntax to avoid crashes
on typos or syntax errors in long runs.

View File

@ -44,7 +44,7 @@ OPT.
* :doc:`born/coul/wolf/cs (g) <pair_cs>`
* :doc:`born/gauss <pair_born_gauss>`
* :doc:`bpm/spring <pair_bpm_spring>`
* :doc:`brownian (o) <pair_brownian>`
* :doc:`brownian (ko) <pair_brownian>`
* :doc:`brownian/poly (o) <pair_brownian>`
* :doc:`buck (giko) <pair_buck>`
* :doc:`buck/coul/cut (giko) <pair_buck>`
@ -59,6 +59,7 @@ OPT.
* :doc:`comb (o) <pair_comb>`
* :doc:`comb3 <pair_comb>`
* :doc:`cosine/squared <pair_cosine_squared>`
* :doc:`coul/ctip <pair_coul>`
* :doc:`coul/cut (gko) <pair_coul>`
* :doc:`coul/cut/dielectric <pair_dielectric>`
* :doc:`coul/cut/global (o) <pair_coul>`
@ -79,6 +80,7 @@ OPT.
* :doc:`coul/tt <pair_coul_tt>`
* :doc:`coul/wolf (ko) <pair_coul>`
* :doc:`coul/wolf/cs <pair_cs>`
* :doc:`dispersion/d3 <pair_dispersion_d3>`
* :doc:`dpd (giko) <pair_dpd>`
* :doc:`dpd/coul/slater/long (g) <pair_dpd_coul_slater_long>`
* :doc:`dpd/ext (ko) <pair_dpd_ext>`
@ -113,7 +115,9 @@ OPT.
* :doc:`gw/zbl <pair_gw>`
* :doc:`harmonic/cut (o) <pair_harmonic_cut>`
* :doc:`hbond/dreiding/lj (o) <pair_hbond_dreiding>`
* :doc:`hbond/dreiding/lj/angleoffset (o) <pair_hbond_dreiding>`
* :doc:`hbond/dreiding/morse (o) <pair_hbond_dreiding>`
* :doc:`hbond/dreiding/morse/angleoffset (o) <pair_hbond_dreiding>`
* :doc:`hdnnp <pair_hdnnp>`
* :doc:`hippo (g) <pair_amoeba>`
* :doc:`ilp/graphene/hbn (t) <pair_ilp_graphene_hbn>`

View File

@ -1,6 +1,10 @@
Removed commands and packages
=============================
.. contents::
------
This page lists LAMMPS commands and packages that have been removed from
the distribution and provides suggestions for alternatives or
replacements. LAMMPS has special dummy styles implemented, that will
@ -8,94 +12,32 @@ stop LAMMPS and print a suitable error message in most cases, when a
style/command is used that has been removed or will replace the command
with the direct alternative (if available) and print a warning.
restart2data tool
-----------------
.. versionchanged:: 23Nov2013
The functionality of the restart2data tool has been folded into the
LAMMPS executable directly instead of having a separate tool. A
combination of the commands :doc:`read_restart <read_restart>` and
:doc:`write_data <write_data>` can be used to the same effect. For
added convenience this conversion can also be triggered by
:doc:`command line flags <Run_options>`
Fix ave/spatial and fix ave/spatial/sphere
------------------------------------------
.. deprecated:: 11Dec2015
The fixes ave/spatial and ave/spatial/sphere have been removed from LAMMPS
since they were superseded by the more general and extensible "chunk
infrastructure". Here the system is partitioned in one of many possible
ways through the :doc:`compute chunk/atom <compute_chunk_atom>` command
and then averaging is done using :doc:`fix ave/chunk <fix_ave_chunk>`.
Please refer to the :doc:`chunk HOWTO <Howto_chunk>` section for an overview.
Box command
-----------
.. deprecated:: 22Dec2022
The *box* command has been removed and the LAMMPS code changed so it won't
be needed. If present, LAMMPS will ignore the command and print a warning.
Reset_ids, reset_atom_ids, reset_mol_ids commands
-------------------------------------------------
.. deprecated:: 22Dec2022
The *reset_ids*, *reset_atom_ids*, and *reset_mol_ids* commands have
been folded into the :doc:`reset_atoms <reset_atoms>` command. If
present, LAMMPS will replace the commands accordingly and print a
warning.
LATTE package
-------------
.. deprecated:: 15Jun2023
The LATTE package with the fix latte command was removed from LAMMPS.
This functionality has been superseded by :doc:`fix mdi/qm <fix_mdi_qm>`
and :doc:`fix mdi/qmmm <fix_mdi_qmmm>` from the :ref:`MDI package
<PKG-MDI>`. These fixes are compatible with several quantum software
packages, including LATTE. See the ``examples/QUANTUM`` dir and the
:doc:`MDI coupling HOWTO <Howto_mdi>` page. MDI supports running LAMMPS
with LATTE as a plugin library (similar to the way fix latte worked), as
well as on a different set of MPI processors.
MEAM package
LAMMPS shell
------------
The MEAM package in Fortran has been replaced by a C++ implementation.
The code in the :ref:`MEAM package <PKG-MEAM>` is a translation of the
Fortran code of MEAM into C++, which removes several restrictions
(e.g. there can be multiple instances in hybrid pair styles) and allows
for some optimizations leading to better performance. The pair style
:doc:`meam <pair_meam>` has the exact same syntax. For a transition
period the C++ version of MEAM was called USER-MEAMC so it could
coexist with the Fortran version.
.. versionchanged:: 29Aug2024
Minimize style fire/old
-----------------------
The LAMMPS shell has been removed from the LAMMPS distribution. Users
are encouraged to use the :ref:`LAMMPS-GUI <lammps_gui>` tool instead.
.. deprecated:: 8Feb2023
i-PI tool
---------
Minimize style *fire/old* has been removed. Its functionality can be
reproduced with *fire* with specific options. Please see the
:doc:`min_modify command <min_modify>` documentation for details.
.. versionchanged:: 27Jun2024
Pair style mesont/tpm, compute style mesont, atom style mesont
--------------------------------------------------------------
The i-PI tool has been removed from the LAMMPS distribution. Instead,
instructions to install i-PI from PyPI via pip are provided.
.. deprecated:: 8Feb2023
USER-REAXC package
------------------
Pair style *mesont/tpm*, compute style *mesont*, and atom style
*mesont* have been removed from the :ref:`MESONT package <PKG-MESONT>`.
The same functionality is available through
:doc:`pair style mesocnt <pair_mesocnt>`,
:doc:`bond style mesocnt <bond_mesocnt>` and
:doc:`angle style mesocnt <angle_mesocnt>`.
.. deprecated:: 7Feb2024
The USER-REAXC package has been renamed to :ref:`REAXFF <PKG-REAXFF>`.
In the process also the pair style and related fixes were renamed to use
the "reaxff" string instead of "reax/c". For a while LAMMPS was maintaining
backward compatibility by providing aliases for the styles. These have
been removed, so using "reaxff" is now *required*.
MPIIO package
-------------
@ -115,7 +57,6 @@ Similarly, the "nfile" and "fileper" keywords exist for restarts:
see :doc:`restart <restart>`, :doc:`read_restart <read_restart>`,
:doc:`write_restart <write_restart>`.
MSCG package
------------
@ -126,9 +67,73 @@ for many years and instead superseded by the `OpenMSCG software
<https://software.rcc.uchicago.edu/mscg/>`_ of the Voth group at the
University of Chicago, which can be used independent from LAMMPS.
LATTE package
-------------
.. deprecated:: 15Jun2023
The LATTE package with the fix latte command was removed from LAMMPS.
This functionality has been superseded by :doc:`fix mdi/qm <fix_mdi_qm>`
and :doc:`fix mdi/qmmm <fix_mdi_qmmm>` from the :ref:`MDI package
<PKG-MDI>`. These fixes are compatible with several quantum software
packages, including LATTE. See the ``examples/QUANTUM`` dir and the
:doc:`MDI coupling HOWTO <Howto_mdi>` page. MDI supports running LAMMPS
with LATTE as a plugin library (similar to the way fix latte worked), as
well as on a different set of MPI processors.
Minimize style fire/old
-----------------------
.. deprecated:: 8Feb2023
Minimize style *fire/old* has been removed. Its functionality can be
reproduced with style *fire* with specific options. Please see the
:doc:`min_modify command <min_modify>` documentation for details.
Pair style mesont/tpm, compute style mesont, atom style mesont
--------------------------------------------------------------
.. deprecated:: 8Feb2023
Pair style *mesont/tpm*, compute style *mesont*, and atom style
*mesont* have been removed from the :ref:`MESONT package <PKG-MESONT>`.
The same functionality is available through
:doc:`pair style mesocnt <pair_mesocnt>`,
:doc:`bond style mesocnt <bond_mesocnt>` and
:doc:`angle style mesocnt <angle_mesocnt>`.
Box command
-----------
.. deprecated:: 22Dec2022
The *box* command has been removed and the LAMMPS code changed so it won't
be needed. If present, LAMMPS will ignore the command and print a warning.
Reset_ids, reset_atom_ids, reset_mol_ids commands
-------------------------------------------------
.. deprecated:: 22Dec2022
The *reset_ids*, *reset_atom_ids*, and *reset_mol_ids* commands have
been folded into the :doc:`reset_atoms <reset_atoms>` command. If
present, LAMMPS will replace the commands accordingly and print a
warning.
MESSAGE package
---------------
.. deprecated:: 4May2022
The MESSAGE package has been removed since it was superseded by the
:ref:`MDI package <PKG-MDI>`. MDI implements the same functionality
and in a more general way with direct support for more applications.
REAX package
------------
.. deprecated:: 4Jan2019
The REAX package has been removed since it was superseded by the
:ref:`REAXFF package <PKG-REAXFF>`. The REAXFF package has been tested
to yield equivalent results to the REAX package, offers better
@ -138,20 +143,25 @@ syntax compatible with the removed reax pair style, so input files will
have to be adapted. The REAXFF package was originally called
USER-REAXC.
USER-REAXC package
------------------
MEAM package
------------
.. deprecated:: 7Feb2024
.. deprecated:: 4Jan2019
The USER-REAXC package has been renamed to :ref:`REAXFF <PKG-REAXFF>`.
In the process also the pair style and related fixes were renamed to use
the "reaxff" string instead of "reax/c". For a while LAMMPS was maintaining
backward compatibility by providing aliases for the styles. These have
been removed, so using "reaxff" is now *required*.
The MEAM package in Fortran has been replaced by a C++ implementation.
The code in the :ref:`MEAM package <PKG-MEAM>` is a translation of the
Fortran code of MEAM into C++, which removes several restrictions
(e.g. there can be multiple instances in hybrid pair styles) and allows
for some optimizations leading to better performance. The pair style
:doc:`meam <pair_meam>` has the exact same syntax. For a transition
period the C++ version of MEAM was called USER-MEAMC so it could
coexist with the Fortran version.
USER-CUDA package
-----------------
.. deprecated:: 31May2016
The USER-CUDA package had been removed, since it had been unmaintained
for a long time and had known bugs and problems. Significant parts of
the design were transferred to the
@ -160,19 +170,27 @@ performance characteristics on NVIDIA GPUs. Both, the KOKKOS
and the :ref:`GPU package <PKG-GPU>` are maintained
and allow running LAMMPS with GPU acceleration.
i-PI tool
---------
Fix ave/spatial and fix ave/spatial/sphere
------------------------------------------
.. versionchanged:: 27Jun2024
.. deprecated:: 11Dec2015
The i-PI tool has been removed from the LAMMPS distribution. Instead,
instructions to install i-PI from PyPI via pip are provided.
The fixes ave/spatial and ave/spatial/sphere have been removed from LAMMPS
since they were superseded by the more general and extensible "chunk
infrastructure". Here the system is partitioned in one of many possible
ways through the :doc:`compute chunk/atom <compute_chunk_atom>` command
and then averaging is done using :doc:`fix ave/chunk <fix_ave_chunk>`.
Please refer to the :doc:`chunk HOWTO <Howto_chunk>` section for an overview.
LAMMPS shell
------------
restart2data tool
-----------------
.. versionchanged:: 29Aug2024
.. deprecated:: 23Nov2013
The LAMMPS shell has been removed from the LAMMPS distribution. Users
are encouraged to use the :ref:`LAMMPS-GUI <lammps_gui>` tool instead.
The functionality of the restart2data tool has been folded into the
LAMMPS executable directly instead of having a separate tool. A
combination of the commands :doc:`read_restart <read_restart>` and
:doc:`write_data <write_data>` can be used to the same effect. For
added convenience this conversion can also be triggered by
:doc:`command-line flags <Run_options>`

View File

@ -203,6 +203,7 @@ processed in the expected order before types are removed from dynamic
dispatch.
.. admonition:: Important Notes
:class: note
In order to be able to detect incompatibilities at compile time and
to avoid unexpected behavior, it is crucial that all member functions
@ -300,18 +301,24 @@ Formatting with the {fmt} library
The LAMMPS source code includes a copy of the `{fmt} library
<https://fmt.dev>`_, which is preferred over formatting with the
"printf()" family of functions. The primary reason is that it allows
a typesafe default format for any type of supported data. This is
"printf()" family of functions. The primary reason is that it allows a
typesafe default format for any type of supported data. This is
particularly useful for formatting integers of a given size (32-bit or
64-bit) which may require different format strings depending on
compile time settings or compilers/operating systems. Furthermore,
{fmt} gives better performance, has more functionality, a familiar
formatting syntax that has similarities to ``format()`` in Python, and
provides a facility that can be used to integrate format strings and a
variable number of arguments into custom functions in a much simpler
way than the varargs mechanism of the C library. Finally, {fmt} has
been included into the C++20 language standard, so changes to adopt it
are future-proof.
64-bit) which may require different format strings depending on compile
time settings or compilers/operating systems. Furthermore, {fmt} gives
better performance, has more functionality, a familiar formatting syntax
that has similarities to ``format()`` in Python, and provides a facility
that can be used to integrate format strings and a variable number of
arguments into custom functions in a much simpler way than the varargs
mechanism of the C library. Finally, {fmt} has been included into the
C++20 language standard as ``std::format()``, so changes to adopt it are
future-proof, for as long as they are not using any extensions that are
not (yet) included into C++.
The long-term plan is to switch to using ``std::format()`` instead of
``fmt::format()`` when the minimum C++ standard required for LAMMPS will
be set to C++20. See the :ref:`basic build instructions <compile>` for
more details.
Formatted strings are frequently created by calling the
``fmt::format()`` function, which will return a string as a
@ -319,11 +326,13 @@ Formatted strings are frequently created by calling the
``printf()``, the {fmt} library uses ``{}`` to embed format descriptors.
In the simplest case, no additional characters are needed, as {fmt} will
choose the default format based on the data type of the argument.
Otherwise, the ``fmt::print()`` function may be used instead of
``printf()`` or ``fprintf()``. In addition, several LAMMPS output
functions, that originally accepted a single string as argument have
been overloaded to accept a format string with optional arguments as
well (e.g., ``Error::all()``, ``Error::one()``, ``utils::logmesg()``).
Otherwise, the :cpp:func:`utils::print() <LAMMPS_NS::utils::print>`
function may be used instead of ``printf()`` or ``fprintf()``. In
addition, several LAMMPS output functions, that originally accepted a
single string as argument have been overloaded to accept a format string
with optional arguments as well (e.g., ``Error::all()``,
``Error::one()``, :cpp:func:`utils::logmesg()
<LAMMPS_NS::utils::logmesg>`).
Summary of the {fmt} format syntax
==================================

View File

@ -79,19 +79,19 @@ containing ``double`` values. To correctly store integers that may be
64-bit (bigint, tagint, imageint) in the buffer, you need to use the
:ref:`ubuf union <communication_buffer_coding_with_ubuf>` construct.
The *Fix*, *Compute*, and *Dump* classes can also invoke the same kind
of forward and reverse communication operations using the same *Comm*
class methods. Likewise, the same pack/unpack methods and
The *Fix*, *Bond*, *Compute*, and *Dump* classes can also invoke the
same kind of forward and reverse communication operations using the
same *Comm* class methods. Likewise, the same pack/unpack methods and
comm_forward/comm_reverse variables must be defined by the calling
*Fix*, *Compute*, or *Dump* class.
*Fix*, *Bond*, *Compute*, or *Dump* class.
For *Fix* classes, there is an optional second argument to the
For all of these classes, there is an optional second argument to the
*forward_comm()* and *reverse_comm()* call which can be used when the
fix performs multiple modes of communication, with different numbers
of values per atom. The fix should set the *comm_forward* and
class performs multiple modes of communication, with different numbers
of values per atom. The class should set the *comm_forward* and
*comm_reverse* variables to the maximum value, but can invoke the
communication for a particular mode with a smaller value. For this
to work, the *pack_forward_comm()*, etc methods typically use a class
to work, the *pack_forward_comm()*, etc. methods typically use a class
member variable to choose which values to pack/unpack into/from the
buffer.

View File

@ -209,7 +209,7 @@ nve, nvt, npt.
At the end of the timestep, fixes that contain an ``end_of_step()``
method are invoked. These typically perform a diagnostic calculation,
e.g. the ave/time and ave/spatial fixes. The final operation of the
e.g. the ave/time and ave/chunk fixes. The final operation of the
timestep is to perform any requested output, via the ``write()`` method
of the Output class. There are 3 kinds of LAMMPS output: thermodynamic
output to the screen and log file, snapshots of atom data to a dump

View File

@ -7,13 +7,7 @@ typically document what a variable stores, what a small section of
code does, or what a function does and its input/outputs. The topics
on this page are intended to document code functionality at a higher level.
Available topics are:
- `Reading and parsing of text and text files`_
- `Requesting and accessing neighbor lists`_
- `Choosing between a custom atom style, fix property/atom, and fix STORE/ATOM`_
- `Fix contributions to instantaneous energy, virial, and cumulative energy`_
- `KSpace PPPM FFT grids`_
.. contents::
----
@ -218,6 +212,149 @@ command:
neighbor->add_request(this, "delete_atoms", NeighConst::REQ_FULL);
Errors, warnings, and informational messages
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
LAMMPS has specialized functionality to handle errors (which should
terminate LAMMPS), warning messages (which should indicate possible
problems *without* terminating LAMMPS), and informational text for
messages about the progress and chosen settings. We *strongly*
encourage using these facilities and to *stay away* from using
``printf()`` or ``fprintf()`` or ``std::cout`` or ``std::cerr`` and
calling ``MPI_Abort()`` or ``exit()`` directly. Warnings and
informational messages should be printed only on MPI rank 0 to avoid
flooding the output when running in parallel with many MPI processes.
**Errors**
When LAMMPS encounters an error, for example a syntax error in the
input, then a suitable error message should be printed giving a brief,
one line remark about the reason and then call either ``Error::all()``
or ``Error::one()``. ``Error::all()`` must be called when the failing
code path is executed by *all* MPI processes and the error condition
will appear for *all* MPI processes the same. If desired, each MPI
process may set a flag to either 0 or 1 and then MPI_Allreduce()
searching for the maximum can be used to determine if there was an error
on *any* of the MPI processes and make this information available to
*all*. ``Error::one()`` in contrast needs to be called when only one or
a few MPI processes execute the code path or can have the error
condition. ``Error::all()`` is generally the preferred option.
Calling these functions does not abort LAMMPS directly, but rather
throws either a ``LAMMPSException`` (from ``Error::all()``) or a
``LAMMPSAbortException`` (from ``Error::one()``). These exceptions are
caught by the LAMMPS ``main()`` program and then handled accordingly.
The reason for this approach is to support applications, especially
graphical applications like :ref:`LAMMPS-GUI <lammps_gui>`, that are
linked to the LAMMPS library and have a mechanism to avoid that an error
in LAMMPS terminates the application. By catching the exceptions, the
application can delete the failing LAMMPS class instance and create a
new one to try again. In a similar fashion, the :doc:`LAMMPS Python
module <Python_module>` checks for this and then re-throws corresponding
Python exception, which in turn can be caught by the calling Python
code.
There are multiple "signatures" that can be called:
- ``Error::all(FLERR, "Error message")``: this will abort LAMMPS with
the error message "Error message", followed by the last line of input
that was read and processed before the error condition happened.
- ``Error::all(FLERR, Error::NOLASTLINE, "Error message")``: this is the
same as before but without the last line of input. This is preferred
for errors that would happen *during* a :doc:`run <run>` or
:doc:`minimization <minimize>`, since showing the "run" or "minimize"
command would be the last line, but is unrelated to the error.
- ``Error::all(FLERR, idx, "Error message")``: this is for argument
parsing where "idx" is the index (starting at 0) of the argument for a
LAMMPS command that is causing the failure (use -1 for the command
itself). For index 0, you need to use the constant ``Error::ARGZERO``
to work around the inability of some compilers to disambiguate between
a NULL pointer and an integer constant 0, even with an added type cast.
The output may also include the last input line *before* and
*after*, if they differ due to substituting variables. A textual
indicator is pointing to the specific word that failed. Using the
constant ``Error::NOPOINTER`` in place of the *idx* argument will
suppress the marker and then the behavior is like the *idx* argument
is not provided.
FLERR is a macro containing the filename and line where the Error class
is called and that information is appended to the error message. This
allows to quickly find the relevant source code causing the error. For
all three signatures, the single string "Error message" may be replaced
with a format string using '{}' placeholders and followed by a variable
number of arguments, one for each placeholder. This format string and
the arguments are then handed for formatting to the `{fmt} library
<https://fmt.dev>`_ (which is bundled with LAMMPS) and thus allow
processing similar to the "format()" functionality in Python.
.. note::
For commands like :doc:`fix ave/time <fix_ave_time>` that accept
wildcard arguments, the :cpp:func:`utils::expand_args` function
may be passed as an optional argument where the function will provide
a map to the original arguments from the expanded argument indices.
For complex errors, that can have multiple causes and which cannot be
explained in a single line, you can append to the error message, the
string created by :cpp:func:`utils::errorurl`, which then provides a
URL pointing to a paragraph of the :doc:`Errors_details` that
corresponds to the number provided. Example:
.. code-block:: c++
error->all(FLERR, "Unknown identifier in data file: {}{}", keyword, utils::errorurl(1));
This will output something like this:
.. parsed-literal::
ERROR: Unknown identifier in data file: Massess
For more information see https://docs.lammps.org/err0001 (src/read_data.cpp:1482)
Last input line: read_data data.peptide
Where the URL points to the first paragraph with explanations on
the :doc:`Errors_details` page in the manual.
**Warnings**
To print warnings, the ``Errors::warning()`` function should be used.
It also requires the FLERR macros as first argument to easily identify
the location of the warning in the source code. Same as with the error
functions above, the function has two variants: one just taking a single
string as final argument and a second that uses the `{fmt} library
<https://fmt.dev>`_ to make it similar to, say, ``fprintf()``. One
motivation to use this function is that it will output warnings with
always the same capitalization of the leading "WARNING" string. A
second is that it has a built in rate limiter. After a given number (by
default 100), that can be set via the :doc:`thermo_modify command
<thermo_modify>` no more warnings are printed. Also, warnings are
written consistently to both screen and logfile or not, depending on the
settings for :ref:`screen <screen>` or :doc:`logfile <log>` output.
.. note::
Unlike ``Error::all()``, the warning function will produce output on
*every* MPI process, so it typically would be prefixed with an if
statement testing for ``comm->me == 0``, i.e. limiting output to MPI
rank 0.
**Informational messages**
Finally, for informational message LAMMPS has the
:cpp:func:`utils::logmesg() convenience function
<LAMMPS_NS::utils::logmesg>`. It also uses the `{fmt} library
<https://fmt.dev>`_ to support using a format string followed by a
matching number of arguments. It will output the resulting formatted
text to both, the screen and the logfile and will honor the
corresponding settings about whether this output is active and to which
file it should be send. Same as for ``Error::warning()``, it would
produce output for every MPI process and thus should usually be called
only on MPI rank 0 to avoid flooding the output when running with many
parallel processes.
Choosing between a custom atom style, fix property/atom, and fix STORE/ATOM
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

View File

@ -94,12 +94,12 @@ represents what is generally referred to as an "instance of LAMMPS". It
is a composite holding pointers to instances of other core classes
providing the core functionality of the MD engine in LAMMPS and through
them abstractions of the required operations. The constructor of the
LAMMPS class will instantiate those instances, process the command line
LAMMPS class will instantiate those instances, process the command-line
flags, initialize MPI (if not already done) and set up file pointers for
input and output. The destructor will shut everything down and free all
associated memory. Thus code for the standalone LAMMPS executable in
``main.cpp`` simply initializes MPI, instantiates a single instance of
LAMMPS while passing it the command line flags and input script. It
LAMMPS while passing it the command-line flags and input script. It
deletes the LAMMPS instance after the method reading the input returns
and shuts down the MPI environment before it exits the executable.

View File

@ -227,12 +227,12 @@ Tests for the C-style library interface
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Tests for validating the LAMMPS C-style library interface are in the
``unittest/c-library`` folder. They are implemented either to be used
for utility functions or for LAMMPS commands, but use the functions
implemented in the ``src/library.cpp`` file as much as possible. There
may be some overlap with other tests, but only in as much as is required
to test the C-style library API. The tests are distributed over
multiple test programs which try to match the grouping of the
``unittest/c-library`` folder. They text either utility functions or
LAMMPS commands, but use the functions implemented in
``src/library.cpp`` as much as possible. There may be some overlap with
other tests as far as the LAMMPS functionality is concerned, but the
focus is on testing the C-style library API. The tests are distributed
over multiple test programs which try to match the grouping of the
functions in the source code and :ref:`in the manual <lammps_c_api>`.
This group of tests also includes tests invoking LAMMPS in parallel
@ -258,7 +258,7 @@ Tests for the Python module and package
The ``unittest/python`` folder contains primarily tests for classes and
functions in the LAMMPS python module but also for commands in the
PYTHON package. These tests are only enabled if the necessary
PYTHON package. These tests are only enabled, if the necessary
prerequisites are detected or enabled during configuration and
compilation of LAMMPS (shared library build enabled, Python interpreter
found, Python development files found).
@ -272,29 +272,30 @@ Tests for the Fortran interface
Tests for using the Fortran module are in the ``unittest/fortran``
folder. Since they are also using the GoogleTest library, they require
implementing test wrappers in C++ that will call fortran functions
which provide a C function interface through ISO_C_BINDINGS that will in
turn call the functions in the LAMMPS Fortran module.
test wrappers written in C++ that will call fortran functions with a C
function interface through ISO_C_BINDINGS which will in turn call the
functions in the LAMMPS Fortran module.
Tests for the C++-style library interface
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The tests in the ``unittest/cplusplus`` folder are somewhat similar to
the tests for the C-style library interface, but do not need to test the
several convenience and utility functions that are only available through
the C-style interface. Instead it can focus on the more generic features
that are used internally. This part of the unit tests is currently still
mostly in the planning stage.
convenience and utility functions that are only available through the
C-style library interface. Instead they focus on the more generic
features that are used in LAMMPS internally. This part of the unit
tests is currently still mostly in the planning stage.
Tests for reading and writing file formats
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The ``unittest/formats`` folder contains test programs for reading and
writing files like data files, restart files, potential files or dump files.
This covers simple things like the file i/o convenience functions in the
``utils::`` namespace to complex tests of atom styles where creating and
deleting atoms with different properties is tested in different ways
and through script commands or reading and writing of data or restart files.
writing files like data files, restart files, potential files or dump
files. This covers simple things like the file i/o convenience
functions in the ``utils::`` namespace to complex tests of atom styles
where creating and deleting of atoms with different properties is tested
in different ways and through script commands or reading and writing of
data or restart files.
Tests for styles computing or modifying forces
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -443,7 +444,7 @@ file for a style that is similar to one to be tested. The file name should
follow the naming conventions described above and after copying the file,
the first step is to replace the style names where needed. The coefficient
values do not have to be meaningful, just in a reasonable range for the
given system. It does not matter if some forces are large, as long as
given system. It does not matter if some forces are large, for as long as
they do not diverge.
The template input files define a large number of index variables at the top
@ -476,7 +477,7 @@ the tabulated coulomb, to test both code paths. The reference results in the YA
files then should be compared manually, if they agree well enough within the limits
of those two approximations.
The ``test_pair_style`` and equivalent programs have special command line options
The ``test_pair_style`` and equivalent programs have special command-line options
to update the YAML files. Running a command like
.. code-block:: bash
@ -531,19 +532,20 @@ Python module.
Troubleshooting failed unit tests
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The are by default no unit tests for newly added features (e.g. pair, fix,
or compute styles) unless your pull request also includes tests for the
added features. If you are modifying some features, you may see failures
for existing tests, if your modifications have some unexpected side effects
or your changes render the existing test invalid. If you are adding an
accelerated version of an existing style, then only tests for INTEL,
KOKKOS (with OpenMP only), OPENMP, and OPT will be run automatically.
Tests for the GPU package are time consuming and thus are only run
*after* a merge, or when a special label, ``gpu_unit_tests`` is added
to the pull request. After the test has started, it is often best to
remove the label since every PR activity will re-trigger the test (that
is a limitation of triggering a test with a label). Support for unit
tests when using KOKKOS with GPU acceleration is currently not supported.
There are by default no unit tests for newly added features (e.g. pair,
fix, or compute styles) unless your pull request also includes tests for
these added features. If you are modifying some existing LAMMPS
features, you may see failures for existing tests, if your modifications
have some unexpected side effects or your changes render the existing
test invalid. If you are adding an accelerated version of an existing
style, then only tests for INTEL, KOKKOS (with OpenMP only), OPENMP, and
OPT will be run automatically. Tests for the GPU package are time
consuming and thus are only run *after* a merge, or when a special
label, ``gpu_unit_tests`` is added to the pull request. After the test
has started, it is often best to remove the label since every PR
activity will re-trigger the test (that is a limitation of triggering a
test with a label). Support for unit tests using KOKKOS with GPU
acceleration is currently not supported.
When you see a failed build on GitHub, click on ``Details`` to be taken
to the corresponding LAMMPS Jenkins CI web page. Click on the "Exit"
@ -588,7 +590,7 @@ While the epsilon (relative precision) for a single, `IEEE 754 compliant
<https://en.wikipedia.org/wiki/IEEE_754>`_, double precision floating
point operation is at about 2.2e-16, the achievable precision for the
tests is lower due to most numbers being sums over intermediate results
and the non-associativity of floating point math leading to larger
for which the non-associativity of floating point math leads to larger
errors. As a rule of thumb, the test epsilon can often be in the range
5.0e-14 to 1.0e-13. But for "noisy" force kernels, e.g. those a larger
amount of arithmetic operations involving `exp()`, `log()` or `sin()`
@ -602,14 +604,14 @@ of floating point operations or that some or most intermediate operations
may be done using approximations or with single precision floating point
math.
To rerun the failed unit test individually, change to the ``build`` directory
To rerun a failed unit test individually, change to the ``build`` directory
and run the test with verbose output. For example,
.. code-block:: bash
env TEST_ARGS=-v ctest -R ^MolPairStyle:lj_cut_coul_long -V
``ctest`` with the ``-V`` flag also shows the exact command line
``ctest`` with the ``-V`` flag also shows the exact command
of the test. One can then use ``gdb --args`` to further debug and
catch exceptions with the test command, for example,

View File

@ -133,6 +133,9 @@ and parsing files or arguments.
.. doxygenfunction:: trim_comment
:project: progguide
.. doxygenfunction:: strcompress
:project: progguide
.. doxygenfunction:: strip_style_suffix
:project: progguide
@ -166,6 +169,9 @@ and parsing files or arguments.
.. doxygenfunction:: split_lines
:project: progguide
.. doxygenfunction:: strsame
:project: progguide
.. doxygenfunction:: strmatch
:project: progguide
@ -232,12 +238,21 @@ Convenience functions
.. doxygenfunction:: logmesg(LAMMPS *lmp, const std::string &mesg)
:project: progguide
.. doxygenfunction:: print(FILE *fp, const std::string &format, Args&&... args)
:project: progguide
.. doxygenfunction:: print(FILE *fp, const std::string &mesg)
:project: progguide
.. doxygenfunction:: errorurl
:project: progguide
.. doxygenfunction:: missing_cmd_args
:project: progguide
.. doxygenfunction:: point_to_error
:project: progguide
.. doxygenfunction:: flush_buffers(LAMMPS *lmp)
:project: progguide

View File

@ -12,3 +12,4 @@ details are provided for writing code for LAMMPS.
Developer_write_pair
Developer_write_fix
Developer_write_command

View File

@ -0,0 +1,348 @@
Writing a new command style
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Command styles allow to do system manipulations or interfaces to the
operating system.
In the text below, we will discuss the implementation of one example. As
shown on the page for :doc:`writing or extending command styles
<Modify_command>`, in order to implement a new command style, a new class
must be written that is either directly or indirectly derived from the
``Command`` class. There is just one method that must be implemented:
``Command::command()``. In addition, a custom constructor is needed to get
access to the members of the ``LAMMPS`` class like the ``Error`` class to
print out error messages. The ``Command::command()`` method processes the
arguments passed to the command in the input and executes it. Any other
methods would be for the convenience of implementation of the new command.
In general, new command styles should be added to the :ref:`EXTRA-COMMAND
package <PKG-EXTRA-COMMAND>`. If you feel that your contribution should be
added to a different package, please consult with the :doc:`LAMMPS
developers <Intro_authors>` first. The contributed code needs to support
the :doc:`traditional GNU make build process <Build_make>` **and** the
:doc:`CMake build process <Build_cmake>`.
----
Case 1: Implementing the geturl command
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
In this section, we will describe the procedure of adding a simple command
style to LAMMPS: the :doc:`geturl command <geturl>` that allows to download
files directly without having to rely on an external program like "wget" or
"curl". The complete implementation can be found in the files
``src/EXTRA-COMMAND/geturl.cpp`` and ``src/EXTRA-COMMAND/geturl.h`` of the
LAMMPS source code.
Interfacing the *libcurl* library
"""""""""""""""""""""""""""""""""
Rather than implementing the various protocols for downloading files, we
rely on an external library: `libcurl library <https:://curl.se/libcurl/>`_.
This requires that the library and its headers are installed. For the
traditional GNU make build system, this simply requires edits to the machine
makefile to add compilation flags like for other libraries. For the CMake
based build system, we need to add some lines to the file
``cmake/Modules/Packages/EXTRA-COMMAND.cmake``:
.. code-block:: cmake
find_package(CURL QUIET COMPONENTS HTTP HTTPS)
option(WITH_CURL "Enable libcurl support" ${CURL_FOUND})
if(WITH_CURL)
find_package(CURL REQUIRED COMPONENTS HTTP HTTPS)
target_compile_definitions(lammps PRIVATE -DLAMMPS_CURL)
target_link_libraries(lammps PRIVATE CURL::libcurl)
endif()
The first ``find_package()`` command uses a built-in CMake module to find
an existing *libcurl* installation with development headers and support for
using the HTTP and HTTPS protocols. The "QUIET" flag ensures that there is
no screen output and no error if the search fails. The status of the search
is recorded in the "${CURL_FOUND}" variable. That variable sets the default
of the WITH_CURL option, which toggles whether support for *libcurl* is included
or not.
The second ``find_package()`` uses the "REQUIRED" flag to produce an error
if the WITH_CURL option was set to ``True``, but no suitable *libcurl*
implementation with development support was found. This construct is used
so that the CMake script code inside the ``if(WITH_CURL)`` and ``endif()``
block can be expanded later to download and compile *libcurl* as part of the
LAMMPS build process, if it is not found locally. The
``target_compile_definitions()`` function added the define ``-DLAMMPS_CURL``
to the compilation flags when compiling objects for the LAMMPS library.
This allows to always compile the :doc:`geturl command <geturl>`, but use
pre-processing to compile in the interface to *libcurl* only when it is
present and usable and otherwise stop with an error message about the
unavailability of *libcurl* to execute the functionality of the command.
Header file
"""""""""""
The first segment of any LAMMPS source should be the copyright and
license statement. Note the marker in the first line to indicate to
editors like emacs that this file is a C++ source, even though the .h
extension suggests a C source (this is a convention inherited from the
very beginning of the C++ version of LAMMPS).
.. code-block:: c++
/* -*- c++ -*- ----------------------------------------------------------
LAMMPS - Large-scale Atomic/Molecular Massively Parallel Simulator
https://www.lammps.org/, Sandia National Laboratories
LAMMPS development team: developers@lammps.org
Copyright (2003) Sandia Corporation. Under the terms of Contract
DE-AC04-94AL85000 with Sandia Corporation, the U.S. Government retains
certain rights in this software. This software is distributed under
the GNU General Public License.
See the README file in the top-level LAMMPS directory.
------------------------------------------------------------------------- */
Every command style must be registered in LAMMPS by including the following
lines of code in the second part of the header after the copyright
message and before the include guards for the class definition:
.. code-block:: c++
#ifdef COMMAND_CLASS
// clang-format off
CommandStyle(geturl,GetURL);
// clang-format on
#else
This block between ``#ifdef COMMAND_CLASS`` and ``#else`` will be
included by the ``Input`` class in ``input.cpp`` to build a map of
"factory functions" that will create an instance of a Command class
and call its ``command()`` method. The map connects the name of the
command ``geturl`` with the name of the class ``GetURL``. During
compilation, LAMMPS constructs a file ``style_command.h`` that contains
``#include`` statements for all "installed" command styles. Before
including ``style_command.h`` into ``input.cpp``, the ``COMMAND_CLASS``
define is set and the ``CommandStyle(name,class)`` macro defined. The
code of the macro adds the installed command styles to the "factory map"
which enables the ``Input`` to execute the command.
The list of header files to include in ``style_command.h`` is automatically
updated by the build system if there are new files, so the presence of the
new header file in the ``src/EXTRA-COMMAND`` folder and the enabling of the
EXTRA-COMMAND package will trigger LAMMPS to include the new command style
when it is (re-)compiled. The "// clang-format" format comments are needed
so that running :ref:`clang-format <clang-format>` on the file will not
insert unwanted blanks which would break the ``CommandStyle`` macro.
The third part of the header file is the actual class definition of the
``GetURL`` class. This has the custom constructor and the ``command()``
method implemented by this command style. For the constructor there is
nothing to do but to pass the ``lmp`` pointer to the base class. Since the
``command()`` method is labeled "virtual" in the base class, it must be
given the "override" property.
.. code-block:: c++
#ifndef LMP_GETURL_H
#define LMP_GETURL_H
#include "command.h"
namespace LAMMPS_NS {
class GetURL : public Command {
public:
GetURL(class LAMMPS *lmp) : Command(lmp) {};
void command(int, char **) override;
};
} // namespace LAMMPS_NS
#endif
#endif
The "override" property helps to detect unexpected mismatches because
compilation will stop with an error in case the signature of a function
is changed in the base class without also changing it in all derived
classes.
Implementation file
"""""""""""""""""""
We move on to the implementation of the ``GetURL`` class in the
``geturl.cpp`` file. This file also starts with a LAMMPS copyright and
license header. Below that notice is typically the space where comments may
be added with additional information about this specific file, the
author(s), affiliation(s), and email address(es). This way the contributing
author(s) can be easily contacted, when there are questions about the
implementation later. Since the file(s) may be around for a long time, it
is beneficial to use some kind of "permanent" email address, if possible.
.. code-block:: c++
/* ----------------------------------------------------------------------
LAMMPS - Large-scale Atomic/Molecular Massively Parallel Simulator
https://www.lammps.org/, Sandia National Laboratories
LAMMPS development team: developers@lammps.org
Copyright (2003) Sandia Corporation. Under the terms of Contract
DE-AC04-94AL85000 with Sandia Corporation, the U.S. Government retains
certain rights in this software. This software is distributed under
the GNU General Public License.
See the README file in the top-level LAMMPS directory.
------------------------------------------------------------------------- */
/* ----------------------------------------------------------------------
Contributing authors: Axel Kohlmeyer (Temple U),
------------------------------------------------------------------------- */
#include "geturl.h"
#include "comm.h"
#include "error.h"
#if defined(LAMMPS_CURL)
#include <curl/curl.h>
#endif
using namespace LAMMPS_NS;
The second section of the implementation file has various include
statements. The include file for the class header has to come first, then a
couple of LAMMPS classes (sorted alphabetically) followed by the header for
the *libcurl* interface. This is wrapped into an ``#ifdef`` block so that
LAMMPS will compile this file without error when the *libcurl* header is not
available and thus the define not set. The final statement of this segment
imports the ``LAMMPS_NS::`` namespace globally for this file. This way, all
LAMMPS specific functions and classes do not have to be prefixed with
``LAMMPS_NS::``.
The command() function (required)
"""""""""""""""""""""""""""""""""
Since the required custom constructor is trivial and implemented in the
header, there is only one function that must be implemented for a command
style and that is the ``command()`` function.
.. code-block:: c++
void GetURL::command(int narg, char **arg)
{
#if !defined(LAMMPS_CURL)
error->all(FLERR, "LAMMPS has not been compiled with libcurl support");
#else
if (narg < 1) utils::missing_cmd_args(FLERR, "geturl", error);
int verify = 1;
int overwrite = 1;
int verbose = 0;
This first part also has the ``#ifdef`` block depending on the LAMMPS_CURL
define. This way the command will simply print an error, if *libcurl* is
not available but will not fail to compile. Furthermore, it sets the
defaults for the following optional arguments.
.. code-block:: c++
// process arguments
std::string url = arg[0];
// sanity check
if ((url.find(':') == std::string::npos) || (url.find('/') == std::string::npos))
error->all(FLERR, "URL '{}' is not a supported URL", url);
std::string output = url.substr(url.find_last_of('/') + 1);
if (output.empty()) error->all(FLERR, "URL '{}' must end in a file string", url);
This block stores the positional, i.e. non-optional argument of the URL to
be downloaded and adds a couple of sanity checks on the string to make sure it is
a valid URL. Also it derives the default name of the output file from the URL.
.. code-block:: c++
int iarg = 1;
while (iarg < narg) {
if (strcmp(arg[iarg], "output") == 0) {
if (iarg + 2 > narg) utils::missing_cmd_args(FLERR, "geturl output", error);
output = arg[iarg + 1];
++iarg;
} else if (strcmp(arg[iarg], "overwrite") == 0) {
if (iarg + 2 > narg) utils::missing_cmd_args(FLERR, "geturl overwrite", error);
overwrite = utils::logical(FLERR, arg[iarg + 1], false, lmp);
++iarg;
} else if (strcmp(arg[iarg], "verify") == 0) {
if (iarg + 2 > narg) utils::missing_cmd_args(FLERR, "geturl verify", error);
verify = utils::logical(FLERR, arg[iarg + 1], false, lmp);
++iarg;
} else if (strcmp(arg[iarg], "verbose") == 0) {
if (iarg + 2 > narg) utils::missing_cmd_args(FLERR, "geturl verbose", error);
verbose = utils::logical(FLERR, arg[iarg + 1], false, lmp);
++iarg;
} else {
error->all(FLERR, "Unknown geturl keyword: {}", arg[iarg]);
}
++iarg;
}
This block parses the optional arguments following the URL and stops with an
error if there are arguments missing or an unknown argument is encountered.
.. code-block:: c++
// only download files from rank 0
if (comm->me != 0) return;
if (!overwrite && platform::file_is_readable(output)) return;
// open output file for writing
FILE *out = fopen(output.c_str(), "wb");
if (!out)
error->all(FLERR, "Cannot open output file {} for writing: {}", output, utils::getsyserror());
Here all MPI ranks other than 0 will return, so that the URL download will
only happen from a single MPI rank. For that rank the output file is opened
for writing using the C library function ``fopen()``.
.. code-block:: c++
// initialize curl and perform download
CURL *curl;
curl_global_init(CURL_GLOBAL_DEFAULT);
curl = curl_easy_init();
if (curl) {
(void) curl_easy_setopt(curl, CURLOPT_URL, url.c_str());
(void) curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void *) out);
(void) curl_easy_setopt(curl, CURLOPT_FILETIME, 1L);
(void) curl_easy_setopt(curl, CURLOPT_FAILONERROR, 1L);
if (verbose && screen) {
(void) curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
(void) curl_easy_setopt(curl, CURLOPT_STDERR, (void *) screen);
}
if (!verify) {
(void) curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
(void) curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
}
auto res = curl_easy_perform(curl);
if (res != CURLE_OK) {
long response = 0L;
curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &response);
error->one(FLERR, "Download of {} failed with: {} {}", output, curl_easy_strerror(res),
response);
}
curl_easy_cleanup(curl);
This block now implements the actual URL download with the selected options
via the "easy" interface of *libcurl*. For the details of what these
function calls do, please have a look at the `*libcurl documentation
<https://curl.se/libcurl/c/allfuncs.html>`_.
.. code-block:: c++
}
curl_global_cleanup();
fclose(out);
#endif
}
Finally, the previously opened file is closed and the command is complete.

View File

@ -96,8 +96,8 @@ Here the we specify which methods of the fix should be called during
MPI_Allreduce(localAvgVel, globalAvgVel, 4, MPI_DOUBLE, MPI_SUM, world);
scale3(1.0 / globalAvgVel[3], globalAvgVel);
if ((comm->me == 0) && screen) {
fmt::print(screen,"{}, {}, {}\n",
globalAvgVel[0], globalAvgVel[1], globalAvgVel[2]);
utils::print(screen, "{}, {}, {}\n",
globalAvgVel[0], globalAvgVel[1], globalAvgVel[2]);
}
}

View File

@ -160,7 +160,7 @@ message and before the include guards for the class definition:
#endif
This block of between ``#ifdef PAIR_CLASS`` and ``#else`` will be
This block between ``#ifdef PAIR_CLASS`` and ``#else`` will be
included by the ``Force`` class in ``force.cpp`` to build a map of
"factory functions" that will create an instance of these classes and
return a pointer to it. The map connects the name of the pair style,
@ -310,7 +310,7 @@ the constructor and the destructor.
Pair styles are different from most classes in LAMMPS that define a
"style", as their constructor only uses the LAMMPS class instance
pointer as an argument, but **not** the command line arguments of the
pointer as an argument, but **not** the arguments of the
:doc:`pair_style command <pair_style>`. Instead, those arguments are
processed in the ``Pair::settings()`` function (or rather the version in
the derived class). The constructor is the place where global defaults
@ -891,7 +891,7 @@ originally created from mixing or not).
These data file output functions are only useful for true pair-wise
additive potentials, where the potential parameters can be entered
through *multiple* :doc:`pair_coeff commands <pair_coeff>`. Pair styles
that require a single "pair_coeff \* \*" command line are not compatible
that require a single "pair_coeff \* \*" command are not compatible
with reading their parameters from data files. For pair styles like
*born/gauss* that do support writing to data files, the potential
parameters will be read from the data file, if present, and
@ -1122,7 +1122,7 @@ once. Thus, the ``coeff()`` function has to do three tasks, each of
which is delegated to a function in the ``PairTersoff`` class:
#. map elements to atom types. Those follow the potential file name in the
command line arguments and are processed by the ``map_element2type()`` function.
command arguments and are processed by the ``map_element2type()`` function.
#. read and parse the potential parameter file in the ``read_file()`` function.
#. Build data structures where the original and derived parameters are
indexed by all possible triples of atom types and thus can be looked
@ -1356,8 +1356,8 @@ either 0 or 1.
The ``morseflag`` variable defaults to 0 and is set to 1 in the
``PairAIREBOMorse::settings()`` function which is called by the
:doc:`pair_style <pair_style>` command. This function delegates
all command line processing and setting of other parameters to the
:doc:`pair_style <pair_style>` command. This function delegates all
command argument processing and setting of other parameters to the
``PairAIREBO::settings()`` function of the base class.
.. code-block:: c++

View File

@ -83,7 +83,7 @@ Run LAMMPS from within the debugger
Running LAMMPS under the control of the debugger as shown below only
works for a single MPI rank (for debugging a program running in parallel
you usually need a parallel debugger program). A simple way to launch
GDB is to prefix the LAMMPS command line with ``gdb --args`` and then
GDB is to prefix the LAMMPS command-line with ``gdb --args`` and then
type the command "run" at the GDB prompt. This will launch the
debugger, load the LAMMPS executable and its debug info, and then run
it. When it reaches the code causing the segmentation fault, it will
@ -180,7 +180,7 @@ inspect the behavior of a compiled program by essentially emulating a
CPU and instrumenting the program while running. This slows down
execution quite significantly, but can also report issues that are not
resulting in a crash. The default valgrind tool is a memory checker and
you can use it by prefixing the normal command line with ``valgrind``.
you can use it by prefixing the normal command-line with ``valgrind``.
Unlike GDB, this will also work for parallel execution, but it is
recommended to redirect the valgrind output to a file (e.g. with
``--log-file=crash-%p.txt``, the %p will be substituted with the
@ -235,3 +235,53 @@ from GDB. In addition you get a more specific hint about what cause the
segmentation fault, i.e. that it is a NULL pointer dereference. To find
out which pointer exactly was NULL, you need to use the debugger, though.
Debugging when LAMMPS appears to be stuck
=========================================
Sometimes the LAMMPS calculation appears to be stuck, that is the LAMMPS
process or processes are active, but there is no visible progress. This
can have multiple reasons:
- The selected styles are slow and require a lot of CPU time and the
system is large. When extrapolating the expected speed from smaller
systems, one has to factor in that not all models scale linearly with
system size, e.g. :doc:`kspace styles like ewald or pppm
<kspace_style>`. There is very little that can be done in this case.
- The output interval is not set or set to a large value with the
:doc:`thermo <thermo>` command. I the first case, there will be output
only at the first and last step.
- The output is block-buffered and instead of line-buffered. The output
will only be written to the screen after 4096 or 8192 characters of
output have accumulated. This most often happens for files but also
with MPI parallel executables for output to the screen, since the
output to the screen is handled by the MPI library so that output from
all processes can be shown. This can be suppressed by using the
``-nonblock`` or ``-nb`` command-line flag, which turns off buffering
for screen and logfile output.
- An MPI parallel calculation has a bug where a collective MPI function
is called (e.g. ``MPI_Barrier()``, ``MPI_Bcast()``,
``MPI_Allreduce()`` and so on) before pending point-to-point
communications are completed or when the collective function is only
called from a subset of the MPI processes. This also applies to some
internal LAMMPS functions like ``Error::all()`` which uses
``MPI_Barrier()`` and thus ``Error::one()`` must be called, if the
error condition does not happen on all MPI processes simultaneously.
- Some function in LAMMPS has a bug where a ``for`` or ``while`` loop
does not trigger the exit condition and thus will loop forever. This
can happen when the wrong variable is incremented or when one value in
a comparison becomes ``NaN`` due to an overflow.
In the latter two cases, further information and stack traces (see above)
can be obtain by attaching a debugger to a running process. For that the
process ID (PID) is needed; this can be found on Linux machines with the
``top``, ``htop``, ``ps``, or ``pstree`` commands.
Then running the (GNU) debugger ``gdb`` with the ``-p`` flag followed by
the process id will attach the process to the debugger and stop
execution of that specific process. From there on it is possible to
issue all debugger commands in the same way as when LAMMPS was started
from the debugger (see above). Most importantly it is possible to
obtain a stack trace with the ``where`` command and thus determine where
in the execution of a timestep this process is. Also internal data can
be printed and execution single stepped or continued. When the debugger
is exited, the calculation will resume normally.

View File

@ -4,9 +4,172 @@ Error and warning details
Many errors or warnings are self-explanatory and thus straightforward to
resolve. However, there are also cases, where there is no single cause
and explanation, where LAMMPS can only detect symptoms of an error but
not the exact cause, or where the explanation needs to be more detailed than
what can be fit into a message printed by the program. The following are
discussions of such cases.
not the exact cause, or where the explanation needs to be more detailed
than what can be fit into a message printed by the program. The
following are discussions of such cases.
- :ref:`Unknown identifier in data file <err0001>`
- :ref:`Incorrect format in ... section of data file <err0002>`
- :ref:`Illegal variable command: expected X arguments but found Y <err0003>`
- :ref:`Out of range atoms - cannot compute ... <err0004>`
- :ref:`Too many neighbor bins <err0009>`
- :ref:`Cannot use neighbor bins - box size \<\< cutoff <err0015>`
- :ref:`Domain too large for neighbor bins <err0017>`
- :ref:`Molecule topology/atom exceeds system topology/atom <err0024>`
- :ref:`Molecule topology type exceeds system topology type <err0025>`
- :ref:`Molecule attributes do not match system attributes <err0026>`
------
General troubleshooting advice
------------------------------
Below are suggestions that can help to understand the causes of problems
with simulations leading to errors or unexpected results.
Create a small test system
^^^^^^^^^^^^^^^^^^^^^^^^^^
Debugging problems often requires running a simulation many times with
small modifications, thus it can be a huge time saver to first assemble
a small test system input that has the same issue, but will take much
time until it triggers the error condition. Also, it will be easier to
see what happens.
Visualize your trajectory
^^^^^^^^^^^^^^^^^^^^^^^^^
To better understand what is causing problems, it is often very useful
to visualize the system close to the point of failure. It may be
necessary to have LAMMPS output trajectory frames rather frequently. To
avoid gigantic files, you can use :doc:`dump_modify delay <dump_modify>`
to delay output until the critical section is reached, and you can use a
smaller test system (see above).
Parallel versus serial
^^^^^^^^^^^^^^^^^^^^^^
Issues where something is "lost" or "missing" often exhibit that issue
only when running in parallel. That doesn't mean there is no problem,
only the symptoms are not triggering an error quickly. Correspondingly,
errors may be triggered faster with more processors and thus smaller
sub-domains.
Fast moving atoms
^^^^^^^^^^^^^^^^^
Fast moving atoms may be "lost" or "missing" when their velocity becomes
so large that they can cross a sub-domain within one timestep. This
often happens when atoms are too close, but atoms may also "move" too
fast from sub-domain to sub-domain if the box changes rapidly, e.g. when
setting a large an initial box with :doc:`shrink-wrap boundary
conditions <boundary>` that collapses on the first step (in this case
the solution is often using 'm' instead of 's' as boundary condition).
To reduce the impact of "close contacts", one can remove those atoms or
molecules with something like :doc:`delete_atoms overlap 0.1 all all
<delete_atoms>`. With periodic boundaries, a close contact pair of atoms
may be on opposite sides of the simulation box. Another option would be
to first run a minimization (aka quench) before starting the MD. Reducing
the time step can also help. Many times, one just needs to "ease" the
system into a balanced state and can then switch to more aggressive settings.
The speed of atoms during an MD depends on the steepness of the
potential function and their mass. Since the positions and velocities
of atoms are computed with finite timesteps, they choice of timestep can
be too large for a stable numeric integration of the trajectory. In
those cases using (temporarily) :doc:`fix nve/limit <fix_nve_limit>` or
:doc:`fix dt/reset <fix_dt_reset>` can help to avoid too large updates
or adapt the timestep according to the displacements.
Pressure, forces, positions becoming NaN of Inf
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Some potentials can overflow or have a division by zero with close contacts
or bad geometries (for the given force styles in use) leading to forces
that can no longer be represented as numbers. Those will show as "NaN" or
"Inf". On most machines, the program will continue, but there is no way
to recover from it and those NaN or Inf values will propagate. So-called
:doc:`"soft-core" potentials <pair_fep_soft>` or the :doc:`"soft" repulsive-only
pair style <pair_soft>` are less prone for this behavior (depending on the
settings in use) and can be used at the beginning of a simulation. Also,
single precision numbers can overflow much faster, so for the GPU or INTEL
package it may be beneficial to run with double precision initially before
switching to mixed or single precision for faster execution when the system
has relaxed.
Communication cutoff
^^^^^^^^^^^^^^^^^^^^
The communication cutoff determines the "overlap" between sub-domains
and atoms in these regions are referred to in LAMMPS as "ghost atoms".
This region has to be large enough to contain all atoms of a bond,
angle, dihedral or improper with just one atom in the actual sub-domain.
Typically, this cutoff is set to the largest cutoff from the :doc:`pair
style(s) <pair_style>` plus the :doc:`neighbor list skin distance
<neighbor>` and will be more than sufficient for all bonded
interactions. But if the pair style cutoff is small this may bot be
enough. LAMMPS will print a warning in this case using some heuristic
based on the equilibrium bond length, but that may not be sufficient for
cases where the force constants are small and thus bonds may be
stretched very far. The communication cutoff can be adjusted with
:doc:`comm_modify cutoff \<value\> <comm_modify>`, but setting this too
large will waste CPU time and memory.
Neighbor list settings
^^^^^^^^^^^^^^^^^^^^^^
Every time LAMMPS rebuilds the neighbor lists, LAMMPS will also check
for "lost" or "missing" atoms. Thus it can help to use very
conservative :doc:`neighbor list settings <neigh_modify>` and then
examine the neighbor list statistics if the neighbor list rebuild can be
safely delayed. Rebuilding the neighbor list less frequently
(i.e. through increasing the *delay* or *every* setting has diminishing
returns and increasing risks).
Ignoring lost atoms
^^^^^^^^^^^^^^^^^^^
It is tempting to use the :doc:`thermo_modify lost ignore <thermo_modify>`
to avoid that LAMMPS stops with an error. This setting should, however,
*only* be used when atoms *should* leave the system. In general, ignoring
a problem does not solve it.
Units
^^^^^
A frequent cause for a variety of problems is due to using the wrong
:doc:`units <units>` settings for a particular potentials, especially
when reading them from a potential file. Most of the (example)
potentials bundled with LAMMPS have a "UNITS:" tag that allows LAMMPS to
check of the units are consistent with what is intended, but potential
files from publications or potential parameter databases may lack this
metadata information and thus will not error out or warn when using the
wrong setting. Most potential files usually use "metal" units, but some
are parameterized for other settings, most notably :doc:`ReaxFF
potentials <pair_reaxff>` that use "real" units.
Also, individual parameters for :doc:`pair_coeff <pair_coeff>` commands
taken from publications or other MD software, may need to be converted
and sometimes in unexpected ways. Thus some careful checking is
recommended.
No error message printed
^^^^^^^^^^^^^^^^^^^^^^^^
In some cases - especially when running in parallel with MPI - LAMMPS
may stop without displaying an error. But that does not mean, that
there was no error message, instead it is highly likely that the message
was written to a buffer and LAMMPS was aborted before the buffer was
output. Usually, output buffers are output for every line of output,
but sometimes, this is delayed until 4096 or 8192 bytes of output have
been accumulated. This buffering for screen and logfile output can be
disabled by using the :ref:`-nb or -nonbuf <nonbuf>` command-line flag.
This is most often needed when debugging crashing multi-replica
calculations.
------
.. _err0001:
@ -54,3 +217,153 @@ header of a data file (e.g. the number of atoms) is larger than the
number of lines provided (e.g. in the corresponding Atoms section)
and then LAMMPS will continue reading into the next section and that
would have a completely different format.
.. _err0003:
Illegal variable command: expected X arguments but found Y
----------------------------------------------------------
This error indicates that there are the wrong number of arguments for a
specific variable command, but a common reason for that is a variable
expression that has whitespace but is not enclosed in single or double
quotes.
To explain, the LAMMPS input parser reads and processes lines. The
resulting line is broken down into "words". Those are usually
individual commands, labels, names, values separated by whitespace (a
space or tab character). For "words" that may contain whitespace, they
have to be enclosed in single (') or double (") quotes. The parser will
then remove the outermost pair of quotes and then pass that string as
"word" to the variable command.
Thus missing quotes or accidental extra whitespace will lead to the
error shown in the header because the unquoted whitespace will result
in the text being broken into more "words", i.e. the variable expression
being split.
.. _err0004:
Out of range atoms - cannot compute ...
---------------------------------------
The PPPM (and also PPPMDisp and MSM) methods require to assemble a grid
of electron density data derived from the (partial) charges assigned to
the atoms. This charges are smeared out across multiple grid points
(see :doc:`kspace_modify order <kspace_modify>`). When running in
parallel with MPI, LAMMPS uses a :doc:`domain decomposition scheme
<Developer_par_part>` where each processor manages a subset of atoms and
thus also a grid representing the density, which covers the actual
volume of the sub-domain and some extra space corresponding to the
:doc:`neighbor list skin <neighbor>`. These are then :doc:`combined and
redistributed <Developer_par_long>` for parallel processing of the
long-range component of the Coulomb interaction.
The ``Out of range atoms`` error can happen, when atoms move too fast or
the neighbor list skin is too small or the neighbor lists are not
updated frequently enough. Then the smeared charges cannot be fully
assigned to the density grid for all atoms. LAMMPS checks for this
condition and stops with an error. Most of the time, this is an
indication of a system with very high forces, most often at the
beginning of a simulation or when boundary conditions are changed. The
error becomes more likely with more MPI processes.
There are multiple options to explore for avoiding the error. The best
choice depends strongly on the individual system, and often a
combination of changes is required. For example, more conservative MD
parameter settings can be used (larger neighbor skin, shorter time step,
more frequent neighbor list updates). Sometimes, it helps to revisit
the system generation and avoid close contacts when building it, or use
the :doc:`delete_atoms overlap<delete_atoms>` command to delete those
close contact atoms, or run a minimization before the MD. It can also
help to temporarily use a cutoff-Coulomb pair style and no kspace style
until the system has somewhat equilibrated and then switch to the
long-range solver.
.. _err0009:
Too many neighbor bins
----------------------
The simulation box has become too large relative to the size of a
neighbor bin and LAMMPS is unable to store the needed number of
bins. This typically implies the simulation box has expanded too far.
This can happen when some atoms move rapidly apart with shrink-wrap
boundaries or when a fix (like fix deform or a barostat) excessively
grows the simulation box.
.. _err0015:
Cannot use neighbor bins - box size \<\< cutoff
-----------------------------------------------
LAMMPS is unable to build neighbor bins since the size of the box is
much smaller than an interaction cutoff in at least one of its dimensions.
Typically, this error is triggered when the simulation box has one very
thin dimension. If a cubic neighbor bin had to fit exactly within
the thin dimension, then an inordinate amount of bins would be created to
fill space. This error can be avoided using the generally slower
:doc:`nsq neighbor style <neighbor>` or by increasing the size of the
smallest box lengths.
.. _err0017:
Domain too large for neighbor bins
----------------------------------
The domain has become extremely large so that neighbor bins cannot
be used. Too many neighbor bins would need to be created to fill space
Most likely, one or more atoms have been blown out of the simulation
box to a great distance or a fix (like fix deform or a barostat) has
excessively grown the simulation box.
.. _err0024:
Molecule topology/atom exceeds system topology/atom
---------------------------------------------------
LAMMPS uses :doc:`domain decomposition <Developer_par_part>` to
distribute data (i.e. atoms) across the MPI processes in parallel runs.
This includes topology data, that is data about bonds, angles,
dihedrals, impropers and :doc:`"special" neighbors <special_bonds>`.
This information is stored with either one or all atoms involved in such
a topology entry (which of the two option applies depends on the
:doc:`newton <newton>` setting for bonds. When reading a data file,
LAMMPS analyzes the requirements for this file and then the values
are "locked in" and cannot be extended.
So loading a molecule file that requires more of the topology per atom
storage or adding a data file with such needs will lead to an error. To
avoid the error, one or more of the `extra/XXX/per/atom` keywords are
required to extend the corresponding storage. It is no problem to
choose those numbers generously and have more storage reserved than
actually needed, but having these numbers set too small will lead to an
error.
.. _err0025:
Molecule topology type exceeds system topology type
---------------------------------------------------
The total number of atom, bond, angle, dihedral, and improper types is
"locked in" when LAMMPS creates the simulation box. This can happen
through either the :doc:`create_box <create_box>`, the :doc:`read_data
<read_data>`, or the :doc:`read_restart <read_restart>` command. After
this it is not possible to refer to an additional type. So loading a
molecule file that uses additional types or adding a data file that
would require additional types will lead to an error. To avoid the
error, one or more of the `extra/XXX/types` keywords are required to
extend the maximum number of the individual types.
.. _err0026:
Molecule attributes do not match system attributes
--------------------------------------------------
Choosing an :doc:`atom_style <atom_style>` in LAMMPS determines which
per-atom properties are available. In a :doc:`molecule file
<molecule>`, however, it is possible to add sections (for example Masses
or Charges) that are not supported by the atom style. Masses for
example, are usually not a per-atom property, but defined through the
atom type. Thus it would not be required to have a Masses section and
the included data would be ignored. LAMMPS prints this warning to
inform about this case.

View File

@ -7774,7 +7774,7 @@ Doc page with :doc:`WARNING messages <Errors_warnings>`
*Too few values in body section of molecule file*
Self-explanatory.
*Too many -pk arguments in command line*
*Too many -pk arguments in command-line*
The string formed by concatenating the arguments is too long. Use a
package command in the input script instead.

View File

@ -146,6 +146,8 @@ Lowercase directories
+-------------+------------------------------------------------------------------+
| streitz | use of Streitz/Mintmire potential with charge equilibration |
+-------------+------------------------------------------------------------------+
| stress_vcm | removing binned rigid body motion from binned stress profile |
+-------------+------------------------------------------------------------------+
| tad | temperature-accelerated dynamics of vacancy diffusion in bulk Si |
+-------------+------------------------------------------------------------------+
| threebody | regression test input for a variety of manybody potentials |

View File

@ -16,7 +16,7 @@ compiled alongside the code using it from the source code in
``fortran/lammps.f90`` *and* with the same compiler used to build the
rest of the Fortran code that interfaces to LAMMPS. When linking, you
also need to :doc:`link to the LAMMPS library <Build_link>`. A typical
command line for a simple program using the Fortran interface would be:
command for a simple program using the Fortran interface would be:
.. code-block:: bash
@ -91,12 +91,12 @@ function and triggered with the optional logical argument set to
CALL lmp%close(.TRUE.)
END PROGRAM testlib
It is also possible to pass command line flags from Fortran to C/C++ and
It is also possible to pass command-line flags from Fortran to C/C++ and
thus make the resulting executable behave similarly to the standalone
executable (it will ignore the `-in/-i` flag, though). This allows
using the command line to configure accelerator and suffix settings,
using the command-line to configure accelerator and suffix settings,
configure screen and logfile output, or to set index style variables
from the command line and more. Here is a correspondingly adapted
from the command-line and more. Here is a correspondingly adapted
version of the previous example:
.. code-block:: fortran
@ -108,7 +108,7 @@ version of the previous example:
CHARACTER(LEN=128), ALLOCATABLE :: command_args(:)
INTEGER :: i, argc
! copy command line flags to `command_args()`
! copy command-line flags to `command_args()`
argc = COMMAND_ARGUMENT_COUNT()
ALLOCATE(command_args(0:argc))
DO i=0, argc
@ -321,6 +321,14 @@ of the contents of the :f:mod:`LIBLAMMPS` Fortran interface to LAMMPS.
:ftype set_string_variable: subroutine
:f set_internal_variable: :f:subr:`set_internal_variable`
:ftype set_internal_variable: subroutine
:f eval: :f:func:`eval`
:ftype eval: function
:f clearstep_compute: :f:subr:`clearstep_compute`
:ftype clearstep_compute: subroutine
:f addstep_compute: :f:subr:`addstep_compute`
:ftype addstep_compute: subroutine
:f addstep_compute_all: :f:subr:`addstep_compute_all`
:ftype addstep_compute_all: subroutine
:f gather_atoms: :f:subr:`gather_atoms`
:ftype gather_atoms: subroutine
:f gather_atoms_concat: :f:subr:`gather_atoms_concat`
@ -448,7 +456,7 @@ of the contents of the :f:mod:`LIBLAMMPS` Fortran interface to LAMMPS.
compiled with MPI support, it will also initialize MPI, if it has
not already been initialized before.
The *args* argument with the list of command line parameters is
The *args* argument with the list of command-line parameters is
optional and so it the *comm* argument with the MPI communicator.
If *comm* is not provided, ``MPI_COMM_WORLD`` is assumed. For
more details please see the documentation of :cpp:func:`lammps_open`.
@ -954,6 +962,7 @@ Procedures Bound to the :f:type:`lammps` Derived Type
:f:func:`extract_atom` between runs.
.. admonition:: Array index order
:class: tip
Two-dimensional arrays returned from :f:func:`extract_atom` will be
**transposed** from equivalent arrays in C, and they will be indexed
@ -1066,6 +1075,7 @@ Procedures Bound to the :f:type:`lammps` Derived Type
you based on data from the :cpp:class:`Compute` class.
.. admonition:: Array index order
:class: tip
Two-dimensional arrays returned from :f:func:`extract_compute` will be
**transposed** from equivalent arrays in C, and they will be indexed
@ -1324,6 +1334,7 @@ Procedures Bound to the :f:type:`lammps` Derived Type
:rtype data: polymorphic
.. admonition:: Array index order
:class: tip
Two-dimensional global, per-atom, or local array data from
:f:func:`extract_fix` will be **transposed** from equivalent arrays in
@ -1448,11 +1459,62 @@ Procedures Bound to the :f:type:`lammps` Derived Type
an internal-style variable, an error is generated.
:p character(len=*) name: name of the variable
:p read(c_double) val: new value to assign to the variable
:p real(c_double) val: new value to assign to the variable
:to: :cpp:func:`lammps_set_internal_variable`
--------
.. f:function:: eval(expr)
This function is a wrapper around :cpp:func:`lammps_eval` that takes a
LAMMPS equal style variable string, evaluates it and returns the resulting
scalar value as a floating-point number.
.. versionadded:: 4Feb2025
:p character(len=\*) expr: string to be evaluated
:to: :cpp:func:`lammps_eval`
:r value [real(c_double)]: result of the evaluated string
--------
.. f:subroutine:: clearstep_compute()
Clear whether a compute has been invoked
.. versionadded:: 4Feb2025
:to: :cpp:func:`lammps_clearstep_compute`
--------
.. f:subroutine:: addstep_compute(nextstep)
Add timestep to list of future compute invocations
if the compute has been invoked on the current timestep
.. versionadded:: 4Feb2025
overloaded for 32-bit and 64-bit integer arguments
:p integer(kind=8 or kind=4) nextstep: next timestep
:to: :cpp:func:`lammps_addstep_compute`
--------
.. f:subroutine:: addstep_compute_all(nextstep)
Add timestep to list of future compute invocations
.. versionadded:: 4Feb2025
overloaded for 32-bit and 64-bit integer arguments
:p integer(kind=8 or kind=4) nextstep: next timestep
:to: :cpp:func:`lammps_addstep_compute_all`
--------
.. f:subroutine:: gather_atoms(name, count, data)
This function calls :cpp:func:`lammps_gather_atoms` to gather the named

View File

@ -103,6 +103,7 @@ Tutorials howto
Howto_github
Howto_lammps_gui
Howto_moltemplate
Howto_python
Howto_pylammps
Howto_wsl

View File

@ -10,20 +10,21 @@ and/or pressure (P) is specified by the user, and the thermostat or
barostat attempts to equilibrate the system to the requested T and/or
P.
Barostatting in LAMMPS is performed by :doc:`fixes <fix>`. Two
Barostatting in LAMMPS is performed by :doc:`fixes <fix>`. Three
barostatting methods are currently available: Nose-Hoover (npt and
nph) and Berendsen:
nph), Berendsen, and various linear controllers in deform/pressure:
* :doc:`fix npt <fix_nh>`
* :doc:`fix npt/sphere <fix_npt_sphere>`
* :doc:`fix npt/asphere <fix_npt_asphere>`
* :doc:`fix nph <fix_nh>`
* :doc:`fix press/berendsen <fix_press_berendsen>`
* :doc:`fix deform/pressure <fix_deform_pressure>`
The :doc:`fix npt <fix_nh>` commands include a Nose-Hoover thermostat
and barostat. :doc:`Fix nph <fix_nh>` is just a Nose/Hoover barostat;
it does no thermostatting. Both :doc:`fix nph <fix_nh>` and :doc:`fix press/berendsen <fix_press_berendsen>` can be used in conjunction
with any of the thermostatting fixes.
it does no thermostatting. The fixes :doc:`nph <fix_nh>`, :doc:`press/berendsen <fix_press_berendsen>`, and :doc:`deform/pressure <fix_deform_pressure>`
can be used in conjunction with any of the thermostatting fixes.
As with the :doc:`thermostats <Howto_thermostat>`, :doc:`fix npt <fix_nh>`
and :doc:`fix nph <fix_nh>` only use translational motion of the
@ -44,9 +45,9 @@ a temperature or pressure compute to a barostatting fix.
.. note::
As with the thermostats, the Nose/Hoover methods (:doc:`fix npt <fix_nh>` and :doc:`fix nph <fix_nh>`) perform time integration.
:doc:`Fix press/berendsen <fix_press_berendsen>` does NOT, so it should
be used with one of the constant NVE fixes or with one of the NVT
fixes.
:doc:`Fix press/berendsen <fix_press_berendsen>` and :doc:`fix deform/pressure <fix_deform_pressure>`
do NOT, so they should be used with one of the constant NVE fixes or with
one of the NVT fixes.
Thermodynamic output, which can be setup via the
:doc:`thermo_style <thermo_style>` command, often includes pressure

View File

@ -1,5 +1,5 @@
CHARMM, AMBER, COMPASS, and DREIDING force fields
=================================================
CHARMM, AMBER, COMPASS, DREIDING, and OPLS force fields
=======================================================
A compact summary of the concepts, definitions, and properties of
force fields with explicit bonded interactions (like the ones discussed
@ -236,6 +236,40 @@ documentation for the formula it computes.
* :doc:`special_bonds <special_bonds>` dreiding
OPLS
----
OPLS (Optimized Potentials for Liquid Simulations) is a general force
field for atomistic simulation of organic molecules in solvent. It was
developed by the `Jorgensen group
<https://traken.chem.yale.edu/oplsaam.html>`_ at Purdue University and
later at Yale University. Multiple versions of the OPLS parameters
exist for united atom representations (OPLS-UA) and for all-atom
representations (OPLS-AA).
This force field is based on atom types mapped to specific functional
groups in organic and biological molecules. Each atom includes a
static, partial atomic charge reflecting the oxidation state of the
element derived from its bonded neighbors :ref:`(Jorgensen)
<howto-jorgensen>` and computed based on increments determined by the
atom type of the atoms bond to it.
The interaction styles listed below compute force field formulas that
are fully or in part consistent with the OPLS style force fields. See
each command's documentation for the formula it computes. Some are only
compatible with a subset of OPLS interactions.
* :doc:`bond_style <bond_harmonic>` harmonic
* :doc:`angle_style <angle_harmonic>` harmonic
* :doc:`dihedral_style <dihedral_opls>` opls
* :doc:`improper_style <improper_cvff>` cvff
* :doc:`improper_style <improper_fourier>` fourier
* :doc:`improper_style <improper_harmonic>` harmonic
* :doc:`pair_style <pair_lj_cut_coul>` lj/cut/coul/cut
* :doc:`pair_style <pair_lj_cut_coul>` lj/cut/coul/long
* :doc:`pair_modify <pair_modify>` geometric
* :doc:`special_bonds <special_bonds>` lj/coul 0.0 0.0 0.5
----------
.. _Typelabel2:
@ -266,3 +300,6 @@ documentation for the formula it computes.
**(Mayo)** Mayo, Olfason, Goddard III (1990). J Phys Chem, 94, 8897-8909. https://doi.org/10.1021/j100389a010
.. _howto-Jorgensen:
**(Jorgensen)** Jorgensen, Tirado-Rives (1988). J Am Chem Soc, 110, 1657-1666. https://doi.org/10.1021/ja00214a001

View File

@ -5,7 +5,11 @@ The BPM package implements bonded particle models which can be used to
simulate mesoscale solids. Solids are constructed as a collection of
particles, which each represent a coarse-grained region of space much
larger than the atomistic scale. Particles within a solid region are
then connected by a network of bonds to provide solid elasticity.
then connected by a network of bonds to model solid elasticity.
There are many names for methods that are based on similar (or
equivalent) capabilities to those in this package, including, but not
limited to, cohesive beam models, bonded DEMs, lattice spring models,
mass spring models, and lattice particle methods.
Unlike traditional bonds in molecular dynamics, the equilibrium bond
length can vary between bonds. Bonds store the reference state. This
@ -42,7 +46,8 @@ Currently, there are two types of bonds included in the BPM package. The
first bond style, :doc:`bond bpm/spring <bond_bpm_spring>`, only applies
pairwise, central body forces. Point particles must have :doc:`bond atom
style <atom_style>` and may be thought of as nodes in a spring
network. Alternatively, the second bond style, :doc:`bond bpm/rotational
network. An optional multibody term can be used to adjust the network's
Poisson's ratio. Alternatively, the second bond style, :doc:`bond bpm/rotational
<bond_bpm_rotational>`, resolves tangential forces and torques arising
with the shearing, bending, and twisting of the bond due to rotation or
displacement of particles. Particles are similar to those used in the
@ -55,8 +60,9 @@ orientation similar to :doc:`fix nve/asphere <fix_nve_asphere>`.
In addition to bond styles, a new pair style :doc:`pair bpm/spring
<pair_bpm_spring>` was added to accompany the bpm/spring bond
style. This pair style is simply a hookean repulsion with similar
velocity damping as its sister bond style.
style. By default, this pair style is simply a hookean repulsion with
similar velocity damping as its sister bond style, but optional
arguments can be used to modify the force.
----------

View File

@ -58,28 +58,30 @@ chunk ID for an individual atom can also be static (e.g. a molecule
ID), or dynamic (e.g. what spatial bin an atom is in as it moves).
Note that this compute allows the per-atom output of other
:doc:`computes <compute>`, :doc:`fixes <fix>`, and
:doc:`variables <variable>` to be used to define chunk IDs for each
atom. This means you can write your own compute or fix to output a
per-atom quantity to use as chunk ID. See the :doc:`Modify <Modify>`
doc pages for info on how to do this. You can also define a :doc:`per-atom variable <variable>` in the input script that uses a formula to
generate a chunk ID for each atom.
:doc:`computes <compute>`, :doc:`fixes <fix>`, and :doc:`variables
<variable>` to be used to define chunk IDs for each atom. This means
you can write your own compute or fix to output a per-atom quantity to
use as chunk ID. See the :doc:`Modify <Modify>` doc pages for info on
how to do this. You can also define a :doc:`per-atom variable
<variable>` in the input script that uses a formula to generate a chunk
ID for each atom.
Fix ave/chunk command:
----------------------
This fix takes the ID of a :doc:`compute chunk/atom <compute_chunk_atom>` command as input. For each chunk,
it then sums one or more specified per-atom values over the atoms in
each chunk. The per-atom values can be any atom property, such as
velocity, force, charge, potential energy, kinetic energy, stress,
etc. Additional keywords are defined for per-chunk properties like
density and temperature. More generally any per-atom value generated
by other :doc:`computes <compute>`, :doc:`fixes <fix>`, and :doc:`per-atom variables <variable>`, can be summed over atoms in each chunk.
This fix takes the ID of a :doc:`compute chunk/atom
<compute_chunk_atom>` command as input. For each chunk, it then sums
one or more specified per-atom values over the atoms in each chunk. The
per-atom values can be any atom property, such as velocity, force,
charge, potential energy, kinetic energy, stress, etc. Additional
keywords are defined for per-chunk properties like density and
temperature. More generally any per-atom value generated by other
:doc:`computes <compute>`, :doc:`fixes <fix>`, and :doc:`per-atom
variables <variable>`, can be summed over atoms in each chunk.
Similar to other averaging fixes, this fix allows the summed per-chunk
values to be time-averaged in various ways, and output to a file. The
fix produces a global array as output with one row of values per
chunk.
fix produces a global array as output with one row of values per chunk.
Compute \*/chunk commands:
--------------------------
@ -97,17 +99,20 @@ category:
* :doc:`compute torque/chunk <compute_vcm_chunk>`
* :doc:`compute vcm/chunk <compute_vcm_chunk>`
They each take the ID of a :doc:`compute chunk/atom <compute_chunk_atom>` command as input. As their names
indicate, they calculate the center-of-mass, radius of gyration,
moments of inertia, mean-squared displacement, temperature, torque,
and velocity of center-of-mass for each chunk of atoms. The :doc:`compute property/chunk <compute_property_chunk>` command can tally the
count of atoms in each chunk and extract other per-chunk properties.
They each take the ID of a :doc:`compute chunk/atom
<compute_chunk_atom>` command as input. As their names indicate, they
calculate the center-of-mass, radius of gyration, moments of inertia,
mean-squared displacement, temperature, torque, and velocity of
center-of-mass for each chunk of atoms. The :doc:`compute
property/chunk <compute_property_chunk>` command can tally the count of
atoms in each chunk and extract other per-chunk properties.
The reason these various calculations are not part of the :doc:`fix ave/chunk command <fix_ave_chunk>`, is that each requires a more
The reason these various calculations are not part of the :doc:`fix
ave/chunk command <fix_ave_chunk>`, is that each requires a more
complicated operation than simply summing and averaging over per-atom
values in each chunk. For example, many of them require calculation
of a center of mass, which requires summing mass\*position over the
atoms and then dividing by summed mass.
values in each chunk. For example, many of them require calculation of
a center of mass, which requires summing mass\*position over the atoms
and then dividing by summed mass.
All of these computes produce a global vector or global array as
output, with one or more values per chunk. The output can be used in
@ -118,9 +123,10 @@ various ways:
* As input to the :doc:`fix ave/histo <fix_ave_histo>` command to
histogram values across chunks. E.g. a histogram of cluster sizes or
molecule diffusion rates.
* As input to special functions of :doc:`equal-style variables <variable>`, like sum() and max() and ave(). E.g. to
find the largest cluster or fastest diffusing molecule or average
radius-of-gyration of a set of molecules (chunks).
* As input to special functions of :doc:`equal-style variables
<variable>`, like sum() and max() and ave(). E.g. to find the largest
cluster or fastest diffusing molecule or average radius-of-gyration of
a set of molecules (chunks).
Other chunk commands:
---------------------
@ -138,9 +144,10 @@ spatially average per-chunk values calculated by a per-chunk compute.
The :doc:`compute reduce/chunk <compute_reduce_chunk>` command reduces a
peratom value across the atoms in each chunk to produce a value per
chunk. When used with the :doc:`compute chunk/spread/atom <compute_chunk_spread_atom>` command it can
create peratom values that induce a new set of chunks with a second
:doc:`compute chunk/atom <compute_chunk_atom>` command.
chunk. When used with the :doc:`compute chunk/spread/atom
<compute_chunk_spread_atom>` command it can create peratom values that
induce a new set of chunks with a second :doc:`compute chunk/atom
<compute_chunk_atom>` command.
Example calculations with chunks
--------------------------------

View File

@ -56,7 +56,7 @@ using a shell like Bash or Zsh.
Visual Studio IDE with the bundled CMake or from the Windows command prompt using
a separately installed CMake package, both using the native Microsoft Visual C++
compilers and (optionally) the Microsoft MPI SDK. This tutorial, however, only
covers unix-like command line interfaces.
covers unix-like command-line interfaces.
We also assume that you have downloaded and unpacked a recent LAMMPS source code package
or used Git to create a clone of the LAMMPS sources on your compilation machine.
@ -277,7 +277,7 @@ Setting options
---------------
Options that enable, disable or modify settings are modified by setting
the value of CMake variables. This is done on the command line with the
the value of CMake variables. This is done on the command-line with the
*-D* flag in the format ``-D VARIABLE=value``, e.g. ``-D
CMAKE_BUILD_TYPE=Release`` or ``-D BUILD_MPI=on``. There is one quirk:
when used before the CMake directory, there may be a space between the
@ -348,7 +348,7 @@ Some common LAMMPS specific variables
* - ``FFT``
- select which FFT library to use: ``FFTW3``, ``MKL``, ``KISS`` (default, unless FFTW3 is found)
* - ``FFT_KOKKOS``
- select which FFT library to use in Kokkos-enabled styles: ``FFTW3``, ``MKL``, ``HIPFFT``, ``CUFFT``, ``KISS`` (default)
- select which FFT library to use in Kokkos-enabled styles: ``FFTW3``, ``MKL``, ``HIPFFT``, ``CUFFT``, ``MKL_GPU``, ``KISS`` (default)
* - ``FFT_SINGLE``
- select whether to use single precision FFTs (default: ``off``)
* - ``WITH_JPEG``
@ -376,7 +376,7 @@ Using presets
-------------
Since LAMMPS has a lot of optional features and packages, specifying
them all on the command line can be tedious. Or when selecting a
them all on the command-line can be tedious. Or when selecting a
different compiler toolchain, multiple options have to be changed
consistently and that is rather error prone. Or when enabling certain
packages, they require consistent settings to be operated in a
@ -384,7 +384,7 @@ particular mode. For this purpose, we are providing a selection of
"preset files" for CMake in the folder ``cmake/presets``. They
represent a way to pre-load or override the CMake configuration cache by
setting or changing CMake variables. Preset files are loaded using the
*-C* command line flag. You can combine loading multiple preset files or
*-C* command-line flag. You can combine loading multiple preset files or
change some variables later with additional *-D* flags. A few examples:
.. code-block:: bash

View File

@ -163,7 +163,7 @@ After everything is done, add the files to the branch and commit them:
*git rm*, *git mv* for adding, removing, renaming individual files,
respectively, and then *git commit* to finalize the commit.
Carefully check all pending changes with *git status* before
committing them. If you find doing this on the command line too
committing them. If you find doing this on the command-line too
tedious, consider using a GUI, for example the one included in git
distributions written in Tk, i.e. use *git gui* (on some Linux
distributions it may be required to install an additional package to

View File

@ -20,8 +20,11 @@ to the online LAMMPS documentation for known LAMMPS commands and styles.
(Ubuntu 20.04LTS or later and compatible), macOS (version 11 aka Big
Sur or later), and Windows (version 10 or later) :ref:`are available
<lammps_gui_install>` for download. Non-MPI LAMMPS executables (as
``lmp``) for running LAMMPS from the command line and :doc:`some
``lmp``) for running LAMMPS from the command-line and :doc:`some
LAMMPS tools <Tools>` compiled executables are also included.
Also, the pre-compiled LAMMPS-GUI packages include the WHAM executables
from http://membrane.urmc.rochester.edu/content/wham/ for use with
LAMMPS tutorials.
The source code for LAMMPS-GUI is included in the LAMMPS source code
distribution and can be found in the ``tools/lammps-gui`` folder. It
@ -29,16 +32,16 @@ to the online LAMMPS documentation for known LAMMPS commands and styles.
<Build_cmake>`.
LAMMPS-GUI tries to provide an experience similar to what people
traditionally would have running LAMMPS using a command line window and
traditionally would have running LAMMPS using a command-line window and
the console LAMMPS executable but just rolled into a single executable:
- writing & editing LAMMPS input files with a text editor
- run LAMMPS on those input file with selected command line flags
- run LAMMPS on those input file with selected command-line flags
- extract data from the created files and visualize it with and
external software
That procedure is quite effective for people proficient in using the
command line, as that allows them to use tools for the individual steps
command-line, as that allows them to use tools for the individual steps
that they are most comfortable with. In fact, it is often *required* to
adopt this workflow when running LAMMPS simulations on high-performance
computing facilities.
@ -61,13 +64,18 @@ simple LAMMPS simulations. It is very suitable for tutorials on LAMMPS
since you only need to learn how to use a single program for most tasks
and thus time can be saved and people can focus on learning LAMMPS.
The tutorials at https://lammpstutorials.github.io/ are specifically
updated for use with LAMMPS-GUI.
updated for use with LAMMPS-GUI and can their tutorial materials can
be downloaded and loaded directly from the GUI.
Another design goal is to keep the barrier low when replacing part of
the functionality of LAMMPS-GUI with external tools. That said, LAMMPS-GUI
has some unique functionality that is not found elsewhere:
- auto-adapting to features available in the integrated LAMMPS library
- auto-completion for LAMMPS commands and options
- context-sensitive online help
- start and stop of simulations via mouse or keyboard
- monitoring of simulation progress
- interactive visualization using the :doc:`dump image <dump_image>`
command with the option to copy-paste the resulting settings
- automatic slide show generation from dump image out at runtime
@ -100,10 +108,11 @@ MacOS 11 and later
^^^^^^^^^^^^^^^^^^
After downloading the ``LAMMPS-macOS-multiarch-GUI-<version>.dmg``
installer package, you need to double-click it and then, in the window
that opens, drag the app bundle as indicated into the "Applications"
folder. The follow the instructions in the "README.txt" file to
get access to the other included executables.
application bundle disk image, you need to double-click it and then, in
the window that opens, drag the app bundle as indicated into the
"Applications" folder. Afterwards, the disk image can be unmounted.
Then follow the instructions in the "README.txt" file to get access to
the other included command-line executables.
Linux on x86\_64
^^^^^^^^^^^^^^^^
@ -117,15 +126,25 @@ into the "LAMMPS_GUI" folder and execute "./lammps-gui" directly.
The second variant uses `flatpak <https://www.flatpak.org>`_ and
requires the flatpak management and runtime software to be installed.
After downloading the ``LAMMPS-GUI-Linux-x86_64-GUI-<version>.tar.gz``
After downloading the ``LAMMPS-GUI-Linux-x86_64-GUI-<version>.flatpak``
flatpak bundle, you can install it with ``flatpak install --user
LAMMPS-GUI-Linux-x86_64-GUI-<version>.tar.gz``. After installation,
LAMMPS-GUI-Linux-x86_64-GUI-<version>.flatpak``. After installation,
LAMMPS-GUI should be integrated into your desktop environment under
"Applications > Science" but also can be launched from the console with
``flatpak run org.lammps.lammps-gui``. The flatpak bundle also includes
the console LAMMPS executable ``lmp`` which can be launched to run
simulations with, for example: ``flatpak run --command=lmp
org.lammps.lammps-gui -in in.melt``.
simulations with, for example with:
.. code-block:: sh
flatpak run --command=lmp org.lammps.lammps-gui -in in.melt
Other bundled command-line executables are run the same way and can be
listed with:
.. code-block:: sh
ls $(flatpak info --show-location org.lammps.lammps-gui )/files/bin
Compiling from Source
@ -165,9 +184,9 @@ window is stored when exiting and restored when starting again.
Opening Files
^^^^^^^^^^^^^
The LAMMPS-GUI application can be launched without command line arguments
The LAMMPS-GUI application can be launched without command-line arguments
and then starts with an empty buffer in the *Editor* window. If arguments
are given LAMMPS will use first command line argument as the file name for
are given LAMMPS will use first command-line argument as the file name for
the *Editor* buffer and reads its contents into the buffer, if the file
exists. All further arguments are ignored. Files can also be opened via
the *File* menu, the `Ctrl-O` (`Command-O` on macOS) keyboard shortcut
@ -261,14 +280,21 @@ Output Window
By default, when starting a run, an *Output* window opens that displays
the screen output of the running LAMMPS calculation, as shown below.
This text would normally be seen in the command line window.
This text would normally be seen in the command-line window.
.. image:: JPG/lammps-gui-log.png
:align: center
:scale: 50%
LAMMPS-GUI captures the screen output from LAMMPS as it is generated and
updates the *Output* window regularly during a run.
updates the *Output* window regularly during a run. If there are any
warnings or errors in the LAMMPS output, they are highlighted by using
bold text colored in red. There is a small panel at the bottom center
of the *Output* window showing how many warnings and errors were
detected and how many lines the entire output has. By clicking on the
button on the right with the warning symbol or by using the keyboard
shortcut `Ctrl-N` (`Command-N` on macOS), you can jump to the next
line with a warning or error.
By default, the *Output* window is replaced each time a run is started.
The runs are counted and the run number for the current run is displayed
@ -398,7 +424,7 @@ below.
Like for the *Output* and *Charts* windows, its content is continuously
updated during a run. It will show "(none)" if there are no variables
defined. Note that it is also possible to *set* :doc:`index style
variables <variable>`, that would normally be set via command line
variables <variable>`, that would normally be set via command-line
flags, via the "Set Variables..." dialog from the *Run* menu.
LAMMPS-GUI automatically defines the variable "gui_run" to the current
value of the run counter. That way it is possible to automatically
@ -775,11 +801,11 @@ General Settings:
- *Echo input to log:* when checked, all input commands, including
variable expansions, are echoed to the *Output* window. This is
equivalent to using `-echo screen` at the command line. There is no
equivalent to using `-echo screen` at the command-line. There is no
log *file* produced by default, since LAMMPS-GUI uses `-log none`.
- *Include citation details:* when checked full citation info will be
included to the log window. This is equivalent to using `-cite
screen` on the command line.
screen` on the command-line.
- *Show log window by default:* when checked, the screen output of a
LAMMPS run will be collected in a log window during the run
- *Show chart window by default:* when checked, the thermodynamic
@ -828,7 +854,7 @@ Accelerators:
This tab enables selection of an accelerator package for LAMMPS to use
and is equivalent to using the `-suffix` and `-package` flags on the
command line. Only settings supported by the LAMMPS library and local
command-line. Only settings supported by the LAMMPS library and local
hardware are available. The `Number of threads` field allows setting
the maximum number of threads for the accelerator packages that use
threads.

View File

@ -738,8 +738,8 @@ command.
This can be done, for example, by using the built-in visualizer of the
:doc:`dump image or dump movie <dump_image>` command to create snapshot
images or a movie. Below are example command lines for using dump image
with the :ref:`example listed below <periexample>` and a set of images
images or a movie. Below are example command for using dump image with
the :ref:`example listed below <periexample>` and a set of images
created for steps 300, 600, and 2000 this way.
.. code-block:: LAMMPS

View File

@ -1,562 +1,6 @@
PyLammps Tutorial
=================
.. contents::
Overview
--------
:py:class:`PyLammps <lammps.PyLammps>` is a Python wrapper class for
LAMMPS which can be created on its own or use an existing
:py:class:`lammps Python <lammps.lammps>` object. It creates a simpler,
more "pythonic" interface to common LAMMPS functionality, in contrast to
the :py:class:`lammps <lammps.lammps>` wrapper for the LAMMPS :ref:`C
language library interface API <lammps_c_api>` which is written using
`Python ctypes <ctypes_>`_. The :py:class:`lammps <lammps.lammps>`
wrapper is discussed on the :doc:`Python_head` doc page.
Unlike the flat `ctypes <ctypes_>`_ interface, PyLammps exposes a
discoverable API. It no longer requires knowledge of the underlying C++
code implementation. Finally, the :py:class:`IPyLammps
<lammps.IPyLammps>` wrapper builds on top of :py:class:`PyLammps
<lammps.PyLammps>` and adds some additional features for `IPython
integration <ipython_>`_ into `Jupyter notebooks <jupyter_>`_, e.g. for
embedded visualization output from :doc:`dump style image <dump_image>`.
.. _ctypes: https://docs.python.org/3/library/ctypes.html
.. _ipython: https://ipython.org/
.. _jupyter: https://jupyter.org/
Comparison of lammps and PyLammps interfaces
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lammps.lammps
"""""""""""""
* uses `ctypes <ctypes_>`_
* direct memory access to native C++ data with optional support for NumPy arrays
* provides functions to send and receive data to LAMMPS
* interface modeled after the LAMMPS :ref:`C language library interface API <lammps_c_api>`
* requires knowledge of how LAMMPS internally works (C pointers, etc)
* full support for running Python with MPI using `mpi4py <https://mpi4py.readthedocs.io>`_
lammps.PyLammps
"""""""""""""""
* higher-level abstraction built on *top* of original :py:class:`ctypes based interface <lammps.lammps>`
* manipulation of Python objects
* communication with LAMMPS is hidden from API user
* shorter, more concise Python
* better IPython integration, designed for quick prototyping
* designed for serial execution
Quick Start
-----------
System-wide Installation
^^^^^^^^^^^^^^^^^^^^^^^^
Step 1: Building LAMMPS as a shared library
"""""""""""""""""""""""""""""""""""""""""""
To use LAMMPS inside of Python it has to be compiled as shared
library. This library is then loaded by the Python interface. In this
example we enable the MOLECULE package and compile LAMMPS with PNG, JPEG
and FFMPEG output support enabled.
Step 1a: For the CMake based build system, the steps are:
.. code-block:: bash
mkdir $LAMMPS_DIR/build-shared
cd $LAMMPS_DIR/build-shared
# MPI, PNG, Jpeg, FFMPEG are auto-detected
cmake ../cmake -DPKG_MOLECULE=yes -DBUILD_LIB=yes -DBUILD_SHARED_LIBS=yes
make
Step 1b: For the legacy, make based build system, the steps are:
.. code-block:: bash
cd $LAMMPS_DIR/src
# add packages if necessary
make yes-MOLECULE
# compile shared library using Makefile
make mpi mode=shlib LMP_INC="-DLAMMPS_PNG -DLAMMPS_JPEG -DLAMMPS_FFMPEG" JPG_LIB="-lpng -ljpeg"
Step 2: Installing the LAMMPS Python package
""""""""""""""""""""""""""""""""""""""""""""
PyLammps is part of the lammps Python package. To install it simply install
that package into your current Python installation with:
.. code-block:: bash
make install-python
.. note::
Recompiling the shared library requires re-installing the Python package
Installation inside of a virtualenv
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You can use virtualenv to create a custom Python environment specifically tuned
for your workflow.
Benefits of using a virtualenv
""""""""""""""""""""""""""""""
* isolation of your system Python installation from your development installation
* installation can happen in your user directory without root access (useful for HPC clusters)
* installing packages through pip allows you to get newer versions of packages than e.g., through apt-get or yum package managers (and without root access)
* you can even install specific old versions of a package if necessary
**Prerequisite (e.g. on Ubuntu)**
.. code-block:: bash
apt-get install python-virtualenv
Creating a virtualenv with lammps installed
"""""""""""""""""""""""""""""""""""""""""""
.. code-block:: bash
# create virtualenv named 'testing'
virtualenv $HOME/python/testing
# activate 'testing' environment
source $HOME/python/testing/bin/activate
Now configure and compile the LAMMPS shared library as outlined above.
When using CMake and the shared library has already been build, you
need to re-run CMake to update the location of the python executable
to the location in the virtual environment with:
.. code-block:: bash
cmake . -DPython_EXECUTABLE=$(which python)
# install LAMMPS package in virtualenv
(testing) make install-python
# install other useful packages
(testing) pip install matplotlib jupyter mpi4py
...
# return to original shell
(testing) deactivate
Creating a new instance of PyLammps
-----------------------------------
To create a PyLammps object you need to first import the class from the lammps
module. By using the default constructor, a new *lammps* instance is created.
.. code-block:: python
from lammps import PyLammps
L = PyLammps()
You can also initialize PyLammps on top of this existing *lammps* object:
.. code-block:: python
from lammps import lammps, PyLammps
lmp = lammps()
L = PyLammps(ptr=lmp)
Commands
--------
Sending a LAMMPS command with the existing library interfaces is done using
the command method of the lammps object instance.
For instance, let's take the following LAMMPS command:
.. code-block:: LAMMPS
region box block 0 10 0 5 -0.5 0.5
In the original interface this command can be executed with the following
Python code if *L* was a lammps instance:
.. code-block:: python
L.command("region box block 0 10 0 5 -0.5 0.5")
With the PyLammps interface, any command can be split up into arbitrary parts
separated by white-space, passed as individual arguments to a region method.
.. code-block:: python
L.region("box block", 0, 10, 0, 5, -0.5, 0.5)
Note that each parameter is set as Python literal floating-point number. In the
PyLammps interface, each command takes an arbitrary parameter list and transparently
merges it to a single command string, separating individual parameters by white-space.
The benefit of this approach is avoiding redundant command calls and easier
parameterization. In the original interface parameterization needed to be done
manually by creating formatted strings.
.. code-block:: python
L.command("region box block %f %f %f %f %f %f" % (xlo, xhi, ylo, yhi, zlo, zhi))
In contrast, methods of PyLammps accept parameters directly and will convert
them automatically to a final command string.
.. code-block:: python
L.region("box block", xlo, xhi, ylo, yhi, zlo, zhi)
System state
------------
In addition to dispatching commands directly through the PyLammps object, it
also provides several properties which allow you to query the system state.
L.system
Is a dictionary describing the system such as the bounding box or number of atoms
L.system.xlo, L.system.xhi
bounding box limits along x-axis
L.system.ylo, L.system.yhi
bounding box limits along y-axis
L.system.zlo, L.system.zhi
bounding box limits along z-axis
L.communication
configuration of communication subsystem, such as the number of threads or processors
L.communication.nthreads
number of threads used by each LAMMPS process
L.communication.nprocs
number of MPI processes used by LAMMPS
L.fixes
List of fixes in the current system
L.computes
List of active computes in the current system
L.dump
List of active dumps in the current system
L.groups
List of groups present in the current system
Working with LAMMPS variables
-----------------------------
LAMMPS variables can be both defined and accessed via the PyLammps interface.
To define a variable you can use the :doc:`variable <variable>` command:
.. code-block:: python
L.variable("a index 2")
A dictionary of all variables is returned by L.variables
you can access an individual variable by retrieving a variable object from the
L.variables dictionary by name
.. code-block:: python
a = L.variables['a']
The variable value can then be easily read and written by accessing the value
property of this object.
.. code-block:: python
print(a.value)
a.value = 4
Retrieving the value of an arbitrary LAMMPS expressions
-------------------------------------------------------
LAMMPS expressions can be immediately evaluated by using the eval method. The
passed string parameter can be any expression containing global thermo values,
variables, compute or fix data.
.. code-block:: python
result = L.eval("ke") # kinetic energy
result = L.eval("pe") # potential energy
result = L.eval("v_t/2.0")
Accessing atom data
-------------------
All atoms in the current simulation can be accessed by using the L.atoms list.
Each element of this list is an object which exposes its properties (id, type,
position, velocity, force, etc.).
.. code-block:: python
# access first atom
L.atoms[0].id
L.atoms[0].type
# access second atom
L.atoms[1].position
L.atoms[1].velocity
L.atoms[1].force
Some properties can also be used to set:
.. code-block:: python
# set position in 2D simulation
L.atoms[0].position = (1.0, 0.0)
# set position in 3D simulation
L.atoms[0].position = (1.0, 0.0, 1.)
Evaluating thermo data
----------------------
Each simulation run usually produces thermo output based on system state,
computes, fixes or variables. The trajectories of these values can be queried
after a run via the L.runs list. This list contains a growing list of run data.
The first element is the output of the first run, the second element that of
the second run.
.. code-block:: python
L.run(1000)
L.runs[0] # data of first 1000 time steps
L.run(1000)
L.runs[1] # data of second 1000 time steps
Each run contains a dictionary of all trajectories. Each trajectory is
accessible through its thermo name:
.. code-block:: python
L.runs[0].thermo.Step # list of time steps in first run
L.runs[0].thermo.Ke # list of kinetic energy values in first run
Together with matplotlib plotting data out of LAMMPS becomes simple:
.. code-block:: python
import matplotlib.plot as plt
steps = L.runs[0].thermo.Step
ke = L.runs[0].thermo.Ke
plt.plot(steps, ke)
Error handling with PyLammps
----------------------------
Using C++ exceptions in LAMMPS for errors allows capturing them on the
C++ side and rethrowing them on the Python side. This way you can handle
LAMMPS errors through the Python exception handling mechanism.
.. warning::
Capturing a LAMMPS exception in Python can still mean that the
current LAMMPS process is in an illegal state and must be
terminated. It is advised to save your data and terminate the Python
instance as quickly as possible.
Using PyLammps in IPython notebooks and Jupyter
-----------------------------------------------
If the LAMMPS Python package is installed for the same Python interpreter as
IPython, you can use PyLammps directly inside of an IPython notebook inside of
Jupyter. Jupyter is a powerful integrated development environment (IDE) for
many dynamic languages like Python, Julia and others, which operates inside of
any web browser. Besides auto-completion and syntax highlighting it allows you
to create formatted documents using Markup, mathematical formulas, graphics and
animations intermixed with executable Python code. It is a great format for
tutorials and showcasing your latest research.
To launch an instance of Jupyter simply run the following command inside your
Python environment (this assumes you followed the Quick Start instructions):
.. code-block:: bash
jupyter notebook
IPyLammps Examples
------------------
Examples of IPython notebooks can be found in the python/examples/pylammps
subdirectory. To open these notebooks launch *jupyter notebook* inside this
directory and navigate to one of them. If you compiled and installed
a LAMMPS shared library with exceptions, PNG, JPEG and FFMPEG support
you should be able to rerun all of these notebooks.
Validating a dihedral potential
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This example showcases how an IPython Notebook can be used to compare a simple
LAMMPS simulation of a harmonic dihedral potential to its analytical solution.
Four atoms are placed in the simulation and the dihedral potential is applied on
them using a datafile. Then one of the atoms is rotated along the central axis by
setting its position from Python, which changes the dihedral angle.
.. code-block:: python
phi = [d \* math.pi / 180 for d in range(360)]
pos = [(1.0, math.cos(p), math.sin(p)) for p in phi]
pe = []
for p in pos:
L.atoms[3].position = p
L.run(0)
pe.append(L.eval("pe"))
By evaluating the potential energy for each position we can verify that
trajectory with the analytical formula. To compare both solutions, we plot
both trajectories over each other using matplotlib, which embeds the generated
plot inside the IPython notebook.
.. image:: JPG/pylammps_dihedral.jpg
:align: center
Running a Monte Carlo relaxation
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This second example shows how to use PyLammps to create a 2D Monte Carlo Relaxation
simulation, computing and plotting energy terms and even embedding video output.
Initially, a 2D system is created in a state with minimal energy.
.. image:: JPG/pylammps_mc_minimum.jpg
:align: center
It is then disordered by moving each atom by a random delta.
.. code-block:: python
random.seed(27848)
deltaperturb = 0.2
for i in range(L.system.natoms):
x, y = L.atoms[i].position
dx = deltaperturb \* random.uniform(-1, 1)
dy = deltaperturb \* random.uniform(-1, 1)
L.atoms[i].position = (x+dx, y+dy)
L.run(0)
.. image:: JPG/pylammps_mc_disordered.jpg
:align: center
Finally, the Monte Carlo algorithm is implemented in Python. It continuously
moves random atoms by a random delta and only accepts certain moves.
.. code-block:: python
estart = L.eval("pe")
elast = estart
naccept = 0
energies = [estart]
niterations = 3000
deltamove = 0.1
kT = 0.05
natoms = L.system.natoms
for i in range(niterations):
iatom = random.randrange(0, natoms)
current_atom = L.atoms[iatom]
x0, y0 = current_atom.position
dx = deltamove \* random.uniform(-1, 1)
dy = deltamove \* random.uniform(-1, 1)
current_atom.position = (x0+dx, y0+dy)
L.run(1, "pre no post no")
e = L.eval("pe")
energies.append(e)
if e <= elast:
naccept += 1
elast = e
elif random.random() <= math.exp(natoms\*(elast-e)/kT):
naccept += 1
elast = e
else:
current_atom.position = (x0, y0)
The energies of each iteration are collected in a Python list and finally plotted using matplotlib.
.. image:: JPG/pylammps_mc_energies_plot.jpg
:align: center
The IPython notebook also shows how to use dump commands and embed video files
inside of the IPython notebook.
Using PyLammps and mpi4py (Experimental)
----------------------------------------
PyLammps can be run in parallel using `mpi4py
<https://mpi4py.readthedocs.io>`_. This python package can be installed
using
.. code-block:: bash
pip install mpi4py
.. warning::
Usually, any :py:class:`PyLammps <lammps.PyLammps>` command must be
executed by *all* MPI processes. However, evaluations and querying
the system state is only available on MPI rank 0. Using these
functions from other MPI ranks will raise an exception.
The following is a short example which reads in an existing LAMMPS input
file and executes it in parallel. You can find in.melt in the
examples/melt folder. Please take note that the
:py:meth:`PyLammps.eval() <lammps.PyLammps.eval>` is called only from
MPI rank 0.
.. code-block:: python
from mpi4py import MPI
from lammps import PyLammps
L = PyLammps()
L.file("in.melt")
if MPI.COMM_WORLD.rank == 0:
print("Potential energy: ", L.eval("pe"))
MPI.Finalize()
To run this script (melt.py) in parallel using 4 MPI processes we invoke the
following mpirun command:
.. code-block:: bash
mpirun -np 4 python melt.py
Feedback and Contributing
-------------------------
If you find this Python interface useful, please feel free to provide feedback
and ideas on how to improve it to Richard Berger (richard.berger@outlook.com). We also
want to encourage people to write tutorial style IPython notebooks showcasing LAMMPS usage
and maybe their latest research results.
The PyLammps interface is deprecated and will be removed in a future release of
LAMMPS. As such, the PyLammps version of this tutorial has been removed and is
replaced by the :doc:`Python_head`.

441
doc/src/Howto_python.rst Normal file
View File

@ -0,0 +1,441 @@
LAMMPS Python Tutorial
======================
.. contents::
-----
Overview
--------
The :py:class:`lammps <lammps.lammps>` Python module is a wrapper class for the
LAMMPS :ref:`C language library interface API <lammps_c_api>` which is written using
`Python ctypes <ctypes_>`_. The design choice of this wrapper class is to
follow the C language API closely with only small changes related to Python
specific requirements and to better accommodate object oriented programming.
In addition to this flat `ctypes <ctypes_>`_ interface, the
:py:class:`lammps <lammps.lammps>` wrapper class exposes a discoverable
API that doesn't require as much knowledge of the underlying C language
library interface or LAMMPS C++ code implementation.
Finally, the API exposes some additional features for `IPython integration
<ipython_>`_ into `Jupyter notebooks <jupyter_>`_, e.g. for embedded
visualization output from :doc:`dump style image <dump_image>`.
.. _ctypes: https://docs.python.org/3/library/ctypes.html
.. _ipython: https://ipython.org/
.. _jupyter: https://jupyter.org/
-----
Quick Start
-----------
System-wide or User Installation
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Step 1: Building LAMMPS as a shared library
"""""""""""""""""""""""""""""""""""""""""""
To use LAMMPS inside of Python it has to be compiled as shared library.
This library is then loaded by the Python interface. In this example we
enable the :ref:`MOLECULE package <PKG-MOLECULE>` and compile LAMMPS
with :ref:`PNG, JPEG and FFMPEG output support <graphics>` enabled.
.. tabs::
.. tab:: CMake build
.. code-block:: bash
mkdir $LAMMPS_DIR/build-shared
cd $LAMMPS_DIR/build-shared
# MPI, PNG, Jpeg, FFMPEG are auto-detected
cmake ../cmake -DPKG_MOLECULE=yes -DPKG_PYTHON=on -DBUILD_SHARED_LIBS=yes
make
.. tab:: Traditional make
.. code-block:: bash
cd $LAMMPS_DIR/src
# add packages if necessary
make yes-MOLECULE
make yes-PYTHON
# compile shared library using Makefile
make mpi mode=shlib LMP_INC="-DLAMMPS_PNG -DLAMMPS_JPEG -DLAMMPS_FFMPEG" JPG_LIB="-lpng -ljpeg"
Step 2: Installing the LAMMPS Python package
""""""""""""""""""""""""""""""""""""""""""""
Next install the LAMMPS Python package into your current Python installation with:
.. code-block:: bash
make install-python
This will create a so-called `"wheel"
<https://packaging.python.org/en/latest/discussions/package-formats/#what-is-a-wheel>`_
and then install the LAMMPS Python module from that "wheel" into either
into a system folder (provided the command is executed with root
privileges) or into your personal Python module folder.
.. note::
Recompiling the shared library requires re-installing the Python
package.
Installation inside of a virtual environment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You can use virtual environments to create a custom Python environment
specifically tuned for your workflow.
Benefits of using a virtualenv
""""""""""""""""""""""""""""""
* isolation of your system Python installation from your development installation
* installation can happen in your user directory without root access (useful for HPC clusters)
* installing packages through pip allows you to get newer versions of packages than e.g., through apt-get or yum package managers (and without root access)
* you can even install specific old versions of a package if necessary
**Prerequisite (e.g. on Ubuntu)**
.. code-block:: bash
apt-get install python-venv
Creating a virtualenv with lammps installed
"""""""""""""""""""""""""""""""""""""""""""
.. code-block:: bash
# create virtual envrionment named 'testing'
python3 -m venv $HOME/python/testing
# activate 'testing' environment
source $HOME/python/testing/bin/activate
Now configure and compile the LAMMPS shared library as outlined above.
When using CMake and the shared library has already been build, you
need to re-run CMake to update the location of the python executable
to the location in the virtual environment with:
.. code-block:: bash
cmake . -DPython_EXECUTABLE=$(which python)
# install LAMMPS package in virtualenv
(testing) make install-python
# install other useful packages
(testing) pip install matplotlib jupyter mpi4py pandas
...
# return to original shell
(testing) deactivate
-------
Creating a new lammps instance
------------------------------
To create a lammps object you need to first import the class from the lammps
module. By using the default constructor, a new :py:class:`lammps
<lammps.lammps>` instance is created.
.. code-block:: python
from lammps import lammps
L = lammps()
See the :doc:`LAMMPS Python documentation <Python_create>` for how to customize
the instance creation with optional arguments.
-----
Commands
--------
Sending a LAMMPS command with the library interface is done using
the ``command`` method of the lammps object.
For instance, let's take the following LAMMPS command:
.. code-block:: LAMMPS
region box block 0 10 0 5 -0.5 0.5
This command can be executed with the following Python code if ``L`` is a ``lammps``
instance:
.. code-block:: python
L.command("region box block 0 10 0 5 -0.5 0.5")
For convenience, the ``lammps`` class also provides a command wrapper ``cmd``
that turns any LAMMPS command into a regular function call:
.. code-block:: python
L.cmd.region("box block", 0, 10, 0, 5, -0.5, 0.5)
Note that each parameter is set as Python number literal. With
the wrapper each command takes an arbitrary parameter list and transparently
merges it to a single command string, separating individual parameters by
white-space.
The benefit of this approach is avoiding redundant command calls and easier
parameterization. With the ``command`` function each call needs to be assembled
manually using formatted strings.
.. code-block:: python
L.command(f"region box block {xlo} {xhi} {ylo} {yhi} {zlo} {zhi}")
The wrapper accepts parameters directly and will convert
them automatically to a final command string.
.. code-block:: python
L.cmd.region("box block", xlo, xhi, ylo, yhi, zlo, zhi)
.. note::
When running in IPython you can use Tab-completion after ``L.cmd.`` to see
all available LAMMPS commands.
-----
Accessing atom data
-------------------
All per-atom properties that are part of the :doc:`atom style
<atom_style>` in the current simulation can be accessed using the
:py:meth:`extract_atoms() <lammps.lammps.extract_atoms()>` method. This
can be retrieved as ctypes objects or as NumPy arrays through the
lammps.numpy module. Those represent the *local* atoms of the
individual sub-domain for the current MPI process and may contain
information for the local ghost atoms or not depending on the property.
Both can be accessed as lists, but for the ctypes list object the size
is not known and hast to be retrieved first to avoid out-of-bounds
accesses.
.. code-block:: python
nlocal = L.extract_setting("nlocal")
nall = L.extract_setting("nall")
print("Number of local atoms ", nlocal, " Number of local and ghost atoms ", nall);
# access via ctypes directly
atom_id = L.extract_atom("id")
print("Atom IDs", atom_id[0:nlocal])
# access through numpy wrapper
atom_type = L.numpy.extract_atom("type")
print("Atom types", atom_type)
x = L.numpy.extract_atom("x")
v = L.numpy.extract_atom("v")
print("positions array shape", x.shape)
print("velocity array shape", v.shape)
# turn on communicating velocities to ghost atoms
L.cmd.comm_modify("vel", "yes")
v = L.numpy.extract_atom('v')
print("velocity array shape", v.shape)
Some properties can also be set from Python since internally the
data of the C++ code is accessed directly:
.. code-block:: python
# set position in 2D simulation
x[0] = (1.0, 0.0)
# set position in 3D simulation
x[0] = (1.0, 0.0, 1.)
------
Retrieving the values of thermodynamic data and variables
---------------------------------------------------------
To access thermodynamic data from the last completed timestep,
you can use the :py:meth:`get_thermo() <lammps.lammps.get_thermo>`
method, and to extract the value of (compatible) variables, you
can use the :py:meth:`extract_variable() <lammps.lammps.extract_variable>`
method.
.. code-block:: python
result = L.get_thermo("ke") # kinetic energy
result = L.get_thermo("pe") # potential energy
result = L.extract_variable("t") / 2.0
Error handling
--------------
We are using C++ exceptions in LAMMPS for errors and the C language
library interface captures and records them. This allows checking
whether errors have happened in Python during a call into LAMMPS and
then re-throw the error as a Python exception. This way you can handle
LAMMPS errors in the conventional way through the Python exception
handling mechanism.
.. warning::
Capturing a LAMMPS exception in Python can still mean that the
current LAMMPS process is in an illegal state and must be
terminated. It is advised to save your data and terminate the Python
instance as quickly as possible.
Using LAMMPS in IPython notebooks and Jupyter
---------------------------------------------
If the LAMMPS Python package is installed for the same Python
interpreter as IPython, you can use LAMMPS directly inside of an IPython
notebook inside of Jupyter. Jupyter is a powerful integrated development
environment (IDE) for many dynamic languages like Python, Julia and
others, which operates inside of any web browser. Besides
auto-completion and syntax highlighting it allows you to create
formatted documents using Markup, mathematical formulas, graphics and
animations intermixed with executable Python code. It is a great format
for tutorials and showcasing your latest research.
To launch an instance of Jupyter simply run the following command inside your
Python environment (this assumes you followed the Quick Start instructions):
.. code-block:: bash
jupyter notebook
Interactive Python Examples
---------------------------
Examples of IPython notebooks can be found in the ``python/examples/ipython``
subdirectory. To open these notebooks launch ``jupyter notebook`` inside this
directory and navigate to one of them. If you compiled and installed
a LAMMPS shared library with PNG, JPEG and FFMPEG support
you should be able to rerun all of these notebooks.
Validating a dihedral potential
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This example showcases how an IPython Notebook can be used to compare a simple
LAMMPS simulation of a harmonic dihedral potential to its analytical solution.
Four atoms are placed in the simulation and the dihedral potential is applied on
them using a datafile. Then one of the atoms is rotated along the central axis by
setting its position from Python, which changes the dihedral angle.
.. code-block:: python
phi = [d \* math.pi / 180 for d in range(360)]
pos = [(1.0, math.cos(p), math.sin(p)) for p in phi]
x = L.numpy.extract_atom("x")
pe = []
for p in pos:
x[3] = p
L.cmd.run(0, "post", "no")
pe.append(L.get_thermo("pe"))
By evaluating the potential energy for each position we can verify that
trajectory with the analytical formula. To compare both solutions, we plot
both trajectories over each other using matplotlib, which embeds the generated
plot inside the IPython notebook.
.. image:: JPG/pylammps_dihedral.jpg
:align: center
Running a Monte Carlo relaxation
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This second example shows how to use the `lammps` Python interface to create a
2D Monte Carlo Relaxation simulation, computing and plotting energy terms and
even embedding video output.
Initially, a 2D system is created in a state with minimal energy.
.. image:: JPG/pylammps_mc_minimum.jpg
:align: center
It is then disordered by moving each atom by a random delta.
.. code-block:: python
random.seed(27848)
deltaperturb = 0.2
x = L.numpy.extract_atom("x")
natoms = x.shape[0]
for i in range(natoms):
dx = deltaperturb \* random.uniform(-1, 1)
dy = deltaperturb \* random.uniform(-1, 1)
x[i][0] += dx
x[i][1] += dy
L.cmd.run(0, "post", "no")
.. image:: JPG/pylammps_mc_disordered.jpg
:align: center
Finally, the Monte Carlo algorithm is implemented in Python. It continuously
moves random atoms by a random delta and only accepts certain moves.
.. code-block:: python
estart = L.get_thermo("pe")
elast = estart
naccept = 0
energies = [estart]
niterations = 3000
deltamove = 0.1
kT = 0.05
for i in range(niterations):
x = L.numpy.extract_atom("x")
natoms = x.shape[0]
iatom = random.randrange(0, natoms)
current_atom = x[iatom]
x0 = current_atom[0]
y0 = current_atom[1]
dx = deltamove \* random.uniform(-1, 1)
dy = deltamove \* random.uniform(-1, 1)
current_atom[0] = x0 + dx
current_atom[1] = y0 + dy
L.cmd.run(1, "pre no post no")
e = L.get_thermo("pe")
energies.append(e)
if e <= elast:
naccept += 1
elast = e
elif random.random() <= math.exp(natoms\*(elast-e)/kT):
naccept += 1
elast = e
else:
current_atom[0] = x0
current_atom[1] = y0
The energies of each iteration are collected in a Python list and finally plotted using matplotlib.
.. image:: JPG/pylammps_mc_energies_plot.jpg
:align: center
The IPython notebook also shows how to use dump commands and embed video files
inside of the IPython notebook.

View File

@ -15,8 +15,9 @@ details of the system, or develop new capabilities. For instance, the numerics
associated with calculating gradients, reproducing kernels, etc. are separated
into distinct classes to simplify the development of new integration schemes
which can call these calculations. Additional numerical details can be found in
:ref:`(Clemmer) <howto_rheo_clemmer>`. Example movies illustrating some of these
capabilities are found at https://www.lammps.org/movies.html#rheopackage.
:ref:`(Palermo) <howto_rheo_palermo>` and :ref:`(Clemmer) <howto_rheo_clemmer>`.
Example movies illustrating some of these capabilities are found at
https://www.lammps.org/movies.html#rheopackage.
Note, if you simply want to run a traditional SPH simulation, the :ref:`SPH package
<PKG-SPH>` package is likely better suited for your application. It has fewer advanced
@ -70,7 +71,7 @@ particles to solid (e.g. with the :doc:`set <set>` command), (b) create bpm
bonds between the particles (see the :doc:`bpm howto <Howto_bpm>` page for
more details), and (c) use :doc:`pair rheo/solid <pair_rheo_solid>` to
apply repulsive contact forces between distinct solid bodies. Akin to pair rheo,
pair rheo/solid considers a particles fluid/solid phase to determine whether to
pair rheo/solid considers a particle's fluid/solid phase to determine whether to
apply forces. However, unlike pair rheo, pair rheo/solid does obey special bond
settings such that contact forces do not have to be calculated between two bonded
solid particles in the same elastic body.
@ -79,10 +80,10 @@ In systems with thermal evolution, fix rheo/thermal can optionally set a
melting/solidification temperature allowing particles to dynamically swap their
state between fluid and solid when the temperature exceeds or drops below the
critical temperature, respectively. Using the *react* option, one can specify a maximum
bond length and a bond type. Then, when solidifying, particles will search their
bond length and a bond type. Then, when solidifying, particles search their
local neighbors and automatically create bonds with any neighboring solid particles
in range. For BPM bond styles, bonds will then use the immediate position of the two
particles to calculate a reference state. When melting, particles will delete any
in range. For BPM bond styles, bonds then use the immediate position of the two
particles to calculate a reference state. When melting, particles delete any
bonds of the specified type when reverting to a fluid state. Special bonds are updated
as bonds are created/broken.
@ -107,6 +108,10 @@ criteria for creating/deleting a bond or altering force calculations).
----------
.. _howto_rheo_palermo:
**(Palermo)** Palermo, Wolf, Clemmer, O'Connor, Phys. Fluids, 36, 113337 (2024).
.. _howto_rheo_clemmer:
**(Clemmer)** Clemmer, Pierce, O'Connor, Nevins, Jones, Lechman, Tencer, Appl. Math. Model., 130, 310-326 (2024).

View File

@ -260,7 +260,7 @@ Switch into the :code:`examples/melt` folder:
cd ../examples/melt
To run this example in serial, use the following command line:
To run this example in serial, use the following command:
.. code-block::

View File

@ -52,6 +52,7 @@ your machine and "release" is one of the 3 branches listed above.
between them at any time using "git checkout <branch name>".)
.. admonition:: Saving time and disk space when using ``git clone``
:class: note
The complete git history of the LAMMPS project is quite large because
it contains the entire commit history of the project since fall 2006,
@ -60,7 +61,7 @@ between them at any time using "git checkout <branch name>".)
files (mostly by accident). If you do not need access to the entire
commit history (most people don't), you can speed up the "cloning"
process and reduce local disk space requirements by using the
``--depth`` git command line flag. That will create a "shallow clone"
``--depth`` git command-line flag. That will create a "shallow clone"
of the repository, which contains only a subset of the git history.
Using a depth of 1000 is usually sufficient to include the head
commits of the *develop*, the *release*, and the *maintenance*

View File

@ -8,6 +8,8 @@ send an email to all of them at this address: "developers at
lammps.org". General questions about LAMMPS should be posted in the
`LAMMPS forum on MatSci <https://matsci.org/lammps/>`_.
.. We need to keep this file in sync with https://www.lammps.org/authors.html
.. raw:: latex
\small
@ -27,7 +29,7 @@ lammps.org". General questions about LAMMPS should be posted in the
* - `Steve Plimpton <sjp_>`_
- SNL (retired)
- sjplimp at gmail.com
- MD kernels, parallel algorithms & scalability, code structure and design
- original author, MD kernels, parallel algorithms & scalability, code structure and design
* - `Aidan Thompson <at_>`_
- SNL
- athomps at sandia.gov
@ -56,7 +58,7 @@ lammps.org". General questions about LAMMPS should be posted in the
- SNL
- jmgoff at sandia.gov
- machine learned potentials, QEq solvers, Python
* - Megan McCarthy
* - Meg McCarthy
- SNL
- megmcca at sandia.gov
- alloys, micro-structure, machine learned potentials
@ -67,7 +69,7 @@ lammps.org". General questions about LAMMPS should be posted in the
* - `Trung Nguyen <tn_>`_
- U Chicago
- ndactrung at gmail.com
- soft matter, GPU package
- soft matter, GPU package, DIELECTRIC package, regression testing
.. _rb: https://rbberger.github.io/
.. _gc: https://enthalpiste.fr/

View File

@ -31,18 +31,19 @@ Operating systems
^^^^^^^^^^^^^^^^^
The primary development platform for LAMMPS is Linux. Thus, the chances
for LAMMPS to compile without problems on Linux machines are the best.
for LAMMPS to compile without problems are the best on Linux machines.
Also, compilation and correct execution on macOS and Windows (using
Microsoft Visual C++) is checked automatically for largest part of the
source code. Some (optional) features are not compatible with all
Microsoft Visual C++) is checked automatically for the largest part of
the source code. Some (optional) features are not compatible with all
operating systems, either through limitations of the corresponding
LAMMPS source code or through source code or build system
incompatibilities of required libraries.
LAMMPS source code or through incompatibilities of source code or
build system of required external libraries or packages.
Executables for Windows may be created natively using either Cygwin or
Visual Studio or with a Linux to Windows MinGW cross-compiler.
Additionally, FreeBSD and Solaris have been tested successfully.
Additionally, FreeBSD and Solaris have been tested successfully to
run LAMMPS and produce results consistent with those on Linux.
Compilers
^^^^^^^^^

Binary file not shown.

Before

Width:  |  Height:  |  Size: 103 KiB

After

Width:  |  Height:  |  Size: 78 KiB

View File

@ -131,16 +131,15 @@ run LAMMPS in serial mode.
.. _lammps_python_api:
LAMMPS Python APIs
==================
LAMMPS Python API
=================
The LAMMPS Python module enables calling the LAMMPS C library API from
Python by dynamically loading functions in the LAMMPS shared library through
the `Python ctypes module <https://docs.python.org/3/library/ctypes.html>`_.
Because of the dynamic loading, it is **required** that LAMMPS is compiled
in :ref:`"shared" mode <exe>`. The Python interface is object-oriented, but
otherwise tries to be very similar to the C library API. Three different
Python classes to run LAMMPS are available and they build on each other.
otherwise tries to be very similar to the C library API.
More information on this is in the :doc:`Python_head`
section of the manual. Use of the LAMMPS Python module is described in
:doc:`Python_module`.

View File

@ -4,6 +4,7 @@ Per-atom properties
This section documents the following functions:
- :cpp:func:`lammps_extract_atom_datatype`
- :cpp:func:`lammps_extract_atom_size`
- :cpp:func:`lammps_extract_atom`
-----------------------
@ -13,6 +14,11 @@ This section documents the following functions:
-----------------------
.. doxygenfunction:: lammps_extract_atom_size
:project: progguide
-----------------------
.. doxygenfunction:: lammps_extract_atom
:project: progguide

View File

@ -7,6 +7,7 @@ This section documents the following functions:
- :cpp:func:`lammps_command`
- :cpp:func:`lammps_commands_list`
- :cpp:func:`lammps_commands_string`
- :cpp:func:`lammps_expand`
--------------------
@ -79,3 +80,8 @@ Below is a short example using some of these functions.
.. doxygenfunction:: lammps_commands_string
:project: progguide
-----------------------
.. doxygenfunction:: lammps_expand
:project: progguide

View File

@ -1,5 +1,5 @@
Compute, fixes, variables
=========================
Computes, fixes, variables
==========================
This section documents accessing or modifying data stored by computes,
fixes, or variables in LAMMPS using the following functions:
@ -12,6 +12,10 @@ fixes, or variables in LAMMPS using the following functions:
- :cpp:func:`lammps_set_string_variable`
- :cpp:func:`lammps_set_internal_variable`
- :cpp:func:`lammps_variable_info`
- :cpp:func:`lammps_eval`
- :cpp:func:`lammps_clearstep_compute`
- :cpp:func:`lammps_addstep_compute_all`
- :cpp:func:`lammps_addstep_compute`
-----------------------
@ -55,6 +59,26 @@ fixes, or variables in LAMMPS using the following functions:
-----------------------
.. doxygenfunction:: lammps_eval
:project: progguide
-----------------------
.. doxygenfunction:: lammps_clearstep_compute
:project: progguide
-----------------------
.. doxygenfunction:: lammps_addstep_compute_all
:project: progguide
-----------------------
.. doxygenfunction:: lammps_addstep_compute
:project: progguide
-----------------------
.. doxygenenum:: _LMP_DATATYPE_CONST
.. doxygenenum:: _LMP_STYLE_CONST

View File

@ -45,6 +45,8 @@ class. See compute.h for details.
+-----------------------+------------------------------------------------------------------+
| pair_tally_callback | callback function for *tally*\ -style computes (optional). |
+-----------------------+------------------------------------------------------------------+
| modify_param | called when a compute_modify request is executed (optional) |
+-----------------------+------------------------------------------------------------------+
| memory_usage | tally memory usage (optional) |
+-----------------------+------------------------------------------------------------------+

View File

@ -208,20 +208,21 @@ Build system (strict)
LAMMPS currently supports two build systems: one that is based on
:doc:`traditional Makefiles <Build_make>` and one that is based on
:doc:`CMake <Build_cmake>`. Therefore, your contribution must be
compatible with and support both build systems.
:doc:`CMake <Build_cmake>`. As of fall 2024, it is no longer required
to support the traditional make build system. New packages may choose
to only support building with CMake. Additions to existing packages
must follow the requirements set by that package.
For a single pair of header and implementation files that are an
independent feature, it is usually only required to add them to
``src/.gitignore``.
For traditional make, if your contributed files or package depend on
other LAMMPS style files or packages also being installed
(e.g. because your file is a derived class from the other LAMMPS
class), then an ``Install.sh`` file is also needed to check for those
dependencies and modifications to ``src/Depend.sh`` to trigger the checks.
See other README and Install.sh files in other directories as
examples.
other LAMMPS style files or packages also being installed (e.g. because
your file is a derived class from the other LAMMPS class), then an
``Install.sh`` file is also needed to check for those dependencies and
modifications to ``src/Depend.sh`` to trigger the checks. See other
README and Install.sh files in other directories as examples.
Similarly, for CMake support, changes may need to be made to
``cmake/CMakeLists.txt``, some of the files in ``cmake/presets``, and

View File

@ -46,7 +46,7 @@ Include files (varied)
but instead should be initialized either in the initializer list of
the constructor or explicitly assigned in the body of the constructor.
If the member variable is relevant to the functionality of a class
(for example when it stores a value from a command line argument), the
(for example when it stores a value from a command-line argument), the
member variable declaration is followed by a brief comment explaining
its purpose and what its values can be. Class members that are
pointers should always be initialized to ``nullptr`` in the

View File

@ -880,7 +880,7 @@ groups of atoms that interact with the remaining atoms as electrolyte.
**Authors:** The ELECTRODE package is written and maintained by Ludwig
Ahrens-Iwers (TUHH, Hamburg, Germany), Shern Tee (UQ, Brisbane, Australia) and
Robert Meissner (TUHH, Hamburg, Germany).
Robert Meissner (Helmholtz-Zentrum Hereon, Geesthacht and TUHH, Hamburg, Germany).
.. versionadded:: 4May2022
@ -994,6 +994,7 @@ Additional pair styles that are less commonly used.
* ``src/EXTRA-PAIR``: filenames -> commands
* :doc:`pair_style <pair_style>`
* ``examples/PACKAGES/dispersion``
----------
@ -2171,8 +2172,8 @@ the :doc:`Build extras <Build_extras>` page.
* ``src/OPENMP/README``
* :doc:`Accelerator packages <Speed_packages>`
* :doc:`OPENMP package <Speed_omp>`
* :doc:`Command line option -suffix/-sf omp <Run_options>`
* :doc:`Command line option -package/-pk omp <Run_options>`
* :doc:`Command-line option -suffix/-sf omp <Run_options>`
* :doc:`Command-line option -package/-pk omp <Run_options>`
* :doc:`package omp <package>`
* Search the :doc:`commands <Commands_all>` pages (:doc:`fix <Commands_fix>`, :doc:`compute <Commands_compute>`,
:doc:`pair <Commands_pair>`, :doc:`bond, angle, dihedral, improper <Commands_bond>`,
@ -2789,14 +2790,15 @@ implements smoothed particle hydrodynamics (SPH) for liquids. See the
related :ref:`MACHDYN package <PKG-MACHDYN>` package for smooth Mach dynamics
(SMD) for solids.
This package contains ideal gas, Lennard-Jones equation of states,
Tait, and full support for complete (i.e. internal-energy dependent)
equations of state. It allows for plain or Monaghans XSPH integration
of the equations of motion. It has options for density continuity or
density summation to propagate the density field. It has
:doc:`set <set>` command options to set the internal energy and density
of particles from the input script and allows the same quantities to
be output with thermodynamic output or to dump files via the :doc:`compute property/atom <compute_property_atom>` command.
This package contains ideal gas, Lennard-Jones equation of states, Tait,
and full support for complete (i.e. internal-energy dependent) equations
of state. It allows for plain or Monaghans XSPH integration of the
equations of motion. It has options for density continuity or density
summation to propagate the density field. It has :doc:`set <set>`
command options to set the internal energy and density of particles from
the input script and allows the same quantities to be output with
thermodynamic output or to dump files via the :doc:`compute
property/atom <compute_property_atom>` command.
**Author:** Georg Ganzenmuller (Fraunhofer-Institute for High-Speed
Dynamics, Ernst Mach Institute, Germany).
@ -2809,6 +2811,17 @@ Dynamics, Ernst Mach Institute, Germany).
* ``examples/PACKAGES/sph``
* https://www.lammps.org/movies.html#sph
.. note::
Please note that the SPH PDF guide file has not been updated for
many years and thus does not reflect the current *syntax* of the
SPH package commands. For that please refer to the LAMMPS manual.
.. note::
Please also note, that the :ref:`RHEO package <PKG-RHEO>` offers
similar functionality in a more modern and flexible implementation.
----------
.. _PKG-SPIN:

View File

@ -2,14 +2,8 @@ Per-atom properties
===================
Similar to what is described in :doc:`Library_atoms`, the instances of
:py:class:`lammps <lammps.lammps>`, :py:class:`PyLammps <lammps.PyLammps>`, or
:py:class:`IPyLammps <lammps.IPyLammps>` can be used to extract atom quantities
and modify some of them. The main difference between the interfaces is how the information
is exposed.
While the :py:class:`lammps <lammps.lammps>` is just a thin layer that wraps C API calls,
:py:class:`PyLammps <lammps.PyLammps>` and :py:class:`IPyLammps <lammps.IPyLammps>` expose
information as objects and properties.
:py:class:`lammps <lammps.lammps>` can be used to extract atom quantities
and modify some of them.
In some cases the data returned is a direct reference to the original data
inside LAMMPS cast to ``ctypes`` pointers. Where possible, the wrappers will
@ -25,57 +19,41 @@ against invalid accesses.
accordingly. These arrays can change sizes and order at every neighbor list
rebuild and atom sort event as atoms are migrating between subdomains.
.. tabs::
.. code-block:: python
.. tab:: lammps API
from lammps import lammps
.. code-block:: python
lmp = lammps()
lmp.file("in.sysinit")
from lammps import lammps
lmp = lammps()
lmp.file("in.sysinit")
# Read/Write access via ctypes
nlocal = lmp.extract_global("nlocal")
x = lmp.extract_atom("x")
nlocal = lmp.extract_global("nlocal")
x = lmp.extract_atom("x")
for i in range(nlocal):
print("(x,y,z) = (", x[i][0], x[i][1], x[i][2], ")")
for i in range(nlocal):
print("(x,y,z) = (", x[i][0], x[i][1], x[i][2], ")")
# Read/Write access via NumPy arrays
atom_id = L.numpy.extract_atom("id")
atom_type = L.numpy.extract_atom("type")
x = L.numpy.extract_atom("x")
v = L.numpy.extract_atom("v")
f = L.numpy.extract_atom("f")
lmp.close()
# set position in 2D simulation
x[0] = (1.0, 0.0)
**Methods**:
# set position in 3D simulation
x[0] = (1.0, 0.0, 1.)
* :py:meth:`extract_atom() <lammps.lammps.extract_atom()>`: extract a per-atom quantity
lmp.close()
**Numpy Methods**:
* :py:meth:`numpy.extract_atom() <lammps.numpy_wrapper.numpy_wrapper.extract_atom()>`: extract a per-atom quantity as numpy array
**Methods**:
.. tab:: PyLammps/IPyLammps API
* :py:meth:`extract_atom() <lammps.lammps.extract_atom()>`: extract a per-atom quantity
All atoms in the current simulation can be accessed by using the :py:attr:`PyLammps.atoms <lammps.PyLammps.atoms>` property.
Each element of this list is a :py:class:`Atom <lammps.Atom>` or :py:class:`Atom2D <lammps.Atom2D>` object. The attributes of
these objects provide access to their data (id, type, position, velocity, force, etc.):
.. code-block:: python
# access first atom
L.atoms[0].id
L.atoms[0].type
# access second atom
L.atoms[1].position
L.atoms[1].velocity
L.atoms[1].force
Some attributes can be changed:
.. code-block:: python
# set position in 2D simulation
L.atoms[0].position = (1.0, 0.0)
# set position in 3D simulation
L.atoms[0].position = (1.0, 0.0, 1.0)
**Numpy Methods**:
* :py:meth:`numpy.extract_atom() <lammps.numpy_wrapper.numpy_wrapper.extract_atom()>`: extract a per-atom quantity as numpy array

View File

@ -6,11 +6,10 @@ Creating or deleting a LAMMPS object
====================================
With the Python interface the creation of a :cpp:class:`LAMMPS
<LAMMPS_NS::LAMMPS>` instance is included in the constructors for the
:py:class:`lammps <lammps.lammps>`, :py:class:`PyLammps <lammps.PyLammps>`,
and :py:class:`IPyLammps <lammps.IPyLammps>` classes.
Internally it will call either :cpp:func:`lammps_open` or :cpp:func:`lammps_open_no_mpi` from the C
library API to create the class instance.
<LAMMPS_NS::LAMMPS>` instance is included in the constructor for the
:py:class:`lammps <lammps.lammps>` class. Internally it will call either
:cpp:func:`lammps_open` or :cpp:func:`lammps_open_no_mpi` from the C library
API to create the class instance.
All arguments are optional. The *name* argument allows loading a
LAMMPS shared library that is named ``liblammps_machine.so`` instead of
@ -26,108 +25,25 @@ to run the Python module like the library interface on a subset of the
MPI ranks after splitting the communicator.
Here are simple examples using all three Python interfaces:
Here is a simple example using the LAMMPS Python interface:
.. tabs::
.. code-block:: python
.. tab:: lammps API
from lammps import lammps
.. code-block:: python
# NOTE: argv[0] is set by the lammps class constructor
args = ["-log", "none"]
from lammps import lammps
# create LAMMPS instance
lmp = lammps(cmdargs=args)
# NOTE: argv[0] is set by the lammps class constructor
args = ["-log", "none"]
# get and print numerical version code
print("LAMMPS Version: ", lmp.version())
# create LAMMPS instance
lmp = lammps(cmdargs=args)
# explicitly close and delete LAMMPS instance (optional)
lmp.close()
# get and print numerical version code
print("LAMMPS Version: ", lmp.version())
# explicitly close and delete LAMMPS instance (optional)
lmp.close()
.. tab:: PyLammps API
The :py:class:`PyLammps <lammps.PyLammps>` class is a wrapper around the
:py:class:`lammps <lammps.lammps>` class and all of its lower level functions.
By default, it will create a new instance of :py:class:`lammps <lammps.lammps>` passing
along all arguments to the constructor of :py:class:`lammps <lammps.lammps>`.
.. code-block:: python
from lammps import PyLammps
# NOTE: argv[0] is set by the lammps class constructor
args = ["-log", "none"]
# create LAMMPS instance
L = PyLammps(cmdargs=args)
# get and print numerical version code
print("LAMMPS Version: ", L.version())
# explicitly close and delete LAMMPS instance (optional)
L.close()
:py:class:`PyLammps <lammps.PyLammps>` objects can also be created on top of an existing
:py:class:`lammps <lammps.lammps>` object:
.. code-block:: python
from lammps import lammps, PyLammps
...
# create LAMMPS instance
lmp = lammps(cmdargs=args)
# create PyLammps instance using previously created LAMMPS instance
L = PyLammps(ptr=lmp)
This is useful if you have to create the :py:class:`lammps <lammps.lammps>`
instance is a specific way, but want to take advantage of the
:py:class:`PyLammps <lammps.PyLammps>` interface.
.. tab:: IPyLammps API
The :py:class:`IPyLammps <lammps.IPyLammps>` class is an extension of the
:py:class:`PyLammps <lammps.PyLammps>` class. It has the same construction behavior. By
default, it will create a new instance of :py:class:`lammps` passing
along all arguments to the constructor of :py:class:`lammps`.
.. code-block:: python
from lammps import IPyLammps
# NOTE: argv[0] is set by the lammps class constructor
args = ["-log", "none"]
# create LAMMPS instance
L = IPyLammps(cmdargs=args)
# get and print numerical version code
print("LAMMPS Version: ", L.version())
# explicitly close and delete LAMMPS instance (optional)
L.close()
You can also initialize IPyLammps on top of an existing :py:class:`lammps` or :py:class:`PyLammps` object:
.. code-block:: python
from lammps import lammps, IPyLammps
...
# create LAMMPS instance
lmp = lammps(cmdargs=args)
# create PyLammps instance using previously created LAMMPS instance
L = PyLammps(ptr=lmp)
This is useful if you have to create the :py:class:`lammps <lammps.lammps>`
instance is a specific way, but want to take advantage of the
:py:class:`IPyLammps <lammps.IPyLammps>` interface.
In all of the above cases, same as with the :ref:`C library API <lammps_c_api>`, this will use the
Same as with the :ref:`C library API <lammps_c_api>`, this will use the
``MPI_COMM_WORLD`` communicator for the MPI library that LAMMPS was
compiled with.

Some files were not shown because too many files have changed in this diff Show More